.gitlab-ci.yml

@@ -12,35 +12,30 @@ stages:
   - release
   - metadata
 
-before_script:
-  - npm install -g @shipzone/npmci
-
 # ====================
 # security stage
 # ====================
-auditProductionDependencies:
+mirror:
-  image: registry.gitlab.com/hosttoday/ht-docker-node:npmci
   stage: security
   script:
-    - npmci npm prepare
+    - npmci git mirror
-    - npmci command npm install --production --ignore-scripts
-    - npmci command npm config set registry https://registry.npmjs.org
-    - npmci command npm audit --audit-level=high --only=prod --production
   tags:
+    - lossless
     - docker
-  allow_failure: true
+    - notpriv
 
-auditDevDependencies:
+audit:
   image: registry.gitlab.com/hosttoday/ht-docker-node:npmci
   stage: security
   script:
     - npmci npm prepare
     - npmci command npm install --ignore-scripts
     - npmci command npm config set registry https://registry.npmjs.org
-    - npmci command npm audit --audit-level=high --only=dev
+    - npmci command npm audit --audit-level=high
   tags:
+    - lossless
     - docker
-  allow_failure: true
+    - notpriv
 
 # ====================
 # test stage
@@ -55,7 +50,9 @@ testStable:
     - npmci npm test
   coverage: /\d+.?\d+?\%\s*coverage/
   tags:
+    - lossless
     - docker
+    - priv
 
 testBuild:
   stage: test
@@ -66,7 +63,9 @@ testBuild:
     - npmci command npm run build
   coverage: /\d+.?\d+?\%\s*coverage/
   tags:
+    - lossless
     - docker
+    - notpriv
 
 release:
   stage: release
@@ -86,12 +85,11 @@ release:
 codequality:
   stage: metadata
   allow_failure: true
-  only:
-    - tags
   script:
-    - npmci command npm install -g typescript
+    - npmci command npm install -g tslint typescript
     - npmci npm prepare
     - npmci npm install
+    - npmci command "tslint -c tslint.json ./ts/**/*.ts"
   tags:
     - lossless
     - docker
@@ -111,10 +109,11 @@ trigger:
 pages:
   stage: metadata
   script:
-    - npmci node install stable 
+    - npmci node install lts
+    - npmci command npm install -g @gitzone/tsdoc
     - npmci npm prepare
     - npmci npm install
-    - npmci command npm run buildDocs
+    - npmci command tsdoc
   tags:
     - lossless
     - docker

.gitlab/.gitlab-webide.yml

@@ -0,0 +1,8 @@
+terminal:
+  image: registry.gitlab.com/hosttoday/ht-docker-node:stable
+  before_script:
+    - npm install -g npm-check
+  variables:
+    RAILS_ENV: "test"
+    NODE_ENV: "test"
+

.snyk

@@ -0,0 +1,4 @@
+# Snyk (https://snyk.io) policy file, patches or ignores known vulnerabilities.
+version: v1.13.5
+ignore: {}
+patch: {}

.vscode/launch.json

@@ -2,10 +2,28 @@
   "version": "0.2.0",
   "configurations": [
     {
-      "command": "npm test",
+      "name": "current file",
-      "name": "Run npm test",
+      "type": "node",
       "request": "launch",
-      "type": "node-terminal"
+      "args": [
+        "${relativeFile}"
+      ],
+      "runtimeArgs": ["-r", "@gitzone/tsrun"],
+      "cwd": "${workspaceRoot}",
+      "protocol": "inspector",
+      "internalConsoleOptions": "openOnSessionStart"
+    },
+    {
+      "name": "test.ts",
+      "type": "node",
+      "request": "launch",
+      "args": [
+        "test/test.ts"
+      ],
+      "runtimeArgs": ["-r", "@gitzone/tsrun"],
+      "cwd": "${workspaceRoot}",
+      "protocol": "inspector",
+      "internalConsoleOptions": "openOnSessionStart"
     }
   ]
 }

.vscode/settings.json

@@ -15,7 +15,7 @@
             "properties": {
               "projectType": {
                 "type": "string",
-                "enum": ["website", "element", "service", "npm", "wcc"]
+                "enum": ["website", "element", "service", "npm"]
               }
             }
           }

npmextra.json

@@ -5,7 +5,7 @@
       "githost": "gitlab.com",
       "gitscope": "mojoio",
       "gitrepo": "mailgun",
-      "description": "an api abstraction package for mailgun",
+      "shortDescription": "an api abstraction package for mailgun",
       "npmPackagename": "@mojoio/mailgun",
       "license": "MIT",
       "projectDomain": "mojo.io"

package.json

@@ -1,32 +1,31 @@
 {
   "name": "@mojoio/mailgun",
-  "version": "2.0.1",
+  "version": "1.0.27",
   "private": false,
   "description": "an api abstraction package for mailgun",
   "main": "dist_ts/index.js",
   "typings": "dist_ts/index.d.ts",
-  "type": "module",
   "author": "Lossless GmbH",
   "license": "MIT",
   "scripts": {
     "test": "(tstest test/)",
-    "build": "(tsbuild --web --allowimplicitany)",
+    "build": "(tsbuild --web)",
-    "format": "(gitzone format)",
+    "format": "(gitzone format)"
-    "buildDocs": "tsdoc"
   },
   "devDependencies": {
-    "@gitzone/tsbuild": "^2.1.65",
+    "@gitzone/tsbuild": "^2.1.25",
-    "@gitzone/tstest": "^1.0.73",
+    "@gitzone/tstest": "^1.0.43",
-    "@pushrocks/qenv": "^5.0.2",
+    "@pushrocks/qenv": "^4.0.10",
-    "@pushrocks/tapbundle": "^5.0.4",
+    "@pushrocks/tapbundle": "^3.2.9",
-    "@types/node": "^18.6.4"
+    "@types/node": "^14.0.27",
+    "tslint": "^6.1.3",
+    "tslint-config-prettier": "^1.15.0"
   },
   "dependencies": {
-    "@pushrocks/smartfile": "^10.0.4",
+    "@pushrocks/smartfile": "^8.0.0",
-    "@pushrocks/smartmail": "^1.0.22",
+    "@pushrocks/smartmail": "^1.0.18",
-    "@pushrocks/smartrequest": "^2.0.10",
+    "@pushrocks/smartrequest": "^1.1.47",
-    "@pushrocks/smartsmtp": "^3.0.3",
+    "@pushrocks/smartstring": "^3.0.18"
-    "@pushrocks/smartstring": "^4.0.2"
   },
   "files": [
     "ts/**/*",
@@ -39,8 +38,5 @@
     "cli.js",
     "npmextra.json",
     "readme.md"
-  ],
-  "browserslist": [
-    "last 1 chrome versions"
   ]
 }

qenv.yml

@@ -1,3 +1,2 @@
 required:
   - MAILGUN_API_TOKEN
-  - MAILGUN_SMTP_CREDENTIALS

test/test.ts

@@ -4,30 +4,24 @@ import * as smartmail from '@pushrocks/smartmail';
 
 const testQenv = new Qenv('./', './.nogit');
 
-import * as mailgun from '../ts/index.js';
+import * as mailgun from '../ts/index';
-import { IMailgunMessage } from '../ts/index.js';
+import { IMailgunMessage } from '../ts/index';
 
 let testMailgunAccount: mailgun.MailgunAccount;
 let testSmartmail: smartmail.Smartmail<IMailgunMessage>;
 
 tap.test('should create a mailgun account', async () => {
-  testMailgunAccount = new mailgun.MailgunAccount({
+  testMailgunAccount = new mailgun.MailgunAccount(testQenv.getEnvVarOnDemand('MAILGUN_API_TOKEN'));
-    apiToken: testQenv.getEnvVarOnDemand('MAILGUN_API_TOKEN'),
+  expect(testMailgunAccount).to.be.instanceOf(mailgun.MailgunAccount);
-    region: 'eu',
-  });
-  await testMailgunAccount.addSmtpCredentials(
-    testQenv.getEnvVarOnDemand('MAILGUN_SMTP_CREDENTIALS')
-  );
-  expect(testMailgunAccount).toBeInstanceOf(mailgun.MailgunAccount);
 });
 
 tap.test('should create a smartmail', async () => {
   testSmartmail = new smartmail.Smartmail({
     body: 'hi there. This is the body.',
     from: 'Lossless GmbH <noreply@mail.lossless.com>',
-    subject: 'TestMessage from @mojoio/mailgun test',
+    subject: 'TestMessage from @mojoio/mailgun test'
   });
-  expect(testSmartmail).toBeInstanceOf(smartmail.Smartmail);
+  return testSmartmail;
 });
 
 tap.test('should send a smartmail', async () => {
@@ -37,23 +31,19 @@ tap.test('should send a smartmail', async () => {
 tap.test('should send a smartmail with empty body', async () => {
   const emptyBodySmartmail = new smartmail.Smartmail<IMailgunMessage>({
     body: '',
-    from: 'Lossless GmbH <noreply@mail.lossless.one>',
+    from: 'Lossless GmbH <noreply@mail.lossless.com>',
-    subject: 'A message with no body from @mojoio/mailgun test',
+    subject: 'A message with no body from @mojoio/mailgun test'
   });
-  await testMailgunAccount.sendSmartMail(
+  console.log('ok');
-    emptyBodySmartmail,
+  await testMailgunAccount.sendSmartMail(emptyBodySmartmail, 'Sandbox Team <sandbox@mail.git.zone>');
-    'Sandbox Team <sandbox@mail.git.zone>'
+  console.log('hey');
-  );
 });
 
 tap.test('should retrieve a mail using a retrieval url', async () => {
   const result = await testMailgunAccount.retrieveSmartMailFromMessageUrl(
     'https://sw.api.mailgun.net/v3/domains/mail.lossless.one/messages/AgMFnnnAKC8xp_dDa79LyoxhloxtaVmnRA=='
   );
-  console.log(result);
+  if (result) {
-
-  // TODO handle empty body
-  if (false) {
     result.options.subject = 'hi there. This is a testmail with attachment';
     result.options.from = 'noreply@mail.lossless.com';
     await testMailgunAccount.sendSmartMail(result, 'Sandbox Team <sandbox@mail.git.zone>');

ts/00_commitinfo_data.ts

@@ -1,8 +0,0 @@
-/**
- * autocreated commitinfo by @pushrocks/commitinfo
- */
-export const commitinfo = {
-  name: '@mojoio/mailgun',
-  version: '2.0.1',
-  description: 'an api abstraction package for mailgun'
-}

ts/index.ts

@@ -1,2 +1,2 @@
-export * from './mailgun.classes.account.js';
+export * from './mailgun.classes.account';
-export * from './interfaces/index.js';
+export * from './interfaces';

ts/interfaces/index.ts

@@ -1,2 +1,2 @@
-export * from './message.js';
+export * from './message';
-export * from './notification.js';
+export * from './notification';

ts/mailgun.classes.account.ts

@@ -1,57 +1,26 @@
-import * as plugins from './mailgun.plugins.js';
+import * as plugins from './mailgun.plugins';
-import * as interfaces from './interfaces/index.js';
+import * as interfaces from './interfaces';
-
-export interface IMailgunAccountContructorOptions {
-  apiToken: string;
-  region: 'eu' | 'us';
-}
 
 export class MailgunAccount {
-  public apiBaseUrl: string;
+  public baseUrl = 'https://api.mailgun.net/v3';
+  public apiToken: string;
 
-  public options: IMailgunAccountContructorOptions;
+  constructor(apiTokenArg: string) {
-
+    this.apiToken = apiTokenArg;
-  public smartSmtps: { [domain: string]: plugins.smartsmtp.Smartsmtp } = {};
-
-  constructor(optionsArg: IMailgunAccountContructorOptions) {
-    this.options = optionsArg;
-    this.apiBaseUrl =
-      this.options.region === 'eu'
-        ? 'https://api.eu.mailgun.net/v3'
-        : 'https://api..mailgun.net/v3';
-  }
-
-  /**
-   * allows adding smtp credentials
-   * Format: [domain]|[username]|[password]
-   */
-  public async addSmtpCredentials(credentials: string) {
-    const credentialArray = credentials.split('|');
-    if (credentialArray.length !== 3) {
-      throw new Error('credentials are in the wrong format');
-    }
-    this.smartSmtps[credentialArray[0]] =
-      await plugins.smartsmtp.Smartsmtp.createSmartsmtpWithRelay({
-        smtpServer: 'smtp.eu.mailgun.org',
-        smtpUser: credentialArray[1],
-        smtpPassword: credentialArray[2],
-      });
   }
 
   public async getRequest(routeArg: string, binaryArg: boolean = false) {
     let requestUrl = routeArg;
     const needsBaseUrlPrefix = !routeArg.startsWith('https://');
-    if (needsBaseUrlPrefix) {
+    needsBaseUrlPrefix ? (requestUrl = `${this.baseUrl}${routeArg}`) : null;
-      requestUrl = `${this.apiBaseUrl}${routeArg}`;
-    }
     console.log(requestUrl);
     const requestOptions: plugins.smartrequest.ISmartRequestOptions = {
       method: 'GET',
       headers: {
-        Authorization: `Basic ${plugins.smartstring.base64.encode(`api:${this.options.apiToken}`)}`,
+        Authorization: `Basic ${plugins.smartstring.base64.encode(`api:${this.apiToken}`)}`,
-        'Content-Type': 'application/json',
+        'Content-Type': 'application/json'
       },
-      keepAlive: false,
+      keepAlive: false
     };
     let response: plugins.smartrequest.IExtendedIncomingMessage;
     if (!binaryArg) {
@@ -63,17 +32,14 @@ export class MailgunAccount {
   }
 
   public async postFormData(routeArg: string, formFields: plugins.smartrequest.IFormField[]) {
-    const requestUrl = `${this.apiBaseUrl}${routeArg}`;
+    const requestUrl = `${this.baseUrl}${routeArg}`; // TODO;
-    console.log(requestUrl);
     const response = await plugins.smartrequest.postFormData(
       requestUrl,
       {
         headers: {
-          Authorization: `Basic ${plugins.smartstring.base64.encode(
+          Authorization: `Basic ${plugins.smartstring.base64.encode(`api:${this.apiToken}`)}`
-            `api:${this.options.apiToken}`
-          )}`,
         },
-        keepAlive: false,
+        keepAlive: false
       },
       formFields
     );
@@ -93,24 +59,34 @@ export class MailgunAccount {
       {
         name: 'from',
         type: 'string',
-        payload: smartmailArg.options.from,
+        payload: smartmailArg.options.from
       },
       {
         name: 'to',
         type: 'string',
-        payload: toArg,
+        payload: toArg
       },
       {
         name: 'subject',
         type: 'string',
-        payload: smartmailArg.getSubject(dataArg),
+        payload: smartmailArg.getSubject(dataArg)
-      },
+      }
-      {
+    ];
+
+    if (smartmailArg.getBody(dataArg)) {
+      formFields.push({
         name: 'html',
         type: 'string',
-        payload: smartmailArg.getBody(dataArg),
+        payload: smartmailArg.getBody(dataArg)
-      },
+      });
-    ];
+    } else {
+      console.log('message has no body');
+      formFields.push({
+        name: 'html',
+        type: 'string',
+        payload: 'The sender did not provide a bodytext.'
+      });
+    }
 
     console.log(smartmailArg.attachments);
 
@@ -119,44 +95,20 @@ export class MailgunAccount {
         name: 'attachment',
         type: 'Buffer',
         payload: attachment.contentBuffer,
-        fileName: attachment.parsedPath.base,
+        fileName: attachment.parsedPath.base
       });
     }
 
-    if (smartmailArg.getBody(dataArg)) {
-      console.log('All requirements for API met');
     const response = await this.postFormData(`/${domain}/messages`, formFields);
     if (response.statusCode === 200) {
-        console.log(
-          `Sent mail with subject ${smartmailArg.getSubject(
-            dataArg
-          )} to ${toArg} using the mailgun API`
-        );
       return response.body;
     } else {
       console.log(response.body);
       throw new Error('could not send email');
     }
-    } else {
-      console.log(
-        'An empty body was provided. This does not work via the API, but using SMTP instead.'
-      );
-      const wantedSmartsmtp = this.smartSmtps[domain];
-      if (!wantedSmartsmtp) {
-        console.log('did not find appropriate smtp credentials');
-        return;
-      }
-      await wantedSmartsmtp.sendSmartMail(smartmailArg, toArg);
-      console.log(
-        `Sent mail with subject "${smartmailArg.getSubject(
-          dataArg
-        )}" to "${toArg}" using an smtp transport over Mailgun.`
-      );
-    }
   }
 
   public async retrieveSmartMailFromMessageUrl(messageUrlArg: string) {
-    console.log(`retrieving message for ${messageUrlArg}`);
     const response = await this.getRequest(messageUrlArg);
     if (response.statusCode === 404) {
       console.log(response.body.message);
@@ -167,7 +119,7 @@ export class MailgunAccount {
       from: responseBody.From,
       body: responseBody['body-html'],
       subject: responseBody.Subject,
-      creationObjectRef: responseBody,
+      creationObjectRef: responseBody
     });
 
     // lets care about attachments
@@ -179,7 +131,7 @@ export class MailgunAccount {
           new plugins.smartfile.Smartfile({
             path: `./${attachmentName}`,
             base: `./${attachmentName}`,
-            contentBuffer: attachmentContents.body,
+            contentBuffer: attachmentContents.body
           })
         );
       }

ts/mailgun.plugins.ts

@@ -2,7 +2,6 @@
 import * as smartfile from '@pushrocks/smartfile';
 import * as smartmail from '@pushrocks/smartmail';
 import * as smartrequest from '@pushrocks/smartrequest';
-import * as smartsmtp from '@pushrocks/smartsmtp';
 import * as smartstring from '@pushrocks/smartstring';
 
-export { smartfile, smartmail, smartrequest, smartsmtp, smartstring };
+export { smartfile, smartmail, smartrequest, smartstring };

tsconfig.json

@@ -1,10 +0,0 @@
-{
-  "compilerOptions": {
-    "experimentalDecorators": true,
-    "useDefineForClassFields": false,
-    "target": "ES2022",
-    "module": "ES2022",
-    "moduleResolution": "nodenext",
-    "esModuleInterop": true
-  }
-}

tslint.json

@@ -0,0 +1,17 @@
+{
+  "extends": ["tslint:latest", "tslint-config-prettier"],
+  "rules": {
+    "semicolon": [true, "always"],
+    "no-console": false,
+    "ordered-imports": false,
+    "object-literal-sort-keys": false,
+    "member-ordering": {
+      "options":{
+        "order": [
+          "static-method"
+        ]
+      }
+    }
+  },
+  "defaultSeverity": "warning"
+}