From 0d33b38e29a88f53c41d6643d632c27cc737bbee Mon Sep 17 00:00:00 2001 From: Hristo Stoyanov Date: Tue, 30 Sep 2025 18:19:01 +0300 Subject: [PATCH] Changedetection: Fix Browserless installation and update process (#8011) * Fix the issue with changedetection.io install: > @browserless.io/browserless@2.37.0 build:ts > tsc sh: 1: tsc: not found [ERROR] in line 70: exit code 0: while executing command $STD npm run build --prefix /opt/browserless * Just to verify the installation works * Just to verify the installation works * Try to fix typescript issues * Try to fix TypeScript issues and update NodeJS * Try to fix TypeScript issues * Add more missing npm dependencies * Cleanup test changes * Revert testing changes and change the way dependencies are installed * Revert testing changes and change the way dependencies are installed * Revert manually added TypeScript and esbuild packages and tried to install them from the optional requirements * Try the clean install * Fix the update script and revert testing changes * Added testing files again * Revert testing repos again --- ct/changedetection.sh | 1 + install/changedetection-install.sh | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ct/changedetection.sh b/ct/changedetection.sh index 0f13917f2..4e7de3c59 100644 --- a/ct/changedetection.sh +++ b/ct/changedetection.sh @@ -51,6 +51,7 @@ function update_script() { $STD git -C /opt/browserless/ fetch --all $STD git -C /opt/browserless/ reset --hard origin/main $STD npm update --prefix /opt/browserless + $STD npm ci --include=optional --include=dev --prefix /opt/browserless $STD /opt/browserless/node_modules/playwright-core/cli.js install --with-deps # Update Chrome separately, as it has to be done with the force option. Otherwise the installation of other browsers will not be done if Chrome is already installed. $STD /opt/browserless/node_modules/playwright-core/cli.js install --force chrome diff --git a/install/changedetection-install.sh b/install/changedetection-install.sh index 328dcfbcf..45a616c7f 100644 --- a/install/changedetection-install.sh +++ b/install/changedetection-install.sh @@ -62,8 +62,7 @@ msg_info "Installing Browserless & Playwright" mkdir /opt/browserless $STD python3 -m pip install playwright $STD git clone https://github.com/browserless/chrome /opt/browserless -$STD npm install --prefix /opt/browserless --include=dev -$STD npm install --prefix /opt/browserless typescript ts-node @types/node --save-dev +$STD npm ci --include=optional --include=dev --prefix /opt/browserless $STD /opt/browserless/node_modules/playwright-core/cli.js install --with-deps &>/dev/null $STD /opt/browserless/node_modules/playwright-core/cli.js install --force chrome &>/dev/null $STD /opt/browserless/node_modules/playwright-core/cli.js install chromium firefox webkit &>/dev/null