Update docs (#4298 )

Update versions.json (#4297 )
Co-authored-by: GitHub Actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-11-05 19:02:50 +00:00 · 2025-05-07 15:21:03 +02:00 · 2025-05-07 14:32:30 +02:00 · 2025-05-07 12:37:46 +02:00 · 2025-05-07 10:45:52 +02:00 · 2025-05-07 10:40:49 +02:00
22 changed files with 615 additions and 383 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -14,6 +14,16 @@ Exercise vigilance regarding copycat or coat-tailing sites that seek to exploit
 All LXC instances created using this repository come pre-installed with Midnight Commander, which is a command-line tool (`mc`) that offers a user-friendly file and directory management interface for the terminal environment.


+## 2025-05-07
+
+### 🚀 Updated Scripts
+
+  - Alpine scripts: Set minimum disk space to 0.5GB [@tremor021](https://github.com/tremor021) ([#4288](https://github.com/community-scripts/ProxmoxVE/pull/4288))
+
+  - #### 🐞 Bug Fixes
+
+    - SuwayomiServer: Bump Java to v21, code formating [@tremor021](https://github.com/tremor021) ([#3987](https://github.com/community-scripts/ProxmoxVE/pull/3987))
+
 ## 2025-05-06

 ### 🆕 New Scripts
--- a/ct/alpine-it-tools.sh
+++ b/ct/alpine-it-tools.sh
@@ -9,7 +9,7 @@ APP="Alpine-IT-Tools"
 var_tags="${var_tags:-alpine;development}"
 var_cpu="${var_cpu:-1}"
 var_ram="${var_ram:-256}"
-var_disk="${var_disk:-0.2}"
+var_disk="${var_disk:-0.5}"
 var_os="${var_os:-alpine}"
 var_version="${var_version:-3.21}"
 var_unprivileged="${var_unprivileged:-1}"
--- a/ct/alpine.sh
+++ b/ct/alpine.sh
@@ -9,7 +9,7 @@ APP="Alpine"
 var_tags="${var_tags:-os;alpine}"
 var_cpu="${var_cpu:-1}"
 var_ram="${var_ram:-512}"
-var_disk="${var_disk:-0.1}"
+var_disk="${var_disk:-0.5}"
 var_os="${var_os:-alpine}"
 var_version="${var_version:-3.21}"
 var_unprivileged="${var_unprivileged:-1}"
@@ -20,9 +20,11 @@ color
 catch_errors

 function update_script() {
-  UPD=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "SUPPORT" --radiolist --cancel-button Exit-Script "Spacebar = Select" 11 58 1 \
+  UPD=$(
+    whiptail --backtitle "Proxmox VE Helper Scripts" --title "SUPPORT" --radiolist --cancel-button Exit-Script "Spacebar = Select" 11 58 1 \
      "1" "Check for Alpine Updates" ON \
-    3>&1 1>&2 2>&3)
+      3>&1 1>&2 2>&3
+  )

  header_info
  if [ "$UPD" == "1" ]; then
--- a/ct/suwayomiserver.sh
+++ b/ct/suwayomiserver.sh
@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 source <(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/misc/build.func)
 # Copyright (c) 2021-2025 community-scripts ORG
-# Author: tremor021
+# Author: Slaviša Arežina (tremor021)
 # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
 # Source: https://github.com/Suwayomi/Suwayomi-Server

@@ -28,24 +28,33 @@ function update_script() {
    msg_error "No ${APP} Installation Found!"
    exit
  fi
+  if dpkg -l | grep -q "openjdk-17-jre"; then
+    $STD apt-get remove -y openjdk-17-jre
+  fi
+  JAVA_VERSION=21 install_java
  RELEASE=$(curl -fsSL https://api.github.com/repos/Suwayomi/Suwayomi-Server/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3) }')
  if [[ "${RELEASE}" != "$(cat /opt/suwayomi-server_version.txt)" ]] || [[ ! -f /opt/suwayomi-server_version.txt ]]; then
    msg_info "Updating $APP"
+
    msg_info "Stopping $APP"
    systemctl stop suwayomi-server
    msg_ok "Stopped $APP"
+
    msg_info "Updating $APP to v${RELEASE}"
-        cd /tmp
-        URL=$(curl -fsSL https://api.github.com/repos/Suwayomi/Suwayomi-Server/releases/latest | grep "browser_download_url" | awk '{print substr($2, 2, length($2)-2) }' | tail -n+2 | head -n 1)
-        curl -fsSL "$URL" -o $(basename "$URL")
-        $STD dpkg -i /tmp/*.deb
+    temp_file=$(mktemp)
+    RELEASE=$(curl -fsSL https://api.github.com/repos/Suwayomi/Suwayomi-Server/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3) }')
+    curl -fsSL "https://github.com/Suwayomi/Suwayomi-Server/releases/download/${RELEASE}/Suwayomi-Server-${RELEASE}-debian-all.deb" -o "$temp_file"
+    $STD dpkg -i "$temp_file"
    msg_ok "Updated $APP to v${RELEASE}"
+
    msg_info "Starting $APP"
    systemctl start suwayomi-server
    msg_ok "Started $APP"
+
    msg_info "Cleaning Up"
-        rm -f *.deb
+    rm -f "$temp_file"
    msg_ok "Cleanup Completed"
+
    echo "${RELEASE}" >/opt/suwayomi-server_version.txt.txt
    msg_ok "Update Successful"
  else
--- a/frontend/public/json/alpine-it-tools.json
+++ b/frontend/public/json/alpine-it-tools.json
@@ -21,7 +21,7 @@
      "resources": {
        "cpu": 1,
        "ram": 256,
-              "hdd": 0.2,
+        "hdd": 0.5,
        "os": "alpine",
        "version": "3.21"
      }
@@ -32,7 +32,7 @@
      "resources": {
        "cpu": 1,
        "ram": 256,
-              "hdd": 0.2,
+        "hdd": 0.5,
        "os": "alpine",
        "version": "3.21"
      }
@@ -44,4 +44,3 @@
  },
  "notes": []
 }
-
--- a/frontend/public/json/alpine.json
+++ b/frontend/public/json/alpine.json
@@ -21,7 +21,7 @@
      "resources": {
        "cpu": 1,
        "ram": 512,
-                "hdd": 0.1,
+        "hdd": 0.5,
        "os": "alpine",
        "version": "3.21"
      }
@@ -32,7 +32,7 @@
      "resources": {
        "cpu": 1,
        "ram": 512,
-                "hdd": 0.1,
+        "hdd": 0.5,
        "os": "alpine",
        "version": "3.21"
      }
@@ -49,4 +49,3 @@
    }
  ]
 }
-
--- a/frontend/public/json/openwebui.json
+++ b/frontend/public/json/openwebui.json
@@ -9,7 +9,7 @@
  "updateable": true,
  "privileged": false,
  "interface_port": 8080,
-    "documentation": null,
+  "documentation": "https://docs.openwebui.com/",
  "website": "https://openwebui.com/",
  "logo": "https://raw.githubusercontent.com/selfhst/icons/refs/heads/main/svg/open-webui.svg",
  "config_path": "/opt/open-webui/.env",
--- a/frontend/public/json/versions.json
+++ b/frontend/public/json/versions.json
@@ -1,8 +1,143 @@
 [
+  {
+    "name": "docker/compose",
+    "version": "v2.36.0",
+    "date": "2025-05-07T11:54:14Z"
+  },
+  {
+    "name": "Graylog2/graylog2-server",
+    "version": "6.2.2",
+    "date": "2025-05-07T11:36:20Z"
+  },
+  {
+    "name": "openobserve/openobserve",
+    "version": "v0.14.7",
+    "date": "2025-05-07T11:32:23Z"
+  },
+  {
+    "name": "home-assistant/core",
+    "version": "2025.4.4",
+    "date": "2025-04-25T07:47:57Z"
+  },
+  {
+    "name": "grokability/snipe-it",
+    "version": "v8.1.3",
+    "date": "2025-05-07T11:09:21Z"
+  },
+  {
+    "name": "cockpit-project/cockpit",
+    "version": "338",
+    "date": "2025-05-07T10:43:29Z"
+  },
+  {
+    "name": "zabbix/zabbix",
+    "version": "7.4.0beta2",
+    "date": "2025-05-07T10:39:21Z"
+  },
+  {
+    "name": "zwave-js/zwave-js-ui",
+    "version": "v10.4.1",
+    "date": "2025-05-07T09:22:38Z"
+  },
+  {
+    "name": "jupyter/notebook",
+    "version": "@jupyter-notebook/ui-components@7.5.0-alpha.0",
+    "date": "2025-05-07T09:12:08Z"
+  },
+  {
+    "name": "Jackett/Jackett",
+    "version": "v0.22.1874",
+    "date": "2025-05-07T05:56:30Z"
+  },
+  {
+    "name": "cross-seed/cross-seed",
+    "version": "v6.12.2",
+    "date": "2025-04-28T17:44:49Z"
+  },
+  {
+    "name": "open-webui/open-webui",
+    "version": "v0.6.7",
+    "date": "2025-05-06T23:08:38Z"
+  },
+  {
+    "name": "influxdata/influxdb",
+    "version": "v1.12.1rc0",
+    "date": "2025-05-06T20:56:30Z"
+  },
+  {
+    "name": "keycloak/keycloak",
+    "version": "26.2.3",
+    "date": "2025-05-05T11:12:36Z"
+  },
+  {
+    "name": "pocket-id/pocket-id",
+    "version": "v0.52.0",
+    "date": "2025-05-06T20:14:44Z"
+  },
+  {
+    "name": "runtipi/runtipi",
+    "version": "v4.0.2",
+    "date": "2025-05-01T16:10:58Z"
+  },
+  {
+    "name": "redis/redis",
+    "version": "8.0.1-int",
+    "date": "2025-05-06T18:40:34Z"
+  },
+  {
+    "name": "Athou/commafeed",
+    "version": "5.8.0",
+    "date": "2025-05-06T18:33:07Z"
+  },
+  {
+    "name": "sysadminsmedia/homebox",
+    "version": "v0.19.0",
+    "date": "2025-05-06T18:05:42Z"
+  },
+  {
+    "name": "HabitRPG/habitica",
+    "version": "v5.36.2",
+    "date": "2025-05-06T17:32:30Z"
+  },
+  {
+    "name": "wazuh/wazuh",
+    "version": "coverity-w19-4.13.0",
+    "date": "2025-05-06T15:59:45Z"
+  },
+  {
+    "name": "jenkinsci/jenkins",
+    "version": "jenkins-2.509",
+    "date": "2025-05-06T15:37:10Z"
+  },
+  {
+    "name": "MariaDB/server",
+    "version": "mariadb-11.4.6",
+    "date": "2025-05-06T15:30:49Z"
+  },
+  {
+    "name": "bluenviron/mediamtx",
+    "version": "v1.12.2",
+    "date": "2025-05-06T15:30:10Z"
+  },
+  {
+    "name": "AdguardTeam/AdGuardHome",
+    "version": "v0.107.61",
+    "date": "2025-04-22T12:42:26Z"
+  },
+  {
+    "name": "zitadel/zitadel",
+    "version": "v2.65.8",
+    "date": "2025-05-06T13:57:49Z"
+  },
  {
    "name": "element-hq/synapse",
    "version": "v1.129.0",
-    "date": "2025-05-06T11:25:39Z"
+    "date": "2025-05-06T12:28:54Z"
+  },
+  {
+    "name": "nzbgetcom/nzbget",
+    "version": "v24.8",
+    "date": "2025-03-18T07:33:51Z"
  },
  {
    "name": "n8n-io/n8n",
@@ -24,11 +159,6 @@
    "version": "v9.11.14",
    "date": "2025-05-05T17:50:53Z"
  },
-  {
-    "name": "zitadel/zitadel",
-    "version": "v3.0.1",
-    "date": "2025-05-06T06:53:59Z"
-  },
  {
    "name": "Checkmk/checkmk",
    "version": "v2.4.0",
@@ -39,46 +169,31 @@
    "version": "v1.5.1",
    "date": "2025-01-01T16:15:52Z"
  },
-  {
-    "name": "Jackett/Jackett",
-    "version": "v0.22.1867",
-    "date": "2025-05-06T05:54:56Z"
-  },
  {
    "name": "linkwarden/linkwarden",
    "version": "v2.10.2",
    "date": "2025-05-06T03:12:53Z"
  },
-  {
-    "name": "home-assistant/core",
-    "version": "2025.4.4",
-    "date": "2025-04-25T07:47:57Z"
-  },
  {
    "name": "fallenbagel/jellyseerr",
    "version": "preview-tvdb",
    "date": "2025-05-06T01:32:52Z"
  },
-  {
-    "name": "keycloak/keycloak",
-    "version": "26.2.3",
-    "date": "2025-05-05T11:12:36Z"
-  },
  {
    "name": "autobrr/autobrr",
    "version": "v1.62.0",
    "date": "2025-05-05T20:35:18Z"
  },
+  {
+    "name": "postgres/postgres",
+    "version": "REL_13_21",
+    "date": "2025-05-05T20:34:49Z"
+  },
  {
    "name": "msgbyte/tianji",
    "version": "v1.20.9",
    "date": "2025-05-05T19:24:09Z"
  },
-  {
-    "name": "runtipi/runtipi",
-    "version": "v4.0.2",
-    "date": "2025-05-01T16:10:58Z"
-  },
  {
    "name": "grafana/grafana",
    "version": "v12.0.0",
@@ -104,31 +219,21 @@
    "version": "2.9.4",
    "date": "2025-05-05T15:17:27Z"
  },
+  {
+    "name": "neo4j/neo4j",
+    "version": "5.26.6",
+    "date": "2025-05-05T13:59:36Z"
+  },
  {
    "name": "traefik/traefik",
    "version": "v3.4.0",
    "date": "2025-05-05T13:59:23Z"
  },
-  {
-    "name": "open-webui/open-webui",
-    "version": "v0.6.6",
-    "date": "2025-05-05T13:59:08Z"
-  },
-  {
-    "name": "zwave-js/zwave-js-ui",
-    "version": "v10.4.0",
-    "date": "2025-05-05T13:01:01Z"
-  },
  {
    "name": "semaphoreui/semaphore",
    "version": "v2.14.9",
    "date": "2025-05-05T12:20:38Z"
  },
-  {
-    "name": "grokability/snipe-it",
-    "version": "v8.1.2",
-    "date": "2025-05-05T10:28:17Z"
-  },
  {
    "name": "theonedev/onedev",
    "version": "v11.9.3",
@@ -164,11 +269,6 @@
    "version": "v0.25.1",
    "date": "2025-02-25T17:30:48Z"
  },
-  {
-    "name": "bluenviron/mediamtx",
-    "version": "v1.12.1",
-    "date": "2025-05-04T18:23:38Z"
-  },
  {
    "name": "Lidarr/Lidarr",
    "version": "v2.11.2.4629",
@@ -199,11 +299,6 @@
    "version": "v0.6.8",
    "date": "2025-05-03T22:56:44Z"
  },
-  {
-    "name": "pocket-id/pocket-id",
-    "version": "v0.51.1",
-    "date": "2025-05-03T21:42:51Z"
-  },
  {
    "name": "FreshRSS/FreshRSS",
    "version": "1.26.2",
@@ -269,11 +364,6 @@
    "version": "v0.304.0-rc.0",
    "date": "2025-05-02T17:29:18Z"
  },
-  {
-    "name": "influxdata/influxdb",
-    "version": "v3.0.2",
-    "date": "2025-05-02T18:11:39Z"
-  },
  {
    "name": "forgejo/forgejo",
    "version": "v11.0.1",
@@ -289,21 +379,11 @@
    "version": "v3.5.4",
    "date": "2025-05-02T13:42:06Z"
  },
-  {
-    "name": "nzbgetcom/nzbget",
-    "version": "v24.8",
-    "date": "2025-03-18T07:33:51Z"
-  },
  {
    "name": "motioneye-project/motioneye",
    "version": "0.42.1",
    "date": "2020-06-07T07:27:04Z"
  },
-  {
-    "name": "redis/redis",
-    "version": "8.0.0",
-    "date": "2025-05-02T11:20:31Z"
-  },
  {
    "name": "emqx/emqx",
    "version": "e5.9.0",
@@ -329,11 +409,6 @@
    "version": "v4.3.0",
    "date": "2025-05-01T04:13:41Z"
  },
-  {
-    "name": "HabitRPG/habitica",
-    "version": "v5.36.1",
-    "date": "2025-04-30T19:44:44Z"
-  },
  {
    "name": "readeck/readeck",
    "version": "0.18.1",
@@ -349,16 +424,6 @@
    "version": "1.6.13",
    "date": "2025-04-30T16:38:35Z"
  },
-  {
-    "name": "Graylog2/graylog2-server",
-    "version": "6.3.0-alpha.2",
-    "date": "2025-04-30T14:55:15Z"
-  },
-  {
-    "name": "jenkinsci/jenkins",
-    "version": "jenkins-2.504.1",
-    "date": "2025-04-30T14:33:59Z"
-  },
  {
    "name": "cloudflare/cloudflared",
    "version": "2025.4.2",
@@ -374,11 +439,6 @@
    "version": "version/2025.4.0",
    "date": "2025-04-30T12:34:14Z"
  },
-  {
-    "name": "wazuh/wazuh",
-    "version": "coverity-w18-4.12.0",
-    "date": "2025-04-30T09:30:26Z"
-  },
  {
    "name": "Stirling-Tools/Stirling-PDF",
    "version": "v0.46.0",
@@ -424,11 +484,6 @@
    "version": "v1.2.0",
    "date": "2025-04-28T17:55:01Z"
  },
-  {
-    "name": "cross-seed/cross-seed",
-    "version": "v6.12.2",
-    "date": "2025-04-28T17:44:49Z"
-  },
  {
    "name": "immich-app/immich",
    "version": "v1.132.3",
@@ -519,11 +574,6 @@
    "version": "v1.4.0",
    "date": "2025-04-24T16:20:17Z"
  },
-  {
-    "name": "openobserve/openobserve",
-    "version": "v0.14.6-rc8",
-    "date": "2025-04-24T15:39:41Z"
-  },
  {
    "name": "glpi-project/glpi",
    "version": "10.0.18",
@@ -544,21 +594,6 @@
    "version": "v3.5.2",
    "date": "2025-04-23T18:41:46Z"
  },
-  {
-    "name": "cockpit-project/cockpit",
-    "version": "337",
-    "date": "2025-04-23T08:26:31Z"
-  },
-  {
-    "name": "zabbix/zabbix",
-    "version": "7.2.6",
-    "date": "2025-04-23T08:06:23Z"
-  },
-  {
-    "name": "jupyter/notebook",
-    "version": "v7.4.1",
-    "date": "2025-04-23T06:40:34Z"
-  },
  {
    "name": "minio/minio",
    "version": "RELEASE.2025-04-22T22-12-26Z",
@@ -574,11 +609,6 @@
    "version": "2025.4.22",
    "date": "2025-04-22T14:18:11Z"
  },
-  {
-    "name": "AdguardTeam/AdGuardHome",
-    "version": "v0.107.61",
-    "date": "2025-04-22T12:42:26Z"
-  },
  {
    "name": "OctoPrint/OctoPrint",
    "version": "1.11.0",
@@ -634,16 +664,6 @@
    "version": "v12.6.1",
    "date": "2025-04-17T17:35:02Z"
  },
-  {
-    "name": "docker/compose",
-    "version": "v2.35.1",
-    "date": "2025-04-17T14:29:11Z"
-  },
-  {
-    "name": "neo4j/neo4j",
-    "version": "2025.04.0",
-    "date": "2025-04-17T11:13:20Z"
-  },
  {
    "name": "IceWhaleTech/CasaOS",
    "version": "v0.4.15",
@@ -754,11 +774,6 @@
    "version": "v0.55.2",
    "date": "2025-04-05T12:07:32Z"
  },
-  {
-    "name": "Athou/commafeed",
-    "version": "5.7.0",
-    "date": "2025-04-04T18:10:16Z"
-  },
  {
    "name": "apache/tomcat",
    "version": "9.0.104",
@@ -964,11 +979,6 @@
    "version": "tc_v0.6.4",
    "date": "2025-03-05T15:43:40Z"
  },
-  {
-    "name": "sysadminsmedia/homebox",
-    "version": "v0.18.0",
-    "date": "2025-03-04T15:35:27Z"
-  },
  {
    "name": "heiher/hev-socks5-server",
    "version": "2.8.0",
@@ -1009,11 +1019,6 @@
    "version": "v28.0",
    "date": "2025-02-18T15:49:57Z"
  },
-  {
-    "name": "postgres/postgres",
-    "version": "REL_13_20",
-    "date": "2025-02-17T21:17:13Z"
-  },
  {
    "name": "sbondCo/Watcharr",
    "version": "v2.0.2",
@@ -1039,11 +1044,6 @@
    "version": "v1.27.0",
    "date": "2025-02-13T15:55:36Z"
  },
-  {
-    "name": "MariaDB/server",
-    "version": "mariadb-11.7.2",
-    "date": "2025-02-13T04:13:46Z"
-  },
  {
    "name": "homebridge/homebridge",
    "version": "v1.9.0",
--- a/install/suwayomiserver-install.sh
+++ b/install/suwayomiserver-install.sh
@@ -1,7 +1,7 @@
 #!/usr/bin/env bash

 # Copyright (c) 2021-2025 community-scripts ORG
-# Author: tremor021
+# Author: Slaviša Arežina (tremor021)
 # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
 # Source: https://github.com/Suwayomi/Suwayomi-Server

@@ -14,18 +14,19 @@ network_check
 update_os

 msg_info "Installing Dependencies"
-$STD apt-get install -y \
-  openjdk-17-jre \
-  libc++-dev
+$STD apt-get install -y libc++-dev
 msg_ok "Installed Dependencies"

+JAVA_VERSION=21 install_java
+
 msg_info "Settting up Suwayomi-Server"
-URL=$(curl -fsSL https://api.github.com/repos/Suwayomi/Suwayomi-Server/releases/latest | grep "browser_download_url" | awk '{print substr($2, 2, length($2)-2) }' | tail -n+2 | head -n 1)
+temp_file=$(mktemp)
 RELEASE=$(curl -fsSL https://api.github.com/repos/Suwayomi/Suwayomi-Server/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3) }')
-curl -fsSL "$URL" -o $(basename "$URL")
-$STD dpkg -i *.deb
-echo ${RELEASE} >/opt/suwayomi-server_version.txt
+curl -fsSL "https://github.com/Suwayomi/Suwayomi-Server/releases/download/${RELEASE}/Suwayomi-Server-${RELEASE}-debian-all.deb" -o "$temp_file"
+$STD dpkg -i "$temp_file"
+echo "${RELEASE}" >/opt/suwayomi-server_version.txt
 msg_ok "Done setting up Suwayomi-Server"
+
 msg_info "Creating Service"
 cat <<EOF >/etc/systemd/system/suwayomi-server.service
 [Unit]
@@ -41,10 +42,12 @@ WantedBy=multi-user.target
 EOF
 systemctl enable -q --now suwayomi-server
 msg_ok "Created Service"
+
 motd_ssh
 customize
+
 msg_info "Cleaning up"
-rm -f *.deb
+rm -f "$temp_file"
 $STD apt-get -y autoremove
 $STD apt-get -y autoclean
 msg_ok "Cleaned"
--- a/vm/archlinux-vm.sh
+++ b/vm/archlinux-vm.sh
@@ -26,7 +26,6 @@ NSAPP="arch-linux-vm"
 var_os="arch-linux"
 var_version=" "
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
-NEXTID=$(pvesh get /cluster/nextid)

 YW=$(echo "\033[33m")
 BL=$(echo "\033[36m")
@@ -76,6 +75,23 @@ function error_handler() {
  cleanup_vmid
 }

+function get_valid_nextid() {
+  local try_id
+  try_id=$(pvesh get /cluster/nextid)
+  while true; do
+    if [ -f "/etc/pve/qemu-server/${try_id}.conf" ] || [ -f "/etc/pve/lxc/${try_id}.conf" ]; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    if lvs --noheadings -o lv_name | grep -qE "(^|[-_])${try_id}($|[-_])"; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    break
+  done
+  echo "$try_id"
+}
+
 function cleanup_vmid() {
  if qm status $VMID &>/dev/null; then
    qm stop $VMID &>/dev/null
@@ -161,7 +177,7 @@ function exit-script() {
 }

 function default_settings() {
-  VMID="$NEXTID"
+  VMID=$(get_valid_nextid)
  FORMAT=",efitype=4m"
  MACHINE=""
  DISK_SIZE="4G"
@@ -194,10 +210,11 @@ function default_settings() {

 function advanced_settings() {
  METHOD="advanced"
+  [ -z "${VMID:-}" ] && VMID=$(get_valid_nextid)
  while true; do
-    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $NEXTID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $VMID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
      if [ -z "$VMID" ]; then
-        VMID="$NEXTID"
+        VMID=$(get_valid_nextid)
      fi
      if pct status "$VMID" &>/dev/null || qm status "$VMID" &>/dev/null; then
        echo -e "${CROSS}${RD} ID $VMID is already in use${CL}"
--- a/vm/debian-vm.sh
+++ b/vm/debian-vm.sh
@@ -20,7 +20,6 @@ EOF
 header_info
 echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
-NEXTID=$(pvesh get /cluster/nextid)
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
 NSAPP="debian12vm"
@@ -75,6 +74,23 @@ function error_handler() {
  cleanup_vmid
 }

+function get_valid_nextid() {
+  local try_id
+  try_id=$(pvesh get /cluster/nextid)
+  while true; do
+    if [ -f "/etc/pve/qemu-server/${try_id}.conf" ] || [ -f "/etc/pve/lxc/${try_id}.conf" ]; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    if lvs --noheadings -o lv_name | grep -qE "(^|[-_])${try_id}($|[-_])"; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    break
+  done
+  echo "$try_id"
+}
+
 function cleanup_vmid() {
  if qm status $VMID &>/dev/null; then
    qm stop $VMID &>/dev/null
@@ -161,7 +177,7 @@ function exit-script() {
 }

 function default_settings() {
-  VMID="$NEXTID"
+  VMID=$(get_valid_nextid)
  FORMAT=",efitype=4m"
  MACHINE=""
  DISK_SIZE="8G"
@@ -194,10 +210,11 @@ function default_settings() {

 function advanced_settings() {
  METHOD="advanced"
+  [ -z "${VMID:-}" ] && VMID=$(get_valid_nextid)
  while true; do
-    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $NEXTID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $VMID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
      if [ -z "$VMID" ]; then
-        VMID="$NEXTID"
+        VMID=$(get_valid_nextid)
      fi
      if pct status "$VMID" &>/dev/null || qm status "$VMID" &>/dev/null; then
        echo -e "${CROSS}${RD} ID $VMID is already in use${CL}"
--- a/vm/docker-vm.sh
+++ b/vm/docker-vm.sh
@@ -20,7 +20,6 @@ EOF
 header_info
 echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
-NEXTID=$(pvesh get /cluster/nextid)
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
 NSAPP="debian12vm"
@@ -76,6 +75,23 @@ function error_handler() {
  cleanup_vmid
 }

+function get_valid_nextid() {
+  local try_id
+  try_id=$(pvesh get /cluster/nextid)
+  while true; do
+    if [ -f "/etc/pve/qemu-server/${try_id}.conf" ] || [ -f "/etc/pve/lxc/${try_id}.conf" ]; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    if lvs --noheadings -o lv_name | grep -qE "(^|[-_])${try_id}($|[-_])"; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    break
+  done
+  echo "$try_id"
+}
+
 function cleanup_vmid() {
  if qm status $VMID &>/dev/null; then
    qm stop $VMID &>/dev/null
@@ -162,7 +178,7 @@ function exit-script() {
 }

 function default_settings() {
-  VMID="$NEXTID"
+  VMID=$(get_valid_nextid)
  FORMAT=",efitype=4m"
  MACHINE=""
  DISK_CACHE=""
@@ -195,10 +211,11 @@ function default_settings() {

 function advanced_settings() {
  METHOD="advanced"
+  [ -z "${VMID:-}" ] && VMID=$(get_valid_nextid)
  while true; do
-    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $NEXTID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $VMID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
      if [ -z "$VMID" ]; then
-        VMID="$NEXTID"
+        VMID=$(get_valid_nextid)
      fi
      if pct status "$VMID" &>/dev/null || qm status "$VMID" &>/dev/null; then
        echo -e "${CROSS}${RD} ID $VMID is already in use${CL}"
@@ -244,7 +261,6 @@ function advanced_settings() {
    exit-script
  fi

-
  if DISK_CACHE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "DISK CACHE" --radiolist "Choose" --cancel-button Exit-Script 10 58 2 \
    "0" "None (Default)" ON \
    "1" "Write Through" OFF \
--- a/vm/haos-vm.sh
+++ b/vm/haos-vm.sh
@@ -21,15 +21,13 @@ EOF
 header_info
 echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
-NEXTID=$(pvesh get /cluster/nextid)
 VERSIONS=(stable beta dev)
-#API VARIABLES
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
 NSAPP="homeassistant-os"
 var_os="homeassistant"
 DISK_SIZE="32G"
-#
+
 for version in "${VERSIONS[@]}"; do
  eval "$version=$(curl -fsSL https://raw.githubusercontent.com/home-assistant/version/master/stable.json | grep '"ova"' | cut -d '"' -f 4)"
 done
@@ -65,6 +63,23 @@ function error_handler() {
  cleanup_vmid
 }

+function get_valid_nextid() {
+  local try_id
+  try_id=$(pvesh get /cluster/nextid)
+  while true; do
+    if [ -f "/etc/pve/qemu-server/${try_id}.conf" ] || [ -f "/etc/pve/lxc/${try_id}.conf" ]; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    if lvs --noheadings -o lv_name | grep -qE "(^|[-_])${try_id}($|[-_])"; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    break
+  done
+  echo "$try_id"
+}
+
 function cleanup_vmid() {
  if qm status $VMID &>/dev/null; then
    qm stop $VMID &>/dev/null
@@ -166,7 +181,7 @@ function exit-script() {

 function default_settings() {
  BRANCH="$stable"
-  VMID="$NEXTID"
+  VMID=$(get_valid_nextid)
  FORMAT=",efitype=4m"
  MACHINE=""
  DISK_CACHE="cache=writethrough,"
@@ -210,10 +225,11 @@ function advanced_settings() {
    exit-script
  fi

+  [ -z "${VMID:-}" ] && VMID=$(get_valid_nextid)
  while true; do
-    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $NEXTID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $VMID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
      if [ -z "$VMID" ]; then
-        VMID="$NEXTID"
+        VMID="$VMID"
      fi
      if pct status "$VMID" &>/dev/null || qm status "$VMID" &>/dev/null; then
        echo -e "${CROSS}${RD} ID $VMID is already in use${CL}"
--- a/vm/mikrotik-routeros.sh
+++ b/vm/mikrotik-routeros.sh
@@ -21,15 +21,12 @@ clear
 header_info
 echo -e "Loading..."
 GEN_MAC=$(echo '00 60 2f'$(od -An -N3 -t xC /dev/urandom) | sed -e 's/ /:/g' | tr '[:lower:]' '[:upper:]')
-NEXTID=$(pvesh get /cluster/nextid)
-#API VARIABLES
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
 NSAPP="mikrotik-router-os"
 var_os="mikrotik"
 var_version=" "
 DISK_SIZE="1G"
-#
 YW=$(echo "\033[33m")
 BL=$(echo "\033[36m")
 HA=$(echo "\033[1;34m")
@@ -60,6 +57,24 @@ function error_exit() {
  [ ! -z ${VMID-} ] && cleanup_vmid
  exit $EXIT
 }
+
+function get_valid_nextid() {
+  local try_id
+  try_id=$(pvesh get /cluster/nextid)
+  while true; do
+    if [ -f "/etc/pve/qemu-server/${try_id}.conf" ] || [ -f "/etc/pve/lxc/${try_id}.conf" ]; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    if lvs --noheadings -o lv_name | grep -qE "(^|[-_])${try_id}($|[-_])"; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    break
+  done
+  echo "$try_id"
+}
+
 function cleanup_vmid() {
  if $(qm status $VMID &>/dev/null); then
    if [ "$(qm status $VMID | awk '{print $2}')" == "running" ]; then
--- a/vm/nextcloud-vm.sh
+++ b/vm/nextcloud-vm.sh
@@ -19,16 +19,13 @@ EOF
 }
 header_info
 echo -e "\n Loading..."
-#API VARIABLES
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
 NSAPP="turnkey-nextcloud"
 var_os="turnkey-nextcloud"
 var_version=" "
 DISK_SIZE="12G"
-#
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
-NEXTID=$(pvesh get /cluster/nextid)
 NAME="TurnKey Nexcloud VM"
 YW=$(echo "\033[33m")
 BL=$(echo "\033[36m")
@@ -58,6 +55,23 @@ function error_handler() {
  cleanup_vmid
 }

+function get_valid_nextid() {
+  local try_id
+  try_id=$(pvesh get /cluster/nextid)
+  while true; do
+    if [ -f "/etc/pve/qemu-server/${try_id}.conf" ] || [ -f "/etc/pve/lxc/${try_id}.conf" ]; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    if lvs --noheadings -o lv_name | grep -qE "(^|[-_])${try_id}($|[-_])"; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    break
+  done
+  echo "$try_id"
+}
+
 function cleanup_vmid() {
  if qm status $VMID &>/dev/null; then
    qm stop $VMID &>/dev/null
@@ -142,7 +156,7 @@ function exit-script() {
 }

 function default_settings() {
-  VMID="$NEXTID"
+  VMID=$(get_valid_nextid)
  FORMAT=",efitype=4m"
  MACHINE=""
  DISK_CACHE=""
@@ -173,10 +187,11 @@ function default_settings() {

 function advanced_settings() {
  METHOD="advanced"
+  [ -z "${VMID:-}" ] && VMID=$(get_valid_nextid)
  while true; do
-    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $NEXTID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $VMID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
      if [ -z "$VMID" ]; then
-        VMID="$NEXTID"
+        VMID=$(get_valid_nextid)
      fi
      if pct status "$VMID" &>/dev/null || qm status "$VMID" &>/dev/null; then
        echo -e "${CROSS}${RD} ID $VMID is already in use${CL}"
--- a/vm/openwrt.sh
+++ b/vm/openwrt.sh
@@ -23,17 +23,15 @@ EOF
 }
 header_info
 echo -e "Loading..."
-#API VARIABLES
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
 NSAPP="openwrt-vm"
 var_os="openwrt"
 var_version=" "
 DISK_SIZE="0.5G"
-#
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
 GEN_MAC_LAN=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
-NEXTID=$(pvesh get /cluster/nextid)
+
 YW=$(echo "\033[33m")
 BL=$(echo "\033[36m")
 HA=$(echo "\033[1;34m")
@@ -61,6 +59,23 @@ function error_handler() {
  cleanup_vmid
 }

+function get_valid_nextid() {
+  local try_id
+  try_id=$(pvesh get /cluster/nextid)
+  while true; do
+    if [ -f "/etc/pve/qemu-server/${try_id}.conf" ] || [ -f "/etc/pve/lxc/${try_id}.conf" ]; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    if lvs --noheadings -o lv_name | grep -qE "(^|[-_])${try_id}($|[-_])"; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    break
+  done
+  echo "$try_id"
+}
+
 function cleanup_vmid() {
  if qm status $VMID &>/dev/null; then
    qm stop $VMID &>/dev/null
@@ -242,10 +257,11 @@ function default_settings() {

 function advanced_settings() {
  METHOD="advanced"
+  [ -z "${VMID:-}" ] && VMID=$(get_valid_nextid)
  while true; do
-    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $NEXTID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $VMID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
      if [ -z "$VMID" ]; then
-        VMID="$NEXTID"
+        VMID=$(get_valid_nextid)
      fi
      if pct status "$VMID" &>/dev/null || qm status "$VMID" &>/dev/null; then
        echo -e "${CROSS}${RD} ID $VMID is already in use${CL}"
--- a/vm/opnsense-vm.sh
+++ b/vm/opnsense-vm.sh
@@ -28,7 +28,7 @@ var_version="25.1"
 #
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
 GEN_MAC_LAN=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
-NEXTID=$(pvesh get /cluster/nextid)
+
 YW=$(echo "\033[33m")
 BL=$(echo "\033[36m")
 HA=$(echo "\033[1;34m")
@@ -54,6 +54,23 @@ function error_handler() {
  cleanup_vmid
 }

+function get_valid_nextid() {
+  local try_id
+  try_id=$(pvesh get /cluster/nextid)
+  while true; do
+    if [ -f "/etc/pve/qemu-server/${try_id}.conf" ] || [ -f "/etc/pve/lxc/${try_id}.conf" ]; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    if lvs --noheadings -o lv_name | grep -qE "(^|[-_])${try_id}($|[-_])"; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    break
+  done
+  echo "$try_id"
+}
+
 function cleanup_vmid() {
  if qm status $VMID &>/dev/null; then
    qm stop $VMID &>/dev/null
@@ -202,7 +219,7 @@ function exit-script() {
 }

 function default_settings() {
-  VMID="$NEXTID"
+  VMID=$(get_valid_nextid)
  FORMAT=",efitype=4m"
  MACHINE=""
  DISK_CACHE=""
@@ -252,10 +269,11 @@ function default_settings() {
 function advanced_settings() {
  local ip_regex='^([0-9]{1,3})\.([0-9]{1,3})\.([0-9]{1,3})\.([0-9]{1,3})$'
  METHOD="advanced"
+  [ -z "${VMID:-}" ] && VMID=$(get_valid_nextid)
  while true; do
-    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $NEXTID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $VMID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
      if [ -z "$VMID" ]; then
-        VMID="$NEXTID"
+        VMID=$(get_valid_nextid)
      fi
      if pct status "$VMID" &>/dev/null || qm status "$VMID" &>/dev/null; then
        echo -e "${CROSS}${RD} ID $VMID is already in use${CL}"
--- a/vm/owncloud-vm.sh
+++ b/vm/owncloud-vm.sh
@@ -19,17 +19,15 @@ EOF
 }
 header_info
 echo -e "\n Loading..."
-#API VARIABLES
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
 NSAPP="turnkey-owncloud-vm"
 var_os="owncloud"
 var_version="12"
 DISK_SIZE="12G"
-#
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
-NEXTID=$(pvesh get /cluster/nextid)
 NAME="TurnKey ownCloud VM"
+
 YW=$(echo "\033[33m")
 BL=$(echo "\033[36m")
 HA=$(echo "\033[1;34m")
@@ -58,6 +56,23 @@ function error_handler() {
  cleanup_vmid
 }

+function get_valid_nextid() {
+  local try_id
+  try_id=$(pvesh get /cluster/nextid)
+  while true; do
+    if [ -f "/etc/pve/qemu-server/${try_id}.conf" ] || [ -f "/etc/pve/lxc/${try_id}.conf" ]; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    if lvs --noheadings -o lv_name | grep -qE "(^|[-_])${try_id}($|[-_])"; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    break
+  done
+  echo "$try_id"
+}
+
 function cleanup_vmid() {
  if qm status $VMID &>/dev/null; then
    qm stop $VMID &>/dev/null
@@ -142,7 +157,7 @@ function exit-script() {
 }

 function default_settings() {
-  VMID="$NEXTID"
+  VMID=$(get_valid_nextid)
  FORMAT=",efitype=4m"
  MACHINE=""
  DISK_CACHE=""
@@ -173,10 +188,11 @@ function default_settings() {

 function advanced_settings() {
  METHOD="advanced"
+  [ -z "${VMID:-}" ] && VMID=$(get_valid_nextid)
  while true; do
-    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $NEXTID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $VMID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
      if [ -z "$VMID" ]; then
-        VMID="$NEXTID"
+        VMID=$(get_valid_nextid)
      fi
      if pct status "$VMID" &>/dev/null || qm status "$VMID" &>/dev/null; then
        echo -e "${CROSS}${RD} ID $VMID is already in use${CL}"
--- a/vm/pimox-haos-vm.sh
+++ b/vm/pimox-haos-vm.sh
@@ -24,17 +24,14 @@ EOF
 clear
 header_info
 echo -e "Loading..."
-#API VARIABLES
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
 NSAPP="pimox-haos-vm"
 var_os="pimox-haos"
 var_version=" "
 DISK_SIZE="32G"
-#
 GEN_MAC=$(echo '00 60 2f'$(od -An -N3 -t xC /dev/urandom) | sed -e 's/ /:/g' | tr '[:lower:]' '[:upper:]')
 USEDID=$(pvesh get /cluster/resources --type vm --output-format yaml | egrep -i 'vmid' | awk '{print substr($2, 1, length($2)-0) }')
-NEXTID=$(pvesh get /cluster/nextid)
 STABLE=$(curl -fsSL https://raw.githubusercontent.com/home-assistant/version/master/stable.json | grep "ova" | awk '{print substr($2, 2, length($2)-3) }')
 BETA=$(curl -fsSL https://raw.githubusercontent.com/home-assistant/version/master/beta.json | grep "ova" | awk '{print substr($2, 2, length($2)-3) }')
 DEV=$(curl -fsSL https://raw.githubusercontent.com/home-assistant/version/master/dev.json | grep "ova" | awk '{print substr($2, 2, length($2)-3) }')
@@ -70,6 +67,24 @@ function error_exit() {
  [ ! -z ${VMID-} ] && cleanup_vmid
  exit $EXIT
 }
+
+function get_valid_nextid() {
+  local try_id
+  try_id=$(pvesh get /cluster/nextid)
+  while true; do
+    if [ -f "/etc/pve/qemu-server/${try_id}.conf" ] || [ -f "/etc/pve/lxc/${try_id}.conf" ]; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    if lvs --noheadings -o lv_name | grep -qE "(^|[-_])${try_id}($|[-_])"; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    break
+  done
+  echo "$try_id"
+}
+
 function cleanup_vmid() {
  if $(qm status $VMID &>/dev/null); then
    if [ "$(qm status $VMID | awk '{print $2}')" == "running" ]; then
--- a/vm/ubuntu2204-vm.sh
+++ b/vm/ubuntu2204-vm.sh
@@ -20,7 +20,6 @@ EOF
 header_info
 echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
-NEXTID=$(pvesh get /cluster/nextid)
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
 NSAPP="ubuntu-2204-vm"
@@ -33,8 +32,6 @@ RD=$(echo "\033[01;31m")
 BGN=$(echo "\033[4;92m")
 GN=$(echo "\033[1;92m")
 DGN=$(echo "\033[32m")
-CL=$(echo "\033[m")
-
 CL=$(echo "\033[m")
 BOLD=$(echo "\033[1m")
 BFR="\\r\\033[K"
@@ -75,6 +72,23 @@ function error_handler() {
  cleanup_vmid
 }

+function get_valid_nextid() {
+  local try_id
+  try_id=$(pvesh get /cluster/nextid)
+  while true; do
+    if [ -f "/etc/pve/qemu-server/${try_id}.conf" ] || [ -f "/etc/pve/lxc/${try_id}.conf" ]; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    if lvs --noheadings -o lv_name | grep -qE "(^|[-_])${try_id}($|[-_])"; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    break
+  done
+  echo "$try_id"
+}
+
 function cleanup_vmid() {
  if qm status $VMID &>/dev/null; then
    qm stop $VMID &>/dev/null
@@ -160,7 +174,7 @@ function exit-script() {
 }

 function default_settings() {
-  VMID="$NEXTID"
+  VMID=$(get_valid_nextid)
  FORMAT=",efitype=4m"
  MACHINE=""
  DISK_SIZE="5G"
@@ -193,10 +207,11 @@ function default_settings() {

 function advanced_settings() {
  METHOD="advanced"
+  [ -z "${VMID:-}" ] && VMID=$(get_valid_nextid)
  while true; do
-    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $NEXTID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $VMID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
      if [ -z "$VMID" ]; then
-        VMID="$NEXTID"
+        VMID=$(get_valid_nextid)
      fi
      if pct status "$VMID" &>/dev/null || qm status "$VMID" &>/dev/null; then
        echo -e "${CROSS}${RD} ID $VMID is already in use${CL}"
--- a/vm/ubuntu2404-vm.sh
+++ b/vm/ubuntu2404-vm.sh
@@ -21,7 +21,6 @@ EOF
 header_info
 echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
-NEXTID=$(pvesh get /cluster/nextid)
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
 NSAPP="ubuntu-2404-vm"
@@ -76,6 +75,23 @@ function error_handler() {
  cleanup_vmid
 }

+function get_valid_nextid() {
+  local try_id
+  try_id=$(pvesh get /cluster/nextid)
+  while true; do
+    if [ -f "/etc/pve/qemu-server/${try_id}.conf" ] || [ -f "/etc/pve/lxc/${try_id}.conf" ]; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    if lvs --noheadings -o lv_name | grep -qE "(^|[-_])${try_id}($|[-_])"; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    break
+  done
+  echo "$try_id"
+}
+
 function cleanup_vmid() {
  if qm status $VMID &>/dev/null; then
    qm stop $VMID &>/dev/null
@@ -161,7 +177,7 @@ function exit-script() {
 }

 function default_settings() {
-  VMID="$NEXTID"
+  VMID=$(get_valid_nextid)
  FORMAT=",efitype=4m"
  MACHINE=""
  DISK_SIZE="7G"
@@ -194,10 +210,11 @@ function default_settings() {

 function advanced_settings() {
  METHOD="advanced"
+  [ -z "${VMID:-}" ] && VMID=$(get_valid_nextid)
  while true; do
-    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $NEXTID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $VMID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
      if [ -z "$VMID" ]; then
-        VMID="$NEXTID"
+        VMID=$(get_valid_nextid)
      fi
      if pct status "$VMID" &>/dev/null || qm status "$VMID" &>/dev/null; then
        echo -e "${CROSS}${RD} ID $VMID is already in use${CL}"
--- a/vm/ubuntu2410-vm.sh
+++ b/vm/ubuntu2410-vm.sh
@@ -20,7 +20,6 @@ EOF
 header_info
 echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
-NEXTID=$(pvesh get /cluster/nextid)
 RANDOM_UUID="$(cat /proc/sys/kernel/random/uuid)"
 METHOD=""
 NSAPP="ubuntu-2410-vm"
@@ -75,6 +74,23 @@ function error_handler() {
  cleanup_vmid
 }

+function get_valid_nextid() {
+  local try_id
+  try_id=$(pvesh get /cluster/nextid)
+  while true; do
+    if [ -f "/etc/pve/qemu-server/${try_id}.conf" ] || [ -f "/etc/pve/lxc/${try_id}.conf" ]; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    if lvs --noheadings -o lv_name | grep -qE "(^|[-_])${try_id}($|[-_])"; then
+      try_id=$((try_id + 1))
+      continue
+    fi
+    break
+  done
+  echo "$try_id"
+}
+
 function cleanup_vmid() {
  if qm status $VMID &>/dev/null; then
    qm stop $VMID &>/dev/null
@@ -160,7 +176,7 @@ function exit-script() {
 }

 function default_settings() {
-  VMID="$NEXTID"
+  VMID=$(get_valid_nextid)
  FORMAT=",efitype=4m"
  MACHINE=""
  DISK_SIZE="8G"
@@ -193,10 +209,11 @@ function default_settings() {

 function advanced_settings() {
  METHOD="advanced"
+  [ -z "${VMID:-}" ] && VMID=$(get_valid_nextid)
  while true; do
-    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $NEXTID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
+    if VMID=$(whiptail --backtitle "Proxmox VE Helper Scripts" --inputbox "Set Virtual Machine ID" 8 58 $VMID --title "VIRTUAL MACHINE ID" --cancel-button Exit-Script 3>&1 1>&2 2>&3); then
      if [ -z "$VMID" ]; then
-        VMID="$NEXTID"
+        VMID=$(get_valid_nextid)
      fi
      if pct status "$VMID" &>/dev/null || qm status "$VMID" &>/dev/null; then
        echo -e "${CROSS}${RD} ID $VMID is already in use${CL}"
Author	SHA1	Message	Date
Slaviša Arežina	9cddbbd986	Update docs (#4298 )	2025-05-07 15:21:03 +02:00
community-scripts-pr-app[bot]	31c7c9301c	Update versions.json (#4297 ) Co-authored-by: GitHub Actions[bot] <github-actions[bot]@users.noreply.github.com>	2025-05-07 14:32:30 +02:00
CanbiZ	c9aad3a54d	Feature: get correct next VMID (#4292 ) fix(vm-creation): ensure whiptail VMID inputbox is pre-filled with a valid and available ID - Replaced hardcoded NEXTID usage with a new get_valid_nextid() function - Ensures no collision with existing VMs, LXCs or orphaned LVM volumes - Improves user experience by properly pre-filling whiptail inputbox - Automatically skips invalid IDs instead of failing on alloc	2025-05-07 12:37:46 +02:00
community-scripts-pr-app[bot]	ebc17e120e	Update CHANGELOG.md (#4290 ) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2025-05-07 10:45:52 +02:00
Slaviša Arežina	1ebb1782fa	Give more disk space to LXC (#4288 )	2025-05-07 10:40:49 +02:00
community-scripts-pr-app[bot]	cce3ca1996	Update CHANGELOG.md (#4287 ) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2025-05-07 10:04:46 +02:00
Slaviša Arežina	eb6018ac01	SuwayomiServer: Bump Java to v21, code formating (#3987 ) * Bump java to v21, code formating * Refactoring * Update * Update * Update suwayomiserver.sh --------- Co-authored-by: CanbiZ <47820557+MickLesk@users.noreply.github.com>	2025-05-07 09:52:39 +02:00
community-scripts-pr-app[bot]	3b54371d5c	Update versions.json (#4285 )	2025-05-07 08:20:00 +02:00