fix(core): Improve formatting, logging, and rollback integrity in core modules

ts/mod_format/classes.rollbackmanager.ts

@@ -43,7 +43,7 @@ export class RollbackManager {
     }
     
     // Read file content and metadata
-    const content = await plugins.smartfile.fs.toStringSync(absolutePath);
+    const content = plugins.smartfile.fs.toStringSync(absolutePath);
     const stats = await plugins.smartfile.fs.stat(absolutePath);
     const checksum = this.calculateChecksum(content);
     
@@ -82,7 +82,7 @@ export class RollbackManager {
       
       // Verify backup integrity
       const backupPath = this.getBackupPath(operationId, file.path);
-      const backupContent = await plugins.smartfile.fs.toStringSync(backupPath);
+      const backupContent = plugins.smartfile.fs.toStringSync(backupPath);
       const backupChecksum = this.calculateChecksum(backupContent);
       
       if (backupChecksum !== file.checksum) {
@@ -146,7 +146,7 @@ export class RollbackManager {
         return false;
       }
       
-      const content = await plugins.smartfile.fs.toStringSync(backupPath);
+      const content = plugins.smartfile.fs.toStringSync(backupPath);
       const checksum = this.calculateChecksum(content);
       
       if (checksum !== file.checksum) {
@@ -185,17 +185,63 @@ export class RollbackManager {
   }
   
   private async getManifest(): Promise<{ operations: IFormatOperation[] }> {
+    const defaultManifest = { operations: [] };
+    
     const exists = await plugins.smartfile.fs.fileExists(this.manifestPath);
     if (!exists) {
-      return { operations: [] };
+      return defaultManifest;
     }
     
-    const content = await plugins.smartfile.fs.toStringSync(this.manifestPath);
-    return JSON.parse(content);
+    try {
+      const content = plugins.smartfile.fs.toStringSync(this.manifestPath);
+      const manifest = JSON.parse(content);
+      
+      // Validate the manifest structure
+      if (this.isValidManifest(manifest)) {
+        return manifest;
+      } else {
+        console.warn('Invalid rollback manifest structure, returning default manifest');
+        return defaultManifest;
+      }
+    } catch (error) {
+      console.warn(`Failed to read rollback manifest: ${error.message}, returning default manifest`);
+      // Try to delete the corrupted file
+      try {
+        await plugins.smartfile.fs.remove(this.manifestPath);
+      } catch (removeError) {
+        // Ignore removal errors
+      }
+      return defaultManifest;
+    }
   }
   
   private async saveManifest(manifest: { operations: IFormatOperation[] }): Promise<void> {
-    await plugins.smartfile.memory.toFs(JSON.stringify(manifest, null, 2), this.manifestPath);
+    // Validate before saving
+    if (!this.isValidManifest(manifest)) {
+      throw new Error('Invalid rollback manifest structure, cannot save');
+    }
+    
+    // Use atomic write: write to temp file, then move it
+    const tempPath = `${this.manifestPath}.tmp`;
+    
+    try {
+      // Write to temporary file
+      const jsonContent = JSON.stringify(manifest, null, 2);
+      await plugins.smartfile.memory.toFs(jsonContent, tempPath);
+      
+      // Move temp file to actual manifest (atomic-like operation)
+      // Since smartfile doesn't have rename, we copy and delete
+      await plugins.smartfile.fs.copy(tempPath, this.manifestPath);
+      await plugins.smartfile.fs.remove(tempPath);
+    } catch (error) {
+      // Clean up temp file if it exists
+      try {
+        await plugins.smartfile.fs.remove(tempPath);
+      } catch (removeError) {
+        // Ignore removal errors
+      }
+      throw error;
+    }
   }
   
   private async getOperation(operationId: string): Promise<IFormatOperation | null> {
@@ -215,4 +261,38 @@ export class RollbackManager {
     
     await this.saveManifest(manifest);
   }
+  
+  private isValidManifest(manifest: any): manifest is { operations: IFormatOperation[] } {
+    // Check if manifest has the required structure
+    if (!manifest || typeof manifest !== 'object') {
+      return false;
+    }
+    
+    // Check required fields
+    if (!Array.isArray(manifest.operations)) {
+      return false;
+    }
+    
+    // Check each operation entry
+    for (const operation of manifest.operations) {
+      if (!operation || typeof operation !== 'object' ||
+          typeof operation.id !== 'string' ||
+          typeof operation.timestamp !== 'number' ||
+          typeof operation.status !== 'string' ||
+          !Array.isArray(operation.files)) {
+        return false;
+      }
+      
+      // Check each file in the operation
+      for (const file of operation.files) {
+        if (!file || typeof file !== 'object' ||
+            typeof file.path !== 'string' ||
+            typeof file.checksum !== 'string') {
+          return false;
+        }
+      }
+    }
+    
+    return true;
+  }
 }