From 9dc74fd392ea0bb420eb4831e678a6312b416524 Mon Sep 17 00:00:00 2001 From: Juergen Kunz Date: Thu, 5 Mar 2026 15:35:57 +0000 Subject: [PATCH] fix(compiler): force global filesystem sync to flush XFS delayed logging and add diagnostics comparing Node's readdirSync with system ls to detect directory entry inconsistencies --- changelog.md | 7 +++++ ts/00_commitinfo_data.ts | 2 +- ts/mod_compiler/classes.tscompiler.ts | 38 +++++++++++++-------------- 3 files changed, 27 insertions(+), 20 deletions(-) diff --git a/changelog.md b/changelog.md index c129163..d85a326 100644 --- a/changelog.md +++ b/changelog.md @@ -1,5 +1,12 @@ # Changelog +## 2026-03-05 - 4.2.2 - fix(compiler) +force global filesystem sync to flush XFS delayed logging and add diagnostics comparing Node's readdirSync with system ls to detect directory entry inconsistencies + +- Replace per-directory fs.fsyncSync loop with execSync('sync') to ensure parent B+tree metadata is flushed on XFS +- Import execSync from child_process +- Add diagnostic comparison: run ls -1 and compare its entries to fs.readdirSync; log mismatches and full entry lists for debugging Node.js caching/readdir inconsistencies + ## 2026-03-05 - 4.2.1 - fix(compiler) use TypeScript sys hooks instead of fs monkeypatching to detect writes/deletes in previous output directories diff --git a/ts/00_commitinfo_data.ts b/ts/00_commitinfo_data.ts index f164013..df38eb4 100644 --- a/ts/00_commitinfo_data.ts +++ b/ts/00_commitinfo_data.ts @@ -3,6 +3,6 @@ */ export const commitinfo = { name: '@git.zone/tsbuild', - version: '4.2.1', + version: '4.2.2', description: 'A tool for compiling TypeScript files using the latest nightly features, offering flexible APIs and a CLI for streamlined development.' } diff --git a/ts/mod_compiler/classes.tscompiler.ts b/ts/mod_compiler/classes.tscompiler.ts index 2eb5238..716c876 100644 --- a/ts/mod_compiler/classes.tscompiler.ts +++ b/ts/mod_compiler/classes.tscompiler.ts @@ -1,6 +1,7 @@ import type { CompilerOptions, Diagnostic, Program } from 'typescript'; import typescript from 'typescript'; import * as fs from 'fs'; +import { execSync } from 'child_process'; import * as smartdelay from '@push.rocks/smartdelay'; import * as smartpromise from '@push.rocks/smartpromise'; import * as smartpath from '@push.rocks/smartpath'; @@ -453,29 +454,28 @@ export class TsCompiler { successfulOutputDirs.push(destDir); } - // Fsync all output directories to force XFS metadata commit - // before the next compilation step. Without this, XFS delayed logging - // can cause directory entries from previous compilations to become - // invisible or corrupted during subsequent TypeScript emit operations. - for (const dir of successfulOutputDirs) { - try { - const fd = fs.openSync(dir, 'r'); - fs.fsyncSync(fd); - fs.closeSync(fd); - } catch { - // Directory might not exist yet - } - } + // Force global filesystem sync to flush XFS delayed logging (CIL) + // before the next compilation step. Per-directory fsync was insufficient; + // XFS defers parent B+tree metadata commits which can make sibling + // directory entries invisible to readdirSync after heavy write activity. + execSync('sync'); - // Diagnostic: log all output directory states after each compilation + // Diagnostic: compare readdirSync vs external ls to detect Node.js caching if (!isQuiet && !isJson) { for (const prevDir of successfulOutputDirs) { try { - const entries = fs.readdirSync(prevDir); - const dirs = entries.filter(e => { - try { return fs.statSync(prevDir + '/' + e).isDirectory(); } catch { return false; } - }); - console.log(` 📋 [diag] ${prevDir.replace(this.cwd + '/', '')}: ${entries.length} entries, ${dirs.length} dirs`); + const nodeEntries = fs.readdirSync(prevDir); + const nodeDirs = nodeEntries.filter(e => { try { return fs.statSync(prevDir + '/' + e).isDirectory(); } catch { return false; } }); + const lsOutput = execSync(`ls -1 "${prevDir}"`, { encoding: 'utf8' }).trim(); + const lsEntries = lsOutput ? lsOutput.split('\n') : []; + const shortDir = prevDir.replace(this.cwd + '/', ''); + if (nodeEntries.length !== lsEntries.length) { + console.log(` ⚠️ [diag] ${shortDir}: readdirSync=${nodeEntries.length}, ls=${lsEntries.length} (MISMATCH!)`); + console.log(` readdirSync: [${nodeEntries.sort().join(', ')}]`); + console.log(` ls: [${lsEntries.sort().join(', ')}]`); + } else { + console.log(` 📋 [diag] ${shortDir}: ${nodeEntries.length} entries, ${nodeDirs.length} dirs ✓`); + } } catch { console.log(` 📋 [diag] ${prevDir.replace(this.cwd + '/', '')}: MISSING!`); }