From 2f976ac5cef45865637aaa491ea3310a340f7f56 Mon Sep 17 00:00:00 2001
From: Philipp Kunz <gitlab@philkunz.com>
Date: Tue, 8 Mar 2022 15:12:51 +0100
Subject: [PATCH] fix(core): update

---
 package-lock.json                           | 14 +++----
 package.json                                |  2 +-
 test/test.nonci.ts                          |  3 +-
 ts/smartclickhouse.classes.timedatatable.ts | 45 ++++++++++++++++-----
 4 files changed, 46 insertions(+), 18 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 9e65a6b..f7551ec 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -10,7 +10,7 @@
       "license": "MIT",
       "dependencies": {
         "@depyronick/clickhouse-client": "^1.0.12",
-        "@pushrocks/smartobject": "^1.0.8"
+        "@pushrocks/smartobject": "^1.0.9"
       },
       "devDependencies": {
         "@gitzone/tsbuild": "^2.1.25",
@@ -2635,9 +2635,9 @@
       }
     },
     "node_modules/@pushrocks/smartobject": {
-      "version": "1.0.8",
-      "resolved": "https://verdaccio.lossless.one/@pushrocks%2fsmartobject/-/smartobject-1.0.8.tgz",
-      "integrity": "sha512-sqrmbPkCZe4+OTqFGYEUBgwG9J/gMVdjz6Tuy8B7v5RaRvUobcjBk7FBa0ahMMPmuKEbddC5xa8+Jqtjb4iJAA==",
+      "version": "1.0.9",
+      "resolved": "https://verdaccio.lossless.one/@pushrocks%2fsmartobject/-/smartobject-1.0.9.tgz",
+      "integrity": "sha512-74IlcVWhhEOsG7X65H4DmYP1o8HejZMWj5uATCk99A+XjZMi8UJu8H7EsgT++JJKkwLz2BKc9323BfNk1B79WA==",
       "license": "MIT",
       "dependencies": {
         "fast-deep-equal": "^3.1.3",
@@ -17723,9 +17723,9 @@
       }
     },
     "@pushrocks/smartobject": {
-      "version": "1.0.8",
-      "resolved": "https://verdaccio.lossless.one/@pushrocks%2fsmartobject/-/smartobject-1.0.8.tgz",
-      "integrity": "sha512-sqrmbPkCZe4+OTqFGYEUBgwG9J/gMVdjz6Tuy8B7v5RaRvUobcjBk7FBa0ahMMPmuKEbddC5xa8+Jqtjb4iJAA==",
+      "version": "1.0.9",
+      "resolved": "https://verdaccio.lossless.one/@pushrocks%2fsmartobject/-/smartobject-1.0.9.tgz",
+      "integrity": "sha512-74IlcVWhhEOsG7X65H4DmYP1o8HejZMWj5uATCk99A+XjZMi8UJu8H7EsgT++JJKkwLz2BKc9323BfNk1B79WA==",
       "requires": {
         "fast-deep-equal": "^3.1.3",
         "minimatch": "^5.0.1"
diff --git a/package.json b/package.json
index db94aba..5fe139e 100644
--- a/package.json
+++ b/package.json
@@ -24,7 +24,7 @@
   },
   "dependencies": {
     "@depyronick/clickhouse-client": "^1.0.12",
-    "@pushrocks/smartobject": "^1.0.8"
+    "@pushrocks/smartobject": "^1.0.9"
   },
   "browserslist": [
     "last 1 chrome versions"
diff --git a/test/test.nonci.ts b/test/test.nonci.ts
index 855d3ec..0c2e832 100644
--- a/test/test.nonci.ts
+++ b/test/test.nonci.ts
@@ -23,7 +23,8 @@ tap.test('should create a timedatatable', async () => {
       message: `hello this is a message ${i}`,
       wow: 'hey',
       deep: {
-        so: 'hello'
+        so: 'hello',
+        myArray: ['array1', 'array2']
       }
     });
     i++;
diff --git a/ts/smartclickhouse.classes.timedatatable.ts b/ts/smartclickhouse.classes.timedatatable.ts
index caa1e40..efd4be3 100644
--- a/ts/smartclickhouse.classes.timedatatable.ts
+++ b/ts/smartclickhouse.classes.timedatatable.ts
@@ -1,7 +1,7 @@
 import * as plugins from './smartclickhouse.plugins';
 import { SmartClickHouseDb } from './smartclickhouse.classes.smartclickhouse';
 
-export type TClickhouseColumnDataType = 'String' | "DateTime64(3, 'Europe/Berlin')" | 'Float64';
+export type TClickhouseColumnDataType = 'String' | "DateTime64(3, 'Europe/Berlin')" | 'Float64' | 'Array(String)' | 'Array(Float64)';
 export interface IColumnInfo {
   database: string;
   table: string;
@@ -82,14 +82,25 @@ export class TimeDataTable {
     let storageJson: { [key: string]: any } = {};
     
     // helper stuff
-    const typeConversion: {[key: string]: TClickhouseColumnDataType} = {
-      string: 'String',
-      number: 'Float64',
-    };
-    const getClickhouseTypeForValue = (valueArg: any) => {
+    
+    const getClickhouseTypeForValue = (valueArg: any): TClickhouseColumnDataType => {
+      const typeConversion: {[key: string]: TClickhouseColumnDataType} = {
+        string: 'String',
+        number: 'Float64',
+        undefined: null,
+        null: null
+      };
+      if (valueArg instanceof Array) {
+        const arrayType = typeConversion[(typeof valueArg[0]) as string];
+        if (!arrayType) {
+          return null;
+        } else {
+          return `Array(${arrayType})` as TClickhouseColumnDataType;
+        }
+      }
       return typeConversion[(typeof valueArg) as string];
     }
-    const checkPath = async (pathArg: string, typeArg: TClickhouseColumnDataType) => {
+    const checkPath = async (pathArg: string, typeArg: TClickhouseColumnDataType, prechecked = false) => {
       let columnFound = false;
       for (const column of this.columns) {
         if (pathArg === column.name) {
@@ -98,9 +109,22 @@ export class TimeDataTable {
         }
       }
       if (!columnFound) {
-        await this.smartClickHouseDbRef.clickhouseClient.queryPromise(`
-          ALTER TABLE ${this.tableName} ADD COLUMN ${pathArg} ${typeArg} FIRST
+        if (!prechecked) {
+          await this.updateColumns();
+          await checkPath(pathArg, typeArg, true);
+          return;
+        }
+        const alterString = `ALTER TABLE ${this.tableName} ADD COLUMN ${pathArg} ${typeArg} FIRST`
+        try {
+          await this.smartClickHouseDbRef.clickhouseClient.queryPromise(`
+          ${alterString}
         `);
+        } catch(err) {
+          console.log(alterString);
+          for (const column of this.columns) {
+            console.log(column.name);
+          }
+        }
         await this.updateColumns();
       }
     };
@@ -117,6 +141,9 @@ export class TimeDataTable {
       }
       // lets deal with the rest
       const clickhouseType = getClickhouseTypeForValue(value);
+      if (!clickhouseType) {
+        continue;
+      }
       await checkPath(key, clickhouseType);
       storageJson[key] = value;
     }