From acba539a6fa4a3beba6c4d1426c8441b41133501 Mon Sep 17 00:00:00 2001 From: Phil Kunz Date: Fri, 8 Jan 2021 22:08:01 +0000 Subject: [PATCH] fix(core): update --- .gitlab-ci.yml | 16 ++++++++++++++-- package.json | 2 +- ts/smartssr.classes.smartssr.ts | 1 - ts/smartssr.function.serialize.ts | 5 +++-- 4 files changed, 18 insertions(+), 6 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d931318..9a4467e 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -26,16 +26,28 @@ mirror: - docker - notpriv -audit: +auditProductionDependencies: + image: registry.gitlab.com/hosttoday/ht-docker-node:npmci + stage: security + script: + - npmci npm prepare + - npmci command npm install --production --ignore-scripts + - npmci command npm config set registry https://registry.npmjs.org + - npmci command npm audit --audit-level=high --only=prod --production + tags: + - docker + +auditDevDependencies: image: registry.gitlab.com/hosttoday/ht-docker-node:npmci stage: security script: - npmci npm prepare - npmci command npm install --ignore-scripts - npmci command npm config set registry https://registry.npmjs.org - - npmci command npm audit --audit-level=high + - npmci command npm audit --audit-level=high --only=dev tags: - docker + allow_failure: true # ==================== # test stage diff --git a/package.json b/package.json index b867bdb..0695ae8 100644 --- a/package.json +++ b/package.json @@ -43,4 +43,4 @@ "browserslist": [ "last 1 chrome versions" ] -} +} \ No newline at end of file diff --git a/ts/smartssr.classes.smartssr.ts b/ts/smartssr.classes.smartssr.ts index 13edcb0..df293fd 100644 --- a/ts/smartssr.classes.smartssr.ts +++ b/ts/smartssr.classes.smartssr.ts @@ -66,7 +66,6 @@ export class SmartSSR { const renderedPageString = pageContent; resultDeferred.resolve(renderedPageString); - const result = await resultDeferred.promise; renderTimeMeasurement.stop(); diff --git a/ts/smartssr.function.serialize.ts b/ts/smartssr.function.serialize.ts index 9d2e044..196c485 100644 --- a/ts/smartssr.function.serialize.ts +++ b/ts/smartssr.function.serialize.ts @@ -47,11 +47,12 @@ export function serializeFunction(rootNode) { slotsForMove.push(slot); }); - for (const slot of slotsForMove) { const slottedLightNodesForMove = []; slot.assignedNodes().forEach((lightNode) => slottedLightNodesForMove.push(lightNode)); - slottedLightNodesForMove.forEach((lightNode) => slot.parentNode.insertBefore(lightNode, slot)); + slottedLightNodesForMove.forEach((lightNode) => + slot.parentNode.insertBefore(lightNode, slot) + ); } // lets modify the css