fix(core): tidy formatting and minor fixes across CLI, SNMP, HTTP server, migrations and packaging

test/test.ts

@@ -1,9 +1,9 @@
 import { assert, assertEquals, assertExists } from 'jsr:@std/assert@^1.0.0';
 import { NupstSnmp } from '../ts/snmp/manager.ts';
 import { UpsOidSets } from '../ts/snmp/oid-sets.ts';
-import type { ISnmpConfig, TUpsModel, IOidSet } from '../ts/snmp/types.ts';
+import type { IOidSet, ISnmpConfig, TUpsModel } from '../ts/snmp/types.ts';
 import { shortId } from '../ts/helpers/shortid.ts';
-import { TIMING, SNMP, THRESHOLDS, HTTP_SERVER, UI } from '../ts/constants.ts';
+import { HTTP_SERVER, SNMP, THRESHOLDS, TIMING, UI } from '../ts/constants.ts';
 import { Action, type IActionContext } from '../ts/actions/base-action.ts';
 
 import * as qenv from 'npm:@push.rocks/qenv@^6.0.0';
@@ -56,8 +56,14 @@ Deno.test('SNMP constants: port is 161', () => {
 });
 
 Deno.test('SNMP constants: timeouts increase with security level', () => {
-  assert(SNMP.TIMEOUT_NO_AUTH_MS <= SNMP.TIMEOUT_AUTH_MS, 'Auth timeout should be >= noAuth timeout');
-  assert(SNMP.TIMEOUT_AUTH_MS <= SNMP.TIMEOUT_AUTH_PRIV_MS, 'AuthPriv timeout should be >= Auth timeout');
+  assert(
+    SNMP.TIMEOUT_NO_AUTH_MS <= SNMP.TIMEOUT_AUTH_MS,
+    'Auth timeout should be >= noAuth timeout',
+  );
+  assert(
+    SNMP.TIMEOUT_AUTH_MS <= SNMP.TIMEOUT_AUTH_PRIV_MS,
+    'AuthPriv timeout should be >= Auth timeout',
+  );
 });
 
 Deno.test('THRESHOLDS constants: defaults are reasonable', () => {
@@ -92,21 +98,21 @@ Deno.test('UpsOidSets: all models have OID sets', () => {
 Deno.test('UpsOidSets: all non-custom models have complete OIDs', () => {
   const requiredOids = ['POWER_STATUS', 'BATTERY_CAPACITY', 'BATTERY_RUNTIME', 'OUTPUT_LOAD'];
 
-  for (const model of UPS_MODELS.filter(m => m !== 'custom')) {
+  for (const model of UPS_MODELS.filter((m) => m !== 'custom')) {
     const oidSet = UpsOidSets.getOidSet(model);
 
     for (const oid of requiredOids) {
       const value = oidSet[oid as keyof IOidSet];
       assert(
         typeof value === 'string' && value.length > 0,
-        `${model} should have non-empty ${oid}`
+        `${model} should have non-empty ${oid}`,
       );
     }
   }
 });
 
 Deno.test('UpsOidSets: power status values defined for non-custom models', () => {
-  for (const model of UPS_MODELS.filter(m => m !== 'custom')) {
+  for (const model of UPS_MODELS.filter((m) => m !== 'custom')) {
     const oidSet = UpsOidSets.getOidSet(model);
     assertExists(oidSet.POWER_STATUS_VALUES, `${model} should have POWER_STATUS_VALUES`);
     assertExists(oidSet.POWER_STATUS_VALUES?.online, `${model} should have online value`);
@@ -200,11 +206,11 @@ Deno.test('Action.shouldExecute: onlyPowerChanges mode', () => {
 
   assertEquals(
     action.testShouldExecute(createMockContext({ triggerReason: 'powerStatusChange' })),
-    true
+    true,
   );
   assertEquals(
     action.testShouldExecute(createMockContext({ triggerReason: 'thresholdViolation' })),
-    false
+    false,
   );
 });
 
@@ -218,13 +224,13 @@ Deno.test('Action.shouldExecute: onlyThresholds mode', () => {
   // Below thresholds - should execute
   assertEquals(
     action.testShouldExecute(createMockContext({ batteryCapacity: 50, batteryRuntime: 10 })),
-    true
+    true,
   );
 
   // Above thresholds - should not execute
   assertEquals(
     action.testShouldExecute(createMockContext({ batteryCapacity: 100, batteryRuntime: 60 })),
-    false
+    false,
   );
 });
 
@@ -248,7 +254,7 @@ Deno.test('Action.shouldExecute: powerChangesAndThresholds mode (default)', () =
   // Power change - should execute
   assertEquals(
     action.testShouldExecute(createMockContext({ triggerReason: 'powerStatusChange' })),
-    true
+    true,
   );
 
   // Threshold violation - should execute
@@ -257,7 +263,7 @@ Deno.test('Action.shouldExecute: powerChangesAndThresholds mode (default)', () =
       triggerReason: 'thresholdViolation',
       batteryCapacity: 50,
     })),
-    true
+    true,
   );
 
   // No power change and above thresholds - should not execute
@@ -267,7 +273,7 @@ Deno.test('Action.shouldExecute: powerChangesAndThresholds mode (default)', () =
       batteryCapacity: 100,
       batteryRuntime: 60,
     })),
-    false
+    false,
   );
 });
 
@@ -279,11 +285,11 @@ Deno.test('Action.shouldExecute: anyChange mode always returns true', () => {
 
   assertEquals(
     action.testShouldExecute(createMockContext({ triggerReason: 'powerStatusChange' })),
-    true
+    true,
   );
   assertEquals(
     action.testShouldExecute(createMockContext({ triggerReason: 'thresholdViolation' })),
-    true
+    true,
   );
 });
 
@@ -339,7 +345,7 @@ async function testUpsConnection(
   assertExists(status, 'Status should exist');
   assert(
     ['online', 'onBattery', 'unknown'].includes(status.powerStatus),
-    `Power status should be valid: ${status.powerStatus}`
+    `Power status should be valid: ${status.powerStatus}`,
   );
   assertEquals(typeof status.batteryCapacity, 'number', 'Battery capacity should be a number');
   assertEquals(typeof status.batteryRuntime, 'number', 'Battery runtime should be a number');
@@ -347,9 +353,12 @@ async function testUpsConnection(
   // Validate ranges
   assert(
     status.batteryCapacity >= 0 && status.batteryCapacity <= 100,
-    `Battery capacity should be 0-100: ${status.batteryCapacity}`
+    `Battery capacity should be 0-100: ${status.batteryCapacity}`,
+  );
+  assert(
+    status.batteryRuntime >= 0,
+    `Battery runtime should be non-negative: ${status.batteryRuntime}`,
   );
-  assert(status.batteryRuntime >= 0, `Battery runtime should be non-negative: ${status.batteryRuntime}`);
 }
 
 // Create SNMP instance for integration tests