Bump Onebox to 1.24.3 with current API/runtime dependencies, registry routing fixes, safer initial admin handling, and cleaner shutdown of Docker-backed resources.
This commit is contained in:
@@ -233,13 +233,13 @@ export class SmartProxyManager {
|
||||
}
|
||||
|
||||
async stop(): Promise<void> {
|
||||
if (!this.serviceRunning && !(await this.getExistingService())) {
|
||||
return;
|
||||
}
|
||||
|
||||
try {
|
||||
await this.ensureDockerClient();
|
||||
|
||||
if (!this.serviceRunning && !(await this.getExistingService())) {
|
||||
return;
|
||||
}
|
||||
|
||||
logger.info('Stopping SmartProxy service...');
|
||||
await this.removeService();
|
||||
|
||||
@@ -247,6 +247,16 @@ export class SmartProxyManager {
|
||||
logger.info('SmartProxy service stopped');
|
||||
} catch (error) {
|
||||
logger.error(`Failed to stop SmartProxy: ${getErrorMessage(error)}`);
|
||||
} finally {
|
||||
if (this.dockerClient) {
|
||||
try {
|
||||
await this.dockerClient.stop();
|
||||
} catch (error) {
|
||||
logger.error(`Failed to stop SmartProxy Docker client: ${getErrorMessage(error)}`);
|
||||
} finally {
|
||||
this.dockerClient = null;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user