Refactor error logging to use getErrorMessage utility

- Updated multiple classes to replace direct error message access with getErrorMessage function for improved error handling and consistency.
- Modified error logging in CertRequirementManager, CloudflareDomainSync, OneboxDnsManager, OneboxDockerManager, OneboxHttpServer, Onebox, OneboxRegistriesManager, and OneboxServicesManager.
- Ensured that all error messages logged provide a standardized format and improved clarity.
This commit is contained in:
2025-11-25 04:38:26 +00:00
parent 8ebd677478
commit c59d56e70a
9 changed files with 159 additions and 149 deletions

View File

@@ -7,6 +7,7 @@
import * as plugins from '../plugins.ts';
import { logger } from '../logging.ts';
import { getErrorMessage } from '../utils/error.ts';
import { OneboxDatabase } from './database.ts';
import { OneboxSslManager } from './ssl.ts';
import type { ICertRequirement, ICertificate, IDomain } from '../types.ts';
@@ -42,12 +43,12 @@ export class CertRequirementManager {
await this.processRequirement(requirement);
} catch (error) {
logger.error(
`Failed to process requirement ${requirement.id}: ${error.message}`
`Failed to process requirement ${requirement.id}: ${getErrorMessage(error)}`
);
}
}
} catch (error) {
logger.error(`Failed to process pending requirements: ${error.message}`);
logger.error(`Failed to process pending requirements: ${getErrorMessage(error)}`);
}
}
@@ -169,7 +170,7 @@ export class CertRequirementManager {
logger.success(`Certificate acquired for ${fullDomain}`);
} catch (error) {
logger.error(`Failed to acquire certificate for ${fullDomain}: ${error.message}`);
logger.error(`Failed to acquire certificate for ${fullDomain}: ${getErrorMessage(error)}`);
throw error;
}
}
@@ -203,7 +204,7 @@ export class CertRequirementManager {
}
}
} catch (error) {
logger.error(`Failed to check certificate renewal: ${error.message}`);
logger.error(`Failed to check certificate renewal: ${getErrorMessage(error)}`);
}
}
@@ -252,7 +253,7 @@ export class CertRequirementManager {
logger.success(`Certificate renewed for ${cert.certDomain}`);
} catch (error) {
logger.error(`Failed to renew certificate for ${cert.certDomain}: ${error.message}`);
logger.error(`Failed to renew certificate for ${cert.certDomain}: ${getErrorMessage(error)}`);
}
}
@@ -278,7 +279,7 @@ export class CertRequirementManager {
await Deno.remove(cert.fullChainPath);
} catch (error) {
logger.debug(
`Failed to delete certificate files for ${cert.certDomain}: ${error.message}`
`Failed to delete certificate files for ${cert.certDomain}: ${getErrorMessage(error)}`
);
}
@@ -298,7 +299,7 @@ export class CertRequirementManager {
logger.info(`Cleaned up ${deletedCount} old certificate(s)`);
}
} catch (error) {
logger.error(`Failed to cleanup old certificates: ${error.message}`);
logger.error(`Failed to cleanup old certificates: ${getErrorMessage(error)}`);
}
}