serve.zone/onebox
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor error logging to use getErrorMessage utility

Browse Source 
- Updated multiple classes to replace direct error message access with getErrorMessage function for improved error handling and consistency.
- Modified error logging in CertRequirementManager, CloudflareDomainSync, OneboxDnsManager, OneboxDockerManager, OneboxHttpServer, Onebox, OneboxRegistriesManager, and OneboxServicesManager.
- Ensured that all error messages logged provide a standardized format and improved clarity.
This commit is contained in:
Jürgen Kunz
2025-11-25 04:38:26 +00:00
parent 8ebd677478
commit c59d56e70a
9 changed files with 159 additions and 149 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
ts/classes/dns.ts
View File

@@ -6,6 +6,7 @@
import Cloudflare from 'npm:cloudflare@5.2.0';
import { logger } from '../logging.ts';
import { getErrorMessage } from '../utils/error.ts';
import { OneboxDatabase } from './database.ts';
export class OneboxDnsManager {
@@ -64,8 +65,9 @@ export class OneboxDnsManager {
}
logger.success('DNS manager initialized with multi-zone support');
} catch (error) {
logger.error(`Failed to initialize DNS manager: ${error.message}`);
if (error.message && error.message.includes('Authorization header')) {
logger.error(`Failed to initialize DNS manager: ${getErrorMessage(error)}`);
const errMsg = getErrorMessage(error);
if (errMsg && errMsg.includes('Authorization header')) {
logger.error('The provided API key appears to be invalid.');
logger.error('Make sure you are using a Cloudflare API TOKEN (not the global API key).');
logger.info('Create an API Token at: https://dash.cloudflare.com/profile/api-tokens');
@@ -153,7 +155,7 @@ export class OneboxDnsManager {
logger.success(`DNS record created for ${domain} → ${targetIP}`);
} catch (error) {
logger.error(`Failed to add DNS record for ${domain}: ${error.message}`);
logger.error(`Failed to add DNS record for ${domain}: ${getErrorMessage(error)}`);
throw error;
}
}
@@ -194,7 +196,7 @@ export class OneboxDnsManager {
logger.success(`DNS record removed for ${domain}`);
} catch (error) {
logger.error(`Failed to remove DNS record for ${domain}: ${error.message}`);
logger.error(`Failed to remove DNS record for ${domain}: ${getErrorMessage(error)}`);
throw error;
}
}
@@ -224,7 +226,7 @@ export class OneboxDnsManager {
return null;
} catch (error) {
logger.error(`Failed to get DNS record for ${domain}: ${error.message}`);
logger.error(`Failed to get DNS record for ${domain}: ${getErrorMessage(error)}`);
return null;
}
}
@@ -247,7 +249,7 @@ export class OneboxDnsManager {
updatedAt: Number(row.updated_at || row[7]),
}));
} catch (error) {
logger.error(`Failed to list DNS records: ${error.message}`);
logger.error(`Failed to list DNS records: ${getErrorMessage(error)}`);
return [];
}
}
@@ -295,7 +297,7 @@ export class OneboxDnsManager {
logger.success('DNS records synced from Cloudflare');
} catch (error) {
logger.error(`Failed to sync DNS records: ${error.message}`);
logger.error(`Failed to sync DNS records: ${getErrorMessage(error)}`);
throw error;
}
}
@@ -331,7 +333,7 @@ export class OneboxDnsManager {
return false;
}
} catch (error) {
logger.error(`Failed to check DNS for ${domain}: ${error.message}`);
logger.error(`Failed to check DNS for ${domain}: ${getErrorMessage(error)}`);
return false;
}
}