Refactor error logging to use getErrorMessage utility
- Updated multiple classes to replace direct error message access with getErrorMessage function for improved error handling and consistency. - Modified error logging in CertRequirementManager, CloudflareDomainSync, OneboxDnsManager, OneboxDockerManager, OneboxHttpServer, Onebox, OneboxRegistriesManager, and OneboxServicesManager. - Ensured that all error messages logged provide a standardized format and improved clarity.
This commit is contained in:
@@ -7,6 +7,7 @@
|
||||
import * as plugins from '../plugins.ts';
|
||||
import type { IRegistry } from '../types.ts';
|
||||
import { logger } from '../logging.ts';
|
||||
import { getErrorMessage } from '../utils/error.ts';
|
||||
import { OneboxDatabase } from './database.ts';
|
||||
|
||||
export class OneboxRegistriesManager {
|
||||
@@ -64,7 +65,7 @@ export class OneboxRegistriesManager {
|
||||
|
||||
return registry;
|
||||
} catch (error) {
|
||||
logger.error(`Failed to add registry ${url}: ${error.message}`);
|
||||
logger.error(`Failed to add registry ${url}: ${getErrorMessage(error)}`);
|
||||
throw error;
|
||||
}
|
||||
}
|
||||
@@ -84,7 +85,7 @@ export class OneboxRegistriesManager {
|
||||
|
||||
// Note: We don't perform docker logout as it might affect other users
|
||||
} catch (error) {
|
||||
logger.error(`Failed to remove registry ${url}: ${error.message}`);
|
||||
logger.error(`Failed to remove registry ${url}: ${getErrorMessage(error)}`);
|
||||
throw error;
|
||||
}
|
||||
}
|
||||
@@ -145,7 +146,7 @@ export class OneboxRegistriesManager {
|
||||
|
||||
logger.success(`Logged into registry: ${registry.url}`);
|
||||
} catch (error) {
|
||||
logger.error(`Failed to login to registry ${registry.url}: ${error.message}`);
|
||||
logger.error(`Failed to login to registry ${registry.url}: ${getErrorMessage(error)}`);
|
||||
throw error;
|
||||
}
|
||||
}
|
||||
@@ -160,7 +161,7 @@ export class OneboxRegistriesManager {
|
||||
try {
|
||||
await this.loginToRegistry(registry);
|
||||
} catch (error) {
|
||||
logger.warn(`Failed to login to ${registry.url}: ${error.message}`);
|
||||
logger.warn(`Failed to login to ${registry.url}: ${getErrorMessage(error)}`);
|
||||
// Continue with other registries
|
||||
}
|
||||
}
|
||||
@@ -188,7 +189,7 @@ export class OneboxRegistriesManager {
|
||||
|
||||
return code === 0;
|
||||
} catch (error) {
|
||||
logger.error(`Failed to test registry ${url}: ${error.message}`);
|
||||
logger.error(`Failed to test registry ${url}: ${getErrorMessage(error)}`);
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user