feat: Update error handling to use getErrorMessage utility and improve logging across multiple services

This commit is contained in:
2025-11-25 08:25:54 +00:00
parent c59d56e70a
commit e94906b3bf
13 changed files with 97 additions and 75 deletions

View File

@@ -8,6 +8,7 @@
import * as plugins from '../plugins.ts';
import { logger } from '../logging.ts';
import { getErrorMessage } from '../utils/error.ts';
export class RegistryManager {
private s3Server: any = null;
@@ -86,7 +87,7 @@ export class RegistryManager {
this.isInitialized = true;
logger.success('Onebox Registry initialized successfully');
} catch (error) {
logger.error(`Failed to initialize registry: ${error.message}`);
logger.error(`Failed to initialize registry: ${getErrorMessage(error)}`);
throw error;
}
}
@@ -102,7 +103,7 @@ export class RegistryManager {
try {
return await this.registry.handleRequest(req);
} catch (error) {
logger.error(`Registry request error: ${error.message}`);
logger.error(`Registry request error: ${getErrorMessage(error)}`);
return new Response('Internal registry error', { status: 500 });
}
}
@@ -119,7 +120,7 @@ export class RegistryManager {
const tags = await this.registry.getTags(repository);
return tags || [];
} catch (error) {
logger.warn(`Failed to get tags for ${repository}: ${error.message}`);
logger.warn(`Failed to get tags for ${repository}: ${getErrorMessage(error)}`);
return [];
}
}
@@ -146,8 +147,9 @@ export class RegistryManager {
return null;
} catch (error) {
// Only log if it's not a "not a function" error
if (!error.message.includes('not a function')) {
logger.warn(`Failed to get digest for ${repository}:${tag}: ${error.message}`);
const errMsg = getErrorMessage(error);
if (!errMsg.includes('not a function')) {
logger.warn(`Failed to get digest for ${repository}:${tag}: ${errMsg}`);
}
return null;
}
@@ -165,7 +167,7 @@ export class RegistryManager {
await this.registry.deleteManifest(repository, tag);
logger.info(`Deleted image ${repository}:${tag}`);
} catch (error) {
logger.error(`Failed to delete image ${repository}:${tag}: ${error.message}`);
logger.error(`Failed to delete image ${repository}:${tag}: ${getErrorMessage(error)}`);
throw error;
}
}
@@ -212,7 +214,7 @@ export class RegistryManager {
await this.s3Server.stop();
logger.info('smarts3 server stopped');
} catch (error) {
logger.error(`Error stopping smarts3: ${error.message}`);
logger.error(`Error stopping smarts3: ${getErrorMessage(error)}`);
}
}