serve.zone/remoteingress
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(remoteingress-core): guard zero-window reads to avoid false EOF handling on stalled streams

Browse Source
This commit is contained in:
Jürgen Kunz
2026-03-16 13:48:35 +00:00
parent e813c2f044
commit 1391b39601
4 changed files with 23 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
rust/crates/remoteingress-core/src/edge.rs
View File

@@ -726,8 +726,15 @@ async fn handle_client_connection(
}
if client_token.is_cancelled() { break; }
// Limit read size to available window
// Limit read size to available window.
// IMPORTANT: if window is 0 (stall timeout fired), we must NOT
// read into an empty buffer — read(&mut buf[..0]) returns Ok(0)
// which would be falsely interpreted as EOF.
let w = send_window.load(Ordering::Acquire) as usize;
if w == 0 {
log::warn!("Stream {} upload: window still 0 after stall timeout, closing", stream_id);
break;
}
let max_read = w.min(buf.len());
tokio::select! {

9
rust/crates/remoteingress-core/src/hub.rs
View File

@@ -601,8 +601,15 @@ async fn handle_edge_connection(
}
if stream_token.is_cancelled() { break; }
// Limit read size to available window
// Limit read size to available window.
// IMPORTANT: if window is 0 (stall timeout fired), we must NOT
// read into an empty buffer — read(&mut buf[..0]) returns Ok(0)
// which would be falsely interpreted as EOF.
let w = send_window.load(Ordering::Acquire) as usize;
if w == 0 {
log::warn!("Stream {} download: window still 0 after stall timeout, closing", stream_id);
break;
}
let max_read = w.min(buf.len());
tokio::select! {