Compare commits
4 Commits
Author | SHA1 | Date | |
---|---|---|---|
57e51543e7 | |||
050966cd6f | |||
11c6559e33 | |||
adff43c0e2 |
12
changelog.md
12
changelog.md
@ -1,5 +1,17 @@
|
||||
# Changelog
|
||||
|
||||
## 2024-10-16 - 3.1.7 - fix(VirtualStream)
|
||||
Fix issue in VirtualStream to handle null values during data writing.
|
||||
|
||||
- Ensured writableStream closes gracefully when null values are encountered.
|
||||
- Added a null check before writing data to the writableStream to prevent errors.
|
||||
|
||||
## 2024-10-16 - 3.1.6 - fix(VirtualStream)
|
||||
Fix backpressure handling in VirtualStream workOnQueue method
|
||||
|
||||
- Resolved an issue in the workOnQueue method of VirtualStream where concurrent execution was not properly managed.
|
||||
- Introduced a workingDeferred promise to ensure proper queue handling and resolve potential race conditions.
|
||||
|
||||
## 2024-10-16 - 3.1.5 - fix(virtualstream)
|
||||
Add console log for debugging backpressure feedback loop
|
||||
|
||||
|
@ -1,6 +1,6 @@
|
||||
{
|
||||
"name": "@api.global/typedrequest",
|
||||
"version": "3.1.5",
|
||||
"version": "3.1.7",
|
||||
"private": false,
|
||||
"description": "A TypeScript library for making typed requests towards APIs, including facilities for handling requests, routing, and virtual stream handling.",
|
||||
"main": "dist_ts/index.js",
|
||||
|
@ -3,6 +3,6 @@
|
||||
*/
|
||||
export const commitinfo = {
|
||||
name: '@api.global/typedrequest',
|
||||
version: '3.1.5',
|
||||
version: '3.1.7',
|
||||
description: 'A TypeScript library for making typed requests towards APIs, including facilities for handling requests, routing, and virtual stream handling.'
|
||||
}
|
||||
|
@ -143,10 +143,17 @@ export class VirtualStream<T = Uint8Array> implements plugins.typedRequestInterf
|
||||
|
||||
constructor() {}
|
||||
|
||||
workingDeferred: plugins.smartpromise.Deferred<void>;
|
||||
|
||||
/**
|
||||
* takes care of sending
|
||||
*/
|
||||
private async workOnQueue() {
|
||||
if (this.workingDeferred) {
|
||||
return this.workingDeferred.promise;
|
||||
} else {
|
||||
this.workingDeferred = plugins.smartpromise.defer();
|
||||
}
|
||||
if(this.side === 'requesting') {
|
||||
let thisSideIsBackpressured = !this.receiveBackpressuredArray.checkSpaceAvailable();
|
||||
let otherSideHasNext = false;
|
||||
@ -219,6 +226,8 @@ export class VirtualStream<T = Uint8Array> implements plugins.typedRequestInterf
|
||||
}
|
||||
|
||||
}
|
||||
this.workingDeferred.resolve();
|
||||
this.workingDeferred = null;
|
||||
}
|
||||
|
||||
/**
|
||||
@ -390,11 +399,17 @@ export class VirtualStream<T = Uint8Array> implements plugins.typedRequestInterf
|
||||
public async writeToWebstream(writableStreamArg: WritableStream<T>) {
|
||||
const writer = writableStreamArg.getWriter();
|
||||
while(this.keepAlive || this.receiveBackpressuredArray.checkHasItems()) {
|
||||
await writer.write(await this.fetchData());
|
||||
const value = await this.fetchData();
|
||||
if (value === null) {
|
||||
writableStreamArg.close();
|
||||
break;
|
||||
}
|
||||
await writer.write(value);
|
||||
}
|
||||
}
|
||||
|
||||
public async close() {
|
||||
this.sendData(null);
|
||||
this.keepAlive = false;
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user