1.0.45

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojoio/docker",
-  "version": "1.0.42",
+  "version": "1.0.45",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojoio/docker",
-  "version": "1.0.42",
+  "version": "1.0.45",
   "description": "easy communication with docker remote api from node, TypeScript ready",
   "private": false,
   "main": "dist/index.js",

test/test.ts

@@ -1,5 +1,6 @@
 import { expect, tap } from '@pushrocks/tapbundle';
 import * as docker from '../ts/index';
+import { DockerService } from '../ts/index';
 
 let testDockerHost: docker.DockerHost;
 
@@ -37,7 +38,7 @@ tap.test('should remove a network', async () => {
 tap.test('should pull an image from imagetag', async () => {
   const image = await docker.DockerImage.createFromRegistry(testDockerHost, {
     imageUrl: 'hosttoday/ht-docker-node',
-    tag: 'alpine'
+    imageTag: 'alpine'
   });
   expect(image).to.be.instanceOf(docker.DockerImage);
   console.log(image);
@@ -62,4 +63,18 @@ tap.test('should list all services', async tools => {
   console.log(services);
 });
 
+tap.test('should create a service', async () => {
+  const testNetwork = await docker.DockerNetwork.createNetwork(testDockerHost, {
+    Name: 'testNetwork'
+  });
+  await DockerService.createService(testDockerHost, {
+    Image: 'nginx:latest',
+    Labels: {    
+      'testlabel': 'hi'
+    },
+    Name: 'testService',
+    networks: [testNetwork]
+  });
+});
+
 tap.start();

ts/docker.classes.container.ts

@@ -49,7 +49,10 @@ export class DockerContainer {
     if (response.statusCode < 300) {
       plugins.smartlog.defaultLogger.log('info', 'Container created successfully');
     } else {
-      plugins.smartlog.defaultLogger.log('error', 'There has been a problem when creating the container');
+      plugins.smartlog.defaultLogger.log(
+        'error',
+        'There has been a problem when creating the container'
+      );
     }
   }
 

ts/docker.classes.image.ts

@@ -24,20 +24,47 @@ export class DockerImage {
     dockerHostArg: DockerHost,
     creationObject: interfaces.IImageCreationDescriptor
   ): Promise<DockerImage> {
+
+    // lets create a sanatized imageUrlObject
+    const imageUrlObject: {
+      imageUrl: string;
+      imageTag: string;
+      imageOriginTag: string;
+    } = {
+      imageUrl: creationObject.imageUrl,
+      imageTag: creationObject.imageTag,
+      imageOriginTag: null
+    };
+    if (imageUrlObject.imageUrl.includes(':')) {
+      const imageUrl = imageUrlObject.imageUrl.split(':')[0];
+      const imageTag = imageUrlObject.imageUrl.split(':')[1];
+      if (imageUrlObject.imageTag) {
+        throw new Error(
+          `imageUrl ${imageUrlObject.imageUrl} can't be tagged with ${
+            imageUrlObject.imageTag
+          } because it is already tagged with ${imageTag}`
+        );
+      } else {
+        imageUrlObject.imageTag = imageTag;
+      }
+    } else if (!imageUrlObject.imageTag) {
+      imageUrlObject.imageTag = 'latest';
+    }
+    imageUrlObject.imageOriginTag = `${imageUrlObject.imageUrl}:${imageUrlObject.imageTag}`;
+
+    // lets actually create the image
     const response = await dockerHostArg.request(
       'POST',
       `/images/create?fromImage=${encodeURIComponent(
-        creationObject.imageUrl
+        imageUrlObject.imageUrl
-      )}&tag=${encodeURIComponent(creationObject.tag)}`
+      )}&tag=${encodeURIComponent(imageUrlObject.imageTag)}`
     );
     if (response.statusCode < 300) {
       plugins.smartlog.defaultLogger.log(
         'info',
-        `Successfully pulled image ${creationObject.imageUrl} from the registry`
+        `Successfully pulled image ${imageUrlObject.imageUrl} from the registry`
       );
-      const originTag = `${creationObject.imageUrl}:${creationObject.tag}`;
+      const image = await DockerImage.findImageByName(dockerHostArg, imageUrlObject.imageOriginTag);
-      console.log(originTag)
-      const image = await DockerImage.findImageByName(dockerHostArg, originTag);
       return image;
     } else {
       plugins.smartlog.defaultLogger.log('error', `Failed at the attempt of creating a new image`);
@@ -93,24 +120,17 @@ export class DockerImage {
     return this.RepoTags.length > 0;
   }
 
-  public tagImage(newTag) {
+  public tagImage(newTag) {}
-
-  }
 
   /**
    * pulls the latest version from the registry
    */
   public async pullLatestImageFromRegistry(): Promise<boolean> {
-    const dockerImageUrl = this.RepoTags[0].split(':')[0];
-    const dockerImageTag = this.RepoTags[0].split(':')[1];
     const updatedImage = await DockerImage.createFromRegistry(this.dockerHost, {
-      imageUrl: dockerImageUrl,
+      imageUrl: this.RepoTags[0]
-      tag: dockerImageTag
     });
     Object.assign(this, updatedImage);
     // TODO: Compare image digists before and after
     return true;
   }
-
-
 }

ts/docker.classes.network.ts

@@ -45,8 +45,11 @@ export class DockerNetwork {
       plugins.smartlog.defaultLogger.log('info', 'Created network successfully');
       return await DockerNetwork.getNetworkByName(dockerHost, networkCreationDescriptor.Name);
     } else {
-      plugins.smartlog.defaultLogger.log('error', 'There has been an error creating the wanted network');
+      plugins.smartlog.defaultLogger.log(
-      return null
+        'error',
+        'There has been an error creating the wanted network'
+      );
+      return null;
     }
   }
 

ts/docker.classes.service.ts

@@ -2,6 +2,7 @@ import * as plugins from './docker.plugins';
 import * as interfaces from './interfaces';
 
 import { DockerHost } from './docker.classes.host';
+import { DockerImage } from './docker.classes.image';
 
 export class DockerService {
   // STATIC
@@ -14,11 +15,27 @@ export class DockerService {
     return services;
   }
 
-
   /**
    * creates a service
    */
-  public static async createService(dockerHost: DockerHost, serviceCreationDescriptor: interfaces.IServiceCreationDescriptor) {
+  public static async createService(
+    dockerHost: DockerHost,
+    serviceCreationDescriptor: interfaces.IServiceCreationDescriptor
+  ) {
+    // lets get the image
+    plugins.smartlog.defaultLogger.log('info', `downloading image for service ${serviceCreationDescriptor.Name}`);
+    const serviceImage = await DockerImage.createFromRegistry(dockerHost, {
+      imageUrl: serviceCreationDescriptor.Image
+    });
+
+    const networkArray: any[] = [];
+    for (const network of serviceCreationDescriptor.networks) {
+      networkArray.push({
+        Target: network.Name,
+        Aliases: []
+      });
+    }
+
     dockerHost.request('POST', '/services/create', {
       Name: serviceCreationDescriptor.Name,
       TaskTemplate: {
@@ -27,7 +44,8 @@ export class DockerService {
           Labels: serviceCreationDescriptor.Labels
         }
       },
-      Labels: serviceCreationDescriptor.Labels
+      Labels: serviceCreationDescriptor.Labels,
+      Networks: networkArray
     });
   }
 

ts/interfaces/image.ts

@@ -1,4 +1,4 @@
 export interface IImageCreationDescriptor {
   imageUrl: string;
-  tag: string;
+  imageTag?: string;
 }

ts/interfaces/index.ts

@@ -4,4 +4,3 @@ export * from './label';
 export * from './network';
 export * from './port';
 export * from './service';
-

ts/interfaces/service.ts

@@ -1,7 +1,9 @@
-import * as interfaces from './'
+import * as interfaces from './';
+import { DockerNetwork } from '../docker.classes.network';
 
 export interface IServiceCreationDescriptor {
   Name: string;
   Image: string;
   Labels: interfaces.TLabels;
+  networks: DockerNetwork[];
 }