1.0.18

.gitlab-ci.yml

@@ -3,14 +3,14 @@ image: registry.gitlab.com/hosttoday/ht-docker-node:npmci
 
 cache:
   paths:
-    - .npmci_cache/
-  key: '$CI_BUILD_STAGE'
+  - .npmci_cache/
+  key: "$CI_BUILD_STAGE"
 
 stages:
-  - security
-  - test
-  - release
-  - metadata
+- security
+- test
+- release
+- metadata
 
 # ====================
 # security stage
@@ -18,23 +18,21 @@ stages:
 mirror:
   stage: security
   script:
-    - npmci git mirror
+  - npmci git mirror
   tags:
-    - lossless
-    - docker
-    - notpriv
+  - docker
+  - notpriv
 
 snyk:
-  image: registry.gitlab.com/hosttoday/ht-docker-node:snyk
   stage: security
   script:
     - npmci npm prepare
+    - npmci command npm install -g snyk
     - npmci command npm install --ignore-scripts
     - npmci command snyk test
   tags:
-    - lossless
-    - docker
-    - notpriv
+  - docker
+  - notpriv
 
 # ====================
 # test stage
@@ -43,40 +41,37 @@ snyk:
 testStable:
   stage: test
   script:
-    - npmci npm prepare
-    - npmci node install stable
-    - npmci npm install
-    - npmci npm test
+  - npmci npm prepare
+  - npmci node install stable
+  - npmci npm install
+  - npmci npm test
   coverage: /\d+.?\d+?\%\s*coverage/
   tags:
-    - lossless
-    - docker
-    - priv
+  - docker
+  - priv
 
 testBuild:
   stage: test
   script:
-    - npmci npm prepare
-    - npmci node install stable
-    - npmci npm install
-    - npmci command npm run build
+  - npmci npm prepare
+  - npmci node install stable
+  - npmci npm install
+  - npmci command npm run build
   coverage: /\d+.?\d+?\%\s*coverage/
   tags:
-    - lossless
-    - docker
-    - notpriv
+  - docker
+  - notpriv
 
 release:
   stage: release
   script:
-    - npmci node install stable
-    - npmci npm publish
+  - npmci node install stable
+  - npmci npm publish
   only:
-    - tags
+  - tags
   tags:
-    - lossless
-    - docker
-    - notpriv
+  - docker
+  - notpriv
 
 # ====================
 # metadata stage
@@ -90,20 +85,18 @@ codequality:
     - npmci npm install
     - npmci command "tslint -c tslint.json ./ts/**/*.ts"
   tags:
-    - lossless
-    - docker
-    - priv
+  - docker
+  - priv
 
 trigger:
   stage: metadata
   script:
-    - npmci trigger
+  - npmci trigger
   only:
-    - tags
+  - tags
   tags:
-    - lossless
-    - docker
-    - notpriv
+  - docker
+  - notpriv
 
 pages:
   stage: metadata
@@ -114,7 +107,6 @@ pages:
     - npmci npm install
     - npmci command tsdoc
   tags:
-    - lossless
     - docker
     - notpriv
   only:
@@ -122,5 +114,5 @@ pages:
   artifacts:
     expire_in: 1 week
     paths:
-      - public
+    - public
   allow_failure: true

.snyk

@@ -1,4 +0,0 @@
-# Snyk (https://snyk.io) policy file, patches or ignores known vulnerabilities.
-version: v1.13.5
-ignore: {}
-patch: {}

npmextra.json

@@ -1,6 +1,5 @@
 {
   "gitzone": {
-    "projectType": "npm",
     "module": {
       "githost": "gitlab.com",
       "gitscope": "mojoio",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mojoio/mailgun",
-  "version": "1.0.25",
+  "version": "1.0.18",
   "private": false,
   "description": "an api abstraction package for mailgun",
   "main": "dist/index.js",
@@ -13,19 +13,19 @@
     "format": "(gitzone format)"
   },
   "devDependencies": {
-    "@gitzone/tsbuild": "^2.1.22",
+    "@gitzone/tsbuild": "^2.0.22",
     "@gitzone/tstest": "^1.0.15",
     "@pushrocks/qenv": "^4.0.6",
-    "@pushrocks/tapbundle": "^3.2.1",
-    "@types/node": "^13.13.4",
-    "tslint": "^6.1.1",
+    "@pushrocks/tapbundle": "^3.2.0",
+    "@types/node": "^13.1.6",
+    "tslint": "^5.20.1",
     "tslint-config-prettier": "^1.15.0"
   },
   "dependencies": {
-    "@pushrocks/smartfile": "^7.0.12",
-    "@pushrocks/smartmail": "^1.0.11",
+    "@pushrocks/smartfile": "^7.0.6",
+    "@pushrocks/smartmail": "^1.0.8",
     "@pushrocks/smartrequest": "^1.1.47",
-    "@pushrocks/smartstring": "^3.0.18"
+    "@pushrocks/smartstring": "^3.0.17"
   },
   "files": [
     "ts/**/*",

test/test.ts

@@ -5,13 +5,12 @@ import * as smartmail from '@pushrocks/smartmail';
 const testQenv = new Qenv('./', './.nogit');
 
 import * as mailgun from '../ts/index';
-import { IMailgunMessage } from '../ts/index';
 
 
 let testMailgunAccount: mailgun.MailgunAccount;
-let testSmartmail: smartmail.Smartmail<IMailgunMessage>;
+let testSmartmail: smartmail.Smartmail;
 
-tap.test('should create a mailgun account', async () => {
+tap.test('first test', async () => {
   testMailgunAccount = new mailgun.MailgunAccount(testQenv.getEnvVarOnDemand('MAILGUN_API_TOKEN'));
   expect(testMailgunAccount).to.be.instanceOf(mailgun.MailgunAccount);
 });
@@ -19,23 +18,21 @@ tap.test('should create a mailgun account', async () => {
 tap.test('should create a smartmail', async () => {
   testSmartmail = new smartmail.Smartmail({
     body: 'hi there. This is the body.',
-    from: 'Lossless GmbH <noreply@mail.lossless.com>',
-    subject: 'TestMessage from @mojoio/mailgun test'
+    from: 'noreply@mail.lossless.com',
+    subject: 'hi there. This is the subject'
   });
   return testSmartmail;
 });
 
 tap.test('should send a smartmail', async () => {
-  await testMailgunAccount.sendSmartMail(testSmartmail, 'Sandbox Team <sandbox@mail.git.zone>');
+  testMailgunAccount.sendSmartMail(testSmartmail, 'sandbox@mail.git.zone');
 });
 
 tap.test('should retrieve a mail using a retrieval url', async () => {
   const result = await testMailgunAccount.retrieveSmartMailFromMessageUrl('https://sw.api.mailgun.net/v3/domains/mail.lossless.one/messages/AgMFnnnAKC8xp_dDa79LyoxhloxtaVmnRA==');
-  if (result) {
-    result.options.subject = 'hi there. This is a testmail with attachment';
-    result.options.from = 'noreply@mail.lossless.com';
-    await testMailgunAccount.sendSmartMail(result, 'Sandbox Team <sandbox@mail.git.zone>');
-  }
+  result.options.subject = 'hi there. This is a testmail with attachment';
+  result.options.from = 'noreply@mail.lossless.com';
+  testMailgunAccount.sendSmartMail(result, 'sandbox@mail.git.zone');
 });
 
 tap.start();

ts/interfaces/message.ts

@@ -15,14 +15,14 @@ export interface IMailgunMessage {
   'X-Gm-Message-State': string;
   'body-plain': string;
   attachments: Array<{
-    url: string;
-    'content-type': string;
-    name: string;
-    size: number;
-  }>;
+      url: string,
+      'content-type': string,
+      name: string,
+      size: number
+    }>;
   'body-html': string;
   'Mime-Version': string;
-  Date: string;
+  Date: string,
   'Message-Id': string;
   'Content-Type': string;
   'X-Google-Smtp-Source': string;

ts/interfaces/notification.ts

@@ -11,8 +11,8 @@ export interface IMailgunNotification {
   'X-Google-Dkim-Signature': string;
   To: string;
   'Dkim-Signature': string;
-  subject: string;
-  from: string;
+  subject: 'Booking confirmation (Order 12PN8P)';
+  from: 'buchungsbestaetigung@bahn.de';
   'X-Received': string[];
   'Ironport-Sdr': string;
   'Arc-Authentication-Results': string[];
@@ -32,16 +32,13 @@ export interface IMailgunNotification {
   'X-Forwarded-For': string;
   'X-Gm-Message-State': string;
   'X-Google-Smtp-Source': string;
-  'X-Envelope-From': string;
-  'Content-Type': string;
-  'X-Forwarded-To': string;
+  'X-Envelope-From': '<phil+caf_=invoiceinbox=mail.lossless.one@lossless.com>';
+  'Content-Type': 'multipart/mixed; boundary="----=_Part_220882_156025801.1578848484963"';
+  'X-Forwarded-To': 'invoiceinbox@mail.lossless.one';
   Subject: string;
   attachments: string;
   'body-plain': string;
   'stripped-text': string;
   'stripped-html': string;
   'stripped-signature': string;
-
-  // Lossless specific
-  "X-Lossless-Auth": string;
 }

ts/mailgun.classes.account.ts

@@ -51,8 +51,8 @@ export class MailgunAccount {
   /**
    * sends a SmartMail
    */
-  public async sendSmartMail(smartmailArg: plugins.smartmail.Smartmail<interfaces.IMailgunMessage>, toArg: string, dataArg = {}) {
-    const domain = smartmailArg.options.from.split('@')[1].replace('>', '');
+  public async sendSmartMail(smartmailArg: plugins.smartmail.Smartmail, toArg: string, dataArg = {}) {
+    const domain = smartmailArg.options.from.split('@')[1];
     const formFields: plugins.smartrequest.IFormField[] = [
       {
         name: 'from',
@@ -98,29 +98,22 @@ export class MailgunAccount {
 
   public async retrieveSmartMailFromMessageUrl(messageUrlArg: string) {
     const response = await this.getRequest(messageUrlArg);
-    if (response.statusCode === 404) {
-      console.log(response.body.message);
-      return null;
-    }
     const responseBody: interfaces.IMailgunMessage = response.body;
-    const smartmail = new plugins.smartmail.Smartmail<interfaces.IMailgunMessage>({
+    const smartmail = new plugins.smartmail.Smartmail({
       from: responseBody.From,
       body: responseBody["body-html"],
       subject: responseBody.Subject,
-      creationObjectRef: responseBody
     });
 
     // lets care about attachments
-    if (responseBody.attachments && responseBody.attachments instanceof Array) {
-      for (const attachmentInfo of responseBody.attachments) {
-        const attachmentName = attachmentInfo.name;
-        const attachmentContents = await this.getRequest(attachmentInfo.url, true);
-        smartmail.addAttachment(new plugins.smartfile.Smartfile({
-          path: `./${attachmentName}`,
-          base: `./${attachmentName}`,
-          contentBuffer: attachmentContents.body
-        }));
-      }
+    for (const attachmentInfo of responseBody.attachments) {
+      const attachmentName = attachmentInfo.name;
+      const attachmentContents = await this.getRequest(attachmentInfo.url, true);
+      smartmail.addAttachment(new plugins.smartfile.Smartfile({
+        path: `./${attachmentName}`,
+        base: `./${attachmentName}`,
+        contentBuffer: attachmentContents.body
+      }));
     }
 
     return smartmail;