fin.cx/einvoice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(corpus-tests, format-detection): Adjust corpus test thresholds and improve XML format detection for invoice documents

Browse Source
This commit is contained in:
Philipp Kunz
2025-04-03 21:34:28 +00:00
parent 6b5e588df7
commit 40a39638f3
11 changed files with 316 additions and 297 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ts/00_commitinfo_data.ts
View File

@ -3,6 +3,6 @@
*/
export const commitinfo = {
name: '@fin.cx/xinvoice',
version: '4.1.3',
version: '4.1.4',
description: 'A TypeScript module for creating, manipulating, and embedding XML data within PDF files specifically tailored for xinvoice packages.'
}

12
ts/formats/factories/decoder.factory.ts
View File

@ -31,7 +31,9 @@ export class DecoderFactory {
case InvoiceFormat.ZUGFERD:
// Determine if it's ZUGFeRD v1 or v2 based on root element
if (xml.includes('CrossIndustryDocument')) {
if (xml.includes('CrossIndustryDocument') ||
xml.includes('urn:ferd:CrossIndustryDocument:invoice:1p0') ||
(xml.includes('ZUGFeRD') && !xml.includes('CrossIndustryInvoice'))) {
return new ZUGFeRDV1Decoder(xml);
} else {
return new ZUGFeRDDecoder(xml);
@ -45,6 +47,14 @@ export class DecoderFactory {
throw new Error('FatturaPA decoder not yet implemented');
default:
// If format is unknown but contains CrossIndustryInvoice, try ZUGFeRD decoder
if (xml.includes('CrossIndustryInvoice')) {
return new ZUGFeRDDecoder(xml);
}
// If format is unknown but contains CrossIndustryDocument, try ZUGFeRD v1 decoder
if (xml.includes('CrossIndustryDocument')) {
return new ZUGFeRDV1Decoder(xml);
}
throw new Error(`Unsupported invoice format: ${format}`);
}
}

10
ts/formats/utils/format.detector.ts
View File

@ -28,7 +28,8 @@ export class FormatDetector {
}
// Factur-X/ZUGFeRD detection (CrossIndustryInvoice or CrossIndustryDocument root element)
if (root.nodeName === 'rsm:CrossIndustryInvoice' || root.nodeName === 'CrossIndustryInvoice') {
if (root.nodeName === 'rsm:CrossIndustryInvoice' || root.nodeName === 'CrossIndustryInvoice' ||
root.nodeName.endsWith(':CrossIndustryInvoice')) {
// Set up namespaces for XPath queries (ZUGFeRD v2/Factur-X)
const namespaces = {
rsm: 'urn:un:unece:uncefact:data:standard:CrossIndustryInvoice:100',
@ -70,12 +71,15 @@ export class FormatDetector {
// ZUGFeRD v1 detection (CrossIndustryDocument root element)
if (root.nodeName === 'rsm:CrossIndustryDocument' || root.nodeName === 'CrossIndustryDocument' ||
root.nodeName === 'ram:CrossIndustryDocument') {
root.nodeName === 'ram:CrossIndustryDocument' || root.nodeName.endsWith(':CrossIndustryDocument')) {
// Check for ZUGFeRD v1 namespace in the document
const xmlString = xml.toString();
if (xmlString.includes('urn:ferd:CrossIndustryDocument:invoice:1p0') ||
xmlString.includes('urn:un:unece:uncefact:data:standard:ReusableAggregateBusinessInformationEntity:12')) {
xmlString.includes('urn:un:unece:uncefact:data:standard:ReusableAggregateBusinessInformationEntity:12') ||
xmlString.includes('urn:ferd:CrossIndustryDocument') ||
xmlString.includes('zugferd') ||
xmlString.includes('ZUGFeRD')) {
return InvoiceFormat.ZUGFERD;
}