Compare commits
14 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 8977ff4525 | |||
| 9dc74fd392 | |||
| 85a33021e4 | |||
| e8e64a4ef3 | |||
| a5dd5252db | |||
| dc9a9640df | |||
| 431c82a186 | |||
| 05184179a4 | |||
| f15ab3a6f9 | |||
| 67d29a8e77 | |||
| 0e1db4bb85 | |||
| 7a1c2d82b9 | |||
| 9f5e4ad76e | |||
| 4feb074c03 |
52
changelog.md
52
changelog.md
@@ -1,5 +1,57 @@
|
|||||||
# Changelog
|
# Changelog
|
||||||
|
|
||||||
|
## 2026-03-05 - 4.2.2 - fix(compiler)
|
||||||
|
force global filesystem sync to flush XFS delayed logging and add diagnostics comparing Node's readdirSync with system ls to detect directory entry inconsistencies
|
||||||
|
|
||||||
|
- Replace per-directory fs.fsyncSync loop with execSync('sync') to ensure parent B+tree metadata is flushed on XFS
|
||||||
|
- Import execSync from child_process
|
||||||
|
- Add diagnostic comparison: run ls -1 and compare its entries to fs.readdirSync; log mismatches and full entry lists for debugging Node.js caching/readdir inconsistencies
|
||||||
|
|
||||||
|
## 2026-03-05 - 4.2.1 - fix(compiler)
|
||||||
|
use TypeScript sys hooks instead of fs monkeypatching to detect writes/deletes in previous output directories
|
||||||
|
|
||||||
|
- Replace direct fs.* monkeypatching with interception of typescript.sys.writeFile, typescript.sys.deleteFile and typescript.sys.createDirectory
|
||||||
|
- Add guards for optional sys.deleteFile before overriding it and preserve original sys methods to restore after compilation
|
||||||
|
- Update diagnostic messages to reference TypeScript sys ops and add an informational message when no ops are observed
|
||||||
|
- Reduce surface area of changes by avoiding global fs changes and focusing on TypeScript's sys API for safer interception
|
||||||
|
|
||||||
|
## 2026-03-05 - 4.2.0 - feat(mod_compiler)
|
||||||
|
add diagnostic interception of fs operations to detect and report unexpected file system changes in previously compiled output directories during compilation
|
||||||
|
|
||||||
|
- Wraps fs.unlinkSync, fs.rmSync, fs.rmdirSync, fs.renameSync and fs.writeFileSync to record operations targeting other successful output directories during a compile.
|
||||||
|
- Enabled only when there are previously compiled output dirs and when not running in quiet or JSON mode; original fs methods are restored after compilation.
|
||||||
|
- Logs up to 30 intercepted operations and prints a summary count if any ops were observed; intercepted calls still perform the original fs action (diagnostic-only).
|
||||||
|
- No functional change to compilation behavior beyond additional diagnostic reporting.
|
||||||
|
|
||||||
|
## 2026-03-05 - 4.1.26 - fix(compiler)
|
||||||
|
fsync output directories after unpack to avoid XFS delayed logging causing corrupt or invisible directory entries during subsequent TypeScript emits
|
||||||
|
|
||||||
|
- Force fsync on each successful output directory (open, fsync, close) before the next compilation step.
|
||||||
|
- Prevents XFS delayed logging from making directory entries invisible or corrupted during TypeScript emit operations.
|
||||||
|
- Operation swallows errors if a directory doesn't exist yet; non-breaking fix with small additional IO.
|
||||||
|
|
||||||
|
## 2026-03-05 - 4.1.25 - fix(mod_unpack)
|
||||||
|
flush directory metadata on XFS before reading and use readdirSync-based iteration to avoid missing entries when unpacking
|
||||||
|
|
||||||
|
- Call fs.fsyncSync on destination and nested directory file descriptors to force XFS to commit delayed directory metadata (addresses XFS CIL delayed logging causing incomplete readdir/opendir results).
|
||||||
|
- Replace opendirSync/readSync loops with readdirSync-based iteration for simpler, deterministic directory listing.
|
||||||
|
- Remove unused moved counter and update diagnostic log to report nestedEntries.length for moved entry count.
|
||||||
|
|
||||||
|
## 2026-03-05 - 4.1.24 - fix(mod_unpack)
|
||||||
|
iterate directories with opendirSync/readSync to avoid missing entries on XFS and ensure directory handles are closed
|
||||||
|
|
||||||
|
- Replaced readdirSync loops with opendirSync + readSync for destination and nested directories to provide a single stable directory handle during iteration
|
||||||
|
- Added explicit closeSync() calls to close directory handles and avoid resource leaks
|
||||||
|
- Avoids partial results/missed entries that can occur when repeatedly calling readdirSync (observed on XFS with delayed metadata)
|
||||||
|
- Preserves existing renameSync move logic and increments moved counter while cleaning up the now-empty nested directory
|
||||||
|
|
||||||
|
## 2026-03-05 - 4.1.23 - fix(mod_unpack)
|
||||||
|
handle partial readdirSync results when moving nested directory entries and add diagnostic log
|
||||||
|
|
||||||
|
- Loop over readdirSync results until the nested directory is empty to avoid missing entries from partial reads
|
||||||
|
- Count moved entries and print a diagnostic message with the final destination entry count
|
||||||
|
- Keep removal of the now-empty nested directory (fs.rmdirSync) after moving contents
|
||||||
|
|
||||||
## 2026-03-05 - 4.1.22 - fix(mod_compiler)
|
## 2026-03-05 - 4.1.22 - fix(mod_compiler)
|
||||||
improve logging of successful output directories to include a sorted list of entries and use a shortened relative path
|
improve logging of successful output directories to include a sorted list of entries and use a shortened relative path
|
||||||
|
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "@git.zone/tsbuild",
|
"name": "@git.zone/tsbuild",
|
||||||
"version": "4.1.22",
|
"version": "4.2.2",
|
||||||
"private": false,
|
"private": false,
|
||||||
"description": "A tool for compiling TypeScript files using the latest nightly features, offering flexible APIs and a CLI for streamlined development.",
|
"description": "A tool for compiling TypeScript files using the latest nightly features, offering flexible APIs and a CLI for streamlined development.",
|
||||||
"main": "dist_ts/index.js",
|
"main": "dist_ts/index.js",
|
||||||
|
|||||||
@@ -3,6 +3,6 @@
|
|||||||
*/
|
*/
|
||||||
export const commitinfo = {
|
export const commitinfo = {
|
||||||
name: '@git.zone/tsbuild',
|
name: '@git.zone/tsbuild',
|
||||||
version: '4.1.22',
|
version: '4.2.2',
|
||||||
description: 'A tool for compiling TypeScript files using the latest nightly features, offering flexible APIs and a CLI for streamlined development.'
|
description: 'A tool for compiling TypeScript files using the latest nightly features, offering flexible APIs and a CLI for streamlined development.'
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,6 +1,7 @@
|
|||||||
import type { CompilerOptions, Diagnostic, Program } from 'typescript';
|
import type { CompilerOptions, Diagnostic, Program } from 'typescript';
|
||||||
import typescript from 'typescript';
|
import typescript from 'typescript';
|
||||||
import * as fs from 'fs';
|
import * as fs from 'fs';
|
||||||
|
import { execSync } from 'child_process';
|
||||||
import * as smartdelay from '@push.rocks/smartdelay';
|
import * as smartdelay from '@push.rocks/smartdelay';
|
||||||
import * as smartpromise from '@push.rocks/smartpromise';
|
import * as smartpromise from '@push.rocks/smartpromise';
|
||||||
import * as smartpath from '@push.rocks/smartpath';
|
import * as smartpath from '@push.rocks/smartpath';
|
||||||
@@ -380,9 +381,57 @@ export class TsCompiler {
|
|||||||
fileCount: absoluteFiles.length,
|
fileCount: absoluteFiles.length,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// Diagnostic: intercept TypeScript sys operations during compilation to detect
|
||||||
|
// any unexpected writes/deletes in previously compiled output directories
|
||||||
|
const watchedDirs = successfulOutputDirs.filter(d => d !== destDir);
|
||||||
|
let interceptedOps: string[] = [];
|
||||||
|
const origSysWriteFile = typescript.sys.writeFile;
|
||||||
|
const origSysDeleteFile = typescript.sys.deleteFile;
|
||||||
|
const origSysCreateDir = typescript.sys.createDirectory;
|
||||||
|
if (watchedDirs.length > 0 && !isQuiet && !isJson) {
|
||||||
|
typescript.sys.writeFile = (p: string, data: string, writeBom?: boolean) => {
|
||||||
|
if (watchedDirs.some(d => p.startsWith(d + '/'))) {
|
||||||
|
interceptedOps.push(`sys.writeFile: ${p}`);
|
||||||
|
}
|
||||||
|
return origSysWriteFile.call(typescript.sys, p, data, writeBom);
|
||||||
|
};
|
||||||
|
if (origSysDeleteFile) {
|
||||||
|
typescript.sys.deleteFile = (p: string) => {
|
||||||
|
if (watchedDirs.some(d => p.startsWith(d + '/'))) {
|
||||||
|
interceptedOps.push(`sys.deleteFile: ${p}`);
|
||||||
|
}
|
||||||
|
return origSysDeleteFile!.call(typescript.sys, p);
|
||||||
|
};
|
||||||
|
}
|
||||||
|
typescript.sys.createDirectory = (p: string) => {
|
||||||
|
if (watchedDirs.some(d => p.startsWith(d + '/'))) {
|
||||||
|
interceptedOps.push(`sys.createDirectory: ${p}`);
|
||||||
|
}
|
||||||
|
return origSysCreateDir.call(typescript.sys, p);
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
const result = await this.compileFiles(absoluteFiles, options, taskInfo);
|
const result = await this.compileFiles(absoluteFiles, options, taskInfo);
|
||||||
emittedFiles.push(...result.emittedFiles);
|
emittedFiles.push(...result.emittedFiles);
|
||||||
errorSummaries.push(result.errorSummary);
|
errorSummaries.push(result.errorSummary);
|
||||||
|
|
||||||
|
// Restore original sys methods and report any intercepted operations
|
||||||
|
if (watchedDirs.length > 0 && !isQuiet && !isJson) {
|
||||||
|
typescript.sys.writeFile = origSysWriteFile;
|
||||||
|
typescript.sys.deleteFile = origSysDeleteFile;
|
||||||
|
typescript.sys.createDirectory = origSysCreateDir;
|
||||||
|
if (interceptedOps.length > 0) {
|
||||||
|
console.log(` ⚠️ [diag] ${interceptedOps.length} TypeScript sys ops on previous output dirs:`);
|
||||||
|
for (const op of interceptedOps.slice(0, 30)) {
|
||||||
|
console.log(` ${op.replace(this.cwd + '/', '')}`);
|
||||||
|
}
|
||||||
|
if (interceptedOps.length > 30) {
|
||||||
|
console.log(` ... and ${interceptedOps.length - 30} more`);
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
console.log(` ℹ️ [diag] No TypeScript sys ops on previous output dirs during this compilation`);
|
||||||
|
}
|
||||||
|
}
|
||||||
diagSnap('post-compile');
|
diagSnap('post-compile');
|
||||||
|
|
||||||
// Diagnostic: log emitted files that went to unexpected directories
|
// Diagnostic: log emitted files that went to unexpected directories
|
||||||
@@ -405,15 +454,28 @@ export class TsCompiler {
|
|||||||
successfulOutputDirs.push(destDir);
|
successfulOutputDirs.push(destDir);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Diagnostic: log all output directory states after each compilation
|
// Force global filesystem sync to flush XFS delayed logging (CIL)
|
||||||
|
// before the next compilation step. Per-directory fsync was insufficient;
|
||||||
|
// XFS defers parent B+tree metadata commits which can make sibling
|
||||||
|
// directory entries invisible to readdirSync after heavy write activity.
|
||||||
|
execSync('sync');
|
||||||
|
|
||||||
|
// Diagnostic: compare readdirSync vs external ls to detect Node.js caching
|
||||||
if (!isQuiet && !isJson) {
|
if (!isQuiet && !isJson) {
|
||||||
for (const prevDir of successfulOutputDirs) {
|
for (const prevDir of successfulOutputDirs) {
|
||||||
try {
|
try {
|
||||||
const entries = fs.readdirSync(prevDir);
|
const nodeEntries = fs.readdirSync(prevDir);
|
||||||
const dirs = entries.filter(e => {
|
const nodeDirs = nodeEntries.filter(e => { try { return fs.statSync(prevDir + '/' + e).isDirectory(); } catch { return false; } });
|
||||||
try { return fs.statSync(prevDir + '/' + e).isDirectory(); } catch { return false; }
|
const lsOutput = execSync(`ls -1 "${prevDir}"`, { encoding: 'utf8' }).trim();
|
||||||
});
|
const lsEntries = lsOutput ? lsOutput.split('\n') : [];
|
||||||
console.log(` 📋 [diag] ${prevDir.replace(this.cwd + '/', '')}: ${entries.length} entries, ${dirs.length} dirs`);
|
const shortDir = prevDir.replace(this.cwd + '/', '');
|
||||||
|
if (nodeEntries.length !== lsEntries.length) {
|
||||||
|
console.log(` ⚠️ [diag] ${shortDir}: readdirSync=${nodeEntries.length}, ls=${lsEntries.length} (MISMATCH!)`);
|
||||||
|
console.log(` readdirSync: [${nodeEntries.sort().join(', ')}]`);
|
||||||
|
console.log(` ls: [${lsEntries.sort().join(', ')}]`);
|
||||||
|
} else {
|
||||||
|
console.log(` 📋 [diag] ${shortDir}: ${nodeEntries.length} entries, ${nodeDirs.length} dirs ✓`);
|
||||||
|
}
|
||||||
} catch {
|
} catch {
|
||||||
console.log(` 📋 [diag] ${prevDir.replace(this.cwd + '/', '')}: MISSING!`);
|
console.log(` 📋 [diag] ${prevDir.replace(this.cwd + '/', '')}: MISSING!`);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -107,6 +107,17 @@ export class TsUnpacker {
|
|||||||
|
|
||||||
const nestedPath = this.getNestedPath();
|
const nestedPath = this.getNestedPath();
|
||||||
|
|
||||||
|
// Force XFS to flush pending directory metadata before reading.
|
||||||
|
// XFS delayed logging (CIL) can defer metadata commits, causing
|
||||||
|
// readdirSync/opendirSync to return incomplete results immediately
|
||||||
|
// after TypeScript's emit() creates files via writeFileSync.
|
||||||
|
const destFd = fs.openSync(this.destDir, 'r');
|
||||||
|
fs.fsyncSync(destFd);
|
||||||
|
fs.closeSync(destFd);
|
||||||
|
const nestedFd = fs.openSync(nestedPath, 'r');
|
||||||
|
fs.fsyncSync(nestedFd);
|
||||||
|
fs.closeSync(nestedFd);
|
||||||
|
|
||||||
// Step 1: Remove sibling entries (everything in dest except the source folder)
|
// Step 1: Remove sibling entries (everything in dest except the source folder)
|
||||||
const destEntries = fs.readdirSync(this.destDir);
|
const destEntries = fs.readdirSync(this.destDir);
|
||||||
for (const entry of destEntries) {
|
for (const entry of destEntries) {
|
||||||
@@ -127,6 +138,10 @@ export class TsUnpacker {
|
|||||||
// Step 3: Remove the now-empty nested directory
|
// Step 3: Remove the now-empty nested directory
|
||||||
fs.rmdirSync(nestedPath);
|
fs.rmdirSync(nestedPath);
|
||||||
|
|
||||||
|
// Diagnostic: verify final state
|
||||||
|
const finalEntries = fs.readdirSync(this.destDir);
|
||||||
|
console.log(` 📦 Unpacked ${this.sourceFolderName}: moved ${nestedEntries.length} entries, final: ${finalEntries.length} entries`);
|
||||||
|
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user