BREAKING CHANGE(core): switch to esm

.gitlab-ci.yml

@@ -12,6 +12,9 @@ stages:
   - release
   - metadata
 
+before_script:
+  - npm install -g @shipzone/npmci
+
 # ====================
 # security stage
 # ====================
@@ -36,6 +39,7 @@ auditProductionDependencies:
     - npmci command npm audit --audit-level=high --only=prod --production
   tags:
     - docker
+  allow_failure: true
 
 auditDevDependencies:
   image: registry.gitlab.com/hosttoday/ht-docker-node:npmci
@@ -96,10 +100,9 @@ codequality:
   only:
     - tags
   script:
-    - npmci command npm install -g tslint typescript
+    - npmci command npm install -g typescript
     - npmci npm prepare
     - npmci npm install
-    - npmci command "tslint -c tslint.json ./ts/**/*.ts"
   tags:
     - lossless
     - docker

.vscode/launch.json

@@ -2,28 +2,10 @@
   "version": "0.2.0",
   "configurations": [
     {
-      "name": "current file",
-      "type": "node",
+      "command": "npm test",
+      "name": "Run npm test",
       "request": "launch",
-      "args": [
-        "${relativeFile}"
-      ],
-      "runtimeArgs": ["-r", "@gitzone/tsrun"],
-      "cwd": "${workspaceRoot}",
-      "protocol": "inspector",
-      "internalConsoleOptions": "openOnSessionStart"
-    },
-    {
-      "name": "test.ts",
-      "type": "node",
-      "request": "launch",
-      "args": [
-        "test/test.ts"
-      ],
-      "runtimeArgs": ["-r", "@gitzone/tsrun"],
-      "cwd": "${workspaceRoot}",
-      "protocol": "inspector",
-      "internalConsoleOptions": "openOnSessionStart"
+      "type": "node-terminal"
     }
   ]
 }

npmextra.json

@@ -5,7 +5,7 @@
       "githost": "gitlab.com",
       "gitscope": "pushrocks",
       "gitrepo": "levelcache",
-      "shortDescription": "a cache that uses memory/disk/s3 as backup",
+      "description": "a cache that uses memory/disk/s3 as backup",
       "npmPackagename": "@pushrocks/levelcache",
       "license": "MIT",
       "projectDomain": "push.rocks"

package.json

@@ -5,6 +5,7 @@
   "description": "a cache that uses memory/disk/s3 as backup",
   "main": "dist_ts/index.js",
   "typings": "dist_ts/index.d.ts",
+  "type": "module",
   "author": "Lossless GmbH",
   "license": "MIT",
   "scripts": {
@@ -12,24 +13,24 @@
     "build": "(tsbuild --web)"
   },
   "devDependencies": {
-    "@gitzone/tsbuild": "^2.1.25",
-    "@gitzone/tstest": "^1.0.52",
-    "@pushrocks/tapbundle": "^3.2.14",
-    "@types/node": "^14.14.41",
-    "tslint": "^6.1.3",
-    "tslint-config-prettier": "^1.15.0"
+    "@gitzone/tsbuild": "^2.1.60",
+    "@gitzone/tstest": "^1.0.69",
+    "@pushrocks/tapbundle": "^5.0.2",
+    "@types/node": "^17.0.22"
   },
   "dependencies": {
-    "@pushrocks/lik": "^4.0.20",
-    "@pushrocks/smartbucket": "^1.0.39",
+    "@pushrocks/lik": "^5.0.4",
+    "@pushrocks/smartbucket": "^1.0.44",
     "@pushrocks/smartcache": "^1.0.13",
-    "@pushrocks/smartexit": "^1.0.15",
-    "@pushrocks/smartfile": "^8.0.9",
+    "@pushrocks/smartenv": "^5.0.0",
+    "@pushrocks/smartexit": "^1.0.20",
+    "@pushrocks/smartfile": "^9.0.6",
     "@pushrocks/smartjson": "^4.0.6",
-    "@pushrocks/smartpromise": "^3.1.5",
-    "@pushrocks/smartstring": "^3.0.24",
+    "@pushrocks/smartpath": "^5.0.5",
+    "@pushrocks/smartpromise": "^3.1.7",
+    "@pushrocks/smartstring": "^4.0.1",
     "@pushrocks/smartunique": "^3.0.3",
-    "@pushrocks/taskbuffer": "^2.1.13"
+    "@pushrocks/taskbuffer": "^2.1.17"
   },
   "files": [
     "ts/**/*",

test/test.ts

@@ -1,6 +1,6 @@
 import { expect, tap } from '@pushrocks/tapbundle';
-import * as levelcache from '../ts/index';
-import { CacheEntry } from '../ts/index';
+import * as levelcache from '../ts/index.js';
+import { CacheEntry } from '../ts/index.js';
 
 let testLevelCache: levelcache.LevelCache;
 
@@ -8,7 +8,7 @@ tap.test('should create a new levelcache instance', async () => {
   testLevelCache = new levelcache.LevelCache({
     cacheId: 'myCache',
   });
-  expect(testLevelCache).to.be.instanceOf(levelcache.LevelCache);
+  expect(testLevelCache).toBeInstanceOf(levelcache.LevelCache);
 });
 
 tap.test('should cache a value', async () => {
@@ -21,7 +21,7 @@ tap.test('should cache a value', async () => {
     })
   );
   const result = await testLevelCache.retrieveCacheEntryByKey('mykey');
-  expect(result.contents.toString()).to.equal('heythere');
+  expect(result.contents.toString()).toEqual('heythere');
 });
 
 tap.test('should respect ttl', async (tools) => {
@@ -34,10 +34,10 @@ tap.test('should respect ttl', async (tools) => {
     })
   );
   const result = await testLevelCache.retrieveCacheEntryByKey('mykey');
-  expect(result.contents.toString()).to.equal('heythere');
+  expect(result.contents.toString()).toEqual('heythere');
   await tools.delayFor(1100);
   const result2 = await testLevelCache.retrieveCacheEntryByKey('mykey');
-  expect(result2).to.be.null;
+  expect(result2).toBeNull();
 });
 
 tap.start();

ts/index.ts

@@ -1,2 +1,2 @@
-export * from './levelcache.classes.levelcache';
-export * from './levelcache.classes.cacheentry';
+export * from './levelcache.classes.levelcache.js';
+export * from './levelcache.classes.cacheentry.js';

ts/levelcache.abstract.classes.cache.ts

@@ -1,4 +1,4 @@
-import { CacheEntry } from './levelcache.classes.cacheentry';
+import { CacheEntry } from './levelcache.classes.cacheentry.js';
 
 export abstract class AbstractCache {
   public abstract ready: Promise<void>;
@@ -24,7 +24,7 @@ export abstract class AbstractCache {
   /**
    * delete a key
    */
-   public abstract deleteCacheEntryByKey(keyArg: string): Promise<void>;
+  public abstract deleteCacheEntryByKey(keyArg: string): Promise<void>;
 
   /**
    * clean the cache

ts/levelcache.classes.cache.diskmanager.ts

@@ -1,8 +1,8 @@
-import * as plugins from './levelcache.plugins';
-import * as paths from './levelcache.paths';
-import { AbstractCache } from './levelcache.abstract.classes.cache';
-import { ILevelCacheConstructorOptions, LevelCache } from './levelcache.classes.levelcache';
-import { CacheEntry } from './levelcache.classes.cacheentry';
+import * as plugins from './levelcache.plugins.js';
+import * as paths from './levelcache.paths.js';
+import { AbstractCache } from './levelcache.abstract.classes.cache.js';
+import { ILevelCacheConstructorOptions, LevelCache } from './levelcache.classes.levelcache.js';
+import { CacheEntry } from './levelcache.classes.cacheentry.js';
 
 /**
  *
@@ -59,7 +59,6 @@ export class CacheDiskManager extends AbstractCache {
     await plugins.smartfile.fs.remove(plugins.path.join(this.fsPath, encodeURIComponent(keyArg)));
   }
 
-
   public async cleanOutdated() {}
 
   public async cleanAll() {

ts/levelcache.classes.cache.memorymanager.ts

@@ -1,7 +1,7 @@
-import * as plugins from './levelcache.plugins';
-import { AbstractCache } from './levelcache.abstract.classes.cache';
-import { CacheEntry } from './levelcache.classes.cacheentry';
-import { ILevelCacheConstructorOptions, LevelCache } from './levelcache.classes.levelcache';
+import * as plugins from './levelcache.plugins.js';
+import { AbstractCache } from './levelcache.abstract.classes.cache.js';
+import { CacheEntry } from './levelcache.classes.cacheentry.js';
+import { ILevelCacheConstructorOptions, LevelCache } from './levelcache.classes.levelcache.js';
 
 export class CacheMemoryManager extends AbstractCache {
   private levelCacheRef: LevelCache;

ts/levelcache.classes.cache.s3manager.ts

@@ -1,7 +1,7 @@
-import * as plugins from './levelcache.plugins';
-import { AbstractCache } from './levelcache.abstract.classes.cache';
-import { LevelCache } from './levelcache.classes.levelcache';
-import { CacheEntry } from './levelcache.classes.cacheentry';
+import * as plugins from './levelcache.plugins.js';
+import { AbstractCache } from './levelcache.abstract.classes.cache.js';
+import { LevelCache } from './levelcache.classes.levelcache.js';
+import { CacheEntry } from './levelcache.classes.cacheentry.js';
 
 /**
  *
@@ -26,9 +26,9 @@ export class CacheS3Manager extends AbstractCache {
     if (this.levelCacheRef.options.s3Config) {
       this.smartbucket = new plugins.smartbucket.SmartBucket(this.levelCacheRef.options.s3Config);
       this.s3CacheBucket = await this.smartbucket.getBucketByName('');
-      this.s3CacheDir = await (await this.s3CacheBucket.getBaseDirectory()).getSubDirectoryByName(
-        this.levelCacheRef.options.cacheId
-      );
+      this.s3CacheDir = await (
+        await this.s3CacheBucket.getBaseDirectory()
+      ).getSubDirectoryByName(this.levelCacheRef.options.cacheId);
       if (this.levelCacheRef.options.maxS3StorageInMB) {
         console.log(`cache level S3 activated with ${this.levelCacheRef.options.maxS3StorageInMB}`);
       } else {
@@ -65,7 +65,7 @@ export class CacheS3Manager extends AbstractCache {
   }
 
   public async deleteCacheEntryByKey(keyArg: string) {
-    if(this.status === 'active') {
+    if (this.status === 'active') {
       await this.s3CacheDir.fastRemove(encodeURIComponent(keyArg));
     }
   }

ts/levelcache.classes.cacheentry.ts

@@ -1,4 +1,4 @@
-import * as plugins from './levelcache.plugins';
+import * as plugins from './levelcache.plugins.js';
 
 export interface ICacheEntryConstructorOptions {
   key?: string;
@@ -12,7 +12,8 @@ export interface ICacheEntryConstructorOptions {
  */
 export class CacheEntry
   extends plugins.smartjson.Smartjson
-  implements ICacheEntryConstructorOptions {
+  implements ICacheEntryConstructorOptions
+{
   public static fromStorageJsonString(storageJsonString: string) {
     return new CacheEntry(plugins.smartjson.parse(storageJsonString));
   }
@@ -23,15 +24,15 @@ export class CacheEntry
   @plugins.smartjson.foldDec()
   public ttl: number;
 
+  @plugins.smartjson.foldDec()
+  public createdAt: number;
+
   @plugins.smartjson.foldDec()
   public typeInfo: string;
 
   @plugins.smartjson.foldDec()
   contents: Buffer;
 
-  @plugins.smartjson.foldDec()
-  public createdAt: number;
-
   public toStorageJsonString(): string {
     return this.foldToJson();
   }

ts/levelcache.classes.cacherouter.ts

@@ -1,7 +1,7 @@
-import * as plugins from './levelcache.plugins';
-import { LevelCache } from './levelcache.classes.levelcache';
-import { AbstractCache } from './levelcache.abstract.classes.cache';
-import { CacheEntry } from './levelcache.classes.cacheentry';
+import * as plugins from './levelcache.plugins.js';
+import { LevelCache } from './levelcache.classes.levelcache.js';
+import { AbstractCache } from './levelcache.abstract.classes.cache.js';
+import { CacheEntry } from './levelcache.classes.cacheentry.js';
 
 export class CacheRouter {
   public levelCacheRef: LevelCache;
@@ -14,24 +14,31 @@ export class CacheRouter {
   /**
    * gets the relevant cache to perform a store action on
    */
-  async getCacheForStoreAction(keyArg: string, cacheEntry: CacheEntry): Promise<AbstractCache> {
+  async getCacheForStoreAction (keyArg: string, cacheEntry: CacheEntry): Promise<AbstractCache> {
     let returnCache: AbstractCache;
+    const mbToBytesMultiplier = 1000 * 1000;
+    const maxMemoryBytes = this.levelCacheRef.options.maxMemoryStorageInMB * mbToBytesMultiplier;
+    const maxDiskBytes = this.levelCacheRef.options.maxDiskStorageInMB * mbToBytesMultiplier;
+    const maxS3Bytes = this.levelCacheRef.options.maxS3StorageInMB * mbToBytesMultiplier;
+
     switch (true) {
-      case cacheEntry.contents.byteLength <= 500:
+      case cacheEntry.contents.byteLength <= maxMemoryBytes &&
+        this.levelCacheRef.cacheMemoryManager.status === 'active':
         returnCache = this.levelCacheRef.cacheMemoryManager;
         break;
       case this.levelCacheRef.cacheDiskManager.status === 'active' &&
-        cacheEntry.contents.byteLength >= 500 &&
-        (cacheEntry.contents.byteLength < 10000 ||
-          this.levelCacheRef.cacheS3Manager.status === 'inactive'):
+        cacheEntry.contents.byteLength > maxMemoryBytes &&
+        cacheEntry.contents.byteLength <= maxDiskBytes &&
+        this.levelCacheRef.cacheDiskManager.status === 'active':
         returnCache = this.levelCacheRef.cacheDiskManager;
         break;
-      case cacheEntry.contents.byteLength >= 10000 &&
+      case cacheEntry.contents.byteLength > maxDiskBytes &&
+        cacheEntry.contents.byteLength < maxS3Bytes &&
         this.levelCacheRef.cacheS3Manager.status === 'active':
         returnCache = this.levelCacheRef.cacheS3Manager;
         break;
       default:
-        returnCache = this.levelCacheRef.cacheMemoryManager;
+        returnCache = null;
     }
     this.cacheKeyMap.addToMap(keyArg, returnCache);
     return returnCache;
@@ -40,7 +47,7 @@ export class CacheRouter {
   /**
    * gets the relevant cache to perform a retrieval action on
    */
-  async getCacheForRetrieveAction(keyArg: string): Promise<AbstractCache> {
+  async getCacheForRetrieveAction (keyArg: string): Promise<AbstractCache> {
     const done = plugins.smartpromise.defer<AbstractCache>();
     const returnCache = this.cacheKeyMap.getByKey(keyArg);
     if (!returnCache && this.levelCacheRef.options.persistentCache) {

ts/levelcache.classes.levelcache.ts

@@ -1,10 +1,10 @@
-import * as plugins from './levelcache.plugins';
-import { CacheDiskManager } from './levelcache.classes.cache.diskmanager';
-import { CacheMemoryManager } from './levelcache.classes.cache.memorymanager';
-import { CacheS3Manager } from './levelcache.classes.cache.s3manager';
-import { CacheEntry } from './levelcache.classes.cacheentry';
-import { CacheRouter } from './levelcache.classes.cacherouter';
-import { AbstractCache } from './levelcache.abstract.classes.cache';
+import * as plugins from './levelcache.plugins.js';
+import { CacheDiskManager } from './levelcache.classes.cache.diskmanager.js';
+import { CacheMemoryManager } from './levelcache.classes.cache.memorymanager.js';
+import { CacheS3Manager } from './levelcache.classes.cache.s3manager.js';
+import { CacheEntry } from './levelcache.classes.cacheentry.js';
+import { CacheRouter } from './levelcache.classes.cacherouter.js';
+import { AbstractCache } from './levelcache.abstract.classes.cache.js';
 
 export interface ILevelCacheConstructorOptions {
   /**
@@ -42,13 +42,18 @@ export class LevelCache extends AbstractCache {
 
   constructor(optionsArg: ILevelCacheConstructorOptions) {
     super();
-    this.options = optionsArg;
+    this.options = {
+      maxMemoryStorageInMB: 0.5,
+      maxDiskStorageInMB: 10,
+      maxS3StorageInMB: 50,
+      ...optionsArg
+    };
     this.init();
   }
 
   public async init() {
-    this.cacheDiskManager = new CacheDiskManager(this);
     this.cacheMemoryManager = new CacheMemoryManager(this);
+    this.cacheDiskManager = new CacheDiskManager(this);
     this.cacheS3Manager = new CacheS3Manager(this);
     await Promise.all([
       this.cacheDiskManager.ready,

ts/levelcache.paths.ts

@@ -1,4 +1,7 @@
-import * as plugins from './levelcache.plugins';
+import * as plugins from './levelcache.plugins.js';
 
-export const packageDir = plugins.path.join(__dirname, '../');
+export const packageDir = plugins.path.join(
+  plugins.smartpath.get.dirnameFromImportMetaUrl(import.meta.url),
+  '../'
+);
 export const nogitDir = plugins.path.join(packageDir, '.nogit/');

ts/levelcache.plugins.ts

@@ -9,6 +9,7 @@ import * as smartbucket from '@pushrocks/smartbucket';
 import * as smartcache from '@pushrocks/smartcache';
 import * as smartfile from '@pushrocks/smartfile';
 import * as smartjson from '@pushrocks/smartjson';
+import * as smartpath from '@pushrocks/smartpath';
 import * as smartpromise from '@pushrocks/smartpromise';
 import * as smartstring from '@pushrocks/smartstring';
 import * as smartunique from '@pushrocks/smartunique';
@@ -20,6 +21,7 @@ export {
   smartcache,
   smartfile,
   smartjson,
+  smartpath,
   smartpromise,
   smartstring,
   smartunique,

tsconfig.json

@@ -1,7 +1,8 @@
 {
   "compilerOptions": {
     "experimentalDecorators": true,
-    "target": "es2017",
-    "module": "commonjs"
+    "target": "ES2022",
+    "module": "ES2022",
+    "moduleResolution": "nodenext"
   }
 }

tslint.json

@@ -1,17 +0,0 @@
-{
-  "extends": ["tslint:latest", "tslint-config-prettier"],
-  "rules": {
-    "semicolon": [true, "always"],
-    "no-console": false,
-    "ordered-imports": false,
-    "object-literal-sort-keys": false,
-    "member-ordering": {
-      "options":{
-        "order": [
-          "static-method"
-        ]
-      }
-    }
-  },
-  "defaultSeverity": "warning"
-}