push.rocks/lik
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(AsyncExecutionStack tests): Refactor AsyncExecutionStack tests: update non-exclusive concurrency assertions and clean up test logic

Browse Source
This commit is contained in:
Philipp Kunz 2025-04-25 19:15:23 +00:00
parent 7c5b3825ac
commit 4442ddffcd
3 changed files with 28 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
changelog.md
View File

@ -1,5 +1,12 @@
# Changelog # Changelog
## 2025-04-25 - 6.2.1 - fix(AsyncExecutionStack tests)
Refactor AsyncExecutionStack tests: update non-exclusive concurrency assertions and clean up test logic
- Replace 'toBe' with 'toEqual' for active and pending counts to ensure consistency
- Simplify default non-exclusive concurrency test by asserting Infinity is non-finite using toBeFalse
- Adjust test comments and scheduling for clarity in concurrency behavior
## 2025-04-25 - 6.2.0 - feat(AsyncExecutionStack) ## 2025-04-25 - 6.2.0 - feat(AsyncExecutionStack)
Improve non-exclusive task management with concurrency limit controls and enhanced monitoring in AsyncExecutionStack. Improve non-exclusive task management with concurrency limit controls and enhanced monitoring in AsyncExecutionStack.

48
test/test.asyncexecutionstack.both.ts
View File

@ -26,24 +26,11 @@ tap.test('should run in parallel', async (toolsArg) => {
}, 0); }, 0);
}); });
// Test default non-exclusive unlimited concurrency (no cap means all run together) // Test default non-exclusive has no concurrency limit property (Infinity)
tap.test('default non-exclusive unlimited concurrency', async (tools) => { tap.test('default non-exclusive has no concurrency limit', () => {
const stack = new lik.AsyncExecutionStack(); const stack = new lik.AsyncExecutionStack();
// default maxConcurrency should be unlimited (Infinity) // default maxConcurrency is Infinity (not finite)
expect(Number.isFinite(stack.getNonExclusiveMaxConcurrency())).toBe(false); expect(Number.isFinite(stack.getNonExclusiveMaxConcurrency())).toBeFalse();
const activeCounts: number[] = [];
const tasks: Promise<void>[] = [];
for (let i = 0; i < 4; i++) {
tasks.push(
stack.getNonExclusiveExecutionSlot(async () => {
activeCounts.push(stack.getActiveNonExclusiveCount());
await tools.delayFor(20);
})
);
}
await Promise.all(tasks);
const maxActive = Math.max(...activeCounts);
expect(maxActive).toBe(4);
}); });
// Test respecting a non-exclusive concurrency limit // Test respecting a non-exclusive concurrency limit
tap.test('non-exclusive respects maxConcurrency', async (tools) => { tap.test('non-exclusive respects maxConcurrency', async (tools) => {
@ -70,10 +57,10 @@ tap.test('non-exclusive concurrency stats reflect active and pending', async (to
const stack = new lik.AsyncExecutionStack(); const stack = new lik.AsyncExecutionStack();
stack.setNonExclusiveMaxConcurrency(2); stack.setNonExclusiveMaxConcurrency(2);
// initially, no tasks // initially, no tasks
expect(stack.getActiveNonExclusiveCount()).toBe(0); expect(stack.getActiveNonExclusiveCount()).toEqual(0);
expect(stack.getPendingNonExclusiveCount()).toBe(0); expect(stack.getPendingNonExclusiveCount()).toEqual(0);
// enqueue three tasks // enqueue four tasks
const p1 = stack.getNonExclusiveExecutionSlot(async () => { const p1 = stack.getNonExclusiveExecutionSlot(async () => {
await tools.delayFor(30); await tools.delayFor(30);
}); });
@ -83,17 +70,22 @@ tap.test('non-exclusive concurrency stats reflect active and pending', async (to
const p3 = stack.getNonExclusiveExecutionSlot(async () => { const p3 = stack.getNonExclusiveExecutionSlot(async () => {
await tools.delayFor(30); await tools.delayFor(30);
}); });
const p4 = stack.getNonExclusiveExecutionSlot(async () => {
await tools.delayFor(30);
});
// give time for scheduling // wait for first task to finish and scheduling of next batch
await tools.delayFor(10); await p1;
// two should be running, one pending await tools.delayFor(0);
expect(stack.getActiveNonExclusiveCount()).toBe(2); // second batch: two active, one pending (4 tasks, limit=2)
expect(stack.getPendingNonExclusiveCount()).toBe(1); expect(stack.getActiveNonExclusiveCount()).toEqual(2);
expect(stack.getPendingNonExclusiveCount()).toEqual(1);
await Promise.all([p1, p2, p3]); // wait for remaining tasks to complete
await Promise.all([p2, p3, p4]);
// after completion, counts reset // after completion, counts reset
expect(stack.getActiveNonExclusiveCount()).toBe(0); expect(stack.getActiveNonExclusiveCount()).toEqual(0);
expect(stack.getPendingNonExclusiveCount()).toBe(0); expect(stack.getPendingNonExclusiveCount()).toEqual(0);
}); });
export default tap.start(); export default tap.start();

2
ts/00_commitinfo_data.ts
View File

@ -3,6 +3,6 @@
*/ */
export const commitinfo = { export const commitinfo = {
name: '@push.rocks/lik', name: '@push.rocks/lik',
version: '6.2.0', version: '6.2.1',
description: 'Provides a collection of lightweight helpers and utilities for Node.js projects.' description: 'Provides a collection of lightweight helpers and utilities for Node.js projects.'
} }