2.0.23

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushrocks/smartacme",
-  "version": "2.0.20",
+  "version": "2.0.23",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {
@@ -271,12 +271,12 @@
       }
     },
     "@pushrocks/smartstring": {
-      "version": "3.0.5",
+      "version": "3.0.8",
-      "resolved": "https://verdaccio.lossless.one/@pushrocks%2fsmartstring/-/smartstring-3.0.5.tgz",
+      "resolved": "https://verdaccio.lossless.one/@pushrocks%2fsmartstring/-/smartstring-3.0.8.tgz",
-      "integrity": "sha512-Bws2s6+Pc0HIXA35QH6cl6LJywhZ1U5icjyYMx+1kH8nURG+njzkacfarr9NWqyVYYOVu7SgXLzp9sR0eH7k9g==",
+      "integrity": "sha512-twmCGF47+TJoiCpj6t5MxwcKDDJEATuKqJXxftcHOlXWW743LJ/1bCpMueDdtumo5EheUfSxb43aRse3DU3wig==",
       "requires": {
         "crypto-random-string": "^1.0.0",
-        "js-base64": "^2.4.9",
+        "js-base64": "^2.5.0",
         "normalize-newline": "^3.0.0",
         "randomatic": "^3.1.1",
         "strip-indent": "^2.0.0"

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushrocks/smartacme",
-  "version": "2.0.20",
+  "version": "2.0.23",
   "private": false,
   "description": "acme implementation in TypeScript",
   "main": "dist/index.js",
@@ -32,6 +32,7 @@
     "@pushrocks/smartexpress": "^3.0.0",
     "@pushrocks/smartpromise": "^2.0.5",
     "@pushrocks/smartrequest": "^1.1.14",
+    "@pushrocks/smartstring": "^3.0.8",
     "@pushrocks/smarttime": "^3.0.5",
     "@pushrocks/smartunique": "^3.0.1",
     "acme-client": "^2.2.2"

test/test.ts

@@ -30,6 +30,13 @@ tap.test('should create a valid instance of SmartAcme', async () => {
   // await smartAcmeInstance.getCertificateForDomain('bleu.de');
 });
 
+tap.test('certmatcher should correctly match domains', async () => {
+  const certMatcherMod = await import('../ts/smartacme.classes.certmatcher'); 
+  const certMatcher = new certMatcherMod.CertMatcher();
+  const matchedCert = certMatcher.getCertificateDomainNameByDomainName('level3.level2.level1');
+  expect(matchedCert).to.equal('level2.level1');
+});
+
 tap.test('should stop correctly', async () => {
   await smartAcmeInstance.stop();
 });

ts/smartacme.classes.cert.ts

@@ -31,8 +31,10 @@ export class Cert extends plugins.smartdata.SmartDataDbDoc<Cert> implements inte
 
   constructor(optionsArg: ICert) {
     super();
+    if (optionsArg) {
       Object.keys(optionsArg).forEach(key => {
         this[key] = optionsArg[key];
       });
     }
+  }
 }

ts/smartacme.classes.certmatcher.ts

@@ -0,0 +1,10 @@
+import * as plugins from './smartacme.plugins';
+
+export class CertMatcher {
+  public getCertificateDomainNameByDomainName(domainNameArg: string): string {
+    const originalDomain = new plugins.smartstring.Domain(domainNameArg);
+    if (!originalDomain.level4) {
+      return `${originalDomain.level2}.${originalDomain.level1}`;
+    }
+  }
+}

ts/smartacme.classes.smartacme.ts

@@ -1,6 +1,7 @@
 import * as plugins from './smartacme.plugins';
 import { Cert } from './smartacme.classes.cert';
 import { CertManager } from './smartacme.classes.certmanager';
+import { CertMatcher } from './smartacme.classes.certmatcher';
 
 import * as interfaces from './interfaces';
 import { request } from 'http';
@@ -44,6 +45,7 @@ export class SmartAcme {
 
   // certmanager
   private certmanager: CertManager;
+  private certmatcher: CertMatcher;
   private certremoteHandler: plugins.smartexpress.Handler;
 
   constructor(optionsArg: ISmartAcmeOptions) {
@@ -68,6 +70,9 @@ export class SmartAcme {
     });
     await this.certmanager.init();
 
+    // CertMatcher
+    this.certmatcher = new CertMatcher();
+
     // CertRemoteHandler
     this.certremoteHandler = new plugins.smartexpress.Handler('POST', async (req, res) => {
       const requestBody: interfaces.ICertRemoteRequest = req.body;
@@ -118,9 +123,9 @@ export class SmartAcme {
   }
 
   public async getCertificateForDomain(domainArg: string): Promise<Cert> {
-    const domain = domainArg;
+    const certDomain = this.certmatcher.getCertificateDomainNameByDomainName(domainArg);
 
-    const retrievedCertificate = await this.certmanager.retrieveCertificate(domain);
+    const retrievedCertificate = await this.certmanager.retrieveCertificate(certDomain);
 
     if (retrievedCertificate) {
       return retrievedCertificate;
@@ -128,7 +133,7 @@ export class SmartAcme {
 
     /* Place new order */
     const order = await this.client.createOrder({
-      identifiers: [{ type: 'dns', value: domain }, { type: 'dns', value: `*.${domain}` }]
+      identifiers: [{ type: 'dns', value: certDomain }, { type: 'dns', value: `*.${certDomain}` }]
     });
 
     /* Get authorizations and select challenges */
@@ -168,8 +173,8 @@ export class SmartAcme {
 
     /* Finalize order */
     const [key, csr] = await plugins.acme.forge.createCsr({
-      commonName: `*.${domain}`,
+      commonName: `*.${certDomain}`,
-      altNames: [domain]
+      altNames: [certDomain]
     });
 
     await this.client.finalizeOrder(order, csr);
@@ -181,14 +186,14 @@ export class SmartAcme {
     console.log(`Certificate:\n${cert.toString()}`);
 
     await this.certmanager.storeCertificate({
-      domainName: domainArg,
+      domainName: certDomain,
       privateKey: key.toString(),
       publicKey: cert.toString(),
       csr: csr.toString(),
       created: Date.now()
     });
 
-    const newCertificate = await this.certmanager.retrieveCertificate(domainArg);
+    const newCertificate = await this.certmanager.retrieveCertificate(certDomain);
     return newCertificate;
   }
 }

ts/smartacme.plugins.ts

@@ -7,9 +7,10 @@ import * as smartexpress from '@pushrocks/smartexpress';
 import * as smartpromise from '@pushrocks/smartpromise';
 import * as smartrequest from '@pushrocks/smartrequest';
 import * as smartunique from '@pushrocks/smartunique';
+import * as smartstring from '@pushrocks/smartstring';
 import * as smarttime from '@pushrocks/smarttime';
 
-export { lik, smartdata, smartdelay, smartdns, smartexpress, smartpromise, smartrequest, smartunique, smarttime };
+export { lik, smartdata, smartdelay, smartdns, smartexpress, smartpromise, smartrequest, smartunique, smartstring, smarttime };
 
 // thirs party scope
 import * as acme from 'acme-client';