7.3.3

changelog.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## 2025-05-05 - 7.3.3 - fix(SmartAcme)
+Remove duplicate challengeHandlers declaration from SmartAcme class
+
+- Eliminated the redundant private declaration of challengeHandlers since it is already defined as a public property
+- Ensures a single source of truth and clearer interface for challenge handler configuration
+
+## 2025-05-05 - 7.3.2 - fix(test)
+Add missing checkWetherDomainIsSupported implementation to DummyHandler for interface compliance in tests
+
+- Implemented the missing checkWetherDomainIsSupported method in the DummyHandler to satisfy IChallengeHandler interface requirements
+- Ensured that tests now correctly instantiate the DummyHandler without interface errors
+
 ## 2025-05-05 - 7.3.1 - fix(core)
 Refactor import paths and update dependency references
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@push.rocks/smartacme",
-  "version": "7.3.1",
+  "version": "7.3.3",
   "private": false,
   "description": "A TypeScript-based ACME client for LetsEncrypt certificate management with a focus on simplicity and power.",
   "main": "dist_ts/index.js",

test/test.smartacme.ts

@@ -8,6 +8,7 @@ class DummyHandler implements IChallengeHandler<any> {
   getSupportedTypes(): string[] { return ['dns-01']; }
   async prepare(_: any): Promise<void> { /* no-op */ }
   async cleanup(_: any): Promise<void> { /* no-op */ }
+  async checkWetherDomainIsSupported(_: string): Promise<boolean> { return true; }
 }
 
 tap.test('constructor throws without challengeHandlers', async () => {

ts/00_commitinfo_data.ts

@@ -3,6 +3,6 @@
  */
 export const commitinfo = {
   name: '@push.rocks/smartacme',
-  version: '7.3.1',
+  version: '7.3.3',
   description: 'A TypeScript-based ACME client for LetsEncrypt certificate management with a focus on simplicity and power.'
 }

ts/smartacme.classes.smartacme.ts

@@ -64,13 +64,15 @@ export class SmartAcme {
 
   // certificate manager for persistence (implements ICertManager)
   public certmanager: ICertManager;
+  // configured pluggable ACME challenge handlers
+  public challengeHandlers: plugins.handlers.IChallengeHandler<any>[];
+
+
   private certmatcher: SmartacmeCertMatcher;
   // retry/backoff configuration (resolved with defaults)
   private retryOptions: { retries: number; factor: number; minTimeoutMs: number; maxTimeoutMs: number };
   // track pending DNS challenges for graceful shutdown
   private pendingChallenges: plugins.tsclass.network.IDnsChallenge[] = [];
-  // configured pluggable ACME challenge handlers
-  private challengeHandlers: plugins.handlers.IChallengeHandler<any>[];
   // priority order of challenge types
   private challengePriority: string[];
   // Map for coordinating concurrent certificate requests