push.rocks/smartbrowser
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(core): update

Browse Source
This commit is contained in:
Philipp Kunz 2019-06-03 17:17:20 +02:00
parent 318bdd1bd8
commit d79a5af51a
4 changed files with 11 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -42,4 +42,4 @@
"npmextra.json", "npmextra.json",
"readme.md" "readme.md"
] ]
} }

13
test/test.ts
View File

@ -3,22 +3,21 @@ import { tap, expect } from '@pushrocks/tapbundle';
import * as smartbrowser from '../ts/index'; import * as smartbrowser from '../ts/index';
let testSmartBrowser: smartbrowser.SmartBrowser; let testSmartBrowser: smartbrowser.SmartBrowser;
tap tap.test('should instanstiate a new browser ', async () => {
.test('should instanstiate a new browser ', async () => { testSmartBrowser = new smartbrowser.SmartBrowser();
testSmartBrowser = new smartbrowser.SmartBrowser(); return expect(testSmartBrowser).to.be.instanceof(smartbrowser.SmartBrowser);
return expect(testSmartBrowser).to.be.instanceof(smartbrowser.SmartBrowser); });
})
tap.test('should start the browser ', async () => { tap.test('should start the browser ', async () => {
await expect(testSmartBrowser.start()).to.eventually.be.fulfilled; await expect(testSmartBrowser.start()).to.eventually.be.fulfilled;
}); });
tap.test('should create a PDF from a page', async (tools) => { tap.test('should create a PDF from a page', async tools => {
const result = await testSmartBrowser.pdfFromPage('https://lossless.com'); const result = await testSmartBrowser.pdfFromPage('https://lossless.com');
expect(result.buffer).to.be.instanceOf(Buffer); expect(result.buffer).to.be.instanceOf(Buffer);
}); });
tap.test('should produce a valid screenshot', async (tools) => { tap.test('should produce a valid screenshot', async tools => {
const result = await testSmartBrowser.screenshotFromPage('https://lossless.com'); const result = await testSmartBrowser.screenshotFromPage('https://lossless.com');
expect(result.buffer).to.be.instanceOf(Buffer); expect(result.buffer).to.be.instanceOf(Buffer);
}); });

9
ts/index.ts
View File

@ -20,7 +20,7 @@ export class SmartBrowser {
/** /**
* make a screenshot from a page * make a screenshot from a page
* @param urlArg * @param urlArg
*/ */
public async screenshotFromPage(urlArg: string): Promise<interfaces.IScreenShotResult> { public async screenshotFromPage(urlArg: string): Promise<interfaces.IScreenShotResult> {
const pageId = plugins.smartunique.shortId(); const pageId = plugins.smartunique.shortId();
@ -41,10 +41,10 @@ export class SmartBrowser {
/** /**
* evalutes an expression on a page * evalutes an expression on a page
* @param urlArg * @param urlArg
* @param funcArg * @param funcArg
*/ */
public async evaluateOnPage (urlArg: string, funcArg: () => Promise<any>) { public async evaluateOnPage(urlArg: string, funcArg: () => Promise<any>) {
const page = await this.headlessBrowser.newPage(); const page = await this.headlessBrowser.newPage();
await page.goto(urlArg, { await page.goto(urlArg, {
waitUntil: 'networkidle2' waitUntil: 'networkidle2'
@ -63,7 +63,6 @@ export class SmartBrowser {
}); });
this.smartpdf = new plugins.smartpdf.SmartPdf(); this.smartpdf = new plugins.smartpdf.SmartPdf();
await this.smartpdf.start(this.headlessBrowser); await this.smartpdf.start(this.headlessBrowser);
} }
/** /**

1
ts/interfaces/index.ts
View File

@ -1,2 +1 @@
export * from './interfaces.screenshotresult'; export * from './interfaces.screenshotresult';