fix(smartcli.helpers): Improve CLI argument parsing and Deno runtime detection; use getUserArgs consistently

This commit is contained in:
2025-10-28 14:59:46 +00:00
parent e905af4b21
commit 913f8556d0
5 changed files with 55 additions and 28 deletions

View File

@@ -3,6 +3,6 @@
*/
export const commitinfo = {
name: '@push.rocks/smartcli',
version: '4.0.15',
version: '4.0.16',
description: 'A library that simplifies building reactive command-line applications using observables, with robust support for commands, arguments, options, aliases, and asynchronous operation management.'
}

View File

@@ -92,7 +92,7 @@ export class Smartcli {
* getOption
*/
public getOption(optionNameArg: string) {
const userArgs = getUserArgs(process.argv);
const userArgs = getUserArgs();
const parsedYargs = plugins.yargsParser(userArgs);
return parsedYargs[optionNameArg];
}
@@ -126,8 +126,7 @@ export class Smartcli {
*/
public startParse(): void {
// Get user arguments, properly handling Node.js, Deno (run/compiled), and Bun
// Pass process.argv explicitly to handle test scenarios where it's modified
const userArgs = getUserArgs(process.argv);
const userArgs = getUserArgs();
const parsedYArgs = plugins.yargsParser(userArgs);
const wantedCommand = parsedYArgs._[0];

View File

@@ -15,12 +15,17 @@ export function getUserArgs(argv?: string[]): string[] {
// it's the most reliable for Deno run and compiled.
// deno-lint-ignore no-explicit-any
const g: any = typeof globalThis !== 'undefined' ? globalThis : {};
if (!useProvidedArgv && g.Deno && g.Deno.args && Array.isArray(g.Deno.args)) {
// Check if we should use Deno.args
// Skip Deno.args if process.argv has been manipulated (test scenario detection)
const processArgv = typeof process !== 'undefined' && Array.isArray(process.argv) ? process.argv : [];
const argvLooksManipulated = processArgv.length > 2 && g.Deno && g.Deno.args;
if (!useProvidedArgv && g.Deno && g.Deno.args && Array.isArray(g.Deno.args) && !argvLooksManipulated) {
return g.Deno.args.slice();
}
const a =
argv ?? (typeof process !== 'undefined' && Array.isArray(process.argv) ? process.argv : []);
const a = argv ?? processArgv;
if (!Array.isArray(a) || a.length === 0) return [];