fix(provider(node)): use synchronous readdir to avoid partial results on some filesystems (e.g., XFS) when the process receives signals
This commit is contained in:
@@ -158,7 +158,11 @@ export class SmartFsProviderNode implements ISmartFsProvider {
|
||||
if (options?.recursive) {
|
||||
await this.listDirectoryRecursive(path, entries, options);
|
||||
} else {
|
||||
const dirents = await fs.readdir(path, { withFileTypes: true });
|
||||
// Use readdirSync for reliability — async readdir can return partial results
|
||||
// on XFS/mounted filesystems when the process receives signals (e.g., from
|
||||
// SmartExit/smartshell process group management). The synchronous version
|
||||
// completes the entire getdents64 syscall without event loop interruption.
|
||||
const dirents = fsSync.readdirSync(path, { withFileTypes: true });
|
||||
|
||||
for (const dirent of dirents) {
|
||||
const entryPath = pathModule.join(path, dirent.name);
|
||||
@@ -196,7 +200,8 @@ export class SmartFsProviderNode implements ISmartFsProvider {
|
||||
entries: IDirectoryEntry[],
|
||||
options?: IListOptions,
|
||||
): Promise<void> {
|
||||
const dirents = await fs.readdir(path, { withFileTypes: true });
|
||||
// Use readdirSync for reliability — see listDirectory comment
|
||||
const dirents = fsSync.readdirSync(path, { withFileTypes: true });
|
||||
|
||||
for (const dirent of dirents) {
|
||||
const entryPath = pathModule.join(path, dirent.name);
|
||||
|
||||
Reference in New Issue
Block a user