fix(core): update
This commit is contained in:
		
							
								
								
									
										
											BIN
										
									
								
								assets/pdfdir/ERpClkJ4T.pdf
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										
											BIN
										
									
								
								assets/pdfdir/ERpClkJ4T.pdf
									
									
									
									
									
										Normal file
									
								
							
										
											Binary file not shown.
										
									
								
							
							
								
								
									
										
											BIN
										
									
								
								assets/pdfdir/deSPavVfr.pdf
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										
											BIN
										
									
								
								assets/pdfdir/deSPavVfr.pdf
									
									
									
									
									
										Normal file
									
								
							
										
											Binary file not shown.
										
									
								
							
							
								
								
									
										
											BIN
										
									
								
								assets/pdfdir/yR7XuEXeT.pdf
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										
											BIN
										
									
								
								assets/pdfdir/yR7XuEXeT.pdf
									
									
									
									
									
										Normal file
									
								
							
										
											Binary file not shown.
										
									
								
							| @@ -8,6 +8,10 @@ tap.test('should create a valid instance of smartpdf', async () => { | ||||
|   expect(testSmartPdf).to.be.instanceof(smartpdf.SmartPdf); | ||||
| }); | ||||
|  | ||||
| tap.test('should start the instance', async () => { | ||||
|   await testSmartPdf.start(); | ||||
| }); | ||||
|  | ||||
| tap.test('should create a pdf from html string', async () => { | ||||
|   await testSmartPdf.getPdfForHtmlString('hi'); | ||||
| }); | ||||
| @@ -21,7 +25,7 @@ tap.test('should create a pdf from website as single page PDF', async () => { | ||||
| }); | ||||
|  | ||||
| tap.test('should be able to close properly', async () => { | ||||
|   await testSmartPdf.close(); | ||||
|   await testSmartPdf.stop(); | ||||
| }); | ||||
|  | ||||
| tap.start(); | ||||
|   | ||||
| @@ -14,10 +14,9 @@ export class SmartPdf { | ||||
|  | ||||
|   constructor() { | ||||
|     this._readyDeferred = new plugins.smartpromise.Deferred(); | ||||
|     this.init(); | ||||
|   } | ||||
|  | ||||
|   async init() { | ||||
|   async start() { | ||||
|     // setup puppeteer | ||||
|     this.headlessBrowser = await plugins.puppeteer.launch(); | ||||
|  | ||||
| @@ -36,7 +35,7 @@ export class SmartPdf { | ||||
|     }); | ||||
|   } | ||||
|  | ||||
|   async close() { | ||||
|   async stop() { | ||||
|     const done = plugins.smartpromise.defer<void>(); | ||||
|     this.htmlServerInstance.close(() => { | ||||
|       done.resolve(); | ||||
|   | ||||
		Reference in New Issue
	
	Block a user