Compare commits

..

4 Commits

Author SHA1 Message Date
86d2fc2c5b 1.0.14 2019-06-03 13:45:57 +02:00
f97866fe82 fix(core): update 2019-06-03 13:45:57 +02:00
5c0b8c4df0 1.0.13 2019-06-03 13:02:01 +02:00
8da88be5e8 fix(core): update 2019-06-03 13:02:01 +02:00
3 changed files with 14 additions and 4 deletions

2
package-lock.json generated
View File

@ -1,6 +1,6 @@
{ {
"name": "@pushrocks/smartpdf", "name": "@pushrocks/smartpdf",
"version": "1.0.12", "version": "1.0.14",
"lockfileVersion": 1, "lockfileVersion": 1,
"requires": true, "requires": true,
"dependencies": { "dependencies": {

View File

@ -1,6 +1,6 @@
{ {
"name": "@pushrocks/smartpdf", "name": "@pushrocks/smartpdf",
"version": "1.0.12", "version": "1.0.14",
"private": false, "private": false,
"description": "create pdfs on the fly", "description": "create pdfs on the fly",
"main": "dist/index.js", "main": "dist/index.js",

View File

@ -23,7 +23,13 @@ export class SmartPdf {
async start() { async start() {
// setup puppeteer // setup puppeteer
if (!this.headlessBrowser) { if (!this.headlessBrowser) {
this.headlessBrowser = await plugins.puppeteer.launch(); let chromeArgs: string[] = [];
if(process.env.CI) {
chromeArgs = chromeArgs.concat(['--no-sandbox', '--disable-setuid-sandbox'])
}
this.headlessBrowser = await plugins.puppeteer.launch({
args: chromeArgs
});
} else { } else {
this.externalBrowser = true; this.externalBrowser = true;
} }
@ -48,7 +54,11 @@ export class SmartPdf {
this.htmlServerInstance.close(() => { this.htmlServerInstance.close(() => {
done.resolve(); done.resolve();
}); });
await this.headlessBrowser.close();
if (!this.externalBrowser) {
await this.headlessBrowser.close();
}
await done.promise; await done.promise;
} }