1.0.17

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushrocks/smartpdf",
-  "version": "1.0.14",
+  "version": "1.0.17",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushrocks/smartpdf",
-  "version": "1.0.14",
+  "version": "1.0.17",
   "private": false,
   "description": "create pdfs on the fly",
   "main": "dist/index.js",

ts/smartpdf.classes.smartpdf.ts

@@ -5,24 +5,27 @@ import { PdfCandidate } from './smartpdf.classes.pdfcandidate';
 
 declare const document;
 
-import { IPdfResult } from './interfaces';
+import * as interfaces from './interfaces';
 
 export class SmartPdf {
   htmlServerInstance: Server;
   serverPort: number;
   headlessBrowser: plugins.puppeteer.Browser;
-  externalBrowser: boolean = false;
+  externalBrowserBool: boolean = false;
   private _readyDeferred: plugins.smartpromise.Deferred<void>;
   private _candidates: { [key: string]: PdfCandidate } = {};
 
-  constructor(headlessBrowserArg?) {
+  constructor() {
-    this.headlessBrowser = headlessBrowserArg
     this._readyDeferred = new plugins.smartpromise.Deferred();
   }
 
-  async start() {
+  async start(headlessBrowserArg?) {
+    // lets set the external browser in case one is provided
+    this.headlessBrowser = headlessBrowserArg
     // setup puppeteer
-    if (!this.headlessBrowser) {
+    if (this.headlessBrowser) {
+      this.externalBrowserBool = true;
+    } else {
       let  chromeArgs: string[] = [];
       if(process.env.CI) {
         chromeArgs = chromeArgs.concat(['--no-sandbox', '--disable-setuid-sandbox'])
@@ -30,8 +33,6 @@ export class SmartPdf {
       this.headlessBrowser = await plugins.puppeteer.launch({
         args: chromeArgs
       });
-    } else {
-      this.externalBrowser = true;
     }
 
     // setup server
@@ -49,13 +50,14 @@ export class SmartPdf {
     });
   }
 
+  // stop
   async stop() {
     const done = plugins.smartpromise.defer<void>();
     this.htmlServerInstance.close(() => {
       done.resolve();
     });
     
-    if (!this.externalBrowser) {
+    if (!this.externalBrowserBool) {
       await this.headlessBrowser.close();
     }
 
@@ -65,7 +67,7 @@ export class SmartPdf {
   /**
    * returns a pdf for a given html string;
    */
-  async getPdfForHtmlString(htmlStringArg: string): Promise<IPdfResult> {
+  async getPdfForHtmlString(htmlStringArg: string): Promise<interfaces.IPdfResult> {
     await this._readyDeferred.promise;
     const pdfCandidate = new PdfCandidate(htmlStringArg);
     this._candidates[pdfCandidate.pdfId] = pdfCandidate;
@@ -95,7 +97,7 @@ export class SmartPdf {
     };
   }
 
-  async getPdfForWebsite(websiteUrl: string): Promise<IPdfResult> {
+  async getPdfForWebsite(websiteUrl: string): Promise<interfaces.IPdfResult> {
     const page = await this.headlessBrowser.newPage();
     page.emulateMedia('screen');
     const response = await page.goto(websiteUrl, { waitUntil: 'networkidle2' });

ts/smartpdf.paths.ts

@@ -1,6 +1,3 @@
 import * as plugins from './smartpdf.plugins';
 
 export const packageDir = plugins.path.join(__dirname, '../');
-export const pdfDir = plugins.path.join(packageDir, 'assets/pdfdir');
-
-plugins.smartfile.fs.ensureDirSync(pdfDir);