Compare commits

...

2 Commits

Author SHA1 Message Date
bb7cb4a6ab 1.0.7 2019-05-29 14:14:03 +02:00
bda43bf5e7 fix(core): update 2019-05-29 14:14:02 +02:00
7 changed files with 9 additions and 6 deletions

BIN
assets/pdfdir/ERpClkJ4T.pdf Normal file

Binary file not shown.

BIN
assets/pdfdir/deSPavVfr.pdf Normal file

Binary file not shown.

BIN
assets/pdfdir/yR7XuEXeT.pdf Normal file

Binary file not shown.

2
package-lock.json generated
View File

@ -1,6 +1,6 @@
{
"name": "@pushrocks/smartpdf",
"version": "1.0.6",
"version": "1.0.7",
"lockfileVersion": 1,
"requires": true,
"dependencies": {

View File

@ -1,6 +1,6 @@
{
"name": "@pushrocks/smartpdf",
"version": "1.0.6",
"version": "1.0.7",
"private": false,
"description": "create pdfs on the fly",
"main": "dist/index.js",

View File

@ -8,6 +8,10 @@ tap.test('should create a valid instance of smartpdf', async () => {
expect(testSmartPdf).to.be.instanceof(smartpdf.SmartPdf);
});
tap.test('should start the instance', async () => {
await testSmartPdf.start();
});
tap.test('should create a pdf from html string', async () => {
await testSmartPdf.getPdfForHtmlString('hi');
});
@ -21,7 +25,7 @@ tap.test('should create a pdf from website as single page PDF', async () => {
});
tap.test('should be able to close properly', async () => {
await testSmartPdf.close();
await testSmartPdf.stop();
});
tap.start();

View File

@ -14,10 +14,9 @@ export class SmartPdf {
constructor() {
this._readyDeferred = new plugins.smartpromise.Deferred();
this.init();
}
async init() {
async start() {
// setup puppeteer
this.headlessBrowser = await plugins.puppeteer.launch();
@ -36,7 +35,7 @@ export class SmartPdf {
});
}
async close() {
async stop() {
const done = plugins.smartpromise.defer<void>();
this.htmlServerInstance.close(() => {
done.resolve();