update
This commit is contained in:
@@ -93,6 +93,12 @@ export class SmartCertManager {
|
||||
*/
|
||||
public setUpdateRoutesCallback(callback: (routes: IRouteConfig[]) => Promise<void>): void {
|
||||
this.updateRoutesCallback = callback;
|
||||
try {
|
||||
logger.log('debug', 'Route update callback set successfully', { component: 'certificate-manager' });
|
||||
} catch (error) {
|
||||
// Silently handle logging errors
|
||||
console.log('[DEBUG] Route update callback set successfully');
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -399,13 +405,23 @@ export class SmartCertManager {
|
||||
private async addChallengeRoute(): Promise<void> {
|
||||
// Check with state manager first
|
||||
if (this.acmeStateManager && this.acmeStateManager.isChallengeRouteActive()) {
|
||||
logger.log('info', 'Challenge route already active in global state, skipping', { component: 'certificate-manager' });
|
||||
try {
|
||||
logger.log('info', 'Challenge route already active in global state, skipping', { component: 'certificate-manager' });
|
||||
} catch (error) {
|
||||
// Silently handle logging errors
|
||||
console.log('[INFO] Challenge route already active in global state, skipping');
|
||||
}
|
||||
this.challengeRouteActive = true;
|
||||
return;
|
||||
}
|
||||
|
||||
if (this.challengeRouteActive) {
|
||||
logger.log('info', 'Challenge route already active locally, skipping', { component: 'certificate-manager' });
|
||||
try {
|
||||
logger.log('info', 'Challenge route already active locally, skipping', { component: 'certificate-manager' });
|
||||
} catch (error) {
|
||||
// Silently handle logging errors
|
||||
console.log('[INFO] Challenge route already active locally, skipping');
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -445,7 +461,24 @@ export class SmartCertManager {
|
||||
// Add the challenge route
|
||||
const challengeRoute = this.challengeRoute;
|
||||
|
||||
// If the port is already in use by other routes in this SmartProxy instance,
|
||||
// we can safely add the ACME challenge route without trying to bind to the port again
|
||||
try {
|
||||
// Check if we're already listening on the challenge port
|
||||
const isPortAlreadyBound = portInUseByRoutes;
|
||||
|
||||
if (isPortAlreadyBound) {
|
||||
try {
|
||||
logger.log('info', `Port ${challengePort} is already bound by SmartProxy, adding ACME challenge route without rebinding`, {
|
||||
port: challengePort,
|
||||
component: 'certificate-manager'
|
||||
});
|
||||
} catch (error) {
|
||||
// Silently handle logging errors
|
||||
console.log(`[INFO] Port ${challengePort} is already bound by SmartProxy, adding ACME challenge route without rebinding`);
|
||||
}
|
||||
}
|
||||
|
||||
const updatedRoutes = [...this.routes, challengeRoute];
|
||||
await this.updateRoutesCallback(updatedRoutes);
|
||||
this.challengeRouteActive = true;
|
||||
@@ -455,15 +488,25 @@ export class SmartCertManager {
|
||||
this.acmeStateManager.addChallengeRoute(challengeRoute);
|
||||
}
|
||||
|
||||
logger.log('info', 'ACME challenge route successfully added', { component: 'certificate-manager' });
|
||||
try {
|
||||
logger.log('info', 'ACME challenge route successfully added', { component: 'certificate-manager' });
|
||||
} catch (error) {
|
||||
// Silently handle logging errors
|
||||
console.log('[INFO] ACME challenge route successfully added');
|
||||
}
|
||||
} catch (error) {
|
||||
// Handle specific EADDRINUSE errors differently based on whether it's an internal conflict
|
||||
if ((error as any).code === 'EADDRINUSE') {
|
||||
logger.log('error', `Failed to add challenge route on port ${challengePort}: ${error.message}`, {
|
||||
error: error.message,
|
||||
port: challengePort,
|
||||
component: 'certificate-manager'
|
||||
});
|
||||
try {
|
||||
logger.log('error', `Failed to add challenge route on port ${challengePort}: ${error.message}`, {
|
||||
error: (error as Error).message,
|
||||
port: challengePort,
|
||||
component: 'certificate-manager'
|
||||
});
|
||||
} catch (logError) {
|
||||
// Silently handle logging errors
|
||||
console.log(`[ERROR] Failed to add challenge route on port ${challengePort}: ${error.message}`);
|
||||
}
|
||||
|
||||
// Provide a more informative error message
|
||||
throw new Error(
|
||||
@@ -474,10 +517,15 @@ export class SmartCertManager {
|
||||
}
|
||||
|
||||
// Log and rethrow other errors
|
||||
logger.log('error', `Failed to add challenge route: ${error.message}`, {
|
||||
error: error.message,
|
||||
component: 'certificate-manager'
|
||||
});
|
||||
try {
|
||||
logger.log('error', `Failed to add challenge route: ${(error as Error).message}`, {
|
||||
error: (error as Error).message,
|
||||
component: 'certificate-manager'
|
||||
});
|
||||
} catch (logError) {
|
||||
// Silently handle logging errors
|
||||
console.log(`[ERROR] Failed to add challenge route: ${(error as Error).message}`);
|
||||
}
|
||||
throw error;
|
||||
}
|
||||
}
|
||||
@@ -487,7 +535,12 @@ export class SmartCertManager {
|
||||
*/
|
||||
private async removeChallengeRoute(): Promise<void> {
|
||||
if (!this.challengeRouteActive) {
|
||||
logger.log('info', 'Challenge route not active, skipping removal', { component: 'certificate-manager' });
|
||||
try {
|
||||
logger.log('info', 'Challenge route not active, skipping removal', { component: 'certificate-manager' });
|
||||
} catch (error) {
|
||||
// Silently handle logging errors
|
||||
console.log('[INFO] Challenge route not active, skipping removal');
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -505,9 +558,19 @@ export class SmartCertManager {
|
||||
this.acmeStateManager.removeChallengeRoute('acme-challenge');
|
||||
}
|
||||
|
||||
logger.log('info', 'ACME challenge route successfully removed', { component: 'certificate-manager' });
|
||||
try {
|
||||
logger.log('info', 'ACME challenge route successfully removed', { component: 'certificate-manager' });
|
||||
} catch (error) {
|
||||
// Silently handle logging errors
|
||||
console.log('[INFO] ACME challenge route successfully removed');
|
||||
}
|
||||
} catch (error) {
|
||||
logger.log('error', `Failed to remove challenge route: ${error.message}`, { error: error.message, component: 'certificate-manager' });
|
||||
try {
|
||||
logger.log('error', `Failed to remove challenge route: ${error.message}`, { error: error.message, component: 'certificate-manager' });
|
||||
} catch (logError) {
|
||||
// Silently handle logging errors
|
||||
console.log(`[ERROR] Failed to remove challenge route: ${error.message}`);
|
||||
}
|
||||
// Reset the flag even on error to avoid getting stuck
|
||||
this.challengeRouteActive = false;
|
||||
throw error;
|
||||
|
Reference in New Issue
Block a user