Compare commits

...

10 Commits

Author SHA1 Message Date
95adf56e52 v25.10.7
Some checks failed
Default (tags) / security (push) Successful in 1m4s
Default (tags) / test (push) Failing after 4m5s
Default (tags) / release (push) Has been skipped
Default (tags) / metadata (push) Has been skipped
2026-03-12 22:41:20 +00:00
c96a493fb6 fix(rustproxy-http): remove Host header from HTTP/2 upstream requests while preserving it for HTTP/1 retries 2026-03-12 22:41:20 +00:00
b92587cc16 v25.10.6
Some checks failed
Default (tags) / security (push) Successful in 52s
Default (tags) / test (push) Failing after 4m0s
Default (tags) / release (push) Has been skipped
Default (tags) / metadata (push) Has been skipped
2026-03-12 22:06:11 +00:00
b3dc0a6db2 fix(rustproxy-http): use the requested domain as HTTP/2 authority instead of the backend host and port 2026-03-12 22:06:11 +00:00
de3b8d3f58 v25.10.5
Some checks failed
Default (tags) / security (push) Successful in 1m12s
Default (tags) / test (push) Failing after 4m5s
Default (tags) / release (push) Has been skipped
Default (tags) / metadata (push) Has been skipped
2026-03-12 21:53:04 +00:00
75089ec975 fix(rustproxy-http): configure HTTP/2 client builders with a Tokio timer for keep-alive handling 2026-03-12 21:53:04 +00:00
b106db932b v25.10.4
Some checks failed
Default (tags) / security (push) Successful in 42s
Default (tags) / test (push) Failing after 4m0s
Default (tags) / release (push) Has been skipped
Default (tags) / metadata (push) Has been skipped
2026-03-12 21:41:54 +00:00
fb0c0dcc31 fix(rustproxy-http): stabilize upstream HTTP/2 forwarding and fallback behavior 2026-03-12 21:41:54 +00:00
61b67b91a0 v25.10.3
Some checks failed
Default (tags) / security (push) Successful in 42s
Default (tags) / test (push) Failing after 4m0s
Default (tags) / release (push) Has been skipped
Default (tags) / metadata (push) Has been skipped
2026-03-12 21:04:58 +00:00
fc64f5a95e fix(rustproxy-http): include request domain in backend proxy error and protocol detection logs 2026-03-12 21:04:58 +00:00
4 changed files with 223 additions and 64 deletions

View File

@@ -1,5 +1,40 @@
# Changelog # Changelog
## 2026-03-12 - 25.10.7 - fix(rustproxy-http)
remove Host header from HTTP/2 upstream requests while preserving it for HTTP/1 retries
- strips the Host header before sending HTTP/2 upstream requests so :authority from the URI is used instead
- avoids 400 responses from nginx caused by sending both Host and :authority headers
- keeps a cloned header set for bodyless request retries so HTTP/1 fallback still retains the Host header
## 2026-03-12 - 25.10.6 - fix(rustproxy-http)
use the requested domain as HTTP/2 authority instead of the backend host and port
- build HTTP/2 absolute URIs from the client-facing domain so the :authority pseudo-header matches the Host header
- remove backend port from generated HTTP/2 request URIs and fall back to the upstream host only when no domain is available
- apply the authority handling consistently across pooled, inline, and generic upstream request paths
## 2026-03-12 - 25.10.5 - fix(rustproxy-http)
configure HTTP/2 client builders with a Tokio timer for keep-alive handling
- Adds TokioTimer to all HTTP/2 client builder instances in proxy_service.
- Ensures configured HTTP/2 keep-alive interval and timeout settings have the required timer runtime support.
## 2026-03-12 - 25.10.4 - fix(rustproxy-http)
stabilize upstream HTTP/2 forwarding and fallback behavior
- Remove hop-by-hop headers before forwarding requests to HTTP/2 backends to comply with RFC 9113.
- Use ALPN-enabled TLS configuration whenever HTTP/2 is possible, including explicit H2 connections and retries.
- Add HTTP/2 handshake timeouts, tuned connection settings, and fallback to HTTP/1 when H2 negotiation times out or fails.
- Register pooled HTTP/2 senders only after a successful first request to avoid reusing broken connections.
- Build absolute URIs for HTTP/2 upstream requests so pseudo-headers such as scheme and authority are derived correctly.
## 2026-03-12 - 25.10.3 - fix(rustproxy-http)
include request domain in backend proxy error and protocol detection logs
- Adds domain context to backend TCP/TLS connect, handshake, request failure, retry, and fallback log entries in the Rust HTTP proxy service.
- Propagates the resolved host/domain through H1, H2, pooled, and fallback forwarding paths so backend-level diagnostics can be correlated with the original request domain.
## 2026-03-12 - 25.10.2 - fix(repo) ## 2026-03-12 - 25.10.2 - fix(repo)
no code changes to release no code changes to release

View File

@@ -1,6 +1,6 @@
{ {
"name": "@push.rocks/smartproxy", "name": "@push.rocks/smartproxy",
"version": "25.10.2", "version": "25.10.7",
"private": false, "private": false,
"description": "A powerful proxy package with unified route-based configuration for high traffic management. Features include SSL/TLS support, flexible routing patterns, WebSocket handling, advanced security options, and automatic ACME certificate management.", "description": "A powerful proxy package with unified route-based configuration for high traffic management. Features include SSL/TLS support, flexible routing patterns, WebSocket handling, advanced security options, and automatic ACME certificate management.",
"main": "dist_ts/index.js", "main": "dist_ts/index.js",

View File

@@ -479,6 +479,7 @@ impl HttpProxyService {
} }
let upstream_key = format!("{}:{}", upstream.host, upstream.port); let upstream_key = format!("{}:{}", upstream.host, upstream.port);
let domain_str = host.as_deref().unwrap_or("-");
self.upstream_selector.connection_started(&upstream_key); self.upstream_selector.connection_started(&upstream_key);
// Check for WebSocket upgrade // Check for WebSocket upgrade
@@ -538,6 +539,15 @@ impl HttpProxyService {
} }
} }
// Remove hop-by-hop headers (RFC 9113 §8.2.2 forbids connection-specific headers in H2)
upstream_headers.remove("connection");
upstream_headers.remove("keep-alive");
upstream_headers.remove("proxy-connection");
upstream_headers.remove("transfer-encoding");
upstream_headers.remove("te");
upstream_headers.remove("trailer");
upstream_headers.remove("upgrade");
// Add standard reverse-proxy headers (X-Forwarded-*) // Add standard reverse-proxy headers (X-Forwarded-*)
{ {
let original_host = host.as_deref().unwrap_or(""); let original_host = host.as_deref().unwrap_or("");
@@ -622,7 +632,7 @@ impl HttpProxyService {
self.metrics.set_backend_protocol(&upstream_key, "h2"); self.metrics.set_backend_protocol(&upstream_key, "h2");
let result = self.forward_h2_pooled( let result = self.forward_h2_pooled(
sender, parts, body, upstream_headers, &upstream_path, sender, parts, body, upstream_headers, &upstream_path,
route_match.route, route_id, &ip_str, &pool_key, route_match.route, route_id, &ip_str, &pool_key, domain_str,
).await; ).await;
self.upstream_selector.connection_ended(&upstream_key); self.upstream_selector.connection_ended(&upstream_key);
return result; return result;
@@ -633,8 +643,8 @@ impl HttpProxyService {
// --- Fresh connection path --- // --- Fresh connection path ---
self.metrics.backend_pool_miss(&upstream_key); self.metrics.backend_pool_miss(&upstream_key);
// Choose TLS config: use ALPN config for auto-detect probe, plain config otherwise // Choose TLS config: use ALPN config when H2 is possible (auto-detect probe OR explicit H2)
let tls_config = if needs_alpn_probe { let tls_config = if needs_alpn_probe || use_h2 {
&self.backend_tls_config_alpn &self.backend_tls_config_alpn
} else { } else {
&self.backend_tls_config &self.backend_tls_config
@@ -668,6 +678,7 @@ impl HttpProxyService {
info!( info!(
backend = %upstream_key, backend = %upstream_key,
domain = %domain_str,
protocol = if is_h2 { "h2" } else { "h1" }, protocol = if is_h2 { "h2" } else { "h1" },
connect_time_ms = %connect_start.elapsed().as_millis(), connect_time_ms = %connect_start.elapsed().as_millis(),
"Backend protocol detected via ALPN" "Backend protocol detected via ALPN"
@@ -684,6 +695,7 @@ impl HttpProxyService {
Ok(Err(e)) => { Ok(Err(e)) => {
error!( error!(
backend = %upstream_key, backend = %upstream_key,
domain = %domain_str,
connect_time_ms = %connect_start.elapsed().as_millis(), connect_time_ms = %connect_start.elapsed().as_millis(),
error = %e, error = %e,
"Backend TLS connect failed" "Backend TLS connect failed"
@@ -695,6 +707,7 @@ impl HttpProxyService {
Err(_) => { Err(_) => {
error!( error!(
backend = %upstream_key, backend = %upstream_key,
domain = %domain_str,
connect_time_ms = %connect_start.elapsed().as_millis(), connect_time_ms = %connect_start.elapsed().as_millis(),
"Backend TLS connect timeout" "Backend TLS connect timeout"
); );
@@ -720,6 +733,7 @@ impl HttpProxyService {
Ok(Err(e)) => { Ok(Err(e)) => {
error!( error!(
backend = %upstream_key, backend = %upstream_key,
domain = %domain_str,
connect_time_ms = %connect_start.elapsed().as_millis(), connect_time_ms = %connect_start.elapsed().as_millis(),
error = %e, error = %e,
"Backend TCP connect failed" "Backend TCP connect failed"
@@ -731,6 +745,7 @@ impl HttpProxyService {
Err(_) => { Err(_) => {
error!( error!(
backend = %upstream_key, backend = %upstream_key,
domain = %domain_str,
connect_time_ms = %connect_start.elapsed().as_millis(), connect_time_ms = %connect_start.elapsed().as_millis(),
"Backend TCP connect timeout" "Backend TCP connect timeout"
); );
@@ -756,19 +771,19 @@ impl HttpProxyService {
self.forward_h2_with_fallback( self.forward_h2_with_fallback(
io, parts, body, upstream_headers, &upstream_path, io, parts, body, upstream_headers, &upstream_path,
&upstream, route_match.route, route_id, &ip_str, &final_pool_key, &upstream, route_match.route, route_id, &ip_str, &final_pool_key,
host.clone(), host.clone(), domain_str,
).await ).await
} else { } else {
// Explicit H2 mode: hard-fail on handshake error (preserved behavior) // Explicit H2 mode: hard-fail on handshake error (preserved behavior)
self.forward_h2( self.forward_h2(
io, parts, body, upstream_headers, &upstream_path, io, parts, body, upstream_headers, &upstream_path,
&upstream, route_match.route, route_id, &ip_str, &final_pool_key, &upstream, route_match.route, route_id, &ip_str, &final_pool_key, domain_str,
).await ).await
} }
} else { } else {
self.forward_h1( self.forward_h1(
io, parts, body, upstream_headers, &upstream_path, io, parts, body, upstream_headers, &upstream_path,
&upstream, route_match.route, route_id, &ip_str, &final_pool_key, &upstream, route_match.route, route_id, &ip_str, &final_pool_key, domain_str,
).await ).await
}; };
self.upstream_selector.connection_ended(&upstream_key); self.upstream_selector.connection_ended(&upstream_key);
@@ -790,6 +805,7 @@ impl HttpProxyService {
route_id: Option<&str>, route_id: Option<&str>,
source_ip: &str, source_ip: &str,
pool_key: &crate::connection_pool::PoolKey, pool_key: &crate::connection_pool::PoolKey,
domain: &str,
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> { ) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
let backend_key = format!("{}:{}", pool_key.host, pool_key.port); let backend_key = format!("{}:{}", pool_key.host, pool_key.port);
@@ -798,7 +814,7 @@ impl HttpProxyService {
self.metrics.backend_pool_hit(&backend_key); self.metrics.backend_pool_hit(&backend_key);
return self.forward_h1_with_sender( return self.forward_h1_with_sender(
pooled_sender, parts, body, upstream_headers, upstream_path, pooled_sender, parts, body, upstream_headers, upstream_path,
route, route_id, source_ip, pool_key, route, route_id, source_ip, pool_key, domain,
).await; ).await;
} }
@@ -809,7 +825,7 @@ impl HttpProxyService {
) = match hyper::client::conn::http1::handshake(io).await { ) = match hyper::client::conn::http1::handshake(io).await {
Ok(h) => h, Ok(h) => h,
Err(e) => { Err(e) => {
error!(backend = %backend_key, error = %e, "Backend H1 handshake failed"); error!(backend = %backend_key, domain = %domain, error = %e, "Backend H1 handshake failed");
self.metrics.backend_handshake_error(&backend_key); self.metrics.backend_handshake_error(&backend_key);
return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend handshake failed")); return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend handshake failed"));
} }
@@ -821,7 +837,7 @@ impl HttpProxyService {
} }
}); });
self.forward_h1_with_sender(sender, parts, body, upstream_headers, upstream_path, route, route_id, source_ip, pool_key).await self.forward_h1_with_sender(sender, parts, body, upstream_headers, upstream_path, route, route_id, source_ip, pool_key, domain).await
} }
/// Common H1 forwarding logic used by both fresh and pooled paths. /// Common H1 forwarding logic used by both fresh and pooled paths.
@@ -836,6 +852,7 @@ impl HttpProxyService {
route_id: Option<&str>, route_id: Option<&str>,
source_ip: &str, source_ip: &str,
pool_key: &crate::connection_pool::PoolKey, pool_key: &crate::connection_pool::PoolKey,
domain: &str,
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> { ) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
// Always use HTTP/1.1 for h1 backend connections (h2 incoming requests have version HTTP/2.0) // Always use HTTP/1.1 for h1 backend connections (h2 incoming requests have version HTTP/2.0)
let mut upstream_req = Request::builder() let mut upstream_req = Request::builder()
@@ -863,7 +880,7 @@ impl HttpProxyService {
Ok(resp) => resp, Ok(resp) => resp,
Err(e) => { Err(e) => {
let bk = format!("{}:{}", pool_key.host, pool_key.port); let bk = format!("{}:{}", pool_key.host, pool_key.port);
error!(backend = %bk, error = %e, "Backend H1 request failed"); error!(backend = %bk, domain = %domain, error = %e, "Backend H1 request failed");
self.metrics.backend_request_error(&bk); self.metrics.backend_request_error(&bk);
return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend request failed")); return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend request failed"));
} }
@@ -889,20 +906,32 @@ impl HttpProxyService {
route_id: Option<&str>, route_id: Option<&str>,
source_ip: &str, source_ip: &str,
pool_key: &crate::connection_pool::PoolKey, pool_key: &crate::connection_pool::PoolKey,
domain: &str,
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> { ) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
let backend_key = format!("{}:{}", pool_key.host, pool_key.port); let backend_key = format!("{}:{}", pool_key.host, pool_key.port);
let exec = hyper_util::rt::TokioExecutor::new(); let exec = hyper_util::rt::TokioExecutor::new();
// Explicitly type the handshake with BoxBody for uniform pool type let mut h2_builder = hyper::client::conn::http2::Builder::new(exec);
h2_builder
.timer(hyper_util::rt::TokioTimer::new())
.keep_alive_interval(std::time::Duration::from_secs(10))
.keep_alive_timeout(std::time::Duration::from_secs(5))
.adaptive_window(true)
.initial_stream_window_size(2 * 1024 * 1024);
let (sender, conn): ( let (sender, conn): (
hyper::client::conn::http2::SendRequest<BoxBody<Bytes, hyper::Error>>, hyper::client::conn::http2::SendRequest<BoxBody<Bytes, hyper::Error>>,
hyper::client::conn::http2::Connection<TokioIo<BackendStream>, BoxBody<Bytes, hyper::Error>, hyper_util::rt::TokioExecutor>, hyper::client::conn::http2::Connection<TokioIo<BackendStream>, BoxBody<Bytes, hyper::Error>, hyper_util::rt::TokioExecutor>,
) = match hyper::client::conn::http2::handshake(exec, io).await { ) = match tokio::time::timeout(self.connect_timeout, h2_builder.handshake(io)).await {
Ok(h) => h, Ok(Ok(h)) => h,
Err(e) => { Ok(Err(e)) => {
error!(backend = %backend_key, error = %e, "Backend H2 handshake failed"); error!(backend = %backend_key, domain = %domain, error = %e, "Backend H2 handshake failed");
self.metrics.backend_handshake_error(&backend_key); self.metrics.backend_handshake_error(&backend_key);
return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend H2 handshake failed")); return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend H2 handshake failed"));
} }
Err(_) => {
error!(backend = %backend_key, domain = %domain, "Backend H2 handshake timeout");
self.metrics.backend_handshake_error(&backend_key);
return Ok(error_response(StatusCode::GATEWAY_TIMEOUT, "Backend H2 handshake timeout"));
}
}; };
tokio::spawn(async move { tokio::spawn(async move {
@@ -911,10 +940,13 @@ impl HttpProxyService {
} }
}); });
// Register for multiplexed reuse // Clone sender for potential pool registration; register only after first request succeeds
self.connection_pool.register_h2(pool_key.clone(), sender.clone()); let sender_for_pool = sender.clone();
let result = self.forward_h2_with_sender(sender, parts, body, upstream_headers, upstream_path, route, route_id, source_ip, Some(pool_key), domain).await;
self.forward_h2_with_sender(sender, parts, body, upstream_headers, upstream_path, route, route_id, source_ip, Some(pool_key)).await if matches!(&result, Ok(ref resp) if resp.status() != StatusCode::BAD_GATEWAY) {
self.connection_pool.register_h2(pool_key.clone(), sender_for_pool);
}
result
} }
/// Forward request using an existing (pooled) HTTP/2 sender. /// Forward request using an existing (pooled) HTTP/2 sender.
@@ -931,6 +963,7 @@ impl HttpProxyService {
route_id: Option<&str>, route_id: Option<&str>,
source_ip: &str, source_ip: &str,
pool_key: &crate::connection_pool::PoolKey, pool_key: &crate::connection_pool::PoolKey,
domain: &str,
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> { ) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
// Save retry state for bodyless requests (cheap: Method is an enum, HeaderMap clones Arc-backed Bytes) // Save retry state for bodyless requests (cheap: Method is an enum, HeaderMap clones Arc-backed Bytes)
let retry_state = if body.is_end_stream() { let retry_state = if body.is_end_stream() {
@@ -941,18 +974,18 @@ impl HttpProxyService {
let result = self.forward_h2_with_sender( let result = self.forward_h2_with_sender(
sender, parts, body, upstream_headers, upstream_path, sender, parts, body, upstream_headers, upstream_path,
route, route_id, source_ip, Some(pool_key), route, route_id, source_ip, Some(pool_key), domain,
).await; ).await;
// If the request failed (502) and we can retry with an empty body, do so // If the request failed (502) and we can retry with an empty body, do so
let is_502 = matches!(&result, Ok(resp) if resp.status() == StatusCode::BAD_GATEWAY); let is_502 = matches!(&result, Ok(resp) if resp.status() == StatusCode::BAD_GATEWAY);
if is_502 { if is_502 {
if let Some((method, headers)) = retry_state { if let Some((method, headers)) = retry_state {
warn!("Stale pooled H2 sender for {}:{}, retrying with fresh connection", warn!(backend = %format!("{}:{}", pool_key.host, pool_key.port), domain = %domain,
pool_key.host, pool_key.port); "Stale pooled H2 sender, retrying with fresh connection");
return self.retry_h2_with_fresh_connection( return self.retry_h2_with_fresh_connection(
method, headers, upstream_path, method, headers, upstream_path,
pool_key, route, route_id, source_ip, pool_key, route, route_id, source_ip, domain,
).await; ).await;
} }
} }
@@ -970,6 +1003,7 @@ impl HttpProxyService {
route: &rustproxy_config::RouteConfig, route: &rustproxy_config::RouteConfig,
route_id: Option<&str>, route_id: Option<&str>,
source_ip: &str, source_ip: &str,
domain: &str,
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> { ) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
let backend_key = format!("{}:{}", pool_key.host, pool_key.port); let backend_key = format!("{}:{}", pool_key.host, pool_key.port);
@@ -978,16 +1012,16 @@ impl HttpProxyService {
let backend = if pool_key.use_tls { let backend = if pool_key.use_tls {
match tokio::time::timeout( match tokio::time::timeout(
self.connect_timeout, self.connect_timeout,
connect_tls_backend(&self.backend_tls_config, &pool_key.host, pool_key.port), connect_tls_backend(&self.backend_tls_config_alpn, &pool_key.host, pool_key.port),
).await { ).await {
Ok(Ok(tls)) => BackendStream::Tls(tls), Ok(Ok(tls)) => BackendStream::Tls(tls),
Ok(Err(e)) => { Ok(Err(e)) => {
error!(backend = %backend_key, error = %e, "H2 retry: TLS connect failed"); error!(backend = %backend_key, domain = %domain, error = %e, "H2 retry: TLS connect failed");
self.metrics.backend_connect_error(&backend_key); self.metrics.backend_connect_error(&backend_key);
return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend unavailable on H2 retry")); return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend unavailable on H2 retry"));
} }
Err(_) => { Err(_) => {
error!(backend = %backend_key, "H2 retry: TLS connect timeout"); error!(backend = %backend_key, domain = %domain, "H2 retry: TLS connect timeout");
self.metrics.backend_connect_error(&backend_key); self.metrics.backend_connect_error(&backend_key);
return Ok(error_response(StatusCode::GATEWAY_TIMEOUT, "Backend timeout on H2 retry")); return Ok(error_response(StatusCode::GATEWAY_TIMEOUT, "Backend timeout on H2 retry"));
} }
@@ -1002,12 +1036,12 @@ impl HttpProxyService {
BackendStream::Plain(s) BackendStream::Plain(s)
} }
Ok(Err(e)) => { Ok(Err(e)) => {
error!(backend = %backend_key, error = %e, "H2 retry: TCP connect failed"); error!(backend = %backend_key, domain = %domain, error = %e, "H2 retry: TCP connect failed");
self.metrics.backend_connect_error(&backend_key); self.metrics.backend_connect_error(&backend_key);
return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend unavailable on H2 retry")); return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend unavailable on H2 retry"));
} }
Err(_) => { Err(_) => {
error!(backend = %backend_key, "H2 retry: TCP connect timeout"); error!(backend = %backend_key, domain = %domain, "H2 retry: TCP connect timeout");
self.metrics.backend_connect_error(&backend_key); self.metrics.backend_connect_error(&backend_key);
return Ok(error_response(StatusCode::GATEWAY_TIMEOUT, "Backend timeout on H2 retry")); return Ok(error_response(StatusCode::GATEWAY_TIMEOUT, "Backend timeout on H2 retry"));
} }
@@ -1017,16 +1051,30 @@ impl HttpProxyService {
let io = TokioIo::new(backend); let io = TokioIo::new(backend);
let exec = hyper_util::rt::TokioExecutor::new(); let exec = hyper_util::rt::TokioExecutor::new();
let mut h2_builder = hyper::client::conn::http2::Builder::new(exec);
h2_builder
.timer(hyper_util::rt::TokioTimer::new())
.keep_alive_interval(std::time::Duration::from_secs(10))
.keep_alive_timeout(std::time::Duration::from_secs(5))
.adaptive_window(true)
.initial_stream_window_size(2 * 1024 * 1024);
let (mut sender, conn): ( let (mut sender, conn): (
hyper::client::conn::http2::SendRequest<BoxBody<Bytes, hyper::Error>>, hyper::client::conn::http2::SendRequest<BoxBody<Bytes, hyper::Error>>,
hyper::client::conn::http2::Connection<TokioIo<BackendStream>, BoxBody<Bytes, hyper::Error>, hyper_util::rt::TokioExecutor>, hyper::client::conn::http2::Connection<TokioIo<BackendStream>, BoxBody<Bytes, hyper::Error>, hyper_util::rt::TokioExecutor>,
) = match hyper::client::conn::http2::handshake(exec, io).await { ) = match tokio::time::timeout(self.connect_timeout, h2_builder.handshake(io)).await {
Ok(h) => h, Ok(Ok(h)) => h,
Err(e) => { Ok(Err(e)) => {
error!(backend = %backend_key, error = %e, "H2 retry: handshake failed"); error!(backend = %backend_key, domain = %domain, error = %e, "H2 retry: handshake failed");
self.metrics.backend_handshake_error(&backend_key); self.metrics.backend_handshake_error(&backend_key);
self.metrics.backend_connection_closed(&backend_key);
return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend H2 retry handshake failed")); return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend H2 retry handshake failed"));
} }
Err(_) => {
error!(backend = %backend_key, domain = %domain, "H2 retry: handshake timeout");
self.metrics.backend_handshake_error(&backend_key);
self.metrics.backend_connection_closed(&backend_key);
return Ok(error_response(StatusCode::GATEWAY_TIMEOUT, "Backend H2 retry handshake timeout"));
}
}; };
tokio::spawn(async move { tokio::spawn(async move {
@@ -1035,13 +1083,17 @@ impl HttpProxyService {
} }
}); });
// Register fresh sender in pool for future requests // Build request with empty body using absolute URI for H2 pseudo-headers
self.connection_pool.register_h2(pool_key.clone(), sender.clone()); let scheme = if pool_key.use_tls { "https" } else { "http" };
let authority = if domain != "-" { domain } else { pool_key.host.as_str() };
// Build request with empty body let h2_uri = format!("{}://{}{}", scheme, authority, upstream_path);
let mut upstream_req = Request::builder() let mut upstream_req = Request::builder()
.method(method) .method(method)
.uri(upstream_path); .uri(&h2_uri);
// Remove Host header for H2 — :authority pseudo-header (from URI) is sufficient
let mut upstream_headers = upstream_headers;
upstream_headers.remove("host");
if let Some(headers) = upstream_req.headers_mut() { if let Some(headers) = upstream_req.headers_mut() {
*headers = upstream_headers; *headers = upstream_headers;
@@ -1054,16 +1106,17 @@ impl HttpProxyService {
match sender.send_request(upstream_req).await { match sender.send_request(upstream_req).await {
Ok(resp) => { Ok(resp) => {
// Register in pool only after request succeeds
self.connection_pool.register_h2(pool_key.clone(), sender);
let result = self.build_streaming_response(resp, route, route_id, source_ip).await; let result = self.build_streaming_response(resp, route, route_id, source_ip).await;
// Close the fresh backend connection (opened at line 1016 above) // Close the fresh backend connection (opened above)
self.metrics.backend_connection_closed(&backend_key); self.metrics.backend_connection_closed(&backend_key);
result result
} }
Err(e) => { Err(e) => {
error!(backend = %backend_key, error = %e, "H2 retry: request failed"); error!(backend = %backend_key, domain = %domain, error = %e, "H2 retry: request failed");
self.metrics.backend_request_error(&backend_key); self.metrics.backend_request_error(&backend_key);
self.connection_pool.remove_h2(pool_key); // Close the fresh backend connection (opened above)
// Close the fresh backend connection (opened at line 1016 above)
self.metrics.backend_connection_closed(&backend_key); self.metrics.backend_connection_closed(&backend_key);
Ok(error_response(StatusCode::BAD_GATEWAY, "Backend H2 request failed on retry")) Ok(error_response(StatusCode::BAD_GATEWAY, "Backend H2 request failed on retry"))
} }
@@ -1082,7 +1135,7 @@ impl HttpProxyService {
io: TokioIo<BackendStream>, io: TokioIo<BackendStream>,
parts: hyper::http::request::Parts, parts: hyper::http::request::Parts,
body: Incoming, body: Incoming,
upstream_headers: hyper::HeaderMap, mut upstream_headers: hyper::HeaderMap,
upstream_path: &str, upstream_path: &str,
upstream: &crate::upstream_selector::UpstreamSelection, upstream: &crate::upstream_selector::UpstreamSelection,
route: &rustproxy_config::RouteConfig, route: &rustproxy_config::RouteConfig,
@@ -1090,15 +1143,62 @@ impl HttpProxyService {
source_ip: &str, source_ip: &str,
pool_key: &crate::connection_pool::PoolKey, pool_key: &crate::connection_pool::PoolKey,
requested_host: Option<String>, requested_host: Option<String>,
domain: &str,
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> { ) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
let exec = hyper_util::rt::TokioExecutor::new(); let exec = hyper_util::rt::TokioExecutor::new();
let handshake_result: Result<( let mut h2_builder = hyper::client::conn::http2::Builder::new(exec);
hyper::client::conn::http2::SendRequest<BoxBody<Bytes, hyper::Error>>, h2_builder
hyper::client::conn::http2::Connection<TokioIo<BackendStream>, BoxBody<Bytes, hyper::Error>, hyper_util::rt::TokioExecutor>, .timer(hyper_util::rt::TokioTimer::new())
), hyper::Error> = hyper::client::conn::http2::handshake(exec, io).await; .keep_alive_interval(std::time::Duration::from_secs(10))
.keep_alive_timeout(std::time::Duration::from_secs(5))
.adaptive_window(true)
.initial_stream_window_size(2 * 1024 * 1024);
let handshake_result = tokio::time::timeout(
self.connect_timeout,
h2_builder.handshake(io),
).await;
match handshake_result { match handshake_result {
Ok((mut sender, conn)) => { Err(_) => {
// H2 handshake timed out — fall back to H1
let bk = format!("{}:{}", upstream.host, upstream.port);
warn!(
backend = %bk,
domain = %domain,
"H2 handshake timeout, falling back to H1"
);
self.metrics.backend_h2_failure(&bk);
self.metrics.backend_handshake_error(&bk);
let cache_key = crate::protocol_cache::ProtocolCacheKey {
host: upstream.host.clone(),
port: upstream.port,
requested_host: requested_host.clone(),
};
self.protocol_cache.insert(cache_key, crate::protocol_cache::DetectedProtocol::H1);
match self.reconnect_backend(upstream, domain).await {
Some(fallback_backend) => {
let h1_pool_key = crate::connection_pool::PoolKey {
host: upstream.host.clone(),
port: upstream.port,
use_tls: upstream.use_tls,
h2: false,
};
let fallback_io = TokioIo::new(fallback_backend);
let result = self.forward_h1(
fallback_io, parts, body, upstream_headers, upstream_path,
upstream, route, route_id, source_ip, &h1_pool_key, domain,
).await;
self.metrics.backend_connection_closed(&bk);
result
}
None => {
Ok(error_response(StatusCode::BAD_GATEWAY, "Backend unavailable after H2 timeout fallback"))
}
}
}
Ok(Ok((mut sender, conn))) => {
tokio::spawn(async move { tokio::spawn(async move {
if let Err(e) = conn.await { if let Err(e) = conn.await {
debug!("HTTP/2 upstream connection error: {}", e); debug!("HTTP/2 upstream connection error: {}", e);
@@ -1106,18 +1206,25 @@ impl HttpProxyService {
}); });
// Save retry state before consuming parts/body (for bodyless requests like GET) // Save retry state before consuming parts/body (for bodyless requests like GET)
// Clone BEFORE removing Host — H1 fallback needs Host header
let retry_state = if body.is_end_stream() { let retry_state = if body.is_end_stream() {
Some((parts.method.clone(), upstream_headers.clone())) Some((parts.method.clone(), upstream_headers.clone()))
} else { } else {
None None
}; };
// Remove Host header for H2 — :authority pseudo-header (from URI) is sufficient
upstream_headers.remove("host");
// Build and send the h2 request inline (don't register in pool yet — // Build and send the h2 request inline (don't register in pool yet —
// we need to verify the request actually succeeds first, because some // we need to verify the request actually succeeds first, because some
// backends advertise h2 via ALPN but don't speak the h2 binary protocol). // backends advertise h2 via ALPN but don't speak the h2 binary protocol).
let scheme = if upstream.use_tls { "https" } else { "http" };
let authority = if domain != "-" { domain } else { upstream.host.as_str() };
let h2_uri = format!("{}://{}{}", scheme, authority, upstream_path);
let mut upstream_req = Request::builder() let mut upstream_req = Request::builder()
.method(parts.method) .method(parts.method)
.uri(upstream_path); .uri(&h2_uri);
if let Some(headers) = upstream_req.headers_mut() { if let Some(headers) = upstream_req.headers_mut() {
*headers = upstream_headers; *headers = upstream_headers;
@@ -1145,6 +1252,7 @@ impl HttpProxyService {
let bk = format!("{}:{}", upstream.host, upstream.port); let bk = format!("{}:{}", upstream.host, upstream.port);
warn!( warn!(
backend = %bk, backend = %bk,
domain = %domain,
error = %e, error = %e,
"Auto-detect: H2 request failed, falling back to H1" "Auto-detect: H2 request failed, falling back to H1"
); );
@@ -1158,7 +1266,7 @@ impl HttpProxyService {
// Retry as H1 for bodyless requests; return 502 for requests with bodies // Retry as H1 for bodyless requests; return 502 for requests with bodies
if let Some((method, headers)) = retry_state { if let Some((method, headers)) = retry_state {
match self.reconnect_backend(upstream).await { match self.reconnect_backend(upstream, domain).await {
Some(fallback_backend) => { Some(fallback_backend) => {
let h1_pool_key = crate::connection_pool::PoolKey { let h1_pool_key = crate::connection_pool::PoolKey {
host: upstream.host.clone(), host: upstream.host.clone(),
@@ -1169,7 +1277,7 @@ impl HttpProxyService {
let fallback_io = TokioIo::new(fallback_backend); let fallback_io = TokioIo::new(fallback_backend);
let result = self.forward_h1_empty_body( let result = self.forward_h1_empty_body(
fallback_io, method, headers, upstream_path, fallback_io, method, headers, upstream_path,
route, route_id, source_ip, &h1_pool_key, route, route_id, source_ip, &h1_pool_key, domain,
).await; ).await;
// Close the reconnected backend connection (opened in reconnect_backend) // Close the reconnected backend connection (opened in reconnect_backend)
self.metrics.backend_connection_closed(&bk); self.metrics.backend_connection_closed(&bk);
@@ -1185,12 +1293,13 @@ impl HttpProxyService {
} }
} }
} }
Err(e) => { Ok(Err(e)) => {
// H2 handshake truly failed — fall back to H1 // H2 handshake truly failed — fall back to H1
// Body is NOT consumed yet, so we can retry the full request. // Body is NOT consumed yet, so we can retry the full request.
let bk = format!("{}:{}", upstream.host, upstream.port); let bk = format!("{}:{}", upstream.host, upstream.port);
warn!( warn!(
backend = %bk, backend = %bk,
domain = %domain,
error = %e, error = %e,
"H2 handshake failed, falling back to H1" "H2 handshake failed, falling back to H1"
); );
@@ -1206,7 +1315,7 @@ impl HttpProxyService {
self.protocol_cache.insert(cache_key, crate::protocol_cache::DetectedProtocol::H1); self.protocol_cache.insert(cache_key, crate::protocol_cache::DetectedProtocol::H1);
// Reconnect for H1 (the original io was consumed by the failed h2 handshake) // Reconnect for H1 (the original io was consumed by the failed h2 handshake)
match self.reconnect_backend(upstream).await { match self.reconnect_backend(upstream, domain).await {
Some(fallback_backend) => { Some(fallback_backend) => {
let h1_pool_key = crate::connection_pool::PoolKey { let h1_pool_key = crate::connection_pool::PoolKey {
host: upstream.host.clone(), host: upstream.host.clone(),
@@ -1217,7 +1326,7 @@ impl HttpProxyService {
let fallback_io = TokioIo::new(fallback_backend); let fallback_io = TokioIo::new(fallback_backend);
let result = self.forward_h1( let result = self.forward_h1(
fallback_io, parts, body, upstream_headers, upstream_path, fallback_io, parts, body, upstream_headers, upstream_path,
upstream, route, route_id, source_ip, &h1_pool_key, upstream, route, route_id, source_ip, &h1_pool_key, domain,
).await; ).await;
// Close the reconnected backend connection (opened in reconnect_backend) // Close the reconnected backend connection (opened in reconnect_backend)
self.metrics.backend_connection_closed(&bk); self.metrics.backend_connection_closed(&bk);
@@ -1243,6 +1352,7 @@ impl HttpProxyService {
route_id: Option<&str>, route_id: Option<&str>,
source_ip: &str, source_ip: &str,
pool_key: &crate::connection_pool::PoolKey, pool_key: &crate::connection_pool::PoolKey,
domain: &str,
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> { ) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
let backend_key = format!("{}:{}", pool_key.host, pool_key.port); let backend_key = format!("{}:{}", pool_key.host, pool_key.port);
let (mut sender, conn): ( let (mut sender, conn): (
@@ -1251,7 +1361,7 @@ impl HttpProxyService {
) = match hyper::client::conn::http1::handshake(io).await { ) = match hyper::client::conn::http1::handshake(io).await {
Ok(h) => h, Ok(h) => h,
Err(e) => { Err(e) => {
error!(backend = %backend_key, error = %e, "H1 fallback: handshake failed"); error!(backend = %backend_key, domain = %domain, error = %e, "H1 fallback: handshake failed");
self.metrics.backend_handshake_error(&backend_key); self.metrics.backend_handshake_error(&backend_key);
return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend H1 fallback handshake failed")); return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend H1 fallback handshake failed"));
} }
@@ -1280,7 +1390,7 @@ impl HttpProxyService {
let upstream_response = match sender.send_request(upstream_req).await { let upstream_response = match sender.send_request(upstream_req).await {
Ok(resp) => resp, Ok(resp) => resp,
Err(e) => { Err(e) => {
error!(backend = %backend_key, error = %e, "H1 fallback: request failed"); error!(backend = %backend_key, domain = %domain, error = %e, "H1 fallback: request failed");
self.metrics.backend_request_error(&backend_key); self.metrics.backend_request_error(&backend_key);
return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend H1 fallback request failed")); return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend H1 fallback request failed"));
} }
@@ -1296,6 +1406,7 @@ impl HttpProxyService {
async fn reconnect_backend( async fn reconnect_backend(
&self, &self,
upstream: &crate::upstream_selector::UpstreamSelection, upstream: &crate::upstream_selector::UpstreamSelection,
domain: &str,
) -> Option<BackendStream> { ) -> Option<BackendStream> {
let backend_key = format!("{}:{}", upstream.host, upstream.port); let backend_key = format!("{}:{}", upstream.host, upstream.port);
let reconnect_start = std::time::Instant::now(); let reconnect_start = std::time::Instant::now();
@@ -1309,12 +1420,12 @@ impl HttpProxyService {
Some(BackendStream::Tls(tls)) Some(BackendStream::Tls(tls))
} }
Ok(Err(e)) => { Ok(Err(e)) => {
error!(backend = %backend_key, error = %e, "H1 fallback: TLS reconnect failed"); error!(backend = %backend_key, domain = %domain, error = %e, "H1 fallback: TLS reconnect failed");
self.metrics.backend_connect_error(&backend_key); self.metrics.backend_connect_error(&backend_key);
None None
} }
Err(_) => { Err(_) => {
error!(backend = %backend_key, "H1 fallback: TLS reconnect timeout"); error!(backend = %backend_key, domain = %domain, "H1 fallback: TLS reconnect timeout");
self.metrics.backend_connect_error(&backend_key); self.metrics.backend_connect_error(&backend_key);
None None
} }
@@ -1333,12 +1444,12 @@ impl HttpProxyService {
Some(BackendStream::Plain(s)) Some(BackendStream::Plain(s))
} }
Ok(Err(e)) => { Ok(Err(e)) => {
error!(backend = %backend_key, error = %e, "H1 fallback: TCP reconnect failed"); error!(backend = %backend_key, domain = %domain, error = %e, "H1 fallback: TCP reconnect failed");
self.metrics.backend_connect_error(&backend_key); self.metrics.backend_connect_error(&backend_key);
None None
} }
Err(_) => { Err(_) => {
error!(backend = %backend_key, "H1 fallback: TCP reconnect timeout"); error!(backend = %backend_key, domain = %domain, "H1 fallback: TCP reconnect timeout");
self.metrics.backend_connect_error(&backend_key); self.metrics.backend_connect_error(&backend_key);
None None
} }
@@ -1358,10 +1469,23 @@ impl HttpProxyService {
route_id: Option<&str>, route_id: Option<&str>,
source_ip: &str, source_ip: &str,
pool_key: Option<&crate::connection_pool::PoolKey>, pool_key: Option<&crate::connection_pool::PoolKey>,
domain: &str,
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> { ) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
// Build absolute URI for H2 pseudo-headers (:scheme, :authority)
// Use the requested domain as authority (not backend address) so :authority matches Host header
let scheme = if pool_key.map(|pk| pk.use_tls).unwrap_or(false) { "https" } else { "http" };
let authority = if domain != "-" { domain } else {
pool_key.map(|pk| pk.host.as_str()).unwrap_or("localhost")
};
let h2_uri = format!("{}://{}{}", scheme, authority, upstream_path);
let mut upstream_req = Request::builder() let mut upstream_req = Request::builder()
.method(parts.method) .method(parts.method)
.uri(upstream_path); .uri(&h2_uri);
// Remove Host header for H2 — :authority pseudo-header (from URI) is sufficient
// Having both Host and :authority causes nginx to return 400
let mut upstream_headers = upstream_headers;
upstream_headers.remove("host");
if let Some(headers) = upstream_req.headers_mut() { if let Some(headers) = upstream_req.headers_mut() {
*headers = upstream_headers; *headers = upstream_headers;
@@ -1385,11 +1509,11 @@ impl HttpProxyService {
// Evict the dead sender so subsequent requests get fresh connections // Evict the dead sender so subsequent requests get fresh connections
if let Some(key) = pool_key { if let Some(key) = pool_key {
let bk = format!("{}:{}", key.host, key.port); let bk = format!("{}:{}", key.host, key.port);
error!(backend = %bk, error = %e, "Backend H2 request failed"); error!(backend = %bk, domain = %domain, error = %e, "Backend H2 request failed");
self.metrics.backend_request_error(&bk); self.metrics.backend_request_error(&bk);
self.connection_pool.remove_h2(key); self.connection_pool.remove_h2(key);
} else { } else {
error!(error = %e, "Backend H2 request failed"); error!(domain = %domain, error = %e, "Backend H2 request failed");
} }
return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend H2 request failed")); return Ok(error_response(StatusCode::BAD_GATEWAY, "Backend H2 request failed"));
} }

View File

@@ -3,6 +3,6 @@
*/ */
export const commitinfo = { export const commitinfo = {
name: '@push.rocks/smartproxy', name: '@push.rocks/smartproxy',
version: '25.10.2', version: '25.10.7',
description: 'A powerful proxy package with unified route-based configuration for high traffic management. Features include SSL/TLS support, flexible routing patterns, WebSocket handling, advanced security options, and automatic ACME certificate management.' description: 'A powerful proxy package with unified route-based configuration for high traffic management. Features include SSL/TLS support, flexible routing patterns, WebSocket handling, advanced security options, and automatic ACME certificate management.'
} }