Compare commits
12 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 0930f7e10c | |||
| aa9e6dfd94 | |||
| 211d5cf835 | |||
| 2ce1899337 | |||
| 2e2ffc4485 | |||
| da26816af5 | |||
| d598bffec3 | |||
| a9dbccfaff | |||
| 386859a2bd | |||
| 2b58615d24 | |||
| 95adf56e52 | |||
| c96a493fb6 |
38
changelog.md
38
changelog.md
@@ -1,5 +1,43 @@
|
|||||||
# Changelog
|
# Changelog
|
||||||
|
|
||||||
|
## 2026-03-15 - 25.11.4 - fix(rustproxy-http)
|
||||||
|
report streamed HTTP and WebSocket bytes per chunk for real-time throughput metrics
|
||||||
|
|
||||||
|
- Update CountingBody to record bytes immediately on each data frame instead of aggregating until completion or drop
|
||||||
|
- Record WebSocket tunnel traffic inside both copy loops and remove the final aggregate byte report to keep throughput metrics current
|
||||||
|
|
||||||
|
## 2026-03-15 - 25.11.3 - fix(repo)
|
||||||
|
no changes to commit
|
||||||
|
|
||||||
|
|
||||||
|
## 2026-03-15 - 25.11.2 - fix(rustproxy-http)
|
||||||
|
avoid reusing HTTP/1 senders during streaming responses and relax HTTP/2 keep-alive timeouts
|
||||||
|
|
||||||
|
- Stop returning HTTP/1 senders to the connection pool before upstream response bodies finish streaming to prevent unsafe reuse on active connections.
|
||||||
|
- Increase HTTP/2 keep-alive timeout from 5 seconds to 30 seconds in proxy connection builders to better support longer-lived backend streams.
|
||||||
|
- Improves reliability for large streaming payloads and backend fallback request handling.
|
||||||
|
|
||||||
|
## 2026-03-15 - 25.11.1 - fix(rustproxy-http)
|
||||||
|
keep connection idle tracking alive during streaming and tune HTTP/2 connection lifetimes
|
||||||
|
|
||||||
|
- Propagate connection activity tracking through HTTP/1, HTTP/2, and WebSocket forwarding so active request and response body streams do not trigger the idle watchdog.
|
||||||
|
- Update CountingBody to refresh connection activity timestamps while data frames are polled during uploads and downloads.
|
||||||
|
- Increase pooled HTTP/2 max age and set explicit HTTP/2 connection window sizes to improve long-lived streaming behavior.
|
||||||
|
|
||||||
|
## 2026-03-15 - 25.11.0 - feat(rustproxy-http)
|
||||||
|
add HTTP/2 Extended CONNECT WebSocket proxy support
|
||||||
|
|
||||||
|
- Enable HTTP/2 CONNECT protocol support on the Hyper auto connection builder
|
||||||
|
- Detect WebSocket requests for both HTTP/1 Upgrade and HTTP/2 Extended CONNECT flows
|
||||||
|
- Translate HTTP/2 WebSocket requests to an HTTP/1.1 backend handshake and return RFC-compliant client responses
|
||||||
|
|
||||||
|
## 2026-03-12 - 25.10.7 - fix(rustproxy-http)
|
||||||
|
remove Host header from HTTP/2 upstream requests while preserving it for HTTP/1 retries
|
||||||
|
|
||||||
|
- strips the Host header before sending HTTP/2 upstream requests so :authority from the URI is used instead
|
||||||
|
- avoids 400 responses from nginx caused by sending both Host and :authority headers
|
||||||
|
- keeps a cloned header set for bodyless request retries so HTTP/1 fallback still retains the Host header
|
||||||
|
|
||||||
## 2026-03-12 - 25.10.6 - fix(rustproxy-http)
|
## 2026-03-12 - 25.10.6 - fix(rustproxy-http)
|
||||||
use the requested domain as HTTP/2 authority instead of the backend host and port
|
use the requested domain as HTTP/2 authority instead of the backend host and port
|
||||||
|
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "@push.rocks/smartproxy",
|
"name": "@push.rocks/smartproxy",
|
||||||
"version": "25.10.6",
|
"version": "25.11.4",
|
||||||
"private": false,
|
"private": false,
|
||||||
"description": "A powerful proxy package with unified route-based configuration for high traffic management. Features include SSL/TLS support, flexible routing patterns, WebSocket handling, advanced security options, and automatic ACME certificate management.",
|
"description": "A powerful proxy package with unified route-based configuration for high traffic management. Features include SSL/TLS support, flexible routing patterns, WebSocket handling, advanced security options, and automatic ACME certificate management.",
|
||||||
"main": "dist_ts/index.js",
|
"main": "dist_ts/index.js",
|
||||||
|
|||||||
@@ -20,7 +20,7 @@ const IDLE_TIMEOUT: Duration = Duration::from_secs(90);
|
|||||||
const EVICTION_INTERVAL: Duration = Duration::from_secs(30);
|
const EVICTION_INTERVAL: Duration = Duration::from_secs(30);
|
||||||
/// Maximum age for pooled HTTP/2 connections before proactive eviction.
|
/// Maximum age for pooled HTTP/2 connections before proactive eviction.
|
||||||
/// Prevents staleness from backends that close idle connections (e.g. nginx GOAWAY).
|
/// Prevents staleness from backends that close idle connections (e.g. nginx GOAWAY).
|
||||||
const MAX_H2_AGE: Duration = Duration::from_secs(120);
|
const MAX_H2_AGE: Duration = Duration::from_secs(300);
|
||||||
|
|
||||||
/// Identifies a unique backend endpoint.
|
/// Identifies a unique backend endpoint.
|
||||||
#[derive(Clone, Debug, Hash, Eq, PartialEq)]
|
#[derive(Clone, Debug, Hash, Eq, PartialEq)]
|
||||||
|
|||||||
@@ -11,20 +11,22 @@ use rustproxy_metrics::MetricsCollector;
|
|||||||
|
|
||||||
/// Wraps any `http_body::Body` and counts data bytes passing through.
|
/// Wraps any `http_body::Body` and counts data bytes passing through.
|
||||||
///
|
///
|
||||||
/// When the body is fully consumed or dropped, accumulated byte counts
|
/// Each chunk is reported to the `MetricsCollector` immediately so that
|
||||||
/// are reported to the `MetricsCollector`.
|
/// the throughput tracker (sampled at 1 Hz) reflects real-time data flow.
|
||||||
///
|
///
|
||||||
/// The inner body is pinned on the heap to support `!Unpin` types like `hyper::body::Incoming`.
|
/// The inner body is pinned on the heap to support `!Unpin` types like `hyper::body::Incoming`.
|
||||||
pub struct CountingBody<B> {
|
pub struct CountingBody<B> {
|
||||||
inner: Pin<Box<B>>,
|
inner: Pin<Box<B>>,
|
||||||
counted_bytes: AtomicU64,
|
|
||||||
metrics: Arc<MetricsCollector>,
|
metrics: Arc<MetricsCollector>,
|
||||||
route_id: Option<String>,
|
route_id: Option<String>,
|
||||||
source_ip: Option<String>,
|
source_ip: Option<String>,
|
||||||
/// Whether we count bytes as "in" (request body) or "out" (response body).
|
/// Whether we count bytes as "in" (request body) or "out" (response body).
|
||||||
direction: Direction,
|
direction: Direction,
|
||||||
/// Whether we've already reported the bytes (to avoid double-reporting on drop).
|
/// Optional connection-level activity tracker. When set, poll_frame updates this
|
||||||
reported: bool,
|
/// to keep the idle watchdog alive during active body streaming (uploads/downloads).
|
||||||
|
connection_activity: Option<Arc<AtomicU64>>,
|
||||||
|
/// Start instant for computing elapsed ms for connection_activity.
|
||||||
|
activity_start: Option<std::time::Instant>,
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Which direction the bytes flow.
|
/// Which direction the bytes flow.
|
||||||
@@ -47,42 +49,36 @@ impl<B> CountingBody<B> {
|
|||||||
) -> Self {
|
) -> Self {
|
||||||
Self {
|
Self {
|
||||||
inner: Box::pin(inner),
|
inner: Box::pin(inner),
|
||||||
counted_bytes: AtomicU64::new(0),
|
|
||||||
metrics,
|
metrics,
|
||||||
route_id,
|
route_id,
|
||||||
source_ip,
|
source_ip,
|
||||||
direction,
|
direction,
|
||||||
reported: false,
|
connection_activity: None,
|
||||||
|
activity_start: None,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Report accumulated bytes to the metrics collector.
|
/// Set the connection-level activity tracker. When set, each data frame
|
||||||
fn report(&mut self) {
|
/// updates this timestamp to prevent the idle watchdog from killing the
|
||||||
if self.reported {
|
/// connection during active body streaming.
|
||||||
return;
|
pub fn with_connection_activity(mut self, activity: Arc<AtomicU64>, start: std::time::Instant) -> Self {
|
||||||
}
|
self.connection_activity = Some(activity);
|
||||||
self.reported = true;
|
self.activity_start = Some(start);
|
||||||
|
self
|
||||||
let bytes = self.counted_bytes.load(Ordering::Relaxed);
|
}
|
||||||
if bytes == 0 {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
|
/// Report a chunk of bytes immediately to the metrics collector.
|
||||||
|
#[inline]
|
||||||
|
fn report_chunk(&self, len: u64) {
|
||||||
let route_id = self.route_id.as_deref();
|
let route_id = self.route_id.as_deref();
|
||||||
let source_ip = self.source_ip.as_deref();
|
let source_ip = self.source_ip.as_deref();
|
||||||
match self.direction {
|
match self.direction {
|
||||||
Direction::In => self.metrics.record_bytes(bytes, 0, route_id, source_ip),
|
Direction::In => self.metrics.record_bytes(len, 0, route_id, source_ip),
|
||||||
Direction::Out => self.metrics.record_bytes(0, bytes, route_id, source_ip),
|
Direction::Out => self.metrics.record_bytes(0, len, route_id, source_ip),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
impl<B> Drop for CountingBody<B> {
|
|
||||||
fn drop(&mut self) {
|
|
||||||
self.report();
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// CountingBody is Unpin because inner is Pin<Box<B>> (always Unpin).
|
// CountingBody is Unpin because inner is Pin<Box<B>> (always Unpin).
|
||||||
impl<B> Unpin for CountingBody<B> {}
|
impl<B> Unpin for CountingBody<B> {}
|
||||||
|
|
||||||
@@ -102,16 +98,18 @@ where
|
|||||||
match this.inner.as_mut().poll_frame(cx) {
|
match this.inner.as_mut().poll_frame(cx) {
|
||||||
Poll::Ready(Some(Ok(frame))) => {
|
Poll::Ready(Some(Ok(frame))) => {
|
||||||
if let Some(data) = frame.data_ref() {
|
if let Some(data) = frame.data_ref() {
|
||||||
this.counted_bytes.fetch_add(data.len() as u64, Ordering::Relaxed);
|
let len = data.len() as u64;
|
||||||
|
// Report bytes immediately so the 1 Hz throughput sampler sees them
|
||||||
|
this.report_chunk(len);
|
||||||
|
// Keep the connection-level idle watchdog alive during body streaming
|
||||||
|
if let (Some(activity), Some(start)) = (&this.connection_activity, &this.activity_start) {
|
||||||
|
activity.store(start.elapsed().as_millis() as u64, Ordering::Relaxed);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
Poll::Ready(Some(Ok(frame)))
|
Poll::Ready(Some(Ok(frame)))
|
||||||
}
|
}
|
||||||
Poll::Ready(Some(Err(e))) => Poll::Ready(Some(Err(e))),
|
Poll::Ready(Some(Err(e))) => Poll::Ready(Some(Err(e))),
|
||||||
Poll::Ready(None) => {
|
Poll::Ready(None) => Poll::Ready(None),
|
||||||
// Body is fully consumed — report now
|
|
||||||
this.report();
|
|
||||||
Poll::Ready(None)
|
|
||||||
}
|
|
||||||
Poll::Pending => Poll::Pending,
|
Poll::Pending => Poll::Pending,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -33,6 +33,14 @@ use crate::request_filter::RequestFilter;
|
|||||||
use crate::response_filter::ResponseFilter;
|
use crate::response_filter::ResponseFilter;
|
||||||
use crate::upstream_selector::UpstreamSelector;
|
use crate::upstream_selector::UpstreamSelector;
|
||||||
|
|
||||||
|
/// Per-connection context for keeping the idle watchdog alive during body streaming.
|
||||||
|
/// Passed through the forwarding chain so CountingBody can update the timestamp.
|
||||||
|
#[derive(Clone)]
|
||||||
|
struct ConnActivity {
|
||||||
|
last_activity: Arc<AtomicU64>,
|
||||||
|
start: std::time::Instant,
|
||||||
|
}
|
||||||
|
|
||||||
/// Default upstream connect timeout (30 seconds).
|
/// Default upstream connect timeout (30 seconds).
|
||||||
const DEFAULT_CONNECT_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(30);
|
const DEFAULT_CONNECT_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(30);
|
||||||
|
|
||||||
@@ -294,8 +302,9 @@ impl HttpProxyService {
|
|||||||
let cn = cancel_inner.clone();
|
let cn = cancel_inner.clone();
|
||||||
let la = Arc::clone(&la_inner);
|
let la = Arc::clone(&la_inner);
|
||||||
let st = start;
|
let st = start;
|
||||||
|
let ca = ConnActivity { last_activity: Arc::clone(&la_inner), start };
|
||||||
async move {
|
async move {
|
||||||
let result = svc.handle_request(req, peer, port, cn).await;
|
let result = svc.handle_request(req, peer, port, cn, ca).await;
|
||||||
// Mark request end — update activity timestamp before guard drops
|
// Mark request end — update activity timestamp before guard drops
|
||||||
la.store(st.elapsed().as_millis() as u64, Ordering::Relaxed);
|
la.store(st.elapsed().as_millis() as u64, Ordering::Relaxed);
|
||||||
drop(req_guard); // Explicitly drop to decrement active_requests
|
drop(req_guard); // Explicitly drop to decrement active_requests
|
||||||
@@ -304,8 +313,13 @@ impl HttpProxyService {
|
|||||||
});
|
});
|
||||||
|
|
||||||
// Auto-detect h1 vs h2 based on ALPN / connection preface.
|
// Auto-detect h1 vs h2 based on ALPN / connection preface.
|
||||||
// serve_connection_with_upgrades supports h1 Upgrade (WebSocket) and h2 CONNECT.
|
// serve_connection_with_upgrades supports h1 Upgrade (WebSocket) and h2 Extended CONNECT (RFC 8441).
|
||||||
let builder = hyper_util::server::conn::auto::Builder::new(hyper_util::rt::TokioExecutor::new());
|
let mut builder = hyper_util::server::conn::auto::Builder::new(hyper_util::rt::TokioExecutor::new());
|
||||||
|
// Configure H2 server settings: Extended CONNECT for WebSocket + flow control tuning
|
||||||
|
builder.http2()
|
||||||
|
.enable_connect_protocol()
|
||||||
|
.initial_stream_window_size(2 * 1024 * 1024) // 2MB per stream (vs default 64KB)
|
||||||
|
.initial_connection_window_size(8 * 1024 * 1024); // 8MB per client connection
|
||||||
let conn = builder.serve_connection_with_upgrades(io, service);
|
let conn = builder.serve_connection_with_upgrades(io, service);
|
||||||
// Pin on the heap — auto::UpgradeableConnection is !Unpin
|
// Pin on the heap — auto::UpgradeableConnection is !Unpin
|
||||||
let mut conn = Box::pin(conn);
|
let mut conn = Box::pin(conn);
|
||||||
@@ -365,6 +379,7 @@ impl HttpProxyService {
|
|||||||
peer_addr: std::net::SocketAddr,
|
peer_addr: std::net::SocketAddr,
|
||||||
port: u16,
|
port: u16,
|
||||||
cancel: CancellationToken,
|
cancel: CancellationToken,
|
||||||
|
conn_activity: ConnActivity,
|
||||||
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
||||||
let host = req.headers()
|
let host = req.headers()
|
||||||
.get("host")
|
.get("host")
|
||||||
@@ -482,16 +497,23 @@ impl HttpProxyService {
|
|||||||
let domain_str = host.as_deref().unwrap_or("-");
|
let domain_str = host.as_deref().unwrap_or("-");
|
||||||
self.upstream_selector.connection_started(&upstream_key);
|
self.upstream_selector.connection_started(&upstream_key);
|
||||||
|
|
||||||
// Check for WebSocket upgrade
|
// Check for WebSocket upgrade: H1 (Upgrade header) or H2 Extended CONNECT (RFC 8441)
|
||||||
let is_websocket = req.headers()
|
let is_h1_websocket = req.headers()
|
||||||
.get("upgrade")
|
.get("upgrade")
|
||||||
.and_then(|v| v.to_str().ok())
|
.and_then(|v| v.to_str().ok())
|
||||||
.map(|v| v.eq_ignore_ascii_case("websocket"))
|
.map(|v| v.eq_ignore_ascii_case("websocket"))
|
||||||
.unwrap_or(false);
|
.unwrap_or(false);
|
||||||
|
|
||||||
if is_websocket {
|
let is_h2_websocket = req.method() == hyper::Method::CONNECT
|
||||||
|
&& req.extensions()
|
||||||
|
.get::<hyper::ext::Protocol>()
|
||||||
|
.map(|p| p.as_str().eq_ignore_ascii_case("websocket"))
|
||||||
|
.unwrap_or(false);
|
||||||
|
|
||||||
|
if is_h1_websocket || is_h2_websocket {
|
||||||
let result = self.handle_websocket_upgrade(
|
let result = self.handle_websocket_upgrade(
|
||||||
req, peer_addr, &upstream, route_match.route, route_id, &upstream_key, cancel, &ip_str,
|
req, peer_addr, &upstream, route_match.route, route_id, &upstream_key, cancel, &ip_str, is_h2_websocket,
|
||||||
|
if is_h2_websocket { Some(conn_activity.clone()) } else { None },
|
||||||
).await;
|
).await;
|
||||||
// Note: for WebSocket, connection_ended is called inside
|
// Note: for WebSocket, connection_ended is called inside
|
||||||
// the spawned tunnel task when the connection closes.
|
// the spawned tunnel task when the connection closes.
|
||||||
@@ -632,7 +654,7 @@ impl HttpProxyService {
|
|||||||
self.metrics.set_backend_protocol(&upstream_key, "h2");
|
self.metrics.set_backend_protocol(&upstream_key, "h2");
|
||||||
let result = self.forward_h2_pooled(
|
let result = self.forward_h2_pooled(
|
||||||
sender, parts, body, upstream_headers, &upstream_path,
|
sender, parts, body, upstream_headers, &upstream_path,
|
||||||
route_match.route, route_id, &ip_str, &pool_key, domain_str,
|
route_match.route, route_id, &ip_str, &pool_key, domain_str, &conn_activity,
|
||||||
).await;
|
).await;
|
||||||
self.upstream_selector.connection_ended(&upstream_key);
|
self.upstream_selector.connection_ended(&upstream_key);
|
||||||
return result;
|
return result;
|
||||||
@@ -771,19 +793,19 @@ impl HttpProxyService {
|
|||||||
self.forward_h2_with_fallback(
|
self.forward_h2_with_fallback(
|
||||||
io, parts, body, upstream_headers, &upstream_path,
|
io, parts, body, upstream_headers, &upstream_path,
|
||||||
&upstream, route_match.route, route_id, &ip_str, &final_pool_key,
|
&upstream, route_match.route, route_id, &ip_str, &final_pool_key,
|
||||||
host.clone(), domain_str,
|
host.clone(), domain_str, &conn_activity,
|
||||||
).await
|
).await
|
||||||
} else {
|
} else {
|
||||||
// Explicit H2 mode: hard-fail on handshake error (preserved behavior)
|
// Explicit H2 mode: hard-fail on handshake error (preserved behavior)
|
||||||
self.forward_h2(
|
self.forward_h2(
|
||||||
io, parts, body, upstream_headers, &upstream_path,
|
io, parts, body, upstream_headers, &upstream_path,
|
||||||
&upstream, route_match.route, route_id, &ip_str, &final_pool_key, domain_str,
|
&upstream, route_match.route, route_id, &ip_str, &final_pool_key, domain_str, &conn_activity,
|
||||||
).await
|
).await
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
self.forward_h1(
|
self.forward_h1(
|
||||||
io, parts, body, upstream_headers, &upstream_path,
|
io, parts, body, upstream_headers, &upstream_path,
|
||||||
&upstream, route_match.route, route_id, &ip_str, &final_pool_key, domain_str,
|
&upstream, route_match.route, route_id, &ip_str, &final_pool_key, domain_str, &conn_activity,
|
||||||
).await
|
).await
|
||||||
};
|
};
|
||||||
self.upstream_selector.connection_ended(&upstream_key);
|
self.upstream_selector.connection_ended(&upstream_key);
|
||||||
@@ -806,6 +828,7 @@ impl HttpProxyService {
|
|||||||
source_ip: &str,
|
source_ip: &str,
|
||||||
pool_key: &crate::connection_pool::PoolKey,
|
pool_key: &crate::connection_pool::PoolKey,
|
||||||
domain: &str,
|
domain: &str,
|
||||||
|
conn_activity: &ConnActivity,
|
||||||
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
||||||
let backend_key = format!("{}:{}", pool_key.host, pool_key.port);
|
let backend_key = format!("{}:{}", pool_key.host, pool_key.port);
|
||||||
|
|
||||||
@@ -814,7 +837,7 @@ impl HttpProxyService {
|
|||||||
self.metrics.backend_pool_hit(&backend_key);
|
self.metrics.backend_pool_hit(&backend_key);
|
||||||
return self.forward_h1_with_sender(
|
return self.forward_h1_with_sender(
|
||||||
pooled_sender, parts, body, upstream_headers, upstream_path,
|
pooled_sender, parts, body, upstream_headers, upstream_path,
|
||||||
route, route_id, source_ip, pool_key, domain,
|
route, route_id, source_ip, pool_key, domain, conn_activity,
|
||||||
).await;
|
).await;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -837,7 +860,7 @@ impl HttpProxyService {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
self.forward_h1_with_sender(sender, parts, body, upstream_headers, upstream_path, route, route_id, source_ip, pool_key, domain).await
|
self.forward_h1_with_sender(sender, parts, body, upstream_headers, upstream_path, route, route_id, source_ip, pool_key, domain, conn_activity).await
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Common H1 forwarding logic used by both fresh and pooled paths.
|
/// Common H1 forwarding logic used by both fresh and pooled paths.
|
||||||
@@ -853,6 +876,7 @@ impl HttpProxyService {
|
|||||||
source_ip: &str,
|
source_ip: &str,
|
||||||
pool_key: &crate::connection_pool::PoolKey,
|
pool_key: &crate::connection_pool::PoolKey,
|
||||||
domain: &str,
|
domain: &str,
|
||||||
|
conn_activity: &ConnActivity,
|
||||||
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
||||||
// Always use HTTP/1.1 for h1 backend connections (h2 incoming requests have version HTTP/2.0)
|
// Always use HTTP/1.1 for h1 backend connections (h2 incoming requests have version HTTP/2.0)
|
||||||
let mut upstream_req = Request::builder()
|
let mut upstream_req = Request::builder()
|
||||||
@@ -871,7 +895,7 @@ impl HttpProxyService {
|
|||||||
route_id.map(|s| s.to_string()),
|
route_id.map(|s| s.to_string()),
|
||||||
Some(source_ip.to_string()),
|
Some(source_ip.to_string()),
|
||||||
Direction::In,
|
Direction::In,
|
||||||
);
|
).with_connection_activity(Arc::clone(&conn_activity.last_activity), conn_activity.start);
|
||||||
let boxed_body: BoxBody<Bytes, hyper::Error> = BoxBody::new(counting_req_body);
|
let boxed_body: BoxBody<Bytes, hyper::Error> = BoxBody::new(counting_req_body);
|
||||||
|
|
||||||
let upstream_req = upstream_req.body(boxed_body).unwrap();
|
let upstream_req = upstream_req.body(boxed_body).unwrap();
|
||||||
@@ -886,10 +910,17 @@ impl HttpProxyService {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
// Return sender to pool (body streams lazily, sender is reusable once response head is received)
|
// Note: we do NOT return the sender to the pool here because the response body
|
||||||
self.connection_pool.checkin_h1(pool_key.clone(), sender);
|
// hasn't been fully streamed yet. Pooling a sender while its response body is still
|
||||||
|
// in-flight risks another request being dispatched on the same connection if is_ready()
|
||||||
|
// momentarily returns true between chunks. The sender is dropped after this scope,
|
||||||
|
// and the backend connection remains alive via the spawned conn driver task until
|
||||||
|
// the response body finishes streaming.
|
||||||
|
// For small/empty responses, the sender could theoretically be reused, but the safety
|
||||||
|
// of large streaming responses (e.g. 352MB Docker layers) takes priority.
|
||||||
|
drop(sender);
|
||||||
|
|
||||||
self.build_streaming_response(upstream_response, route, route_id, source_ip).await
|
self.build_streaming_response(upstream_response, route, route_id, source_ip, conn_activity).await
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Forward request to backend via HTTP/2 with body streaming (fresh connection).
|
/// Forward request to backend via HTTP/2 with body streaming (fresh connection).
|
||||||
@@ -907,6 +938,7 @@ impl HttpProxyService {
|
|||||||
source_ip: &str,
|
source_ip: &str,
|
||||||
pool_key: &crate::connection_pool::PoolKey,
|
pool_key: &crate::connection_pool::PoolKey,
|
||||||
domain: &str,
|
domain: &str,
|
||||||
|
conn_activity: &ConnActivity,
|
||||||
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
||||||
let backend_key = format!("{}:{}", pool_key.host, pool_key.port);
|
let backend_key = format!("{}:{}", pool_key.host, pool_key.port);
|
||||||
let exec = hyper_util::rt::TokioExecutor::new();
|
let exec = hyper_util::rt::TokioExecutor::new();
|
||||||
@@ -914,9 +946,9 @@ impl HttpProxyService {
|
|||||||
h2_builder
|
h2_builder
|
||||||
.timer(hyper_util::rt::TokioTimer::new())
|
.timer(hyper_util::rt::TokioTimer::new())
|
||||||
.keep_alive_interval(std::time::Duration::from_secs(10))
|
.keep_alive_interval(std::time::Duration::from_secs(10))
|
||||||
.keep_alive_timeout(std::time::Duration::from_secs(5))
|
.keep_alive_timeout(std::time::Duration::from_secs(30))
|
||||||
.adaptive_window(true)
|
.initial_stream_window_size(2 * 1024 * 1024)
|
||||||
.initial_stream_window_size(2 * 1024 * 1024);
|
.initial_connection_window_size(16 * 1024 * 1024);
|
||||||
let (sender, conn): (
|
let (sender, conn): (
|
||||||
hyper::client::conn::http2::SendRequest<BoxBody<Bytes, hyper::Error>>,
|
hyper::client::conn::http2::SendRequest<BoxBody<Bytes, hyper::Error>>,
|
||||||
hyper::client::conn::http2::Connection<TokioIo<BackendStream>, BoxBody<Bytes, hyper::Error>, hyper_util::rt::TokioExecutor>,
|
hyper::client::conn::http2::Connection<TokioIo<BackendStream>, BoxBody<Bytes, hyper::Error>, hyper_util::rt::TokioExecutor>,
|
||||||
@@ -942,7 +974,7 @@ impl HttpProxyService {
|
|||||||
|
|
||||||
// Clone sender for potential pool registration; register only after first request succeeds
|
// Clone sender for potential pool registration; register only after first request succeeds
|
||||||
let sender_for_pool = sender.clone();
|
let sender_for_pool = sender.clone();
|
||||||
let result = self.forward_h2_with_sender(sender, parts, body, upstream_headers, upstream_path, route, route_id, source_ip, Some(pool_key), domain).await;
|
let result = self.forward_h2_with_sender(sender, parts, body, upstream_headers, upstream_path, route, route_id, source_ip, Some(pool_key), domain, conn_activity).await;
|
||||||
if matches!(&result, Ok(ref resp) if resp.status() != StatusCode::BAD_GATEWAY) {
|
if matches!(&result, Ok(ref resp) if resp.status() != StatusCode::BAD_GATEWAY) {
|
||||||
self.connection_pool.register_h2(pool_key.clone(), sender_for_pool);
|
self.connection_pool.register_h2(pool_key.clone(), sender_for_pool);
|
||||||
}
|
}
|
||||||
@@ -964,6 +996,7 @@ impl HttpProxyService {
|
|||||||
source_ip: &str,
|
source_ip: &str,
|
||||||
pool_key: &crate::connection_pool::PoolKey,
|
pool_key: &crate::connection_pool::PoolKey,
|
||||||
domain: &str,
|
domain: &str,
|
||||||
|
conn_activity: &ConnActivity,
|
||||||
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
||||||
// Save retry state for bodyless requests (cheap: Method is an enum, HeaderMap clones Arc-backed Bytes)
|
// Save retry state for bodyless requests (cheap: Method is an enum, HeaderMap clones Arc-backed Bytes)
|
||||||
let retry_state = if body.is_end_stream() {
|
let retry_state = if body.is_end_stream() {
|
||||||
@@ -974,7 +1007,7 @@ impl HttpProxyService {
|
|||||||
|
|
||||||
let result = self.forward_h2_with_sender(
|
let result = self.forward_h2_with_sender(
|
||||||
sender, parts, body, upstream_headers, upstream_path,
|
sender, parts, body, upstream_headers, upstream_path,
|
||||||
route, route_id, source_ip, Some(pool_key), domain,
|
route, route_id, source_ip, Some(pool_key), domain, conn_activity,
|
||||||
).await;
|
).await;
|
||||||
|
|
||||||
// If the request failed (502) and we can retry with an empty body, do so
|
// If the request failed (502) and we can retry with an empty body, do so
|
||||||
@@ -985,7 +1018,7 @@ impl HttpProxyService {
|
|||||||
"Stale pooled H2 sender, retrying with fresh connection");
|
"Stale pooled H2 sender, retrying with fresh connection");
|
||||||
return self.retry_h2_with_fresh_connection(
|
return self.retry_h2_with_fresh_connection(
|
||||||
method, headers, upstream_path,
|
method, headers, upstream_path,
|
||||||
pool_key, route, route_id, source_ip, domain,
|
pool_key, route, route_id, source_ip, domain, conn_activity,
|
||||||
).await;
|
).await;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1004,6 +1037,7 @@ impl HttpProxyService {
|
|||||||
route_id: Option<&str>,
|
route_id: Option<&str>,
|
||||||
source_ip: &str,
|
source_ip: &str,
|
||||||
domain: &str,
|
domain: &str,
|
||||||
|
conn_activity: &ConnActivity,
|
||||||
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
||||||
let backend_key = format!("{}:{}", pool_key.host, pool_key.port);
|
let backend_key = format!("{}:{}", pool_key.host, pool_key.port);
|
||||||
|
|
||||||
@@ -1055,9 +1089,9 @@ impl HttpProxyService {
|
|||||||
h2_builder
|
h2_builder
|
||||||
.timer(hyper_util::rt::TokioTimer::new())
|
.timer(hyper_util::rt::TokioTimer::new())
|
||||||
.keep_alive_interval(std::time::Duration::from_secs(10))
|
.keep_alive_interval(std::time::Duration::from_secs(10))
|
||||||
.keep_alive_timeout(std::time::Duration::from_secs(5))
|
.keep_alive_timeout(std::time::Duration::from_secs(30))
|
||||||
.adaptive_window(true)
|
.initial_stream_window_size(2 * 1024 * 1024)
|
||||||
.initial_stream_window_size(2 * 1024 * 1024);
|
.initial_connection_window_size(16 * 1024 * 1024);
|
||||||
let (mut sender, conn): (
|
let (mut sender, conn): (
|
||||||
hyper::client::conn::http2::SendRequest<BoxBody<Bytes, hyper::Error>>,
|
hyper::client::conn::http2::SendRequest<BoxBody<Bytes, hyper::Error>>,
|
||||||
hyper::client::conn::http2::Connection<TokioIo<BackendStream>, BoxBody<Bytes, hyper::Error>, hyper_util::rt::TokioExecutor>,
|
hyper::client::conn::http2::Connection<TokioIo<BackendStream>, BoxBody<Bytes, hyper::Error>, hyper_util::rt::TokioExecutor>,
|
||||||
@@ -1091,6 +1125,10 @@ impl HttpProxyService {
|
|||||||
.method(method)
|
.method(method)
|
||||||
.uri(&h2_uri);
|
.uri(&h2_uri);
|
||||||
|
|
||||||
|
// Remove Host header for H2 — :authority pseudo-header (from URI) is sufficient
|
||||||
|
let mut upstream_headers = upstream_headers;
|
||||||
|
upstream_headers.remove("host");
|
||||||
|
|
||||||
if let Some(headers) = upstream_req.headers_mut() {
|
if let Some(headers) = upstream_req.headers_mut() {
|
||||||
*headers = upstream_headers;
|
*headers = upstream_headers;
|
||||||
}
|
}
|
||||||
@@ -1104,7 +1142,7 @@ impl HttpProxyService {
|
|||||||
Ok(resp) => {
|
Ok(resp) => {
|
||||||
// Register in pool only after request succeeds
|
// Register in pool only after request succeeds
|
||||||
self.connection_pool.register_h2(pool_key.clone(), sender);
|
self.connection_pool.register_h2(pool_key.clone(), sender);
|
||||||
let result = self.build_streaming_response(resp, route, route_id, source_ip).await;
|
let result = self.build_streaming_response(resp, route, route_id, source_ip, conn_activity).await;
|
||||||
// Close the fresh backend connection (opened above)
|
// Close the fresh backend connection (opened above)
|
||||||
self.metrics.backend_connection_closed(&backend_key);
|
self.metrics.backend_connection_closed(&backend_key);
|
||||||
result
|
result
|
||||||
@@ -1131,7 +1169,7 @@ impl HttpProxyService {
|
|||||||
io: TokioIo<BackendStream>,
|
io: TokioIo<BackendStream>,
|
||||||
parts: hyper::http::request::Parts,
|
parts: hyper::http::request::Parts,
|
||||||
body: Incoming,
|
body: Incoming,
|
||||||
upstream_headers: hyper::HeaderMap,
|
mut upstream_headers: hyper::HeaderMap,
|
||||||
upstream_path: &str,
|
upstream_path: &str,
|
||||||
upstream: &crate::upstream_selector::UpstreamSelection,
|
upstream: &crate::upstream_selector::UpstreamSelection,
|
||||||
route: &rustproxy_config::RouteConfig,
|
route: &rustproxy_config::RouteConfig,
|
||||||
@@ -1140,15 +1178,16 @@ impl HttpProxyService {
|
|||||||
pool_key: &crate::connection_pool::PoolKey,
|
pool_key: &crate::connection_pool::PoolKey,
|
||||||
requested_host: Option<String>,
|
requested_host: Option<String>,
|
||||||
domain: &str,
|
domain: &str,
|
||||||
|
conn_activity: &ConnActivity,
|
||||||
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
||||||
let exec = hyper_util::rt::TokioExecutor::new();
|
let exec = hyper_util::rt::TokioExecutor::new();
|
||||||
let mut h2_builder = hyper::client::conn::http2::Builder::new(exec);
|
let mut h2_builder = hyper::client::conn::http2::Builder::new(exec);
|
||||||
h2_builder
|
h2_builder
|
||||||
.timer(hyper_util::rt::TokioTimer::new())
|
.timer(hyper_util::rt::TokioTimer::new())
|
||||||
.keep_alive_interval(std::time::Duration::from_secs(10))
|
.keep_alive_interval(std::time::Duration::from_secs(10))
|
||||||
.keep_alive_timeout(std::time::Duration::from_secs(5))
|
.keep_alive_timeout(std::time::Duration::from_secs(30))
|
||||||
.adaptive_window(true)
|
.initial_stream_window_size(2 * 1024 * 1024)
|
||||||
.initial_stream_window_size(2 * 1024 * 1024);
|
.initial_connection_window_size(16 * 1024 * 1024);
|
||||||
let handshake_result = tokio::time::timeout(
|
let handshake_result = tokio::time::timeout(
|
||||||
self.connect_timeout,
|
self.connect_timeout,
|
||||||
h2_builder.handshake(io),
|
h2_builder.handshake(io),
|
||||||
@@ -1184,7 +1223,7 @@ impl HttpProxyService {
|
|||||||
let fallback_io = TokioIo::new(fallback_backend);
|
let fallback_io = TokioIo::new(fallback_backend);
|
||||||
let result = self.forward_h1(
|
let result = self.forward_h1(
|
||||||
fallback_io, parts, body, upstream_headers, upstream_path,
|
fallback_io, parts, body, upstream_headers, upstream_path,
|
||||||
upstream, route, route_id, source_ip, &h1_pool_key, domain,
|
upstream, route, route_id, source_ip, &h1_pool_key, domain, conn_activity,
|
||||||
).await;
|
).await;
|
||||||
self.metrics.backend_connection_closed(&bk);
|
self.metrics.backend_connection_closed(&bk);
|
||||||
result
|
result
|
||||||
@@ -1202,12 +1241,16 @@ impl HttpProxyService {
|
|||||||
});
|
});
|
||||||
|
|
||||||
// Save retry state before consuming parts/body (for bodyless requests like GET)
|
// Save retry state before consuming parts/body (for bodyless requests like GET)
|
||||||
|
// Clone BEFORE removing Host — H1 fallback needs Host header
|
||||||
let retry_state = if body.is_end_stream() {
|
let retry_state = if body.is_end_stream() {
|
||||||
Some((parts.method.clone(), upstream_headers.clone()))
|
Some((parts.method.clone(), upstream_headers.clone()))
|
||||||
} else {
|
} else {
|
||||||
None
|
None
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// Remove Host header for H2 — :authority pseudo-header (from URI) is sufficient
|
||||||
|
upstream_headers.remove("host");
|
||||||
|
|
||||||
// Build and send the h2 request inline (don't register in pool yet —
|
// Build and send the h2 request inline (don't register in pool yet —
|
||||||
// we need to verify the request actually succeeds first, because some
|
// we need to verify the request actually succeeds first, because some
|
||||||
// backends advertise h2 via ALPN but don't speak the h2 binary protocol).
|
// backends advertise h2 via ALPN but don't speak the h2 binary protocol).
|
||||||
@@ -1228,7 +1271,7 @@ impl HttpProxyService {
|
|||||||
route_id.map(|s| s.to_string()),
|
route_id.map(|s| s.to_string()),
|
||||||
Some(source_ip.to_string()),
|
Some(source_ip.to_string()),
|
||||||
Direction::In,
|
Direction::In,
|
||||||
);
|
).with_connection_activity(Arc::clone(&conn_activity.last_activity), conn_activity.start);
|
||||||
let boxed_body: BoxBody<Bytes, hyper::Error> = BoxBody::new(counting_req_body);
|
let boxed_body: BoxBody<Bytes, hyper::Error> = BoxBody::new(counting_req_body);
|
||||||
let upstream_req = upstream_req.body(boxed_body).unwrap();
|
let upstream_req = upstream_req.body(boxed_body).unwrap();
|
||||||
|
|
||||||
@@ -1236,7 +1279,7 @@ impl HttpProxyService {
|
|||||||
Ok(upstream_response) => {
|
Ok(upstream_response) => {
|
||||||
// H2 works! Register sender in pool for multiplexed reuse
|
// H2 works! Register sender in pool for multiplexed reuse
|
||||||
self.connection_pool.register_h2(pool_key.clone(), sender);
|
self.connection_pool.register_h2(pool_key.clone(), sender);
|
||||||
self.build_streaming_response(upstream_response, route, route_id, source_ip).await
|
self.build_streaming_response(upstream_response, route, route_id, source_ip, conn_activity).await
|
||||||
}
|
}
|
||||||
Err(e) => {
|
Err(e) => {
|
||||||
// H2 request failed — backend advertises h2 via ALPN but doesn't
|
// H2 request failed — backend advertises h2 via ALPN but doesn't
|
||||||
@@ -1269,7 +1312,7 @@ impl HttpProxyService {
|
|||||||
let fallback_io = TokioIo::new(fallback_backend);
|
let fallback_io = TokioIo::new(fallback_backend);
|
||||||
let result = self.forward_h1_empty_body(
|
let result = self.forward_h1_empty_body(
|
||||||
fallback_io, method, headers, upstream_path,
|
fallback_io, method, headers, upstream_path,
|
||||||
route, route_id, source_ip, &h1_pool_key, domain,
|
route, route_id, source_ip, &h1_pool_key, domain, conn_activity,
|
||||||
).await;
|
).await;
|
||||||
// Close the reconnected backend connection (opened in reconnect_backend)
|
// Close the reconnected backend connection (opened in reconnect_backend)
|
||||||
self.metrics.backend_connection_closed(&bk);
|
self.metrics.backend_connection_closed(&bk);
|
||||||
@@ -1318,7 +1361,7 @@ impl HttpProxyService {
|
|||||||
let fallback_io = TokioIo::new(fallback_backend);
|
let fallback_io = TokioIo::new(fallback_backend);
|
||||||
let result = self.forward_h1(
|
let result = self.forward_h1(
|
||||||
fallback_io, parts, body, upstream_headers, upstream_path,
|
fallback_io, parts, body, upstream_headers, upstream_path,
|
||||||
upstream, route, route_id, source_ip, &h1_pool_key, domain,
|
upstream, route, route_id, source_ip, &h1_pool_key, domain, conn_activity,
|
||||||
).await;
|
).await;
|
||||||
// Close the reconnected backend connection (opened in reconnect_backend)
|
// Close the reconnected backend connection (opened in reconnect_backend)
|
||||||
self.metrics.backend_connection_closed(&bk);
|
self.metrics.backend_connection_closed(&bk);
|
||||||
@@ -1345,6 +1388,7 @@ impl HttpProxyService {
|
|||||||
source_ip: &str,
|
source_ip: &str,
|
||||||
pool_key: &crate::connection_pool::PoolKey,
|
pool_key: &crate::connection_pool::PoolKey,
|
||||||
domain: &str,
|
domain: &str,
|
||||||
|
conn_activity: &ConnActivity,
|
||||||
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
||||||
let backend_key = format!("{}:{}", pool_key.host, pool_key.port);
|
let backend_key = format!("{}:{}", pool_key.host, pool_key.port);
|
||||||
let (mut sender, conn): (
|
let (mut sender, conn): (
|
||||||
@@ -1388,10 +1432,10 @@ impl HttpProxyService {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
// Return sender to pool for keep-alive reuse
|
// Don't pool the sender while response body is still streaming (same safety as forward_h1_with_sender)
|
||||||
self.connection_pool.checkin_h1(pool_key.clone(), sender);
|
drop(sender);
|
||||||
|
|
||||||
self.build_streaming_response(upstream_response, route, route_id, source_ip).await
|
self.build_streaming_response(upstream_response, route, route_id, source_ip, conn_activity).await
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Reconnect to a backend (used for H2→H1 fallback).
|
/// Reconnect to a backend (used for H2→H1 fallback).
|
||||||
@@ -1462,6 +1506,7 @@ impl HttpProxyService {
|
|||||||
source_ip: &str,
|
source_ip: &str,
|
||||||
pool_key: Option<&crate::connection_pool::PoolKey>,
|
pool_key: Option<&crate::connection_pool::PoolKey>,
|
||||||
domain: &str,
|
domain: &str,
|
||||||
|
conn_activity: &ConnActivity,
|
||||||
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
||||||
// Build absolute URI for H2 pseudo-headers (:scheme, :authority)
|
// Build absolute URI for H2 pseudo-headers (:scheme, :authority)
|
||||||
// Use the requested domain as authority (not backend address) so :authority matches Host header
|
// Use the requested domain as authority (not backend address) so :authority matches Host header
|
||||||
@@ -1474,6 +1519,11 @@ impl HttpProxyService {
|
|||||||
.method(parts.method)
|
.method(parts.method)
|
||||||
.uri(&h2_uri);
|
.uri(&h2_uri);
|
||||||
|
|
||||||
|
// Remove Host header for H2 — :authority pseudo-header (from URI) is sufficient
|
||||||
|
// Having both Host and :authority causes nginx to return 400
|
||||||
|
let mut upstream_headers = upstream_headers;
|
||||||
|
upstream_headers.remove("host");
|
||||||
|
|
||||||
if let Some(headers) = upstream_req.headers_mut() {
|
if let Some(headers) = upstream_req.headers_mut() {
|
||||||
*headers = upstream_headers;
|
*headers = upstream_headers;
|
||||||
}
|
}
|
||||||
@@ -1485,7 +1535,7 @@ impl HttpProxyService {
|
|||||||
route_id.map(|s| s.to_string()),
|
route_id.map(|s| s.to_string()),
|
||||||
Some(source_ip.to_string()),
|
Some(source_ip.to_string()),
|
||||||
Direction::In,
|
Direction::In,
|
||||||
);
|
).with_connection_activity(Arc::clone(&conn_activity.last_activity), conn_activity.start);
|
||||||
let boxed_body: BoxBody<Bytes, hyper::Error> = BoxBody::new(counting_req_body);
|
let boxed_body: BoxBody<Bytes, hyper::Error> = BoxBody::new(counting_req_body);
|
||||||
|
|
||||||
let upstream_req = upstream_req.body(boxed_body).unwrap();
|
let upstream_req = upstream_req.body(boxed_body).unwrap();
|
||||||
@@ -1506,7 +1556,7 @@ impl HttpProxyService {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
self.build_streaming_response(upstream_response, route, route_id, source_ip).await
|
self.build_streaming_response(upstream_response, route, route_id, source_ip, conn_activity).await
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Build the client-facing response from an upstream response, streaming the body.
|
/// Build the client-facing response from an upstream response, streaming the body.
|
||||||
@@ -1519,6 +1569,7 @@ impl HttpProxyService {
|
|||||||
route: &rustproxy_config::RouteConfig,
|
route: &rustproxy_config::RouteConfig,
|
||||||
route_id: Option<&str>,
|
route_id: Option<&str>,
|
||||||
source_ip: &str,
|
source_ip: &str,
|
||||||
|
conn_activity: &ConnActivity,
|
||||||
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
||||||
let (resp_parts, resp_body) = upstream_response.into_parts();
|
let (resp_parts, resp_body) = upstream_response.into_parts();
|
||||||
|
|
||||||
@@ -1539,14 +1590,14 @@ impl HttpProxyService {
|
|||||||
route_id.map(|s| s.to_string()),
|
route_id.map(|s| s.to_string()),
|
||||||
Some(source_ip.to_string()),
|
Some(source_ip.to_string()),
|
||||||
Direction::Out,
|
Direction::Out,
|
||||||
);
|
).with_connection_activity(Arc::clone(&conn_activity.last_activity), conn_activity.start);
|
||||||
|
|
||||||
let body: BoxBody<Bytes, hyper::Error> = BoxBody::new(counting_body);
|
let body: BoxBody<Bytes, hyper::Error> = BoxBody::new(counting_body);
|
||||||
|
|
||||||
Ok(response.body(body).unwrap())
|
Ok(response.body(body).unwrap())
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Handle a WebSocket upgrade request.
|
/// Handle a WebSocket upgrade request (H1 Upgrade or H2 Extended CONNECT per RFC 8441).
|
||||||
async fn handle_websocket_upgrade(
|
async fn handle_websocket_upgrade(
|
||||||
&self,
|
&self,
|
||||||
req: Request<Incoming>,
|
req: Request<Incoming>,
|
||||||
@@ -1557,6 +1608,8 @@ impl HttpProxyService {
|
|||||||
upstream_key: &str,
|
upstream_key: &str,
|
||||||
cancel: CancellationToken,
|
cancel: CancellationToken,
|
||||||
source_ip: &str,
|
source_ip: &str,
|
||||||
|
is_h2: bool,
|
||||||
|
conn_activity: Option<ConnActivity>,
|
||||||
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
) -> Result<Response<BoxBody<Bytes, hyper::Error>>, hyper::Error> {
|
||||||
use tokio::io::{AsyncReadExt, AsyncWriteExt};
|
use tokio::io::{AsyncReadExt, AsyncWriteExt};
|
||||||
|
|
||||||
@@ -1642,9 +1695,11 @@ impl HttpProxyService {
|
|||||||
|
|
||||||
let (parts, _body) = req.into_parts();
|
let (parts, _body) = req.into_parts();
|
||||||
|
|
||||||
|
// H2 Extended CONNECT uses method=CONNECT, but the H1.1 backend expects GET
|
||||||
|
let backend_method = if is_h2 { "GET" } else { parts.method.as_str() };
|
||||||
let mut raw_request = format!(
|
let mut raw_request = format!(
|
||||||
"{} {} HTTP/1.1\r\n",
|
"{} {} HTTP/1.1\r\n",
|
||||||
parts.method, upstream_path
|
backend_method, upstream_path
|
||||||
);
|
);
|
||||||
|
|
||||||
// Copy all original headers (preserving the client's Host header).
|
// Copy all original headers (preserving the client's Host header).
|
||||||
@@ -1672,6 +1727,23 @@ impl HttpProxyService {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// H2 Extended CONNECT doesn't carry H1 WebSocket handshake headers;
|
||||||
|
// inject them so the H1.1 backend can complete the upgrade.
|
||||||
|
if is_h2 {
|
||||||
|
if !parts.headers.contains_key("upgrade") {
|
||||||
|
raw_request.push_str("upgrade: websocket\r\n");
|
||||||
|
}
|
||||||
|
if !parts.headers.contains_key("connection") {
|
||||||
|
raw_request.push_str("connection: Upgrade\r\n");
|
||||||
|
}
|
||||||
|
if !parts.headers.contains_key("sec-websocket-version") {
|
||||||
|
raw_request.push_str("sec-websocket-version: 13\r\n");
|
||||||
|
}
|
||||||
|
if !parts.headers.contains_key("sec-websocket-key") {
|
||||||
|
raw_request.push_str("sec-websocket-key: dGhlIHNhbXBsZSBub25jZQ==\r\n");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Add standard reverse-proxy headers (X-Forwarded-*)
|
// Add standard reverse-proxy headers (X-Forwarded-*)
|
||||||
{
|
{
|
||||||
let original_host = parts.headers.get("host")
|
let original_host = parts.headers.get("host")
|
||||||
@@ -1774,8 +1846,12 @@ impl HttpProxyService {
|
|||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
let mut client_resp = Response::builder()
|
// H1: 101 Switching Protocols; H2: 200 OK (RFC 8441 — hyper requires 2xx for Extended CONNECT upgrade)
|
||||||
.status(StatusCode::SWITCHING_PROTOCOLS);
|
let mut client_resp = if is_h2 {
|
||||||
|
Response::builder().status(StatusCode::OK)
|
||||||
|
} else {
|
||||||
|
Response::builder().status(StatusCode::SWITCHING_PROTOCOLS)
|
||||||
|
};
|
||||||
|
|
||||||
if let Some(resp_headers) = client_resp.headers_mut() {
|
if let Some(resp_headers) = client_resp.headers_mut() {
|
||||||
for line in response_str.lines().skip(1) {
|
for line in response_str.lines().skip(1) {
|
||||||
@@ -1786,6 +1862,17 @@ impl HttpProxyService {
|
|||||||
if let Some((name, value)) = line.split_once(':') {
|
if let Some((name, value)) = line.split_once(':') {
|
||||||
let name = name.trim();
|
let name = name.trim();
|
||||||
let value = value.trim();
|
let value = value.trim();
|
||||||
|
// Skip hop-by-hop headers for H2 (forbidden by RFC 9113 §8.2.2)
|
||||||
|
if is_h2 {
|
||||||
|
let name_lower = name.to_lowercase();
|
||||||
|
if name_lower == "upgrade" || name_lower == "connection"
|
||||||
|
|| name_lower == "sec-websocket-accept"
|
||||||
|
|| name_lower == "transfer-encoding"
|
||||||
|
|| name_lower == "keep-alive"
|
||||||
|
{
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
}
|
||||||
if let Ok(header_name) = hyper::header::HeaderName::from_bytes(name.as_bytes()) {
|
if let Ok(header_name) = hyper::header::HeaderName::from_bytes(name.as_bytes()) {
|
||||||
if let Ok(header_value) = hyper::header::HeaderValue::from_str(value) {
|
if let Ok(header_value) = hyper::header::HeaderValue::from_str(value) {
|
||||||
resp_headers.insert(header_name, header_value);
|
resp_headers.insert(header_name, header_value);
|
||||||
@@ -1826,7 +1913,15 @@ impl HttpProxyService {
|
|||||||
let last_activity = Arc::new(AtomicU64::new(0));
|
let last_activity = Arc::new(AtomicU64::new(0));
|
||||||
let start = std::time::Instant::now();
|
let start = std::time::Instant::now();
|
||||||
|
|
||||||
|
// For H2 WebSocket: also update the connection-level activity tracker
|
||||||
|
// to prevent the idle watchdog from killing the H2 connection
|
||||||
|
let conn_act_c2u = conn_activity.as_ref().map(|ca| (Arc::clone(&ca.last_activity), ca.start));
|
||||||
|
let conn_act_u2c = conn_activity.as_ref().map(|ca| (Arc::clone(&ca.last_activity), ca.start));
|
||||||
|
|
||||||
let la1 = Arc::clone(&last_activity);
|
let la1 = Arc::clone(&last_activity);
|
||||||
|
let metrics_c2u = Arc::clone(&metrics);
|
||||||
|
let route_c2u = route_id_owned.clone();
|
||||||
|
let ip_c2u = source_ip_owned.clone();
|
||||||
let c2u = tokio::spawn(async move {
|
let c2u = tokio::spawn(async move {
|
||||||
let mut buf = vec![0u8; 65536];
|
let mut buf = vec![0u8; 65536];
|
||||||
let mut total = 0u64;
|
let mut total = 0u64;
|
||||||
@@ -1839,13 +1934,20 @@ impl HttpProxyService {
|
|||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
total += n as u64;
|
total += n as u64;
|
||||||
|
metrics_c2u.record_bytes(n as u64, 0, route_c2u.as_deref(), Some(&ip_c2u));
|
||||||
la1.store(start.elapsed().as_millis() as u64, Ordering::Relaxed);
|
la1.store(start.elapsed().as_millis() as u64, Ordering::Relaxed);
|
||||||
|
if let Some((ref ca, ca_start)) = conn_act_c2u {
|
||||||
|
ca.store(ca_start.elapsed().as_millis() as u64, Ordering::Relaxed);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
let _ = uw.shutdown().await;
|
let _ = uw.shutdown().await;
|
||||||
total
|
total
|
||||||
});
|
});
|
||||||
|
|
||||||
let la2 = Arc::clone(&last_activity);
|
let la2 = Arc::clone(&last_activity);
|
||||||
|
let metrics_u2c = Arc::clone(&metrics);
|
||||||
|
let route_u2c = route_id_owned.clone();
|
||||||
|
let ip_u2c = source_ip_owned.clone();
|
||||||
let u2c = tokio::spawn(async move {
|
let u2c = tokio::spawn(async move {
|
||||||
let mut buf = vec![0u8; 65536];
|
let mut buf = vec![0u8; 65536];
|
||||||
let mut total = 0u64;
|
let mut total = 0u64;
|
||||||
@@ -1858,7 +1960,11 @@ impl HttpProxyService {
|
|||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
total += n as u64;
|
total += n as u64;
|
||||||
|
metrics_u2c.record_bytes(0, n as u64, route_u2c.as_deref(), Some(&ip_u2c));
|
||||||
la2.store(start.elapsed().as_millis() as u64, Ordering::Relaxed);
|
la2.store(start.elapsed().as_millis() as u64, Ordering::Relaxed);
|
||||||
|
if let Some((ref ca, ca_start)) = conn_act_u2c {
|
||||||
|
ca.store(ca_start.elapsed().as_millis() as u64, Ordering::Relaxed);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
let _ = cw.shutdown().await;
|
let _ = cw.shutdown().await;
|
||||||
total
|
total
|
||||||
@@ -1915,9 +2021,7 @@ impl HttpProxyService {
|
|||||||
debug!("WebSocket tunnel closed: {} bytes in, {} bytes out", bytes_in, bytes_out);
|
debug!("WebSocket tunnel closed: {} bytes in, {} bytes out", bytes_in, bytes_out);
|
||||||
|
|
||||||
upstream_selector.connection_ended(&upstream_key_owned);
|
upstream_selector.connection_ended(&upstream_key_owned);
|
||||||
if let Some(ref rid) = route_id_owned {
|
// Bytes already reported per-chunk in the copy loops above
|
||||||
metrics.record_bytes(bytes_in, bytes_out, Some(rid.as_str()), Some(&source_ip_owned));
|
|
||||||
}
|
|
||||||
});
|
});
|
||||||
|
|
||||||
let body: BoxBody<Bytes, hyper::Error> = BoxBody::new(
|
let body: BoxBody<Bytes, hyper::Error> = BoxBody::new(
|
||||||
|
|||||||
@@ -3,6 +3,6 @@
|
|||||||
*/
|
*/
|
||||||
export const commitinfo = {
|
export const commitinfo = {
|
||||||
name: '@push.rocks/smartproxy',
|
name: '@push.rocks/smartproxy',
|
||||||
version: '25.10.6',
|
version: '25.11.4',
|
||||||
description: 'A powerful proxy package with unified route-based configuration for high traffic management. Features include SSL/TLS support, flexible routing patterns, WebSocket handling, advanced security options, and automatic ACME certificate management.'
|
description: 'A powerful proxy package with unified route-based configuration for high traffic management. Features include SSL/TLS support, flexible routing patterns, WebSocket handling, advanced security options, and automatic ACME certificate management.'
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user