Compare commits

...

12 Commits

Author SHA1 Message Date
0475e6b442 v25.11.7
Some checks failed
Default (tags) / security (push) Failing after 1s
Default (tags) / test (push) Failing after 0s
Default (tags) / release (push) Has been skipped
Default (tags) / metadata (push) Has been skipped
2026-03-16 03:01:16 +00:00
8cdb95a853 fix(rustproxy): prevent TLS route reload certificate mismatches and tighten passthrough connection handling 2026-03-16 03:01:16 +00:00
8cefe9d66a v25.11.6
Some checks failed
Default (tags) / security (push) Failing after 0s
Default (tags) / test (push) Failing after 0s
Default (tags) / release (push) Has been skipped
Default (tags) / metadata (push) Has been skipped
2026-03-16 02:05:47 +00:00
d5e08c83fc fix(rustproxy-http,rustproxy-passthrough): improve upstream connection cleanup and graceful tunnel shutdown 2026-03-16 02:05:47 +00:00
1247f48856 v25.11.5
Some checks failed
Default (tags) / security (push) Failing after 1s
Default (tags) / test (push) Failing after 1s
Default (tags) / release (push) Has been skipped
Default (tags) / metadata (push) Has been skipped
2026-03-16 00:03:10 +00:00
e3bae4c399 fix(repo): no changes to commit 2026-03-16 00:03:10 +00:00
0930f7e10c v25.11.4
Some checks failed
Default (tags) / security (push) Failing after 1s
Default (tags) / test (push) Failing after 1s
Default (tags) / release (push) Has been skipped
Default (tags) / metadata (push) Has been skipped
2026-03-15 21:44:32 +00:00
aa9e6dfd94 fix(rustproxy-http): report streamed HTTP and WebSocket bytes per chunk for real-time throughput metrics 2026-03-15 21:44:32 +00:00
211d5cf835 v25.11.3
Some checks failed
Default (tags) / security (push) Failing after 1s
Default (tags) / test (push) Failing after 1s
Default (tags) / release (push) Has been skipped
Default (tags) / metadata (push) Has been skipped
2026-03-15 17:00:33 +00:00
2ce1899337 fix(repo): no changes to commit 2026-03-15 17:00:33 +00:00
2e2ffc4485 v25.11.2
Some checks failed
Default (tags) / security (push) Failing after 1s
Default (tags) / test (push) Failing after 1s
Default (tags) / release (push) Has been skipped
Default (tags) / metadata (push) Has been skipped
2026-03-15 16:58:41 +00:00
da26816af5 fix(rustproxy-http): avoid reusing HTTP/1 senders during streaming responses and relax HTTP/2 keep-alive timeouts 2026-03-15 16:58:41 +00:00
9 changed files with 289 additions and 145 deletions

View File

@@ -1,5 +1,41 @@
# Changelog # Changelog
## 2026-03-16 - 25.11.7 - fix(rustproxy)
prevent TLS route reload certificate mismatches and tighten passthrough connection handling
- Load updated TLS configs before swapping the route manager so newly visible routes always have their certificates available.
- Add timeouts when peeking initial decrypted data after TLS handshake to avoid leaked idle connections.
- Raise dropped, blocked, unmatched, and errored passthrough connection events from debug to warn for better operational visibility.
## 2026-03-16 - 25.11.6 - fix(rustproxy-http,rustproxy-passthrough)
improve upstream connection cleanup and graceful tunnel shutdown
- Evict pooled HTTP/2 connections when their driver exits and shorten the maximum pooled H2 age to reduce reuse of stale upstream connections.
- Strip hop-by-hop headers from backend responses before forwarding to HTTP/2 clients to avoid invalid H2 response handling.
- Replace immediate task aborts in WebSocket and TCP tunnel watchdogs with cancellation-driven graceful shutdown plus timed fallback aborts.
- Use non-blocking semaphore acquisition in the TCP listener so connection limits do not stall the accept loop for the entire port.
## 2026-03-16 - 25.11.5 - fix(repo)
no changes to commit
## 2026-03-15 - 25.11.4 - fix(rustproxy-http)
report streamed HTTP and WebSocket bytes per chunk for real-time throughput metrics
- Update CountingBody to record bytes immediately on each data frame instead of aggregating until completion or drop
- Record WebSocket tunnel traffic inside both copy loops and remove the final aggregate byte report to keep throughput metrics current
## 2026-03-15 - 25.11.3 - fix(repo)
no changes to commit
## 2026-03-15 - 25.11.2 - fix(rustproxy-http)
avoid reusing HTTP/1 senders during streaming responses and relax HTTP/2 keep-alive timeouts
- Stop returning HTTP/1 senders to the connection pool before upstream response bodies finish streaming to prevent unsafe reuse on active connections.
- Increase HTTP/2 keep-alive timeout from 5 seconds to 30 seconds in proxy connection builders to better support longer-lived backend streams.
- Improves reliability for large streaming payloads and backend fallback request handling.
## 2026-03-15 - 25.11.1 - fix(rustproxy-http) ## 2026-03-15 - 25.11.1 - fix(rustproxy-http)
keep connection idle tracking alive during streaming and tune HTTP/2 connection lifetimes keep connection idle tracking alive during streaming and tune HTTP/2 connection lifetimes

View File

@@ -1,6 +1,6 @@
{ {
"name": "@push.rocks/smartproxy", "name": "@push.rocks/smartproxy",
"version": "25.11.1", "version": "25.11.7",
"private": false, "private": false,
"description": "A powerful proxy package with unified route-based configuration for high traffic management. Features include SSL/TLS support, flexible routing patterns, WebSocket handling, advanced security options, and automatic ACME certificate management.", "description": "A powerful proxy package with unified route-based configuration for high traffic management. Features include SSL/TLS support, flexible routing patterns, WebSocket handling, advanced security options, and automatic ACME certificate management.",
"main": "dist_ts/index.js", "main": "dist_ts/index.js",

View File

@@ -20,7 +20,8 @@ const IDLE_TIMEOUT: Duration = Duration::from_secs(90);
const EVICTION_INTERVAL: Duration = Duration::from_secs(30); const EVICTION_INTERVAL: Duration = Duration::from_secs(30);
/// Maximum age for pooled HTTP/2 connections before proactive eviction. /// Maximum age for pooled HTTP/2 connections before proactive eviction.
/// Prevents staleness from backends that close idle connections (e.g. nginx GOAWAY). /// Prevents staleness from backends that close idle connections (e.g. nginx GOAWAY).
const MAX_H2_AGE: Duration = Duration::from_secs(300); /// 120s is well within typical server GOAWAY windows (nginx: ~60s idle, envoy: ~60s).
const MAX_H2_AGE: Duration = Duration::from_secs(120);
/// Identifies a unique backend endpoint. /// Identifies a unique backend endpoint.
#[derive(Clone, Debug, Hash, Eq, PartialEq)] #[derive(Clone, Debug, Hash, Eq, PartialEq)]

View File

@@ -11,20 +11,17 @@ use rustproxy_metrics::MetricsCollector;
/// Wraps any `http_body::Body` and counts data bytes passing through. /// Wraps any `http_body::Body` and counts data bytes passing through.
/// ///
/// When the body is fully consumed or dropped, accumulated byte counts /// Each chunk is reported to the `MetricsCollector` immediately so that
/// are reported to the `MetricsCollector`. /// the throughput tracker (sampled at 1 Hz) reflects real-time data flow.
/// ///
/// The inner body is pinned on the heap to support `!Unpin` types like `hyper::body::Incoming`. /// The inner body is pinned on the heap to support `!Unpin` types like `hyper::body::Incoming`.
pub struct CountingBody<B> { pub struct CountingBody<B> {
inner: Pin<Box<B>>, inner: Pin<Box<B>>,
counted_bytes: AtomicU64,
metrics: Arc<MetricsCollector>, metrics: Arc<MetricsCollector>,
route_id: Option<String>, route_id: Option<String>,
source_ip: Option<String>, source_ip: Option<String>,
/// Whether we count bytes as "in" (request body) or "out" (response body). /// Whether we count bytes as "in" (request body) or "out" (response body).
direction: Direction, direction: Direction,
/// Whether we've already reported the bytes (to avoid double-reporting on drop).
reported: bool,
/// Optional connection-level activity tracker. When set, poll_frame updates this /// Optional connection-level activity tracker. When set, poll_frame updates this
/// to keep the idle watchdog alive during active body streaming (uploads/downloads). /// to keep the idle watchdog alive during active body streaming (uploads/downloads).
connection_activity: Option<Arc<AtomicU64>>, connection_activity: Option<Arc<AtomicU64>>,
@@ -52,12 +49,10 @@ impl<B> CountingBody<B> {
) -> Self { ) -> Self {
Self { Self {
inner: Box::pin(inner), inner: Box::pin(inner),
counted_bytes: AtomicU64::new(0),
metrics, metrics,
route_id, route_id,
source_ip, source_ip,
direction, direction,
reported: false,
connection_activity: None, connection_activity: None,
activity_start: None, activity_start: None,
} }
@@ -72,33 +67,18 @@ impl<B> CountingBody<B> {
self self
} }
/// Report accumulated bytes to the metrics collector. /// Report a chunk of bytes immediately to the metrics collector.
fn report(&mut self) { #[inline]
if self.reported { fn report_chunk(&self, len: u64) {
return;
}
self.reported = true;
let bytes = self.counted_bytes.load(Ordering::Relaxed);
if bytes == 0 {
return;
}
let route_id = self.route_id.as_deref(); let route_id = self.route_id.as_deref();
let source_ip = self.source_ip.as_deref(); let source_ip = self.source_ip.as_deref();
match self.direction { match self.direction {
Direction::In => self.metrics.record_bytes(bytes, 0, route_id, source_ip), Direction::In => self.metrics.record_bytes(len, 0, route_id, source_ip),
Direction::Out => self.metrics.record_bytes(0, bytes, route_id, source_ip), Direction::Out => self.metrics.record_bytes(0, len, route_id, source_ip),
} }
} }
} }
impl<B> Drop for CountingBody<B> {
fn drop(&mut self) {
self.report();
}
}
// CountingBody is Unpin because inner is Pin<Box<B>> (always Unpin). // CountingBody is Unpin because inner is Pin<Box<B>> (always Unpin).
impl<B> Unpin for CountingBody<B> {} impl<B> Unpin for CountingBody<B> {}
@@ -118,7 +98,9 @@ where
match this.inner.as_mut().poll_frame(cx) { match this.inner.as_mut().poll_frame(cx) {
Poll::Ready(Some(Ok(frame))) => { Poll::Ready(Some(Ok(frame))) => {
if let Some(data) = frame.data_ref() { if let Some(data) = frame.data_ref() {
this.counted_bytes.fetch_add(data.len() as u64, Ordering::Relaxed); let len = data.len() as u64;
// Report bytes immediately so the 1 Hz throughput sampler sees them
this.report_chunk(len);
// Keep the connection-level idle watchdog alive during body streaming // Keep the connection-level idle watchdog alive during body streaming
if let (Some(activity), Some(start)) = (&this.connection_activity, &this.activity_start) { if let (Some(activity), Some(start)) = (&this.connection_activity, &this.activity_start) {
activity.store(start.elapsed().as_millis() as u64, Ordering::Relaxed); activity.store(start.elapsed().as_millis() as u64, Ordering::Relaxed);
@@ -127,11 +109,7 @@ where
Poll::Ready(Some(Ok(frame))) Poll::Ready(Some(Ok(frame)))
} }
Poll::Ready(Some(Err(e))) => Poll::Ready(Some(Err(e))), Poll::Ready(Some(Err(e))) => Poll::Ready(Some(Err(e))),
Poll::Ready(None) => { Poll::Ready(None) => Poll::Ready(None),
// Body is fully consumed — report now
this.report();
Poll::Ready(None)
}
Poll::Pending => Poll::Pending, Poll::Pending => Poll::Pending,
} }
} }

View File

@@ -910,8 +910,15 @@ impl HttpProxyService {
} }
}; };
// Return sender to pool (body streams lazily, sender is reusable once response head is received) // Note: we do NOT return the sender to the pool here because the response body
self.connection_pool.checkin_h1(pool_key.clone(), sender); // hasn't been fully streamed yet. Pooling a sender while its response body is still
// in-flight risks another request being dispatched on the same connection if is_ready()
// momentarily returns true between chunks. The sender is dropped after this scope,
// and the backend connection remains alive via the spawned conn driver task until
// the response body finishes streaming.
// For small/empty responses, the sender could theoretically be reused, but the safety
// of large streaming responses (e.g. 352MB Docker layers) takes priority.
drop(sender);
self.build_streaming_response(upstream_response, route, route_id, source_ip, conn_activity).await self.build_streaming_response(upstream_response, route, route_id, source_ip, conn_activity).await
} }
@@ -939,7 +946,7 @@ impl HttpProxyService {
h2_builder h2_builder
.timer(hyper_util::rt::TokioTimer::new()) .timer(hyper_util::rt::TokioTimer::new())
.keep_alive_interval(std::time::Duration::from_secs(10)) .keep_alive_interval(std::time::Duration::from_secs(10))
.keep_alive_timeout(std::time::Duration::from_secs(5)) .keep_alive_timeout(std::time::Duration::from_secs(30))
.initial_stream_window_size(2 * 1024 * 1024) .initial_stream_window_size(2 * 1024 * 1024)
.initial_connection_window_size(16 * 1024 * 1024); .initial_connection_window_size(16 * 1024 * 1024);
let (sender, conn): ( let (sender, conn): (
@@ -959,11 +966,18 @@ impl HttpProxyService {
} }
}; };
tokio::spawn(async move { // Spawn the H2 connection driver; proactively evict from pool on exit
if let Err(e) = conn.await { // so the next request gets a fresh connection instead of a dead sender.
debug!("HTTP/2 upstream connection error: {}", e); {
} let pool = Arc::clone(&self.connection_pool);
}); let key = pool_key.clone();
tokio::spawn(async move {
if let Err(e) = conn.await {
debug!("HTTP/2 upstream connection error: {}", e);
}
pool.remove_h2(&key);
});
}
// Clone sender for potential pool registration; register only after first request succeeds // Clone sender for potential pool registration; register only after first request succeeds
let sender_for_pool = sender.clone(); let sender_for_pool = sender.clone();
@@ -1082,7 +1096,7 @@ impl HttpProxyService {
h2_builder h2_builder
.timer(hyper_util::rt::TokioTimer::new()) .timer(hyper_util::rt::TokioTimer::new())
.keep_alive_interval(std::time::Duration::from_secs(10)) .keep_alive_interval(std::time::Duration::from_secs(10))
.keep_alive_timeout(std::time::Duration::from_secs(5)) .keep_alive_timeout(std::time::Duration::from_secs(30))
.initial_stream_window_size(2 * 1024 * 1024) .initial_stream_window_size(2 * 1024 * 1024)
.initial_connection_window_size(16 * 1024 * 1024); .initial_connection_window_size(16 * 1024 * 1024);
let (mut sender, conn): ( let (mut sender, conn): (
@@ -1104,11 +1118,17 @@ impl HttpProxyService {
} }
}; };
tokio::spawn(async move { // Spawn the H2 connection driver; proactively evict from pool on exit.
if let Err(e) = conn.await { {
debug!("H2 retry: upstream connection error: {}", e); let pool = Arc::clone(&self.connection_pool);
} let key = pool_key.clone();
}); tokio::spawn(async move {
if let Err(e) = conn.await {
debug!("H2 retry: upstream connection error: {}", e);
}
pool.remove_h2(&key);
});
}
// Build request with empty body using absolute URI for H2 pseudo-headers // Build request with empty body using absolute URI for H2 pseudo-headers
let scheme = if pool_key.use_tls { "https" } else { "http" }; let scheme = if pool_key.use_tls { "https" } else { "http" };
@@ -1178,7 +1198,7 @@ impl HttpProxyService {
h2_builder h2_builder
.timer(hyper_util::rt::TokioTimer::new()) .timer(hyper_util::rt::TokioTimer::new())
.keep_alive_interval(std::time::Duration::from_secs(10)) .keep_alive_interval(std::time::Duration::from_secs(10))
.keep_alive_timeout(std::time::Duration::from_secs(5)) .keep_alive_timeout(std::time::Duration::from_secs(30))
.initial_stream_window_size(2 * 1024 * 1024) .initial_stream_window_size(2 * 1024 * 1024)
.initial_connection_window_size(16 * 1024 * 1024); .initial_connection_window_size(16 * 1024 * 1024);
let handshake_result = tokio::time::timeout( let handshake_result = tokio::time::timeout(
@@ -1227,11 +1247,17 @@ impl HttpProxyService {
} }
} }
Ok(Ok((mut sender, conn))) => { Ok(Ok((mut sender, conn))) => {
tokio::spawn(async move { // Spawn the H2 connection driver; proactively evict from pool on exit.
if let Err(e) = conn.await { {
debug!("HTTP/2 upstream connection error: {}", e); let pool = Arc::clone(&self.connection_pool);
} let key = pool_key.clone();
}); tokio::spawn(async move {
if let Err(e) = conn.await {
debug!("HTTP/2 upstream connection error: {}", e);
}
pool.remove_h2(&key);
});
}
// Save retry state before consuming parts/body (for bodyless requests like GET) // Save retry state before consuming parts/body (for bodyless requests like GET)
// Clone BEFORE removing Host — H1 fallback needs Host header // Clone BEFORE removing Host — H1 fallback needs Host header
@@ -1425,8 +1451,8 @@ impl HttpProxyService {
} }
}; };
// Return sender to pool for keep-alive reuse // Don't pool the sender while response body is still streaming (same safety as forward_h1_with_sender)
self.connection_pool.checkin_h1(pool_key.clone(), sender); drop(sender);
self.build_streaming_response(upstream_response, route, route_id, source_ip, conn_activity).await self.build_streaming_response(upstream_response, route, route_id, source_ip, conn_activity).await
} }
@@ -1571,6 +1597,19 @@ impl HttpProxyService {
if let Some(headers) = response.headers_mut() { if let Some(headers) = response.headers_mut() {
*headers = resp_parts.headers; *headers = resp_parts.headers;
// Strip hop-by-hop headers from the backend response.
// RFC 9113 §8.2.2 forbids connection-specific headers in HTTP/2 responses;
// forwarding them from an H1 backend can cause H2 stream resets.
// Mirrors the request-path stripping at the forward methods above.
headers.remove("connection");
headers.remove("keep-alive");
headers.remove("proxy-connection");
headers.remove("transfer-encoding");
headers.remove("te");
headers.remove("trailer");
// Note: "upgrade" is intentionally kept — needed for WebSocket 101 responses.
ResponseFilter::apply_headers(route, headers, None); ResponseFilter::apply_headers(route, headers, None);
} }
@@ -1906,59 +1945,89 @@ impl HttpProxyService {
let last_activity = Arc::new(AtomicU64::new(0)); let last_activity = Arc::new(AtomicU64::new(0));
let start = std::time::Instant::now(); let start = std::time::Instant::now();
// Per-connection cancellation token: the watchdog cancels this instead of
// aborting tasks, so the copy loops can shut down gracefully (TLS close_notify).
let ws_cancel = CancellationToken::new();
// For H2 WebSocket: also update the connection-level activity tracker // For H2 WebSocket: also update the connection-level activity tracker
// to prevent the idle watchdog from killing the H2 connection // to prevent the idle watchdog from killing the H2 connection
let conn_act_c2u = conn_activity.as_ref().map(|ca| (Arc::clone(&ca.last_activity), ca.start)); let conn_act_c2u = conn_activity.as_ref().map(|ca| (Arc::clone(&ca.last_activity), ca.start));
let conn_act_u2c = conn_activity.as_ref().map(|ca| (Arc::clone(&ca.last_activity), ca.start)); let conn_act_u2c = conn_activity.as_ref().map(|ca| (Arc::clone(&ca.last_activity), ca.start));
let la1 = Arc::clone(&last_activity); let la1 = Arc::clone(&last_activity);
let metrics_c2u = Arc::clone(&metrics);
let route_c2u = route_id_owned.clone();
let ip_c2u = source_ip_owned.clone();
let wsc1 = ws_cancel.clone();
let c2u = tokio::spawn(async move { let c2u = tokio::spawn(async move {
let mut buf = vec![0u8; 65536]; let mut buf = vec![0u8; 65536];
let mut total = 0u64; let mut total = 0u64;
loop { loop {
let n = match cr.read(&mut buf).await { let n = tokio::select! {
Ok(0) | Err(_) => break, result = cr.read(&mut buf) => match result {
Ok(n) => n, Ok(0) | Err(_) => break,
Ok(n) => n,
},
_ = wsc1.cancelled() => break,
}; };
if uw.write_all(&buf[..n]).await.is_err() { if uw.write_all(&buf[..n]).await.is_err() {
break; break;
} }
total += n as u64; total += n as u64;
metrics_c2u.record_bytes(n as u64, 0, route_c2u.as_deref(), Some(&ip_c2u));
la1.store(start.elapsed().as_millis() as u64, Ordering::Relaxed); la1.store(start.elapsed().as_millis() as u64, Ordering::Relaxed);
if let Some((ref ca, ca_start)) = conn_act_c2u { if let Some((ref ca, ca_start)) = conn_act_c2u {
ca.store(ca_start.elapsed().as_millis() as u64, Ordering::Relaxed); ca.store(ca_start.elapsed().as_millis() as u64, Ordering::Relaxed);
} }
} }
let _ = uw.shutdown().await; // Graceful shutdown with timeout (sends TLS close_notify / TCP FIN)
let _ = tokio::time::timeout(
std::time::Duration::from_secs(2),
uw.shutdown(),
).await;
total total
}); });
let la2 = Arc::clone(&last_activity); let la2 = Arc::clone(&last_activity);
let metrics_u2c = Arc::clone(&metrics);
let route_u2c = route_id_owned.clone();
let ip_u2c = source_ip_owned.clone();
let wsc2 = ws_cancel.clone();
let u2c = tokio::spawn(async move { let u2c = tokio::spawn(async move {
let mut buf = vec![0u8; 65536]; let mut buf = vec![0u8; 65536];
let mut total = 0u64; let mut total = 0u64;
loop { loop {
let n = match ur.read(&mut buf).await { let n = tokio::select! {
Ok(0) | Err(_) => break, result = ur.read(&mut buf) => match result {
Ok(n) => n, Ok(0) | Err(_) => break,
Ok(n) => n,
},
_ = wsc2.cancelled() => break,
}; };
if cw.write_all(&buf[..n]).await.is_err() { if cw.write_all(&buf[..n]).await.is_err() {
break; break;
} }
total += n as u64; total += n as u64;
metrics_u2c.record_bytes(0, n as u64, route_u2c.as_deref(), Some(&ip_u2c));
la2.store(start.elapsed().as_millis() as u64, Ordering::Relaxed); la2.store(start.elapsed().as_millis() as u64, Ordering::Relaxed);
if let Some((ref ca, ca_start)) = conn_act_u2c { if let Some((ref ca, ca_start)) = conn_act_u2c {
ca.store(ca_start.elapsed().as_millis() as u64, Ordering::Relaxed); ca.store(ca_start.elapsed().as_millis() as u64, Ordering::Relaxed);
} }
} }
let _ = cw.shutdown().await; // Graceful shutdown with timeout (sends TLS close_notify / TCP FIN)
let _ = tokio::time::timeout(
std::time::Duration::from_secs(2),
cw.shutdown(),
).await;
total total
}); });
// Watchdog: monitors inactivity, max lifetime, and cancellation // Watchdog: monitors inactivity, max lifetime, and cancellation.
// First cancels the per-connection token for graceful shutdown (close_notify/FIN),
// then falls back to abort if the tasks are stuck (e.g. on a blocked write_all).
let la_watch = Arc::clone(&last_activity); let la_watch = Arc::clone(&last_activity);
let c2u_handle = c2u.abort_handle(); let c2u_abort = c2u.abort_handle();
let u2c_handle = u2c.abort_handle(); let u2c_abort = u2c.abort_handle();
let inactivity_timeout = ws_inactivity_timeout; let inactivity_timeout = ws_inactivity_timeout;
let max_lifetime = ws_max_lifetime; let max_lifetime = ws_max_lifetime;
@@ -1970,8 +2039,6 @@ impl HttpProxyService {
_ = tokio::time::sleep(check_interval) => {} _ = tokio::time::sleep(check_interval) => {}
_ = cancel.cancelled() => { _ = cancel.cancelled() => {
debug!("WebSocket tunnel cancelled by shutdown"); debug!("WebSocket tunnel cancelled by shutdown");
c2u_handle.abort();
u2c_handle.abort();
break; break;
} }
} }
@@ -1979,8 +2046,6 @@ impl HttpProxyService {
// Check max lifetime // Check max lifetime
if start.elapsed() >= max_lifetime { if start.elapsed() >= max_lifetime {
debug!("WebSocket tunnel exceeded max lifetime, closing"); debug!("WebSocket tunnel exceeded max lifetime, closing");
c2u_handle.abort();
u2c_handle.abort();
break; break;
} }
@@ -1990,13 +2055,18 @@ impl HttpProxyService {
let elapsed_since_activity = start.elapsed().as_millis() as u64 - current; let elapsed_since_activity = start.elapsed().as_millis() as u64 - current;
if elapsed_since_activity >= inactivity_timeout.as_millis() as u64 { if elapsed_since_activity >= inactivity_timeout.as_millis() as u64 {
debug!("WebSocket tunnel inactive for {}ms, closing", elapsed_since_activity); debug!("WebSocket tunnel inactive for {}ms, closing", elapsed_since_activity);
c2u_handle.abort();
u2c_handle.abort();
break; break;
} }
} }
last_seen = current; last_seen = current;
} }
// Phase 1: Signal copy loops to exit gracefully (allows close_notify/FIN)
ws_cancel.cancel();
// Phase 2: Wait for graceful shutdown (2s shutdown timeout + 2s margin)
tokio::time::sleep(std::time::Duration::from_secs(4)).await;
// Phase 3: Force-abort if still stuck (e.g. blocked on write_all)
c2u_abort.abort();
u2c_abort.abort();
}); });
let bytes_in = c2u.await.unwrap_or(0); let bytes_in = c2u.await.unwrap_or(0);
@@ -2006,9 +2076,7 @@ impl HttpProxyService {
debug!("WebSocket tunnel closed: {} bytes in, {} bytes out", bytes_in, bytes_out); debug!("WebSocket tunnel closed: {} bytes in, {} bytes out", bytes_in, bytes_out);
upstream_selector.connection_ended(&upstream_key_owned); upstream_selector.connection_ended(&upstream_key_owned);
if let Some(ref rid) = route_id_owned { // Bytes already reported per-chunk in the copy loops above
metrics.record_bytes(bytes_in, bytes_out, Some(rid.as_str()), Some(&source_ip_owned));
}
}); });
let body: BoxBody<Bytes, hyper::Error> = BoxBody::new( let body: BoxBody<Bytes, hyper::Error> = BoxBody::new(

View File

@@ -97,16 +97,25 @@ pub async fn forward_bidirectional_with_timeouts(
let last_activity = Arc::new(AtomicU64::new(0)); let last_activity = Arc::new(AtomicU64::new(0));
let start = std::time::Instant::now(); let start = std::time::Instant::now();
// Per-connection cancellation token: the watchdog cancels this instead of
// aborting tasks, so the copy loops can shut down gracefully (TCP FIN instead
// of RST, TLS close_notify if the stream is TLS-wrapped).
let conn_cancel = CancellationToken::new();
let la1 = Arc::clone(&last_activity); let la1 = Arc::clone(&last_activity);
let initial_len = initial_data.map_or(0u64, |d| d.len() as u64); let initial_len = initial_data.map_or(0u64, |d| d.len() as u64);
let metrics_c2b = metrics.clone(); let metrics_c2b = metrics.clone();
let cc1 = conn_cancel.clone();
let c2b = tokio::spawn(async move { let c2b = tokio::spawn(async move {
let mut buf = vec![0u8; 65536]; let mut buf = vec![0u8; 65536];
let mut total = initial_len; let mut total = initial_len;
loop { loop {
let n = match client_read.read(&mut buf).await { let n = tokio::select! {
Ok(0) | Err(_) => break, result = client_read.read(&mut buf) => match result {
Ok(n) => n, Ok(0) | Err(_) => break,
Ok(n) => n,
},
_ = cc1.cancelled() => break,
}; };
if backend_write.write_all(&buf[..n]).await.is_err() { if backend_write.write_all(&buf[..n]).await.is_err() {
break; break;
@@ -117,19 +126,27 @@ pub async fn forward_bidirectional_with_timeouts(
ctx.collector.record_bytes(n as u64, 0, ctx.route_id.as_deref(), ctx.source_ip.as_deref()); ctx.collector.record_bytes(n as u64, 0, ctx.route_id.as_deref(), ctx.source_ip.as_deref());
} }
} }
let _ = backend_write.shutdown().await; // Graceful shutdown with timeout (sends TCP FIN / TLS close_notify)
let _ = tokio::time::timeout(
std::time::Duration::from_secs(2),
backend_write.shutdown(),
).await;
total total
}); });
let la2 = Arc::clone(&last_activity); let la2 = Arc::clone(&last_activity);
let metrics_b2c = metrics; let metrics_b2c = metrics;
let cc2 = conn_cancel.clone();
let b2c = tokio::spawn(async move { let b2c = tokio::spawn(async move {
let mut buf = vec![0u8; 65536]; let mut buf = vec![0u8; 65536];
let mut total = 0u64; let mut total = 0u64;
loop { loop {
let n = match backend_read.read(&mut buf).await { let n = tokio::select! {
Ok(0) | Err(_) => break, result = backend_read.read(&mut buf) => match result {
Ok(n) => n, Ok(0) | Err(_) => break,
Ok(n) => n,
},
_ = cc2.cancelled() => break,
}; };
if client_write.write_all(&buf[..n]).await.is_err() { if client_write.write_all(&buf[..n]).await.is_err() {
break; break;
@@ -140,14 +157,20 @@ pub async fn forward_bidirectional_with_timeouts(
ctx.collector.record_bytes(0, n as u64, ctx.route_id.as_deref(), ctx.source_ip.as_deref()); ctx.collector.record_bytes(0, n as u64, ctx.route_id.as_deref(), ctx.source_ip.as_deref());
} }
} }
let _ = client_write.shutdown().await; // Graceful shutdown with timeout (sends TCP FIN / TLS close_notify)
let _ = tokio::time::timeout(
std::time::Duration::from_secs(2),
client_write.shutdown(),
).await;
total total
}); });
// Watchdog: inactivity, max lifetime, and cancellation // Watchdog: inactivity, max lifetime, and cancellation.
// First cancels the per-connection token for graceful shutdown (FIN/close_notify),
// then falls back to abort if the tasks are stuck (e.g. on a blocked write_all).
let la_watch = Arc::clone(&last_activity); let la_watch = Arc::clone(&last_activity);
let c2b_handle = c2b.abort_handle(); let c2b_abort = c2b.abort_handle();
let b2c_handle = b2c.abort_handle(); let b2c_abort = b2c.abort_handle();
let watchdog = tokio::spawn(async move { let watchdog = tokio::spawn(async move {
let check_interval = std::time::Duration::from_secs(5); let check_interval = std::time::Duration::from_secs(5);
let mut last_seen = 0u64; let mut last_seen = 0u64;
@@ -155,16 +178,12 @@ pub async fn forward_bidirectional_with_timeouts(
tokio::select! { tokio::select! {
_ = cancel.cancelled() => { _ = cancel.cancelled() => {
debug!("Connection cancelled by shutdown"); debug!("Connection cancelled by shutdown");
c2b_handle.abort();
b2c_handle.abort();
break; break;
} }
_ = tokio::time::sleep(check_interval) => { _ = tokio::time::sleep(check_interval) => {
// Check max lifetime // Check max lifetime
if start.elapsed() >= max_lifetime { if start.elapsed() >= max_lifetime {
debug!("Connection exceeded max lifetime, closing"); debug!("Connection exceeded max lifetime, closing");
c2b_handle.abort();
b2c_handle.abort();
break; break;
} }
@@ -174,8 +193,6 @@ pub async fn forward_bidirectional_with_timeouts(
let elapsed_since_activity = start.elapsed().as_millis() as u64 - current; let elapsed_since_activity = start.elapsed().as_millis() as u64 - current;
if elapsed_since_activity >= inactivity_timeout.as_millis() as u64 { if elapsed_since_activity >= inactivity_timeout.as_millis() as u64 {
debug!("Connection inactive for {}ms, closing", elapsed_since_activity); debug!("Connection inactive for {}ms, closing", elapsed_since_activity);
c2b_handle.abort();
b2c_handle.abort();
break; break;
} }
} }
@@ -183,6 +200,13 @@ pub async fn forward_bidirectional_with_timeouts(
} }
} }
} }
// Phase 1: Signal copy loops to exit gracefully (allows FIN/close_notify)
conn_cancel.cancel();
// Phase 2: Wait for graceful shutdown (2s shutdown timeout + 2s margin)
tokio::time::sleep(std::time::Duration::from_secs(4)).await;
// Phase 3: Force-abort if still stuck (e.g. blocked on write_all)
c2b_abort.abort();
b2c_abort.abort();
}); });
let bytes_in = c2b.await.unwrap_or(0); let bytes_in = c2b.await.unwrap_or(0);

View File

@@ -465,21 +465,19 @@ impl TcpListenerManager {
Ok((stream, peer_addr)) => { Ok((stream, peer_addr)) => {
let ip = peer_addr.ip(); let ip = peer_addr.ip();
// Global connection limit — acquire semaphore permit with timeout // Global connection limit — non-blocking check.
let permit = match tokio::time::timeout( // MUST NOT block the accept loop: a blocking acquire would stall
std::time::Duration::from_secs(5), // ALL connections to this port (not just the one over limit), because
conn_semaphore.clone().acquire_owned(), // listener.accept() is not polled while we await the semaphore.
).await { let permit = match conn_semaphore.clone().try_acquire_owned() {
Ok(Ok(permit)) => permit, Ok(permit) => permit,
Ok(Err(_)) => { Err(tokio::sync::TryAcquireError::NoPermits) => {
// Semaphore closed — shouldn't happen, but be safe warn!("Global connection limit reached, dropping connection from {}", peer_addr);
debug!("Connection semaphore closed, dropping connection from {}", peer_addr);
drop(stream); drop(stream);
continue; continue;
} }
Err(_) => { Err(tokio::sync::TryAcquireError::Closed) => {
// Timeout — global limit reached warn!("Connection semaphore closed, dropping connection from {}", peer_addr);
debug!("Global connection limit reached, dropping connection from {}", peer_addr);
drop(stream); drop(stream);
continue; continue;
} }
@@ -487,7 +485,7 @@ impl TcpListenerManager {
// Check per-IP limits and rate limiting // Check per-IP limits and rate limiting
if !conn_tracker.try_accept(&ip) { if !conn_tracker.try_accept(&ip) {
debug!("Rejected connection from {} (per-IP limit or rate limit)", peer_addr); warn!("Rejected connection from {} (per-IP limit or rate limit)", peer_addr);
drop(stream); drop(stream);
drop(permit); drop(permit);
continue; continue;
@@ -519,7 +517,7 @@ impl TcpListenerManager {
stream, port, peer_addr, rm, m, tc, sa, hp, cc, cn, sr, rc, stream, port, peer_addr, rm, m, tc, sa, hp, cc, cn, sr, rc,
).await; ).await;
if let Err(e) = result { if let Err(e) = result {
debug!("Connection error from {}: {}", peer_addr, e); warn!("Connection error from {}: {}", peer_addr, e);
} }
}); });
} }
@@ -664,7 +662,7 @@ impl TcpListenerManager {
if !rustproxy_http::request_filter::RequestFilter::check_ip_security( if !rustproxy_http::request_filter::RequestFilter::check_ip_security(
security, &peer_addr.ip(), security, &peer_addr.ip(),
) { ) {
debug!("Connection from {} blocked by route security", peer_addr); warn!("Connection from {} blocked by route security", peer_addr);
return Ok(()); return Ok(());
} }
} }
@@ -810,7 +808,7 @@ impl TcpListenerManager {
let route_match = match route_match { let route_match = match route_match {
Some(rm) => rm, Some(rm) => rm,
None => { None => {
debug!("No route matched for port {} domain {:?}", port, domain); warn!("No route matched for port {} domain {:?} from {}", port, domain, peer_addr);
if is_http { if is_http {
// Send a proper HTTP error instead of dropping the connection // Send a proper HTTP error instead of dropping the connection
use tokio::io::AsyncWriteExt; use tokio::io::AsyncWriteExt;
@@ -844,7 +842,7 @@ impl TcpListenerManager {
security, security,
&peer_addr.ip(), &peer_addr.ip(),
) { ) {
debug!("Connection from {} blocked by route security", peer_addr); warn!("Connection from {} blocked by route security", peer_addr);
return Ok(()); return Ok(());
} }
} }
@@ -987,13 +985,18 @@ impl TcpListenerManager {
Err(_) => return Err("TLS handshake timeout".into()), Err(_) => return Err("TLS handshake timeout".into()),
}; };
// Peek at decrypted data to determine if HTTP // Peek at decrypted data to determine if HTTP.
// Timeout prevents connection leak if client completes TLS
// but never sends application data (scanners, health probes, slow-loris).
let mut buf_stream = tokio::io::BufReader::new(tls_stream); let mut buf_stream = tokio::io::BufReader::new(tls_stream);
let peeked = { let peeked = {
use tokio::io::AsyncBufReadExt; use tokio::io::AsyncBufReadExt;
match buf_stream.fill_buf().await { match tokio::time::timeout(
Ok(data) => sni_parser::is_http(data), std::time::Duration::from_millis(conn_config.initial_data_timeout_ms),
Err(_) => false, buf_stream.fill_buf(),
).await {
Ok(Ok(data)) => sni_parser::is_http(data),
Ok(Err(_)) | Err(_) => false,
} }
}; };
@@ -1062,13 +1065,18 @@ impl TcpListenerManager {
Err(_) => return Err("TLS handshake timeout".into()), Err(_) => return Err("TLS handshake timeout".into()),
}; };
// Peek at decrypted data to detect protocol // Peek at decrypted data to detect protocol.
// Timeout prevents connection leak if client completes TLS
// but never sends application data (scanners, health probes, slow-loris).
let mut buf_stream = tokio::io::BufReader::new(tls_stream); let mut buf_stream = tokio::io::BufReader::new(tls_stream);
let is_http_data = { let is_http_data = {
use tokio::io::AsyncBufReadExt; use tokio::io::AsyncBufReadExt;
match buf_stream.fill_buf().await { match tokio::time::timeout(
Ok(data) => sni_parser::is_http(data), std::time::Duration::from_millis(conn_config.initial_data_timeout_ms),
Err(_) => false, buf_stream.fill_buf(),
).await {
Ok(Ok(data)) => sni_parser::is_http(data),
Ok(Err(_)) | Err(_) => false,
} }
}; };
@@ -1396,15 +1404,24 @@ impl TcpListenerManager {
let last_activity = Arc::new(AtomicU64::new(0)); let last_activity = Arc::new(AtomicU64::new(0));
let start = std::time::Instant::now(); let start = std::time::Instant::now();
// Per-connection cancellation token: the watchdog cancels this instead of
// aborting tasks, so the copy loops can shut down gracefully (TLS close_notify
// for terminate/reencrypt mode, TCP FIN for passthrough mode).
let conn_cancel = CancellationToken::new();
let la1 = Arc::clone(&last_activity); let la1 = Arc::clone(&last_activity);
let metrics_c2b = metrics.clone(); let metrics_c2b = metrics.clone();
let cc1 = conn_cancel.clone();
let c2b = tokio::spawn(async move { let c2b = tokio::spawn(async move {
let mut buf = vec![0u8; 65536]; let mut buf = vec![0u8; 65536];
let mut total = 0u64; let mut total = 0u64;
loop { loop {
let n = match client_read.read(&mut buf).await { let n = tokio::select! {
Ok(0) | Err(_) => break, result = client_read.read(&mut buf) => match result {
Ok(n) => n, Ok(0) | Err(_) => break,
Ok(n) => n,
},
_ = cc1.cancelled() => break,
}; };
if backend_write.write_all(&buf[..n]).await.is_err() { if backend_write.write_all(&buf[..n]).await.is_err() {
break; break;
@@ -1418,19 +1435,27 @@ impl TcpListenerManager {
ctx.collector.record_bytes(n as u64, 0, ctx.route_id.as_deref(), ctx.source_ip.as_deref()); ctx.collector.record_bytes(n as u64, 0, ctx.route_id.as_deref(), ctx.source_ip.as_deref());
} }
} }
let _ = backend_write.shutdown().await; // Graceful shutdown with timeout (sends TLS close_notify / TCP FIN)
let _ = tokio::time::timeout(
std::time::Duration::from_secs(2),
backend_write.shutdown(),
).await;
total total
}); });
let la2 = Arc::clone(&last_activity); let la2 = Arc::clone(&last_activity);
let metrics_b2c = metrics; let metrics_b2c = metrics;
let cc2 = conn_cancel.clone();
let b2c = tokio::spawn(async move { let b2c = tokio::spawn(async move {
let mut buf = vec![0u8; 65536]; let mut buf = vec![0u8; 65536];
let mut total = 0u64; let mut total = 0u64;
loop { loop {
let n = match backend_read.read(&mut buf).await { let n = tokio::select! {
Ok(0) | Err(_) => break, result = backend_read.read(&mut buf) => match result {
Ok(n) => n, Ok(0) | Err(_) => break,
Ok(n) => n,
},
_ = cc2.cancelled() => break,
}; };
if client_write.write_all(&buf[..n]).await.is_err() { if client_write.write_all(&buf[..n]).await.is_err() {
break; break;
@@ -1444,14 +1469,20 @@ impl TcpListenerManager {
ctx.collector.record_bytes(0, n as u64, ctx.route_id.as_deref(), ctx.source_ip.as_deref()); ctx.collector.record_bytes(0, n as u64, ctx.route_id.as_deref(), ctx.source_ip.as_deref());
} }
} }
let _ = client_write.shutdown().await; // Graceful shutdown with timeout (sends TLS close_notify / TCP FIN)
let _ = tokio::time::timeout(
std::time::Duration::from_secs(2),
client_write.shutdown(),
).await;
total total
}); });
// Watchdog task: check for inactivity, max lifetime, and cancellation // Watchdog task: check for inactivity, max lifetime, and cancellation.
// First cancels the per-connection token for graceful shutdown (close_notify/FIN),
// then falls back to abort if the tasks are stuck (e.g. on a blocked write_all).
let la_watch = Arc::clone(&last_activity); let la_watch = Arc::clone(&last_activity);
let c2b_handle = c2b.abort_handle(); let c2b_abort = c2b.abort_handle();
let b2c_handle = b2c.abort_handle(); let b2c_abort = b2c.abort_handle();
let watchdog = tokio::spawn(async move { let watchdog = tokio::spawn(async move {
let check_interval = std::time::Duration::from_secs(5); let check_interval = std::time::Duration::from_secs(5);
let mut last_seen = 0u64; let mut last_seen = 0u64;
@@ -1459,16 +1490,12 @@ impl TcpListenerManager {
tokio::select! { tokio::select! {
_ = cancel.cancelled() => { _ = cancel.cancelled() => {
debug!("Split-stream connection cancelled by shutdown"); debug!("Split-stream connection cancelled by shutdown");
c2b_handle.abort();
b2c_handle.abort();
break; break;
} }
_ = tokio::time::sleep(check_interval) => { _ = tokio::time::sleep(check_interval) => {
// Check max lifetime // Check max lifetime
if start.elapsed() >= max_lifetime { if start.elapsed() >= max_lifetime {
debug!("Connection exceeded max lifetime, closing"); debug!("Connection exceeded max lifetime, closing");
c2b_handle.abort();
b2c_handle.abort();
break; break;
} }
@@ -1479,8 +1506,6 @@ impl TcpListenerManager {
let elapsed_since_activity = start.elapsed().as_millis() as u64 - current; let elapsed_since_activity = start.elapsed().as_millis() as u64 - current;
if elapsed_since_activity >= inactivity_timeout.as_millis() as u64 { if elapsed_since_activity >= inactivity_timeout.as_millis() as u64 {
debug!("Connection inactive for {}ms, closing", elapsed_since_activity); debug!("Connection inactive for {}ms, closing", elapsed_since_activity);
c2b_handle.abort();
b2c_handle.abort();
break; break;
} }
} }
@@ -1488,6 +1513,13 @@ impl TcpListenerManager {
} }
} }
} }
// Phase 1: Signal copy loops to exit gracefully (allows close_notify/FIN)
conn_cancel.cancel();
// Phase 2: Wait for graceful shutdown (2s shutdown timeout + 2s margin)
tokio::time::sleep(std::time::Duration::from_secs(4)).await;
// Phase 3: Force-abort if still stuck (e.g. blocked on write_all)
c2b_abort.abort();
b2c_abort.abort();
}); });
let bytes_in = c2b.await.unwrap_or(0); let bytes_in = c2b.await.unwrap_or(0);

View File

@@ -632,15 +632,13 @@ impl RustProxy {
let new_manager = Arc::new(new_manager); let new_manager = Arc::new(new_manager);
self.route_table.store(Arc::clone(&new_manager)); self.route_table.store(Arc::clone(&new_manager));
// Update listener manager // Update listener manager.
// IMPORTANT: TLS configs must be swapped BEFORE the route manager so that
// new routes only become visible after their certs are loaded. The reverse
// order (routes first) creates a window where connections match new routes
// but get the old TLS acceptor, causing cert mismatches.
if let Some(ref mut listener) = self.listener_manager { if let Some(ref mut listener) = self.listener_manager {
listener.update_route_manager(Arc::clone(&new_manager)); // 1. Update TLS configs first (so new certs are available before new routes)
// Cancel connections on routes that were removed or disabled
listener.invalidate_removed_routes(&active_route_ids);
// Prune HTTP proxy caches (rate limiters, regex cache, round-robin counters)
listener.prune_http_proxy_caches(&active_route_ids);
// Update TLS configs
let mut tls_configs = Self::extract_tls_configs(&routes); let mut tls_configs = Self::extract_tls_configs(&routes);
if let Some(ref cm_arc) = self.cert_manager { if let Some(ref cm_arc) = self.cert_manager {
let cm = cm_arc.lock().await; let cm = cm_arc.lock().await;
@@ -661,6 +659,13 @@ impl RustProxy {
} }
listener.set_tls_configs(tls_configs); listener.set_tls_configs(tls_configs);
// 2. Now swap the route manager (new routes become visible with certs already loaded)
listener.update_route_manager(Arc::clone(&new_manager));
// Cancel connections on routes that were removed or disabled
listener.invalidate_removed_routes(&active_route_ids);
// Prune HTTP proxy caches (rate limiters, regex cache, round-robin counters)
listener.prune_http_proxy_caches(&active_route_ids);
// Add new ports // Add new ports
for port in &new_ports { for port in &new_ports {
if !old_ports.contains(port) { if !old_ports.contains(port) {

View File

@@ -3,6 +3,6 @@
*/ */
export const commitinfo = { export const commitinfo = {
name: '@push.rocks/smartproxy', name: '@push.rocks/smartproxy',
version: '25.11.1', version: '25.11.7',
description: 'A powerful proxy package with unified route-based configuration for high traffic management. Features include SSL/TLS support, flexible routing patterns, WebSocket handling, advanced security options, and automatic ACME certificate management.' description: 'A powerful proxy package with unified route-based configuration for high traffic management. Features include SSL/TLS support, flexible routing patterns, WebSocket handling, advanced security options, and automatic ACME certificate management.'
} }