1.0.28

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushrocks/smartpuppeteer",
-  "version": "1.0.22",
+  "version": "1.0.28",
   "private": false,
   "description": "simplified access to puppeteer",
   "main": "dist_ts/index.js",
@@ -13,7 +13,7 @@
     "format": "(gitzone format)"
   },
   "devDependencies": {
-    "@gitzone/tsbuild": "^2.1.25",
+    "@gitzone/tsbuild": "^2.1.26",
     "@gitzone/tstest": "^1.0.54",
     "@pushrocks/tapbundle": "^3.2.14",
     "@types/node": "^16.6.1",
@@ -23,8 +23,8 @@
   "dependencies": {
     "@pushrocks/smartdelay": "^2.0.13",
     "@pushrocks/smartenv": "^4.0.16",
-    "@types/puppeteer": "^5.4.4",
+    "puppeteer": "^10.2.0",
-    "puppeteer": "^10.2.0"
+    "tree-kill": "^1.2.2"
   },
   "files": [
     "ts/**/*",

test/test.ts

@@ -5,7 +5,15 @@ tap.test('first test', async (tools) => {
   const headlessBrowser = await smartpuppeteer.getEnvAwareBrowserInstance({
     forceNoSandbox: true,
   });
+  const page = await headlessBrowser.newPage();
   await headlessBrowser.close();
 });
 
+tap.test('should get and stop an Incognito browser', async () => {
+  const incognitoInstance = new smartpuppeteer.IncognitoBrowser();
+  await incognitoInstance.start();
+  const page = await incognitoInstance.browser.newPage();
+  await incognitoInstance.stop();
+})
+
 tap.start();

ts/smartpuppeteer.classes.incognitobrowser.ts

@@ -13,7 +13,7 @@ export class IncognitoBrowser {
   public async start() {
     this.status = 'started';
     this.browser = await getEnvAwareBrowserInstance();
-    this.browser.addListener('disconnected', async (eventArg) => {
+    this.browser.on('disconnected', async (eventArg) => {
       try {
         this.browser.removeAllListeners();
       } catch (err) {}
@@ -28,6 +28,7 @@ export class IncognitoBrowser {
    */
   public async stop() {
     this.status = 'stopped';
+    plugins.treeKill(this.browser.process().pid, 'SIGKILL');
     await this.browser.close();
   }
 

ts/smartpuppeteer.plugins.ts

@@ -11,5 +11,6 @@ export { smartdelay, smartenv };
 
 // third party scope
 import puppeteer from 'puppeteer';
+import treeKill from 'tree-kill';
 
-export { puppeteer };
+export { puppeteer, treeKill };