1.2.13

.gitlab-ci.yml

@@ -12,6 +12,9 @@ stages:
   - release
   - metadata
 
+before_script:
+  - npm install -g @shipzone/npmci
+
 # ====================
 # security stage
 # ====================
@@ -36,6 +39,7 @@ auditProductionDependencies:
     - npmci command npm audit --audit-level=high --only=prod --production
   tags:
     - docker
+  allow_failure: true
 
 auditDevDependencies:
   image: registry.gitlab.com/hosttoday/ht-docker-node:npmci

.vscode/launch.json

@@ -2,28 +2,10 @@
   "version": "0.2.0",
   "configurations": [
     {
-      "name": "current file",
+      "command": "npm test",
-      "type": "node",
+      "name": "Run npm test",
       "request": "launch",
-      "args": [
+      "type": "node-terminal"
-        "${relativeFile}"
-      ],
-      "runtimeArgs": ["-r", "@gitzone/tsrun"],
-      "cwd": "${workspaceRoot}",
-      "protocol": "inspector",
-      "internalConsoleOptions": "openOnSessionStart"
-    },
-    {
-      "name": "test.ts",
-      "type": "node",
-      "request": "launch",
-      "args": [
-        "test/test.ts"
-      ],
-      "runtimeArgs": ["-r", "@gitzone/tsrun"],
-      "cwd": "${workspaceRoot}",
-      "protocol": "inspector",
-      "internalConsoleOptions": "openOnSessionStart"
     }
   ]
 }

npmextra.json

@@ -5,7 +5,7 @@
       "githost": "gitlab.com",
       "gitscope": "pushrocks",
       "gitrepo": "smartsocket",
-      "shortDescription": "easy and secure websocket communication",
+      "description": "easy and secure websocket communication",
       "npmPackagename": "@pushrocks/smartsocket",
       "license": "MIT",
       "projectDomain": "push.rocks"

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushrocks/smartsocket",
-  "version": "1.2.4",
+  "version": "1.2.13",
   "description": "easy and secure websocket communication",
   "main": "dist_ts/index.js",
   "typings": "dist_ts/index.d.ts",
@@ -22,26 +22,26 @@
     "@apiglobal/typedrequest-interfaces": "^1.0.15",
     "@pushrocks/isohash": "^1.0.2",
     "@pushrocks/isounique": "^1.0.4",
-    "@pushrocks/lik": "^4.0.20",
+    "@pushrocks/lik": "^5.0.0",
-    "@pushrocks/smartdelay": "^2.0.10",
+    "@pushrocks/smartdelay": "^2.0.13",
     "@pushrocks/smartenv": "^4.0.16",
-    "@pushrocks/smartexpress": "^3.0.100",
+    "@pushrocks/smartexpress": "^3.0.108",
-    "@pushrocks/smartjson": "^4.0.5",
+    "@pushrocks/smartjson": "^4.0.6",
-    "@pushrocks/smartlog": "^2.0.39",
+    "@pushrocks/smartlog": "^2.0.44",
-    "@pushrocks/smartpromise": "^3.1.3",
+    "@pushrocks/smartpromise": "^3.1.6",
     "@pushrocks/smartrx": "^2.0.19",
-    "@pushrocks/smarttime": "^3.0.38",
+    "@pushrocks/smarttime": "^3.0.43",
-    "@types/socket.io": "^2.1.13",
+    "@types/socket.io": "^3.0.2",
-    "@types/socket.io-client": "^1.4.35",
+    "@types/socket.io-client": "^3.0.0",
     "socket.io": "^3.1.0",
     "socket.io-client": "^3.1.0"
   },
   "devDependencies": {
-    "@gitzone/tsbuild": "^2.1.25",
+    "@gitzone/tsbuild": "^2.1.28",
-    "@gitzone/tsrun": "^1.2.12",
+    "@gitzone/tsrun": "^1.2.18",
-    "@gitzone/tstest": "^1.0.52",
+    "@gitzone/tstest": "^1.0.60",
-    "@pushrocks/tapbundle": "^3.2.10",
+    "@pushrocks/tapbundle": "^3.2.15",
-    "@types/node": "^14.14.22",
+    "@types/node": "^17.0.9",
     "tslint": "^6.1.3",
     "tslint-config-prettier": "^1.18.0"
   },

test/common/test.ts

@@ -1 +0,0 @@
-console.log('TODO');

test/test.expressserver.ts

@@ -8,7 +8,6 @@ import smartsocket = require('../ts/index');
 
 let testSmartsocket: smartsocket.Smartsocket;
 let testSmartsocketClient: smartsocket.SmartsocketClient;
-let testSocketRole1: smartsocket.SocketRole;
 let testSocketFunction1: smartsocket.SocketFunction<any>;
 let myseServer: smartexpress.Server;
 
@@ -18,7 +17,7 @@ const testConfig = {
 
 // class smartsocket
 tap.test('should create a new smartsocket', async () => {
-  testSmartsocket = new smartsocket.Smartsocket({ port: testConfig.port });
+  testSmartsocket = new smartsocket.Smartsocket({ alias: 'testserver', port: testConfig.port });
   expect(testSmartsocket).be.instanceOf(smartsocket.Smartsocket);
 });
 
@@ -34,19 +33,10 @@ tap.test('Should accept an smartExpressServer as server', async () => {
   await myseServer.start();
 });
 
-// class socketrole
-tap.test('should add a socketrole', async () => {
-  testSocketRole1 = new smartsocket.SocketRole({
-    name: 'testRole1',
-    passwordHash: await isohash.sha256FromString('testPassword'),
-  });
-  testSmartsocket.addSocketRoles([testSocketRole1]);
-});
 
 // class SocketFunction
 tap.test('should register a new Function', async () => {
   testSocketFunction1 = new smartsocket.SocketFunction({
-    allowedRoles: [testSocketRole1],
     funcDef: async (dataArg, socketConnectionArg) => {
       return dataArg;
     },
@@ -65,12 +55,9 @@ tap.test('should react to a new websocket connection from client', async () => {
   testSmartsocketClient = new smartsocket.SmartsocketClient({
     port: testConfig.port,
     url: 'http://localhost',
-    password: 'testPassword',
     alias: 'testClient1',
-    role: 'testRole1',
   });
   testSmartsocketClient.addSocketFunction(testSocketFunction1);
-  console.log(testSmartsocketClient.socketFunctions);
   await testSmartsocketClient.connect();
 });
 

test/test.reconnect.ts

@@ -0,0 +1,5 @@
+import { tap, expect } from '@pushrocks/tapbundle';
+
+tap.test('should run a test', async () => {});
+
+tap.start();

test/test.tagging.ts

@@ -7,7 +7,6 @@ import * as isohash from '@pushrocks/isohash';
 let testSmartsocket: smartsocket.Smartsocket;
 let testSmartsocketClient: smartsocket.SmartsocketClient;
 let testSocketConnection: smartsocket.SocketConnection;
-let testSocketRole1: smartsocket.SocketRole;
 let testSocketFunctionForServer: smartsocket.SocketFunction<any>;
 let testSocketFunctionClient: smartsocket.SocketFunction<any>;
 
@@ -37,23 +36,13 @@ const testConfig = {
 
 // class smartsocket
 tap.test('should create a new smartsocket', async () => {
-  testSmartsocket = new smartsocket.Smartsocket({ port: testConfig.port });
+  testSmartsocket = new smartsocket.Smartsocket({ alias: 'testserver2', port: testConfig.port });
   expect(testSmartsocket).be.instanceOf(smartsocket.Smartsocket);
 });
 
-// class socketrole
-tap.test('should add a socketrole', async () => {
-  testSocketRole1 = new smartsocket.SocketRole({
-    name: 'testRole1',
-    passwordHash: await isohash.sha256FromString('testPassword'),
-  });
-  testSmartsocket.addSocketRoles([testSocketRole1]);
-});
-
 // class SocketFunction
 tap.test('should register a new Function', async () => {
   testSocketFunctionForServer = new smartsocket.SocketFunction({
-    allowedRoles: [testSocketRole1],
     funcDef: async (dataArg, socketConnectionArg) => {
       return dataArg;
     },
@@ -62,7 +51,6 @@ tap.test('should register a new Function', async () => {
   testSmartsocket.addSocketFunction(testSocketFunctionForServer);
 
   testSocketFunctionClient = new smartsocket.SocketFunction({
-    allowedRoles: [],
     funcDef: async (dataArg, socketConnectionArg) => {
       return dataArg;
     },
@@ -81,25 +69,38 @@ tap.test('should react to a new websocket connection from client', async () => {
   testSmartsocketClient = new smartsocket.SmartsocketClient({
     port: testConfig.port,
     url: 'http://localhost',
-    password: 'testPassword',
     alias: 'testClient1',
-    role: 'testRole1',
   });
   testSmartsocketClient.addSocketFunction(testSocketFunctionClient);
   console.log(testSmartsocketClient.socketFunctions);
   await testSmartsocketClient.connect();
 });
 
-tap.test('should be able to tag a connection', async (tools) => {
+tap.test('should be able to tag a connection from client', async (tools) => {
   await testSmartsocketClient.addTag({
     id: 'awesome',
-    payload: 'yes'
+    payload: 'yes',
   });
-  const tagOnServerSide = await testSmartsocket.socketConnections.find((socketConnection) => {
+  const tagOnServerSide = await testSmartsocket.socketConnections
-    return true;
+    .findSync((socketConnection) => {
-  }).getTagById('awesome');
+      return true;
+    })
+    .getTagById('awesome');
   expect(tagOnServerSide.payload).to.equal('yes');
-})
+});
+
+tap.test('should be able to tag a connection from server', async (tools) => {
+  await testSmartsocket.socketConnections
+    .findSync((socketConnection) => {
+      return true;
+    })
+    .addTag({
+      id: 'awesome2',
+      payload: 'absolutely',
+    });
+  const tagOnClientSide = await testSmartsocketClient.socketConnection.getTagById('awesome2');
+  expect(tagOnClientSide.payload).to.equal('absolutely');
+});
 
 tap.test('2 clients should connect in parallel', async () => {
   // TODO: implement parallel test
@@ -119,7 +120,7 @@ tap.test('should be able to make a functionCall from server to client', async ()
     {
       hi: 'hi there from server',
     },
-    testSmartsocket.socketConnections.find((socketConnection) => {
+    testSmartsocket.socketConnections.findSync((socketConnection) => {
       return true;
     })
   );
@@ -129,10 +130,19 @@ tap.test('should be able to make a functionCall from server to client', async ()
 
 tap.test('client should disconnect and reconnect', async (tools) => {
   await testSmartsocketClient.disconnect();
-  await tools.delayFor(100);
   await testSmartsocketClient.connect();
 });
 
+tap.test('should be able to locate a connection tag after reconnect', async (tools) => {
+  console.log(testSmartsocket.socketConnections.getArray().length);
+  const tagOnServerSide = await testSmartsocket.socketConnections
+    .findSync((socketConnection) => {
+      return true;
+    })
+    .getTagById('awesome');
+  expect(tagOnServerSide.payload).to.equal('yes');
+});
+
 // terminate
 tap.test('should close the server', async () => {
   await testSmartsocket.stop();

ts/index.ts

@@ -4,5 +4,4 @@ export * from './smartsocket.classes.smartsocketclient';
 
 // export further classes and objects
 export * from './smartsocket.classes.socketfunction';
-export * from './smartsocket.classes.socketrole';
 export * from './smartsocket.classes.socketconnection';

ts/interfaces/connection.ts

@@ -1,5 +1,5 @@
 export interface IRequestAuthPayload {
-  serverShortId: string;
+  serverAlias: string;
 }
 
 export type TConnectionStatus =

ts/interfaces/tag.ts

@@ -1,6 +1,6 @@
-export interface ITag <T = any> {
+export interface ITag<T = any> {
   id: string;
   payload: T;
 }
 
-export type TTagStore = {[key: string]: ITag};
+export type TTagStore = { [key: string]: ITag };

ts/smartsocket.classes.smartsocket.ts

@@ -9,12 +9,12 @@ import {
   ISocketFunctionCallDataResponse,
 } from './smartsocket.classes.socketfunction';
 import { SocketRequest } from './smartsocket.classes.socketrequest';
-import { SocketRole } from './smartsocket.classes.socketrole';
 import { SocketServer } from './smartsocket.classes.socketserver';
 
 import { logger } from './smartsocket.logging';
 
 export interface ISmartsocketConstructorOptions {
+  alias: string;
   port?: number;
 }
 
@@ -22,12 +22,11 @@ export class Smartsocket {
   /**
    * a unique id to detect server restarts
    */
-  public shortId = plugins.isounique.uni();
+  public alias: string;
   public smartenv = new plugins.smartenv.Smartenv();
   public options: ISmartsocketConstructorOptions;
   public io: pluginsTyped.socketIo.Server;
   public socketConnections = new plugins.lik.ObjectMap<SocketConnection>();
-  public socketRoles = new plugins.lik.ObjectMap<SocketRole>();
   public socketFunctions = new plugins.lik.ObjectMap<SocketFunction<any>>();
   public socketRequests = new plugins.lik.ObjectMap<SocketRequest<any>>();
 
@@ -35,6 +34,7 @@ export class Smartsocket {
 
   constructor(optionsArg: ISmartsocketConstructorOptions) {
     this.options = optionsArg;
+    this.alias = plugins.isounique.uni(this.options.alias);
   }
 
   // tslint:disable-next-line:member-ordering
@@ -61,8 +61,8 @@ export class Smartsocket {
     await plugins.smartdelay.delayFor(1000);
     this.socketConnections.forEach((socketObjectArg: SocketConnection) => {
       if (socketObjectArg) {
-        logger.log('info', `disconnect socket with >>alias ${socketObjectArg.alias}`);
+        logger.log('info', `disconnecting socket with >>alias ${socketObjectArg.alias} due to server stop...`);
-        socketObjectArg.socket.disconnect();
+        socketObjectArg.disconnect();
       }
     });
     this.socketConnections.wipe();
@@ -96,16 +96,6 @@ export class Smartsocket {
     return result;
   }
 
-  /**
-   * adds socketRoles
-   */
-  public addSocketRoles(socketRolesArray: SocketRole[]): void {
-    for (const socketRole of socketRolesArray) {
-      this.socketRoles.add(socketRole);
-    }
-    return;
-  }
-
   public addSocketFunction(socketFunction: SocketFunction<any>) {
     this.socketFunctions.add(socketFunction);
   }
@@ -113,18 +103,24 @@ export class Smartsocket {
   /**
    * the standard handler for new socket connections
    */
-  private async _handleSocketConnection(socketArg: pluginsTyped.socketIo.Socket) {
+  private async _handleSocketConnection(socketArg: SocketIO.Socket) {
     const socketConnection: SocketConnection = new SocketConnection({
       alias: undefined,
       authenticated: false,
-      role: undefined,
       side: 'server',
       smartsocketHost: this,
       socket: socketArg,
     });
     logger.log('info', 'Socket connected. Trying to authenticate...');
     this.socketConnections.add(socketConnection);
+    const disconnectSubscription = socketConnection.eventSubject.subscribe((eventArg) => {
+      if (eventArg === 'disconnected') {
+        this.socketConnections.remove(socketConnection);
+        disconnectSubscription.unsubscribe();
+      }
+    });
     await socketConnection.authenticate();
     await socketConnection.listenToFunctionRequests();
+    await socketConnection.socket.emit('serverFullyReactive');
   }
 }

ts/smartsocket.classes.smartsocketclient.ts

@@ -8,7 +8,6 @@ import {
   SocketFunction,
 } from './smartsocket.classes.socketfunction';
 import { ISocketRequestDataObject, SocketRequest } from './smartsocket.classes.socketrequest';
-import { SocketRole } from './smartsocket.classes.socketrole';
 import { logger } from './smartsocket.logging';
 
 /**
@@ -18,8 +17,6 @@ export interface ISmartsocketClientOptions {
   port: number;
   url: string;
   alias: string; // an alias makes it easier to identify this client in a multo client environment
-  role: string;
-  password: string; // by setting a password access to functions can be limited
   autoReconnect?: boolean;
 }
 
@@ -31,7 +28,6 @@ export class SmartsocketClient {
   public remoteShortId: string = null;
 
   public alias: string;
-  public socketRole: SocketRole;
   public socketConnection: SocketConnection;
   public serverUrl: string;
   public serverPort: number;
@@ -43,10 +39,9 @@ export class SmartsocketClient {
 
   public socketFunctions = new plugins.lik.ObjectMap<SocketFunction<any>>();
   public socketRequests = new plugins.lik.ObjectMap<SocketRequest<any>>();
-  public socketRoles = new plugins.lik.ObjectMap<SocketRole>();
 
   // tagStore
-  private tagStore: {[key: string]: interfaces.ITag} = {};
+  private tagStore: { [key: string]: interfaces.ITag } = {};
   private tagStoreSubscription: plugins.smartrx.rxjs.Subscription;
 
   /**
@@ -66,7 +61,7 @@ export class SmartsocketClient {
    */
   public async getTagById(tagIdArg: interfaces.ITag['id']) {
     return this.tagStore[tagIdArg];
-  };
+  }
 
   /**
    * removes a tag from a connection
@@ -83,16 +78,11 @@ export class SmartsocketClient {
     this.alias = optionsArg.alias;
     this.serverUrl = optionsArg.url;
     this.serverPort = optionsArg.port;
-    this.socketRole = new SocketRole({
-      name: optionsArg.role,
-      passwordHash: optionsArg.password,
-    });
     this.autoReconnect = optionsArg.autoReconnect;
   }
 
   public addSocketFunction(socketFunction: SocketFunction<any>) {
     this.socketFunctions.add(socketFunction);
-    this.socketRole.allowedFunctions.add(socketFunction);
   }
 
   /**
@@ -113,7 +103,6 @@ export class SmartsocketClient {
     this.socketConnection = new SocketConnection({
       alias: this.alias,
       authenticated: false,
-      role: this.socketRole,
       side: 'client',
       smartsocketHost: this,
       socket: await socketIoClient.connect(socketUrl, {
@@ -138,11 +127,29 @@ export class SmartsocketClient {
         logger.log('info', 'server requested authentication');
 
         // lets register the authenticated event
-        this.socketConnection.socket.on('authenticated', () => {
+        this.socketConnection.socket.on('authenticated', async () => {
-          this.remoteShortId = requestAuthPayload.serverShortId;
+          this.remoteShortId = requestAuthPayload.serverAlias;
           logger.log('info', 'client is authenticated');
           this.socketConnection.authenticated = true;
-          this.socketConnection.listenToFunctionRequests();
+          await this.socketConnection.listenToFunctionRequests();
+        });
+
+        this.socketConnection.socket.on('serverFullyReactive', async () => {
+          // lets take care of retagging
+          const oldTagStore = this.tagStore;
+          this.tagStoreSubscription?.unsubscribe();
+          for (const keyArg of Object.keys(this.tagStore)) {
+            this.socketConnection.addTag(this.tagStore[keyArg]);
+          }
+          this.tagStoreSubscription = this.socketConnection.tagStoreObservable.subscribe(
+            (tagStoreArg) => {
+              this.tagStore = tagStoreArg;
+            }
+          );
+
+          for (const tag of Object.keys(oldTagStore)) {
+            await this.addTag(oldTagStore[tag]);
+          }
           done.resolve();
         });
 
@@ -154,8 +161,6 @@ export class SmartsocketClient {
 
         // lets provide the actual auth data
         this.socketConnection.socket.emit('dataAuth', {
-          role: this.socketRole.name,
-          password: this.socketRole.passwordHash,
           alias: this.alias,
         });
       }
@@ -163,13 +168,6 @@ export class SmartsocketClient {
 
     // handle connection
     this.socketConnection.socket.on('connect', async () => {
-      this.tagStoreSubscription?.unsubscribe();
-      this.tagStoreSubscription = this.socketConnection.tagStoreObservable.subscribe(tagStoreArg => {
-        this.tagStore = tagStoreArg
-      });
-      for (const keyArg of Object.keys(this.tagStore)) {
-        this.socketConnection.addTag(this.tagStore[keyArg]);
-      }
       this.updateStatus('connected');
     });
 
@@ -191,6 +189,7 @@ export class SmartsocketClient {
    * disconnect from the server
    */
   public async disconnect() {
+    this.tagStoreSubscription?.unsubscribe();
     if (this.socketConnection) {
       await this.socketConnection.disconnect();
       this.socketConnection = undefined;
@@ -217,7 +216,7 @@ export class SmartsocketClient {
    * try a reconnection
    */
   public async tryDebouncedReconnect() {
-    await plugins.smartdelay.delayForRandom(10000, 60000);
+    await plugins.smartdelay.delayForRandom(10000, 50000);
     await this.connect();
   }
 

ts/smartsocket.classes.socketconnection.ts

@@ -5,10 +5,9 @@ import * as interfaces from './interfaces';
 import { Smartsocket } from './smartsocket.classes.smartsocket';
 import { SocketFunction } from './smartsocket.classes.socketfunction';
 import { SocketRequest, ISocketRequestDataObject } from './smartsocket.classes.socketrequest';
-import { SocketRole } from './smartsocket.classes.socketrole';
 
 // socket.io
-import * as SocketIO from 'socket.io';
+import * as pluginsTyped from './smartsocket.pluginstyped';
 import { SmartsocketClient } from './smartsocket.classes.smartsocketclient';
 import { logger } from './smartsocket.logging';
 
@@ -25,7 +24,6 @@ export type TSocketConnectionSide = 'server' | 'client';
 export interface ISocketConnectionConstructorOptions {
   alias: string;
   authenticated: boolean;
-  role: SocketRole;
   side: TSocketConnectionSide;
   smartsocketHost: Smartsocket | SmartsocketClient;
   socket: SocketIO.Socket | SocketIOClient.Socket;
@@ -35,9 +33,7 @@ export interface ISocketConnectionConstructorOptions {
  * interface for authentication data
  */
 export interface ISocketConnectionAuthenticationObject {
-  role: 'coreflowContainer';
+  alias: string;
-  password: 'somePassword';
-  alias: 'coreflow1';
 }
 
 // export classes
@@ -50,7 +46,6 @@ export class SocketConnection {
   public alias: string;
   public side: TSocketConnectionSide;
   public authenticated: boolean = false;
-  public role: SocketRole;
   public smartsocketRef: Smartsocket | SmartsocketClient;
   public socket: SocketIO.Socket | SocketIOClient.Socket;
 
@@ -64,7 +59,6 @@ export class SocketConnection {
   constructor(optionsArg: ISocketConnectionConstructorOptions) {
     this.alias = optionsArg.alias;
     this.authenticated = optionsArg.authenticated;
-    this.role = optionsArg.role;
     this.side = optionsArg.side;
     this.smartsocketRef = optionsArg.smartsocketHost;
     this.socket = optionsArg.socket;
@@ -83,6 +77,7 @@ export class SocketConnection {
       );
       await this.disconnect();
       allSocketConnections.remove(this);
+      this.eventSubject.next('disconnected');
     });
   }
 
@@ -94,13 +89,16 @@ export class SocketConnection {
     this.tagStore[tagArg.id] = tagArg;
     this.tagStoreObservable.next(this.tagStore);
     const remoteSubscription = this.remoteTagStoreObservable.subscribe((remoteTagStore) => {
+      if (!remoteTagStore[tagArg.id]) {
+        return;
+      }
       const localTagString = plugins.smartjson.stringify(tagArg);
-      const remoteTagString = plugins.smartjson.stringify(remoteTagStore[tagArg.id])
+      const remoteTagString = plugins.smartjson.stringify(remoteTagStore[tagArg.id]);
       if (localTagString === remoteTagString) {
         remoteSubscription.unsubscribe();
         done.resolve();
       }
-    })
+    });
     this.socket.emit('updateTagStore', this.tagStore);
     await done.promise;
   }
@@ -111,7 +109,7 @@ export class SocketConnection {
    */
   public async getTagById(tagIdArg: interfaces.ITag['id']) {
     return this.tagStore[tagIdArg];
-  };
+  }
 
   /**
    * removes a tag from a connection
@@ -130,24 +128,23 @@ export class SocketConnection {
   public authenticate() {
     const done = plugins.smartpromise.defer();
     this.socket.on('dataAuth', async (dataArg: ISocketConnectionAuthenticationObject) => {
-      logger.log('info', 'received authentication data. now hashing and comparing...');
+      logger.log('info', 'received authentication data...');
       this.socket.removeAllListeners('dataAuth');
-      if (await SocketRole.checkPasswordForRole(dataArg, this.smartsocketRef)) {
+      if (dataArg.alias) {
         // TODO: authenticate password
         this.alias = dataArg.alias;
         this.authenticated = true;
-        this.role = SocketRole.getSocketRoleByName(this.smartsocketRef, dataArg.role);
         this.socket.emit('authenticated');
-        logger.log('ok', `socket with >>alias ${this.alias} >>role ${this.role} is authenticated!`);
+        logger.log('ok', `socket with >>alias ${this.alias} is authenticated!`);
         done.resolve(this);
       } else {
         this.authenticated = false;
         await this.disconnect();
-        done.reject('not authenticated');
+        done.reject('a socket tried to connect, but could not authenticated.');
       }
     });
     const requestAuthPayload: interfaces.IRequestAuthPayload = {
-      serverShortId: this.smartsocketRef.shortId,
+      serverAlias: this.smartsocketRef.alias,
     };
     this.socket.emit('requestAuth', requestAuthPayload);
     return done.promise;
@@ -164,7 +161,7 @@ export class SocketConnection {
       this.socket.on('function', (dataArg: ISocketRequestDataObject<any>) => {
         // check if requested function is available to the socket's scope
         // logger.log('info', 'function request received');
-        const referencedFunction: SocketFunction<any> = this.role.allowedFunctions.find(
+        const referencedFunction: SocketFunction<any> = this.smartsocketRef.socketFunctions.findSync(
           (socketFunctionArg) => {
             return socketFunctionArg.name === dataArg.funcCallData.funcName;
           }
@@ -192,17 +189,13 @@ export class SocketConnection {
       });
 
       this.socket.on('updateTagStore', async (tagStoreArg: interfaces.TTagStore) => {
-        const exitingStoreString = plugins.smartjson.stringify(this.tagStore);
+        if (!plugins.smartjson.deepEqualObjects(this.tagStore, tagStoreArg)) {
-        const newStoreString = plugins.smartjson.stringify(tagStoreArg);
-        console.log(exitingStoreString);
-        console.log(newStoreString);
-        if (exitingStoreString !== newStoreString) {
           this.tagStore = tagStoreArg;
           this.socket.emit('updateTagStore', this.tagStore);
           this.tagStoreObservable.next(this.tagStore);
         }
         this.remoteTagStoreObservable.next(tagStoreArg);
-      })
+      });
 
       logger.log('info', `now listening to function requests for ${this.alias}`);
       done.resolve(this);

ts/smartsocket.classes.socketfunction.ts

@@ -1,7 +1,6 @@
 import * as plugins from './smartsocket.plugins';
 
 // import classes
-import { SocketRole } from './smartsocket.classes.socketrole';
 import { SocketConnection } from './smartsocket.classes.socketconnection';
 import { Smartsocket } from './smartsocket.classes.smartsocket';
 import { SmartsocketClient } from './smartsocket.classes.smartsocketclient';
@@ -16,7 +15,6 @@ export interface ISocketFunctionConstructorOptions<
 > {
   funcName: T['method'];
   funcDef: TFuncDef<T>;
-  allowedRoles: SocketRole[]; // all roles that are allowed to execute a SocketFunction
 }
 
 /**
@@ -58,7 +56,7 @@ export class SocketFunction<T extends plugins.typedrequestInterfaces.ITypedReque
     smartsocketRefArg: Smartsocket | SmartsocketClient,
     functionNameArg: string
   ): SocketFunction<Q> {
-    return smartsocketRefArg.socketFunctions.find((socketFunctionArg) => {
+    return smartsocketRefArg.socketFunctions.findSync((socketFunctionArg) => {
       return socketFunctionArg.name === functionNameArg;
     });
   }
@@ -66,7 +64,6 @@ export class SocketFunction<T extends plugins.typedrequestInterfaces.ITypedReque
   // INSTANCE
   public name: string;
   public funcDef: TFuncDef<T>;
-  public roles: SocketRole[];
 
   /**
    * the constructor for SocketFunction
@@ -74,10 +71,6 @@ export class SocketFunction<T extends plugins.typedrequestInterfaces.ITypedReque
   constructor(optionsArg: ISocketFunctionConstructorOptions<T>) {
     this.name = optionsArg.funcName;
     this.funcDef = optionsArg.funcDef;
-    this.roles = optionsArg.allowedRoles;
-    for (const socketRoleArg of this.roles) {
-      this._notifyRole(socketRoleArg);
-    }
   }
 
   /**
@@ -97,11 +90,4 @@ export class SocketFunction<T extends plugins.typedrequestInterfaces.ITypedReque
       throw new Error("SocketFunction.name does not match the data argument's .name!");
     }
   }
-
-  /**
-   * notifies a role about access to this SocketFunction
-   */
-  private _notifyRole(socketRoleArg: SocketRole) {
-    socketRoleArg.addSocketFunction(this);
-  }
 }

ts/smartsocket.classes.socketrequest.ts

@@ -45,7 +45,7 @@ export class SocketRequest<T extends plugins.typedrequestInterfaces.ITypedReques
     smartsocketRef: Smartsocket | SmartsocketClient,
     shortIdArg: string
   ): SocketRequest<any> {
-    return smartsocketRef.socketRequests.find((socketRequestArg) => {
+    return smartsocketRef.socketRequests.findSync((socketRequestArg) => {
       return socketRequestArg.shortid === shortIdArg;
     });
   }

ts/smartsocket.classes.socketrole.ts

@@ -1,57 +0,0 @@
-import * as plugins from './smartsocket.plugins';
-
-// import classes
-import { SocketFunction } from './smartsocket.classes.socketfunction';
-import { Smartsocket } from './smartsocket.classes.smartsocket';
-import { SmartsocketClient } from './smartsocket.classes.smartsocketclient';
-import { ISocketConnectionAuthenticationObject } from './smartsocket.classes.socketconnection';
-
-/**
- * interface for class SocketRole
- */
-export interface ISocketRoleOptions {
-  name: string;
-  passwordHash: string;
-}
-
-/**
- * A socketrole defines access to certain routines.
- */
-export class SocketRole {
-  // STATIC
-  public static getSocketRoleByName(
-    referenceSmartsocket: Smartsocket | SmartsocketClient,
-    socketRoleNameArg: string
-  ): SocketRole {
-    return referenceSmartsocket.socketRoles.find((socketRoleArg) => {
-      return socketRoleArg.name === socketRoleNameArg;
-    });
-  }
-
-  public static async checkPasswordForRole(
-    dataArg: ISocketConnectionAuthenticationObject,
-    referenceSmartsocket: Smartsocket | SmartsocketClient
-  ): Promise<boolean> {
-    const targetPasswordHash = SocketRole.getSocketRoleByName(referenceSmartsocket, dataArg.role)
-      .passwordHash;
-    const computedCompareHash = await plugins.isohash.sha256FromString(dataArg.password);
-    return targetPasswordHash === computedCompareHash;
-  }
-
-  // INSTANCE
-  public name: string;
-  public passwordHash: string;
-  public allowedFunctions = new plugins.lik.ObjectMap<SocketFunction<any>>();
-  constructor(optionsArg: ISocketRoleOptions) {
-    this.name = optionsArg.name;
-    this.passwordHash = optionsArg.passwordHash;
-  }
-
-  /**
-   * adds the socketfunction to the socketrole
-   * @param socketFunctionArg
-   */
-  public addSocketFunction(socketFunctionArg: SocketFunction<any>) {
-    this.allowedFunctions.add(socketFunctionArg);
-  }
-}

ts/smartsocket.classes.socketserver.ts

@@ -12,7 +12,10 @@ import { logger } from './smartsocket.logging';
 export class SocketServer {
   private smartsocket: Smartsocket;
   private httpServer: pluginsTyped.http.Server | pluginsTyped.https.Server;
-  // wether httpServer is standalone
+  
+  /**
+   * wether httpServer is standalone
+   */
   private standaloneServer = false;
 
   constructor(smartSocketInstance: Smartsocket) {
@@ -77,5 +80,9 @@ export class SocketServer {
   /**
    * closes the server
    */
-  public async stop() {}
+  public async stop() {
+    if (this.httpServer) {
+      this.httpServer.close();
+    }
+  }
 }

ts/smartsocket.classes.socketstats.ts

@@ -1,3 +0,0 @@
-import * as plugins from './smartsocket.plugins';
-
-export class SocketStats {}

ts/smartsocket.pluginstyped.ts

@@ -13,4 +13,4 @@ export { smartexpress };
 import type socketIo from 'socket.io';
 import type socketIoClient from 'socket.io-client';
 
-export { socketIo, socketIoClient };
+export { socketIoClient, socketIo };