1.0.23

.gitlab-ci.yml

@@ -26,16 +26,28 @@ mirror:
     - docker
     - notpriv
 
-audit:
+auditProductionDependencies:
+  image: registry.gitlab.com/hosttoday/ht-docker-node:npmci
+  stage: security
+  script:
+    - npmci npm prepare
+    - npmci command npm install --production --ignore-scripts
+    - npmci command npm config set registry https://registry.npmjs.org
+    - npmci command npm audit --audit-level=high --only=prod --production
+  tags:
+    - docker
+
+auditDevDependencies:
   image: registry.gitlab.com/hosttoday/ht-docker-node:npmci
   stage: security
   script:
     - npmci npm prepare
     - npmci command npm install --ignore-scripts
     - npmci command npm config set registry https://registry.npmjs.org
-    - npmci command npm audit --audit-level=high
+    - npmci command npm audit --audit-level=high --only=dev
   tags:
     - docker
+  allow_failure: true
 
 # ====================
 # test stage

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushrocks/smartssr",
-  "version": "1.0.17",
+  "version": "1.0.23",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {
@@ -2127,9 +2127,9 @@
       "integrity": "sha512-KENdm++8uuzxDz1cbUbXtz6InfReP28TYC5zxRgRtwsXh7ZWUkSA+/82IbO97PcSCAfIpg7dwj77G6KGSsTKEQ=="
     },
     "@pushrocks/smartpuppeteer": {
-      "version": "1.0.19",
-      "resolved": "https://verdaccio.lossless.one/@pushrocks%2fsmartpuppeteer/-/smartpuppeteer-1.0.19.tgz",
-      "integrity": "sha512-URD2QcXP95YZeaY4qQjddjNOCzE+VzIFHsavfyoxzlRmlnpF3y1+r2rbTwuoFcoZW+M0/4j0alISm7reUfhL9A==",
+      "version": "1.0.21",
+      "resolved": "https://verdaccio.lossless.one/@pushrocks%2fsmartpuppeteer/-/smartpuppeteer-1.0.21.tgz",
+      "integrity": "sha512-uTONNTNIIswX5UOPt3VYv/7gIDTdkdNqIhR1DpnKlemOVyVLOT7D0eZPuTGXDgtNjHdTyQ6ywc54/gEBGXTNwg==",
       "requires": {
         "@pushrocks/smartdelay": "^2.0.10",
         "@pushrocks/smartenv": "^4.0.16",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushrocks/smartssr",
-  "version": "1.0.17",
+  "version": "1.0.23",
   "private": false,
   "description": "a smart server side renderer supporting shadow dom",
   "main": "dist_ts/index.js",
@@ -25,7 +25,7 @@
     "@pushrocks/smartdelay": "^2.0.10",
     "@pushrocks/smartfile": "^8.0.8",
     "@pushrocks/smartpromise": "^3.1.3",
-    "@pushrocks/smartpuppeteer": "^1.0.19",
+    "@pushrocks/smartpuppeteer": "^1.0.21",
     "@pushrocks/smarttime": "^3.0.38"
   },
   "files": [

test/test.ts

@@ -13,13 +13,13 @@ tap.test('should start the smartssr instance', async () => {
   await testSSRInstance.start();
 });
 
-tap.skip.test('should render central.eu', async (tools) => {
+tap.test('should render central.eu', async (tools) => {
   await testSSRInstance.renderPage(
-    'https://central.eu/article/5e76873b9cf69b7bf6bc78bc/Introducing%3A%20central.eu'
+    'https://in.work'
   );
 });
 
-tap.test('should render lossless.com', async () => {
+tap.skip.test('should render lossless.com', async () => {
   await testSSRInstance.renderPage('https://lossless.com');
 });
 

ts/smartssr.classes.smartssr.ts

@@ -51,6 +51,7 @@ export class SmartSSR {
     renderTimeMeasurement.start();
     await page.goto(urlArg, {
       waitUntil: 'networkidle2',
+      timeout: 30000
     });
 
     let screenshotBuffer: Buffer;
@@ -66,12 +67,11 @@ export class SmartSSR {
     const renderedPageString = pageContent;
     resultDeferred.resolve(renderedPageString);
 
-
     const result = await resultDeferred.promise;
     renderTimeMeasurement.stop();
 
     // lets clean up async
-    context.close();
+    await context.close();
 
     overallTimeMeasurement.stop();
     console.log(

ts/smartssr.function.serialize.ts

@@ -47,11 +47,12 @@ export function serializeFunction(rootNode) {
         slotsForMove.push(slot);
       });
 
-      
       for (const slot of slotsForMove) {
         const slottedLightNodesForMove = [];
         slot.assignedNodes().forEach((lightNode) => slottedLightNodesForMove.push(lightNode));
-        slottedLightNodesForMove.forEach((lightNode) => slot.parentNode.insertBefore(lightNode, slot));
+        slottedLightNodesForMove.forEach((lightNode) =>
+          slot.parentNode.insertBefore(lightNode, slot)
+        );
       }
 
       // lets modify the css
@@ -68,6 +69,9 @@ export function serializeFunction(rootNode) {
           noteForAppending.push(childNode);
         }
       });
+      while(nodeArg.firstChild) {
+        nodeArg.removeChild(nodeArg.firstChild);
+      }
       noteForAppending.forEach((childNode) => {
         nodeArg.append(childNode);
       });