1.0.25

.gitlab-ci.yml

@@ -26,16 +26,28 @@ mirror:
     - docker
     - notpriv
 
-audit:
+auditProductionDependencies:
+  image: registry.gitlab.com/hosttoday/ht-docker-node:npmci
+  stage: security
+  script:
+    - npmci npm prepare
+    - npmci command npm install --production --ignore-scripts
+    - npmci command npm config set registry https://registry.npmjs.org
+    - npmci command npm audit --audit-level=high --only=prod --production
+  tags:
+    - docker
+
+auditDevDependencies:
   image: registry.gitlab.com/hosttoday/ht-docker-node:npmci
   stage: security
   script:
     - npmci npm prepare
     - npmci command npm install --ignore-scripts
     - npmci command npm config set registry https://registry.npmjs.org
-    - npmci command npm audit --audit-level=high
+    - npmci command npm audit --audit-level=high --only=dev
   tags:
     - docker
+  allow_failure: true
 
 # ====================
 # test stage

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushrocks/smartssr",
-  "version": "1.0.17",
+  "version": "1.0.25",
   "private": false,
   "description": "a smart server side renderer supporting shadow dom",
   "main": "dist_ts/index.js",
@@ -14,18 +14,18 @@
   },
   "devDependencies": {
     "@gitzone/tsbuild": "^2.1.25",
-    "@gitzone/tstest": "^1.0.52",
+    "@gitzone/tstest": "^1.0.54",
     "@pushrocks/smartserve": "^1.1.41",
-    "@pushrocks/tapbundle": "^3.2.9",
+    "@pushrocks/tapbundle": "^3.2.14",
     "@types/node": "^14.14.20",
     "tslint": "^6.1.3",
     "tslint-config-prettier": "^1.15.0"
   },
   "dependencies": {
     "@pushrocks/smartdelay": "^2.0.10",
-    "@pushrocks/smartfile": "^8.0.8",
-    "@pushrocks/smartpromise": "^3.1.3",
-    "@pushrocks/smartpuppeteer": "^1.0.19",
+    "@pushrocks/smartfile": "^8.0.10",
+    "@pushrocks/smartpromise": "^3.1.5",
+    "@pushrocks/smartpuppeteer": "^1.0.21",
     "@pushrocks/smarttime": "^3.0.38"
   },
   "files": [

test/test.ts

@@ -13,13 +13,11 @@ tap.test('should start the smartssr instance', async () => {
   await testSSRInstance.start();
 });
 
-tap.skip.test('should render central.eu', async (tools) => {
-  await testSSRInstance.renderPage(
-    'https://central.eu/article/5e76873b9cf69b7bf6bc78bc/Introducing%3A%20central.eu'
-  );
+tap.test('should render central.eu', async (tools) => {
+  await testSSRInstance.renderPage('https://in.work');
 });
 
-tap.test('should render lossless.com', async () => {
+tap.skip.test('should render lossless.com', async () => {
   await testSSRInstance.renderPage('https://lossless.com');
 });
 

ts/smartssr.classes.smartssr.ts

@@ -43,6 +43,17 @@ export class SmartSSR {
     const resultDeferred = plugins.smartpromise.defer<string>();
     const context = await this.browser.getNewIncognitoContext();
     const page = await context.newPage();
+
+    // lets protext against left open tabs
+    plugins.smartdelay.delayFor(30000).then(() => {
+      if (!page.isClosed) {
+        page.close();
+        context.close();
+        throw new Error(`failed to render ${urlArg}`);
+      }
+      
+    });
+
     page.on('console', (msg) => {
       console.log(`${urlArg}: ${msg.text()}`);
     });
@@ -51,6 +62,7 @@ export class SmartSSR {
     renderTimeMeasurement.start();
     await page.goto(urlArg, {
       waitUntil: 'networkidle2',
+      timeout: 30000,
     });
 
     let screenshotBuffer: Buffer;
@@ -66,12 +78,12 @@ export class SmartSSR {
     const renderedPageString = pageContent;
     resultDeferred.resolve(renderedPageString);
 
-
     const result = await resultDeferred.promise;
     renderTimeMeasurement.stop();
 
     // lets clean up async
-    context.close();
+    await page.close();
+    await context.close();
 
     overallTimeMeasurement.stop();
     console.log(

ts/smartssr.function.serialize.ts

@@ -47,11 +47,12 @@ export function serializeFunction(rootNode) {
         slotsForMove.push(slot);
       });
 
-      
       for (const slot of slotsForMove) {
         const slottedLightNodesForMove = [];
         slot.assignedNodes().forEach((lightNode) => slottedLightNodesForMove.push(lightNode));
-        slottedLightNodesForMove.forEach((lightNode) => slot.parentNode.insertBefore(lightNode, slot));
+        slottedLightNodesForMove.forEach((lightNode) =>
+          slot.parentNode.insertBefore(lightNode, slot)
+        );
       }
 
       // lets modify the css
@@ -68,6 +69,9 @@ export function serializeFunction(rootNode) {
           noteForAppending.push(childNode);
         }
       });
+      while (nodeArg.firstChild) {
+        nodeArg.removeChild(nodeArg.firstChild);
+      }
       noteForAppending.forEach((childNode) => {
         nodeArg.append(childNode);
       });