fix(compiler): force global filesystem sync to flush XFS delayed logging and add diagnostics comparing Node's readdirSync with system ls to detect directory entry inconsistencies

This commit is contained in:
2026-03-05 15:35:57 +00:00
parent 85a33021e4
commit 9dc74fd392
3 changed files with 27 additions and 20 deletions

View File

@@ -1,5 +1,12 @@
# Changelog # Changelog
## 2026-03-05 - 4.2.2 - fix(compiler)
force global filesystem sync to flush XFS delayed logging and add diagnostics comparing Node's readdirSync with system ls to detect directory entry inconsistencies
- Replace per-directory fs.fsyncSync loop with execSync('sync') to ensure parent B+tree metadata is flushed on XFS
- Import execSync from child_process
- Add diagnostic comparison: run ls -1 and compare its entries to fs.readdirSync; log mismatches and full entry lists for debugging Node.js caching/readdir inconsistencies
## 2026-03-05 - 4.2.1 - fix(compiler) ## 2026-03-05 - 4.2.1 - fix(compiler)
use TypeScript sys hooks instead of fs monkeypatching to detect writes/deletes in previous output directories use TypeScript sys hooks instead of fs monkeypatching to detect writes/deletes in previous output directories

View File

@@ -3,6 +3,6 @@
*/ */
export const commitinfo = { export const commitinfo = {
name: '@git.zone/tsbuild', name: '@git.zone/tsbuild',
version: '4.2.1', version: '4.2.2',
description: 'A tool for compiling TypeScript files using the latest nightly features, offering flexible APIs and a CLI for streamlined development.' description: 'A tool for compiling TypeScript files using the latest nightly features, offering flexible APIs and a CLI for streamlined development.'
} }

View File

@@ -1,6 +1,7 @@
import type { CompilerOptions, Diagnostic, Program } from 'typescript'; import type { CompilerOptions, Diagnostic, Program } from 'typescript';
import typescript from 'typescript'; import typescript from 'typescript';
import * as fs from 'fs'; import * as fs from 'fs';
import { execSync } from 'child_process';
import * as smartdelay from '@push.rocks/smartdelay'; import * as smartdelay from '@push.rocks/smartdelay';
import * as smartpromise from '@push.rocks/smartpromise'; import * as smartpromise from '@push.rocks/smartpromise';
import * as smartpath from '@push.rocks/smartpath'; import * as smartpath from '@push.rocks/smartpath';
@@ -453,29 +454,28 @@ export class TsCompiler {
successfulOutputDirs.push(destDir); successfulOutputDirs.push(destDir);
} }
// Fsync all output directories to force XFS metadata commit // Force global filesystem sync to flush XFS delayed logging (CIL)
// before the next compilation step. Without this, XFS delayed logging // before the next compilation step. Per-directory fsync was insufficient;
// can cause directory entries from previous compilations to become // XFS defers parent B+tree metadata commits which can make sibling
// invisible or corrupted during subsequent TypeScript emit operations. // directory entries invisible to readdirSync after heavy write activity.
for (const dir of successfulOutputDirs) { execSync('sync');
try {
const fd = fs.openSync(dir, 'r');
fs.fsyncSync(fd);
fs.closeSync(fd);
} catch {
// Directory might not exist yet
}
}
// Diagnostic: log all output directory states after each compilation // Diagnostic: compare readdirSync vs external ls to detect Node.js caching
if (!isQuiet && !isJson) { if (!isQuiet && !isJson) {
for (const prevDir of successfulOutputDirs) { for (const prevDir of successfulOutputDirs) {
try { try {
const entries = fs.readdirSync(prevDir); const nodeEntries = fs.readdirSync(prevDir);
const dirs = entries.filter(e => { const nodeDirs = nodeEntries.filter(e => { try { return fs.statSync(prevDir + '/' + e).isDirectory(); } catch { return false; } });
try { return fs.statSync(prevDir + '/' + e).isDirectory(); } catch { return false; } const lsOutput = execSync(`ls -1 "${prevDir}"`, { encoding: 'utf8' }).trim();
}); const lsEntries = lsOutput ? lsOutput.split('\n') : [];
console.log(` 📋 [diag] ${prevDir.replace(this.cwd + '/', '')}: ${entries.length} entries, ${dirs.length} dirs`); const shortDir = prevDir.replace(this.cwd + '/', '');
if (nodeEntries.length !== lsEntries.length) {
console.log(` ⚠️ [diag] ${shortDir}: readdirSync=${nodeEntries.length}, ls=${lsEntries.length} (MISMATCH!)`);
console.log(` readdirSync: [${nodeEntries.sort().join(', ')}]`);
console.log(` ls: [${lsEntries.sort().join(', ')}]`);
} else {
console.log(` 📋 [diag] ${shortDir}: ${nodeEntries.length} entries, ${nodeDirs.length} dirs ✓`);
}
} catch { } catch {
console.log(` 📋 [diag] ${prevDir.replace(this.cwd + '/', '')}: MISSING!`); console.log(` 📋 [diag] ${prevDir.replace(this.cwd + '/', '')}: MISSING!`);
} }