2.0.4

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushrocks/smartarchive",
-  "version": "2.0.1",
+  "version": "2.0.4",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushrocks/smartarchive",
-  "version": "2.0.1",
+  "version": "2.0.4",
   "description": "work with archives",
   "main": "dist_ts/index.js",
   "typings": "dist_ts/index.d.ts",

test/test.ts

@@ -60,23 +60,35 @@ tap.test('should extract a package using tarStream', async (tools) => {
   const extractionFileObservable = await testSmartarchive.extractArchiveFromBufferToObservable(
     testTgzBuffer
   );
-  const subscription = extractionFileObservable.subscribe(file => {
-    console.log(file.path);
-  });
-  await tools.delayFor(2000);
-  done.resolve();
+  const subscription = extractionFileObservable.subscribe(
+    (file) => {
+      console.log(file.path);
+    },
+    (err) => {
+      console.log(err);
+    },
+    () => {
+      done.resolve();
+    }
+  );
   await done.promise;
 });
 
 tap.test('should extract a file from url to replaySubject', async (tools) => {
   const done = tools.defer();
   const testSmartarchive = new smartarchive.SmartArchive();
-  const extractionFileObservable = await testSmartarchive.extractArchiveFromUrlToObservable('https://verdaccio.lossless.one/@pushrocks%2fwebsetup/-/websetup-2.0.14.tgz');
-  const subscription = extractionFileObservable.subscribe(file => {
+  const extractionFileObservable = await testSmartarchive.extractArchiveFromUrlToObservable(
+    'https://verdaccio.lossless.one/@pushrocks%2fwebsetup/-/websetup-2.0.14.tgz'
+  );
+  const subscription = extractionFileObservable.subscribe((file) => {
     console.log(file.path);
+  },
+  (err) => {
+    console.log(err);
+  },
+  () => {
+    done.resolve();
   });
-  await tools.delayFor(2000);
-  done.resolve();
   await done.promise;
 });
 

ts/smartarchive.classes.smartarchive.ts

@@ -12,6 +12,7 @@ export class SmartArchive {
   public async extractArchiveFromUrlToFs(urlArg: string, targetDir: string) {
     const parsedPath = plugins.path.parse(urlArg);
     const uniqueFileName = plugins.smartunique.uni() + parsedPath.ext;
+    plugins.smartfile.fs.ensureDir(paths.nogitDir); // TODO: totally remove caching needs
     const downloadPath = plugins.path.join(paths.nogitDir, uniqueFileName);
     const downloadedArchive = (await plugins.smartrequest.getBinary(urlArg)).body;
     await plugins.smartfile.memory.toFs(downloadedArchive, downloadPath);
@@ -68,7 +69,7 @@ export class SmartArchive {
       stream.resume();
     });
     extractPipeStop.on('finish', () => {
-      replaySubject.unsubscribe();
+      replaySubject.complete();
     });
     // lets run the stream
     readableStream

ts/smartarchive.paths.ts

@@ -2,4 +2,3 @@ import * as plugins from './smartarchive.plugins';
 
 export const packageDir = plugins.path.join(__dirname, '../');
 export const nogitDir = plugins.path.join(__dirname, './.nogit');
-plugins.smartfile.fs.ensureDir(nogitDir);