Compare commits

..

No commits in common. "master" and "v5.4.0" have entirely different histories.

19 changed files with 325 additions and 1051 deletions

View File

@ -6,8 +6,8 @@ on:
- '**' - '**'
env: env:
IMAGE: code.foss.global/host.today/ht-docker-node:npmci IMAGE: registry.gitlab.com/hosttoday/ht-docker-node:npmci
NPMCI_COMPUTED_REPOURL: https://${{gitea.repository_owner}}:${{secrets.GITEA_TOKEN}}@/${{gitea.repository}}.git NPMCI_COMPUTED_REPOURL: https://${{gitea.repository_owner}}:${{secrets.GITEA_TOKEN}}@gitea.lossless.digital/${{gitea.repository}}.git
NPMCI_TOKEN_NPM: ${{secrets.NPMCI_TOKEN_NPM}} NPMCI_TOKEN_NPM: ${{secrets.NPMCI_TOKEN_NPM}}
NPMCI_TOKEN_NPM2: ${{secrets.NPMCI_TOKEN_NPM2}} NPMCI_TOKEN_NPM2: ${{secrets.NPMCI_TOKEN_NPM2}}
NPMCI_GIT_GITHUBTOKEN: ${{secrets.NPMCI_GIT_GITHUBTOKEN}} NPMCI_GIT_GITHUBTOKEN: ${{secrets.NPMCI_GIT_GITHUBTOKEN}}
@ -26,7 +26,7 @@ jobs:
- name: Install pnpm and npmci - name: Install pnpm and npmci
run: | run: |
pnpm install -g pnpm pnpm install -g pnpm
pnpm install -g @ship.zone/npmci pnpm install -g @shipzone/npmci
- name: Run npm prepare - name: Run npm prepare
run: npmci npm prepare run: npmci npm prepare

View File

@ -6,8 +6,8 @@ on:
- '*' - '*'
env: env:
IMAGE: code.foss.global/host.today/ht-docker-node:npmci IMAGE: registry.gitlab.com/hosttoday/ht-docker-node:npmci
NPMCI_COMPUTED_REPOURL: https://${{gitea.repository_owner}}:${{secrets.GITEA_TOKEN}}@/${{gitea.repository}}.git NPMCI_COMPUTED_REPOURL: https://${{gitea.repository_owner}}:${{secrets.GITEA_TOKEN}}@gitea.lossless.digital/${{gitea.repository}}.git
NPMCI_TOKEN_NPM: ${{secrets.NPMCI_TOKEN_NPM}} NPMCI_TOKEN_NPM: ${{secrets.NPMCI_TOKEN_NPM}}
NPMCI_TOKEN_NPM2: ${{secrets.NPMCI_TOKEN_NPM2}} NPMCI_TOKEN_NPM2: ${{secrets.NPMCI_TOKEN_NPM2}}
NPMCI_GIT_GITHUBTOKEN: ${{secrets.NPMCI_GIT_GITHUBTOKEN}} NPMCI_GIT_GITHUBTOKEN: ${{secrets.NPMCI_GIT_GITHUBTOKEN}}
@ -26,7 +26,7 @@ jobs:
- name: Prepare - name: Prepare
run: | run: |
pnpm install -g pnpm pnpm install -g pnpm
pnpm install -g @ship.zone/npmci pnpm install -g @shipzone/npmci
npmci npm prepare npmci npm prepare
- name: Audit production dependencies - name: Audit production dependencies
@ -54,7 +54,7 @@ jobs:
- name: Prepare - name: Prepare
run: | run: |
pnpm install -g pnpm pnpm install -g pnpm
pnpm install -g @ship.zone/npmci pnpm install -g @shipzone/npmci
npmci npm prepare npmci npm prepare
- name: Test stable - name: Test stable
@ -82,7 +82,7 @@ jobs:
- name: Prepare - name: Prepare
run: | run: |
pnpm install -g pnpm pnpm install -g pnpm
pnpm install -g @ship.zone/npmci pnpm install -g @shipzone/npmci
npmci npm prepare npmci npm prepare
- name: Release - name: Release
@ -104,7 +104,7 @@ jobs:
- name: Prepare - name: Prepare
run: | run: |
pnpm install -g pnpm pnpm install -g pnpm
pnpm install -g @ship.zone/npmci pnpm install -g @shipzone/npmci
npmci npm prepare npmci npm prepare
- name: Code quality - name: Code quality

3
.gitignore vendored
View File

@ -3,6 +3,7 @@
# artifacts # artifacts
coverage/ coverage/
public/ public/
pages/
# installs # installs
node_modules/ node_modules/
@ -16,4 +17,4 @@ node_modules/
dist/ dist/
dist_*/ dist_*/
#------# custom # custom

View File

@ -1,87 +1,5 @@
# Changelog # Changelog
## 2025-04-18 - 5.9.2 - fix(documentation)
Update search API documentation to replace deprecated searchWithLucene examples with the unified search(query) API and clarify its behavior.
- Replaced 'searchWithLucene' examples with 'search(query)' in the README.
- Updated explanation to detail field-specific exact match, partial word regex search, multi-word literal matching, and handling of empty queries.
- Clarified guidelines for creating MongoDB text indexes on searchable fields for optimized search performance.
## 2025-04-18 - 5.9.1 - fix(search)
Refactor search tests to use unified search API and update text index type casting
- Replaced all calls from searchWithLucene with search in test/search tests
- Updated text index specification in the collection class to use proper type casting
## 2025-04-18 - 5.9.0 - feat(collections/search)
Improve text index creation and search fallback mechanisms in collections and document search methods
- Auto-create a compound text index on all searchable fields in SmartdataCollection with a one-time flag to prevent duplicate index creation.
- Refine the search method in SmartDataDbDoc to support exact field matches and safe regex fallback for non-Lucene queries.
## 2025-04-17 - 5.8.4 - fix(core)
Update commit metadata with no functional code changes
- Commit info and documentation refreshed
- No code or test changes detected in the diff
## 2025-04-17 - 5.8.3 - fix(readme)
Improve readme documentation on data models and connection management
- Clarify that data models use @Collection, @unI, @svDb, @index, and @searchable decorators
- Document that ObjectId and Buffer fields are stored as BSON types natively without extra decorators
- Update connection management section to use 'db.close()' instead of 'db.disconnect()'
- Revise license section to reference the MIT License without including additional legal details
## 2025-04-14 - 5.8.2 - fix(classes.doc.ts)
Ensure collection initialization before creating a cursor in getCursorExtended
- Added 'await collection.init()' to guarantee that the MongoDB collection is initialized before using the cursor
- Prevents potential runtime errors when accessing collection.mongoDbCollection
## 2025-04-14 - 5.8.1 - fix(cursor, doc)
Add explicit return types and casts to SmartdataDbCursor methods and update getCursorExtended signature in SmartDataDbDoc.
- Specify Promise<T> as return type for next() in SmartdataDbCursor and cast return value to T.
- Specify Promise<T[]> as return type for toArray() in SmartdataDbCursor and cast return value to T[].
- Update getCursorExtended to return Promise<SmartdataDbCursor<T>> for clearer type safety.
## 2025-04-14 - 5.8.0 - feat(cursor)
Add toArray method to SmartdataDbCursor to convert raw MongoDB documents into initialized class instances
- Introduced asynchronous toArray method in SmartdataDbCursor which retrieves all documents from the MongoDB cursor
- Maps each native document to a SmartDataDbDoc instance using createInstanceFromMongoDbNativeDoc for consistent API usage
## 2025-04-14 - 5.7.0 - feat(SmartDataDbDoc)
Add extended cursor method getCursorExtended for flexible cursor modifications
- Introduces getCursorExtended in classes.doc.ts to allow modifier functions for MongoDB cursors
- Wraps the modified cursor with SmartdataDbCursor for improved API consistency
- Enhances querying capabilities by enabling customized cursor transformations
## 2025-04-07 - 5.6.0 - feat(indexing)
Add support for regular index creation in documents and collections
- Implement new index decorator in classes.doc.ts to mark properties with regular indexing options
- Update SmartdataCollection to create regular indexes if defined on a document during insert
- Enhance document structure to store and utilize regular index configurations
## 2025-04-06 - 5.5.1 - fix(ci & formatting)
Minor fixes: update CI workflow image and npmci package references, adjust package.json and readme URLs, and apply consistent code formatting.
- Update image and repo URL in Gitea workflows from GitLab to code.foss.global
- Replace '@shipzone/npmci' with '@ship.zone/npmci' throughout CI scripts
- Adjust homepage and bugs URL in package.json and readme
- Apply trailing commas and consistent formatting in TypeScript source files
- Minor update to .gitignore custom section label
## 2025-04-06 - 5.5.0 - feat(search)
Enhance search functionality with robust Lucene query transformation and reliable fallback mechanisms
- Improve Lucene adapter to properly structure $or queries for term, phrase, wildcard, and fuzzy search
- Implement and document a robust searchWithLucene method with fallback to in-memory filtering
- Update readme and tests with extensive examples for @searchable fields and Lucene-based queries
## 2025-04-06 - 5.4.0 - feat(core) ## 2025-04-06 - 5.4.0 - feat(core)
Refactor file structure and update dependency versions Refactor file structure and update dependency versions

View File

@ -1,6 +1,6 @@
{ {
"name": "@push.rocks/smartdata", "name": "@push.rocks/smartdata",
"version": "5.9.2", "version": "5.4.0",
"private": false, "private": false,
"description": "An advanced library for NoSQL data organization and manipulation using TypeScript with support for MongoDB, data validation, collections, and custom data types.", "description": "An advanced library for NoSQL data organization and manipulation using TypeScript with support for MongoDB, data validation, collections, and custom data types.",
"main": "dist_ts/index.js", "main": "dist_ts/index.js",
@ -18,9 +18,9 @@
"author": "Lossless GmbH", "author": "Lossless GmbH",
"license": "MIT", "license": "MIT",
"bugs": { "bugs": {
"url": "https://code.foss.global/push.rocks/smartdata/issues" "url": "https://gitlab.com/pushrocks/smartdata/issues"
}, },
"homepage": "https://code.foss.global/push.rocks/smartdata#readme", "homepage": "https://code.foss.global/push.rocks/smartdata",
"dependencies": { "dependencies": {
"@push.rocks/lik": "^6.0.14", "@push.rocks/lik": "^6.0.14",
"@push.rocks/smartdelay": "^3.0.1", "@push.rocks/smartdelay": "^3.0.1",
@ -68,8 +68,5 @@
"custom data types", "custom data types",
"ODM" "ODM"
], ],
"packageManager": "pnpm@10.7.0+sha512.6b865ad4b62a1d9842b61d674a393903b871d9244954f652b8842c2b553c72176b278f64c463e52d40fff8aba385c235c8c9ecf5cc7de4fd78b8bb6d49633ab6", "packageManager": "pnpm@10.7.0+sha512.6b865ad4b62a1d9842b61d674a393903b871d9244954f652b8842c2b553c72176b278f64c463e52d40fff8aba385c235c8c9ecf5cc7de4fd78b8bb6d49633ab6"
"pnpm": {
"overrides": {}
}
} }

145
readme.md
View File

@ -18,7 +18,6 @@ A powerful TypeScript-first MongoDB wrapper that provides advanced features for
- **Enhanced Cursors**: Chainable, type-safe cursor API with memory efficient data processing - **Enhanced Cursors**: Chainable, type-safe cursor API with memory efficient data processing
- **Type Conversion**: Automatic handling of MongoDB types like ObjectId and Binary data - **Type Conversion**: Automatic handling of MongoDB types like ObjectId and Binary data
- **Serialization Hooks**: Custom serialization and deserialization of document properties - **Serialization Hooks**: Custom serialization and deserialization of document properties
- **Powerful Search Capabilities**: Unified `search(query)` API supporting field:value exact matches, multi-field regex searches, case-insensitive matching, and automatic escaping to prevent regex injection
## Requirements ## Requirements
@ -27,7 +26,6 @@ A powerful TypeScript-first MongoDB wrapper that provides advanced features for
- TypeScript >= 4.x (for development) - TypeScript >= 4.x (for development)
## Install ## Install
To install `@push.rocks/smartdata`, use npm: To install `@push.rocks/smartdata`, use npm:
```bash ```bash
@ -41,11 +39,9 @@ pnpm add @push.rocks/smartdata
``` ```
## Usage ## Usage
`@push.rocks/smartdata` enables efficient data handling and operation management with a focus on using MongoDB. It leverages TypeScript for strong typing and ESM syntax for modern JavaScript usage. `@push.rocks/smartdata` enables efficient data handling and operation management with a focus on using MongoDB. It leverages TypeScript for strong typing and ESM syntax for modern JavaScript usage.
### Setting Up and Connecting to the Database ### Setting Up and Connecting to the Database
Before interacting with the database, you need to set up and establish a connection. The `SmartdataDb` class handles connection pooling and automatic reconnection. Before interacting with the database, you need to set up and establish a connection. The `SmartdataDb` class handles connection pooling and automatic reconnection.
```typescript ```typescript
@ -65,18 +61,10 @@ await db.init();
``` ```
### Defining Data Models ### Defining Data Models
Data models in `@push.rocks/smartdata` are classes that represent collections and documents in your MongoDB database. Use decorators such as `@Collection`, `@unI`, and `@svDb` to define your data models.
Data models in `@push.rocks/smartdata` are classes that represent collections and documents in your MongoDB database. Use decorators such as `@Collection`, `@unI`, `@svDb`, `@index`, and `@searchable` to define your data models. Fields of type `ObjectId` or `Buffer` decorated with `@svDb()` will be stored as BSON ObjectId and Binary, respectively; no separate `@oid()` or `@bin()` decorators are required.
```typescript ```typescript
import { import { SmartDataDbDoc, Collection, unI, svDb, oid, bin, index } from '@push.rocks/smartdata';
SmartDataDbDoc,
Collection,
unI,
svDb,
index,
searchable,
} from '@push.rocks/smartdata';
import { ObjectId } from 'mongodb'; import { ObjectId } from 'mongodb';
@Collection(() => db) // Associate this model with the database instance @Collection(() => db) // Associate this model with the database instance
@ -85,23 +73,23 @@ class User extends SmartDataDbDoc<User, User> {
public id: string = 'unique-user-id'; // Mark 'id' as a unique index public id: string = 'unique-user-id'; // Mark 'id' as a unique index
@svDb() @svDb()
@searchable() // Mark 'username' as searchable
public username: string; // Mark 'username' to be saved in DB public username: string; // Mark 'username' to be saved in DB
@svDb() @svDb()
@searchable() // Mark 'email' as searchable
@index() // Create a regular index for this field @index() // Create a regular index for this field
public email: string; // Mark 'email' to be saved in DB public email: string; // Mark 'email' to be saved in DB
@svDb() @svDb()
public organizationId: ObjectId; // Stored as BSON ObjectId @oid() // Automatically handle as ObjectId type
public organizationId: ObjectId; // Will be automatically converted to/from ObjectId
@svDb() @svDb()
public profilePicture: Buffer; // Stored as BSON Binary @bin() // Automatically handle as Binary data
public profilePicture: Buffer; // Will be automatically converted to/from Binary
@svDb({ @svDb({
serialize: (data) => JSON.stringify(data), // Custom serialization serialize: (data) => JSON.stringify(data), // Custom serialization
deserialize: (data) => JSON.parse(data), // Custom deserialization deserialize: (data) => JSON.parse(data) // Custom deserialization
}) })
public preferences: Record<string, any>; public preferences: Record<string, any>;
@ -114,18 +102,15 @@ class User extends SmartDataDbDoc<User, User> {
``` ```
### CRUD Operations ### CRUD Operations
`@push.rocks/smartdata` simplifies CRUD operations with intuitive methods on model instances. `@push.rocks/smartdata` simplifies CRUD operations with intuitive methods on model instances.
#### Create #### Create
```typescript ```typescript
const newUser = new User('myUsername', 'myEmail@example.com'); const newUser = new User('myUsername', 'myEmail@example.com');
await newUser.save(); // Save the new user to the database await newUser.save(); // Save the new user to the database
``` ```
#### Read #### Read
```typescript ```typescript
// Fetch a single user by a unique attribute // Fetch a single user by a unique attribute
const user = await User.getInstance({ username: 'myUsername' }); const user = await User.getInstance({ username: 'myUsername' });
@ -161,7 +146,6 @@ await cursor.close();
``` ```
#### Update #### Update
```typescript ```typescript
// Assuming 'user' is an instance of User // Assuming 'user' is an instance of User
user.email = 'newEmail@example.com'; user.email = 'newEmail@example.com';
@ -170,16 +154,14 @@ await user.save(); // Update the user in the database
// Upsert operations (insert if not exists, update if exists) // Upsert operations (insert if not exists, update if exists)
const upsertedUser = await User.upsert( const upsertedUser = await User.upsert(
{ id: 'user-123' }, // Query to find the user { id: 'user-123' }, // Query to find the user
{ { // Fields to update or insert
// Fields to update or insert
username: 'newUsername', username: 'newUsername',
email: 'newEmail@example.com', email: 'newEmail@example.com'
}, }
); );
``` ```
#### Delete #### Delete
```typescript ```typescript
// Assuming 'user' is an instance of User // Assuming 'user' is an instance of User
await user.delete(); // Delete the user from the database await user.delete(); // Delete the user from the database
@ -187,65 +169,7 @@ await user.delete(); // Delete the user from the database
## Advanced Features ## Advanced Features
### Search Functionality
SmartData provides powerful search capabilities with a Lucene-like query syntax and robust fallback mechanisms:
```typescript
// Define a model with searchable fields
@Collection(() => db)
class Product extends SmartDataDbDoc<Product, Product> {
@unI()
public id: string = 'product-id';
@svDb()
@searchable() // Mark this field as searchable
public name: string;
@svDb()
@searchable() // Mark this field as searchable
public description: string;
@svDb()
@searchable() // Mark this field as searchable
public category: string;
@svDb()
public price: number;
}
// Get all fields marked as searchable for a class
const searchableFields = getSearchableFields('Product'); // ['name', 'description', 'category']
// Basic search across all searchable fields
const iphoneProducts = await Product.search('iPhone');
// Field-specific exact match
const electronicsProducts = await Product.search('category:Electronics');
// Partial word search (regex across all fields)
const laptopResults = await Product.search('laptop');
// Multi-word literal search
const paperwhite = await Product.search('Kindle Paperwhite');
// Empty query returns all documents
const allProducts = await Product.search('');
```
The search functionality includes:
- `@searchable()` decorator for marking fields as searchable
- `getSearchableFields()` to list searchable fields for a model
- `search(query: string)` method supporting:
- Field-specific exact matches (`field:value`)
- Case-insensitive partial matches across all searchable fields
- Multi-word literal matching
- Empty queries returning all documents
- Automatic escaping of special characters to prevent regex injection
### EasyStore ### EasyStore
EasyStore provides a simple key-value storage system with automatic persistence: EasyStore provides a simple key-value storage system with automatic persistence:
```typescript ```typescript
@ -276,7 +200,6 @@ await store.deleteKey('apiKey');
``` ```
### Distributed Coordination ### Distributed Coordination
Built-in support for distributed systems with leader election: Built-in support for distributed systems with leader election:
```typescript ```typescript
@ -314,20 +237,16 @@ await coordinator.stop();
``` ```
### Real-time Data Watching ### Real-time Data Watching
Watch for changes in your collections with RxJS integration using MongoDB Change Streams: Watch for changes in your collections with RxJS integration using MongoDB Change Streams:
```typescript ```typescript
// Create a watcher for a specific collection with a query filter // Create a watcher for a specific collection with a query filter
const watcher = await User.watch( const watcher = await User.watch({
{ active: true // Only watch for changes to active users
active: true, // Only watch for changes to active users }, {
},
{
fullDocument: true, // Include the full document in change notifications fullDocument: true, // Include the full document in change notifications
bufferTimeMs: 100, // Buffer changes for 100ms to reduce notification frequency bufferTimeMs: 100 // Buffer changes for 100ms to reduce notification frequency
}, });
);
// Subscribe to changes using RxJS // Subscribe to changes using RxJS
watcher.changeSubject.subscribe((change) => { watcher.changeSubject.subscribe((change) => {
@ -354,7 +273,6 @@ await watcher.stop();
``` ```
### Managed Collections ### Managed Collections
For more complex data models that require additional context: For more complex data models that require additional context:
```typescript ```typescript
@ -377,7 +295,6 @@ class ManagedDoc extends SmartDataDbDoc<ManagedDoc, ManagedDoc> {
``` ```
### Automatic Indexing ### Automatic Indexing
Define indexes directly in your model class: Define indexes directly in your model class:
```typescript ```typescript
@ -407,7 +324,6 @@ class Product extends SmartDataDbDoc<Product, Product> {
``` ```
### Transaction Support ### Transaction Support
Use MongoDB transactions for atomic operations: Use MongoDB transactions for atomic operations:
```typescript ```typescript
@ -428,7 +344,6 @@ try {
``` ```
### Deep Object Queries ### Deep Object Queries
SmartData provides fully type-safe deep property queries with the `DeepQuery` type: SmartData provides fully type-safe deep property queries with the `DeepQuery` type:
```typescript ```typescript
@ -445,14 +360,14 @@ class UserProfile extends SmartDataDbDoc<UserProfile, UserProfile> {
address: { address: {
city: string; city: string;
country: string; country: string;
}; }
}; }
}; };
} }
// Type-safe string literals for dot notation // Type-safe string literals for dot notation
const usersInUSA = await UserProfile.getInstances({ const usersInUSA = await UserProfile.getInstances({
'user.details.address.country': 'USA', 'user.details.address.country': 'USA'
}); });
// Fully typed deep queries with the DeepQuery type // Fully typed deep queries with the DeepQuery type
@ -461,7 +376,7 @@ import { DeepQuery } from '@push.rocks/smartdata';
const typedQuery: DeepQuery<UserProfile> = { const typedQuery: DeepQuery<UserProfile> = {
id: 'profile-id', id: 'profile-id',
'user.details.firstName': 'John', 'user.details.firstName': 'John',
'user.details.address.country': 'USA', 'user.details.address.country': 'USA'
}; };
// TypeScript will error if paths are incorrect // TypeScript will error if paths are incorrect
@ -470,14 +385,13 @@ const results = await UserProfile.getInstances(typedQuery);
// MongoDB query operators are supported // MongoDB query operators are supported
const operatorQuery: DeepQuery<UserProfile> = { const operatorQuery: DeepQuery<UserProfile> = {
'user.details.address.country': 'USA', 'user.details.address.country': 'USA',
'user.details.address.city': { $in: ['New York', 'Los Angeles'] }, 'user.details.address.city': { $in: ['New York', 'Los Angeles'] }
}; };
const filteredResults = await UserProfile.getInstances(operatorQuery); const filteredResults = await UserProfile.getInstances(operatorQuery);
``` ```
### Document Lifecycle Hooks ### Document Lifecycle Hooks
Implement custom logic at different stages of a document's lifecycle: Implement custom logic at different stages of a document's lifecycle:
```typescript ```typescript
@ -523,39 +437,26 @@ class Order extends SmartDataDbDoc<Order, Order> {
## Best Practices ## Best Practices
### Connection Management ### Connection Management
- Always call `db.init()` before using any database features - Always call `db.init()` before using any database features
- Use `db.close()` when shutting down your application - Use `db.disconnect()` when shutting down your application
- Set appropriate connection pool sizes based on your application's needs - Set appropriate connection pool sizes based on your application's needs
### Document Design ### Document Design
- Use appropriate decorators (`@svDb`, `@unI`, `@index`) to optimize database operations
- Use appropriate decorators (`@svDb`, `@unI`, `@index`, `@searchable`) to optimize database operations
- Implement type-safe models by properly extending `SmartDataDbDoc` - Implement type-safe models by properly extending `SmartDataDbDoc`
- Consider using interfaces to define document structures separately from implementation - Consider using interfaces to define document structures separately from implementation
- Mark fields that need to be searched with the `@searchable()` decorator
### Search Optimization
- (Optional) Create MongoDB text indexes on searchable fields to speed up full-text search
- Use `search(query)` for all search operations (field:value, partial matches, multi-word)
- Prefer field-specific exact matches when possible for optimal performance
- Avoid unnecessary complexity in query strings to keep regex searches efficient
### Performance Optimization ### Performance Optimization
- Use cursors for large datasets instead of loading all documents into memory - Use cursors for large datasets instead of loading all documents into memory
- Create appropriate indexes for frequent query patterns - Create appropriate indexes for frequent query patterns
- Use projections to limit the fields returned when you don't need the entire document - Use projections to limit the fields returned when you don't need the entire document
### Distributed Systems ### Distributed Systems
- Implement proper error handling for leader election events - Implement proper error handling for leader election events
- Ensure all instances have synchronized clocks when using time-based coordination - Ensure all instances have synchronized clocks when using time-based coordination
- Use the distributed coordinator's task management features for coordinated operations - Use the distributed coordinator's task management features for coordinated operations
### Type Safety ### Type Safety
- Take advantage of the `DeepQuery<T>` type for fully type-safe queries - Take advantage of the `DeepQuery<T>` type for fully type-safe queries
- Define proper types for your document models to enhance IDE auto-completion - Define proper types for your document models to enhance IDE auto-completion
- Use generic type parameters to specify exact document types when working with collections - Use generic type parameters to specify exact document types when working with collections
@ -574,7 +475,7 @@ Please make sure to update tests as appropriate and follow our coding standards.
## License and Legal Information ## License and Legal Information
This repository is licensed under the MIT License. For details, see [MIT License](https://opensource.org/licenses/MIT). This repository contains open-source code that is licensed under the MIT License. A copy of the MIT License can be found in the [license](license) file within this repository.
**Please note:** The MIT License does not grant permission to use the trade names, trademarks, service marks, or product names of the project, except as required for reasonable and customary use in describing the origin of the work and reproducing the content of the NOTICE file. **Please note:** The MIT License does not grant permission to use the trade names, trademarks, service marks, or product names of the project, except as required for reasonable and customary use in describing the origin of the work and reproducing the content of the NOTICE file.

View File

@ -3,10 +3,7 @@ import * as smartmongo from '@push.rocks/smartmongo';
import type * as taskbuffer from '@push.rocks/taskbuffer'; import type * as taskbuffer from '@push.rocks/taskbuffer';
import * as smartdata from '../ts/index.js'; import * as smartdata from '../ts/index.js';
import { import { SmartdataDistributedCoordinator, DistributedClass } from '../ts/classes.distributedcoordinator.js'; // path might need adjusting
SmartdataDistributedCoordinator,
DistributedClass,
} from '../ts/classes.distributedcoordinator.js'; // path might need adjusting
const totalInstances = 10; const totalInstances = 10;
// ======================================= // =======================================
@ -52,71 +49,64 @@ tap.test('SmartdataDistributedCoordinator should update leader status', async (t
await distributedCoordinator.stop(); await distributedCoordinator.stop();
}); });
tap.test( tap.test('SmartdataDistributedCoordinator should handle distributed task requests', async (tools) => {
'SmartdataDistributedCoordinator should handle distributed task requests',
async (tools) => {
const distributedCoordinator = new SmartdataDistributedCoordinator(testDb); const distributedCoordinator = new SmartdataDistributedCoordinator(testDb);
await distributedCoordinator.start(); await distributedCoordinator.start();
const mockTaskRequest: taskbuffer.distributedCoordination.IDistributedTaskRequest = { const mockTaskRequest: taskbuffer.distributedCoordination.IDistributedTaskRequest = {
submitterId: 'mockSubmitter12345', // Some unique mock submitter ID submitterId: "mockSubmitter12345", // Some unique mock submitter ID
requestResponseId: 'uni879873462hjhfkjhsdf', // Some unique ID for the request-response requestResponseId: 'uni879873462hjhfkjhsdf', // Some unique ID for the request-response
taskName: 'SampleTask', taskName: "SampleTask",
taskVersion: '1.0.0', // Assuming it's a version string taskVersion: "1.0.0", // Assuming it's a version string
taskExecutionTime: Date.now(), taskExecutionTime: Date.now(),
taskExecutionTimeout: 60000, // Let's say the timeout is 1 minute (60000 ms) taskExecutionTimeout: 60000, // Let's say the timeout is 1 minute (60000 ms)
taskExecutionParallel: 5, // Let's assume max 5 parallel executions taskExecutionParallel: 5, // Let's assume max 5 parallel executions
status: 'requesting', status: 'requesting'
}; };
const response = await distributedCoordinator.fireDistributedTaskRequest(mockTaskRequest); const response = await distributedCoordinator.fireDistributedTaskRequest(mockTaskRequest);
console.log(response); // based on your expected structure for the response console.log(response) // based on your expected structure for the response
await distributedCoordinator.stop(); await distributedCoordinator.stop();
}, });
);
tap.test( tap.test('SmartdataDistributedCoordinator should update distributed task requests', async (tools) => {
'SmartdataDistributedCoordinator should update distributed task requests',
async (tools) => {
const distributedCoordinator = new SmartdataDistributedCoordinator(testDb); const distributedCoordinator = new SmartdataDistributedCoordinator(testDb);
await distributedCoordinator.start(); await distributedCoordinator.start();
const mockTaskRequest: taskbuffer.distributedCoordination.IDistributedTaskRequest = { const mockTaskRequest: taskbuffer.distributedCoordination.IDistributedTaskRequest = {
submitterId: 'mockSubmitter12345', // Some unique mock submitter ID submitterId: "mockSubmitter12345", // Some unique mock submitter ID
requestResponseId: 'uni879873462hjhfkjhsdf', // Some unique ID for the request-response requestResponseId: 'uni879873462hjhfkjhsdf', // Some unique ID for the request-response
taskName: 'SampleTask', taskName: "SampleTask",
taskVersion: '1.0.0', // Assuming it's a version string taskVersion: "1.0.0", // Assuming it's a version string
taskExecutionTime: Date.now(), taskExecutionTime: Date.now(),
taskExecutionTimeout: 60000, // Let's say the timeout is 1 minute (60000 ms) taskExecutionTimeout: 60000, // Let's say the timeout is 1 minute (60000 ms)
taskExecutionParallel: 5, // Let's assume max 5 parallel executions taskExecutionParallel: 5, // Let's assume max 5 parallel executions
status: 'requesting', status: 'requesting'
}; };
await distributedCoordinator.updateDistributedTaskRequest(mockTaskRequest); await distributedCoordinator.updateDistributedTaskRequest(mockTaskRequest);
// Here, we can potentially check if a DB entry got updated or some other side-effect of the update method. // Here, we can potentially check if a DB entry got updated or some other side-effect of the update method.
await distributedCoordinator.stop(); await distributedCoordinator.stop();
}, });
);
tap.test('should elect only one leader amongst multiple instances', async (tools) => { tap.test('should elect only one leader amongst multiple instances', async (tools) => {
const coordinators = Array.from({ length: totalInstances }).map( const coordinators = Array.from({ length: totalInstances }).map(() => new SmartdataDistributedCoordinator(testDb));
() => new SmartdataDistributedCoordinator(testDb), await Promise.all(coordinators.map(coordinator => coordinator.start()));
); const leaders = coordinators.filter(coordinator => coordinator.ownInstance.data.elected);
await Promise.all(coordinators.map((coordinator) => coordinator.start()));
const leaders = coordinators.filter((coordinator) => coordinator.ownInstance.data.elected);
for (const leader of leaders) { for (const leader of leaders) {
console.log(leader.ownInstance); console.log(leader.ownInstance);
} }
expect(leaders.length).toEqual(1); expect(leaders.length).toEqual(1);
// stopping clears a coordinator from being elected. // stopping clears a coordinator from being elected.
await Promise.all(coordinators.map((coordinator) => coordinator.stop())); await Promise.all(coordinators.map(coordinator => coordinator.stop()));
}); });
tap.test('should clean up', async () => { tap.test('should clean up', async () => {
await smartmongoInstance.stopAndDumpToDir(`.nogit/dbdump/test.distributedcoordinator.ts`); await smartmongoInstance.stopAndDumpToDir(`.nogit/dbdump/test.distributedcoordinator.ts`);
setTimeout(() => process.exit(), 2000); setTimeout(() => process.exit(), 2000);
}); })
tap.start({ throwOnError: true }); tap.start({ throwOnError: true });

View File

@ -1,233 +0,0 @@
import { tap, expect } from '@push.rocks/tapbundle';
import * as smartmongo from '@push.rocks/smartmongo';
import { smartunique } from '../ts/plugins.js';
// Import the smartdata library
import * as smartdata from '../ts/index.js';
import { searchable, getSearchableFields } from '../ts/classes.doc.js';
// Set up database connection
let smartmongoInstance: smartmongo.SmartMongo;
let testDb: smartdata.SmartdataDb;
// Define a test class with searchable fields using the standard SmartDataDbDoc
@smartdata.Collection(() => testDb)
class Product extends smartdata.SmartDataDbDoc<Product, Product> {
@smartdata.unI()
public id: string = smartunique.shortId();
@smartdata.svDb()
@searchable()
public name: string;
@smartdata.svDb()
@searchable()
public description: string;
@smartdata.svDb()
@searchable()
public category: string;
@smartdata.svDb()
public price: number;
constructor(nameArg: string, descriptionArg: string, categoryArg: string, priceArg: number) {
super();
this.name = nameArg;
this.description = descriptionArg;
this.category = categoryArg;
this.price = priceArg;
}
}
tap.test('should create a test database instance', async () => {
smartmongoInstance = await smartmongo.SmartMongo.createAndStart();
testDb = new smartdata.SmartdataDb(await smartmongoInstance.getMongoDescriptor());
await testDb.init();
});
tap.test('should create test products with searchable fields', async () => {
// Create several products with different fields to search
const products = [
new Product('iPhone 12', 'Latest iPhone with A14 Bionic chip', 'Electronics', 999),
new Product('MacBook Pro', 'Powerful laptop for professionals', 'Electronics', 1999),
new Product('AirPods', 'Wireless earbuds with noise cancellation', 'Electronics', 249),
new Product('Galaxy S21', 'Samsung flagship phone with great camera', 'Electronics', 899),
new Product('Kindle Paperwhite', 'E-reader with built-in light', 'Books', 129),
new Product('Harry Potter', 'Fantasy book series about wizards', 'Books', 49),
new Product('Coffee Maker', 'Automatic drip coffee machine', 'Kitchen', 89),
new Product('Blender', 'High-speed blender for smoothies', 'Kitchen', 129),
];
// Save all products to the database
for (const product of products) {
await product.save();
}
// Verify that we can get all products
const allProducts = await Product.getInstances({});
expect(allProducts.length).toEqual(products.length);
console.log(`Successfully created and saved ${allProducts.length} products`);
});
tap.test('should retrieve searchable fields for a class', async () => {
// Use the getSearchableFields function to verify our searchable fields
const searchableFields = getSearchableFields('Product');
console.log('Searchable fields:', searchableFields);
expect(searchableFields.length).toEqual(3);
expect(searchableFields).toContain('name');
expect(searchableFields).toContain('description');
expect(searchableFields).toContain('category');
});
tap.test('should search products by exact field match', async () => {
// Basic field exact match search
const electronicsProducts = await Product.getInstances({ category: 'Electronics' });
console.log(`Found ${electronicsProducts.length} products in Electronics category`);
expect(electronicsProducts.length).toEqual(4);
});
tap.test('should search products by basic search method', async () => {
// Using the basic search method with simple Lucene query
try {
const iPhoneResults = await Product.search('iPhone');
console.log(`Found ${iPhoneResults.length} products matching 'iPhone' using basic search`);
expect(iPhoneResults.length).toEqual(1);
expect(iPhoneResults[0].name).toEqual('iPhone 12');
} catch (error) {
console.error('Basic search error:', error.message);
// If basic search fails, we'll demonstrate the enhanced approach in later tests
console.log('Will test with enhanced searchWithLucene method next');
}
});
tap.test('should search products with search method', async () => {
// Using the robust searchWithLucene method
const wirelessResults = await Product.search('wireless');
console.log(
`Found ${wirelessResults.length} products matching 'wireless' using search`,
);
expect(wirelessResults.length).toEqual(1);
expect(wirelessResults[0].name).toEqual('AirPods');
});
tap.test('should search products by category with search', async () => {
// Using field-specific search with searchWithLucene
const kitchenResults = await Product.search('category:Kitchen');
console.log(`Found ${kitchenResults.length} products in Kitchen category using search`);
expect(kitchenResults.length).toEqual(2);
expect(kitchenResults[0].category).toEqual('Kitchen');
expect(kitchenResults[1].category).toEqual('Kitchen');
});
tap.test('should search products with partial word matches', async () => {
// Testing partial word matches
const proResults = await Product.search('Pro');
console.log(`Found ${proResults.length} products matching 'Pro'`);
// Should match both "MacBook Pro" and "professionals" in description
expect(proResults.length).toBeGreaterThan(0);
});
tap.test('should search across multiple searchable fields', async () => {
// Test searching across all searchable fields
const bookResults = await Product.search('book');
console.log(`Found ${bookResults.length} products matching 'book' across all fields`);
// Should match "MacBook" in name and "Books" in category
expect(bookResults.length).toBeGreaterThan(1);
});
tap.test('should handle case insensitive searches', async () => {
// Test case insensitivity
const electronicsResults = await Product.search('electronics');
const ElectronicsResults = await Product.search('Electronics');
console.log(`Found ${electronicsResults.length} products matching lowercase 'electronics'`);
console.log(`Found ${ElectronicsResults.length} products matching capitalized 'Electronics'`);
// Both searches should return the same results
expect(electronicsResults.length).toEqual(ElectronicsResults.length);
});
tap.test('should demonstrate search fallback mechanisms', async () => {
console.log('\n====== FALLBACK MECHANISM DEMONSTRATION ======');
console.log('If MongoDB query fails, searchWithLucene will:');
console.log('1. Try using basic MongoDB filters');
console.log('2. Fall back to field-specific searches');
console.log('3. As last resort, perform in-memory filtering');
console.log('This ensures robust search even with complex queries');
console.log('==============================================\n');
// Use a simpler term that should be found in descriptions
// Avoid using "OR" operator which requires a text index
const results = await Product.search('high');
console.log(`Found ${results.length} products matching 'high'`);
// "High-speed blender" contains "high"
expect(results.length).toBeGreaterThan(0);
// Try another fallback example that won't need $text
const powerfulResults = await Product.search('powerful');
console.log(`Found ${powerfulResults.length} products matching 'powerful'`);
// "Powerful laptop for professionals" contains "powerful"
expect(powerfulResults.length).toBeGreaterThan(0);
});
tap.test('should explain the advantages of the integrated approach', async () => {
console.log('\n====== INTEGRATED SEARCH APPROACH BENEFITS ======');
console.log('1. No separate class hierarchy - keeps code simple');
console.log('2. Enhanced convertFilterForMongoDb handles MongoDB operators');
console.log('3. Robust fallback mechanisms ensure searches always work');
console.log('4. searchWithLucene provides powerful search capabilities');
console.log('5. Backwards compatible with existing code');
console.log('================================================\n');
expect(true).toEqual(true);
});
// Additional robustness tests
tap.test('should search exact name using field:value', async () => {
const nameResults = await Product.search('name:AirPods');
expect(nameResults.length).toEqual(1);
expect(nameResults[0].name).toEqual('AirPods');
});
tap.test('should throw when searching non-searchable field', async () => {
let error: Error;
try {
await Product.search('price:129');
} catch (err) {
error = err as Error;
}
expect(error).toBeTruthy();
expect(error.message).toMatch(/not searchable/);
});
tap.test('empty query should return all products', async () => {
const allResults = await Product.search('');
expect(allResults.length).toEqual(8);
});
tap.test('should search multi-word term across fields', async () => {
const termResults = await Product.search('iPhone 12');
expect(termResults.length).toEqual(1);
expect(termResults[0].name).toEqual('iPhone 12');
});
tap.test('close database connection', async () => {
await testDb.mongoDb.dropDatabase();
await testDb.close();
if (smartmongoInstance) {
await smartmongoInstance.stopAndDumpToDir(`.nogit/dbdump/test.search.ts`);
}
setTimeout(() => process.exit(), 2000);
});
tap.start({ throwOnError: true });

View File

@ -97,7 +97,7 @@ tap.test('should save the car to the db', async (toolsArg) => {
console.log( console.log(
`Filled database with ${counter} of ${totalCars} Cars and memory usage ${ `Filled database with ${counter} of ${totalCars} Cars and memory usage ${
process.memoryUsage().rss / 1e6 process.memoryUsage().rss / 1e6
} MB`, } MB`
); );
} }
} while (counter < totalCars); } while (counter < totalCars);
@ -116,7 +116,7 @@ tap.test('expect to get instance of Car with shallow match', async () => {
console.log( console.log(
`performed ${counter} of ${totalQueryCycles} total query cycles: took ${ `performed ${counter} of ${totalQueryCycles} total query cycles: took ${
Date.now() - timeStart Date.now() - timeStart
}ms to query a set of 2000 with memory footprint ${process.memoryUsage().rss / 1e6} MB`, }ms to query a set of 2000 with memory footprint ${process.memoryUsage().rss / 1e6} MB`
); );
} }
expect(myCars[0].deepData.sodeep).toEqual('yes'); expect(myCars[0].deepData.sodeep).toEqual('yes');
@ -139,7 +139,7 @@ tap.test('expect to get instance of Car with deep match', async () => {
console.log( console.log(
`performed ${counter} of ${totalQueryCycles} total query cycles: took ${ `performed ${counter} of ${totalQueryCycles} total query cycles: took ${
Date.now() - timeStart Date.now() - timeStart
}ms to deep query a set of 2000 with memory footprint ${process.memoryUsage().rss / 1e6} MB`, }ms to deep query a set of 2000 with memory footprint ${process.memoryUsage().rss / 1e6} MB`
); );
} }
expect(myCars2[0].deepData.sodeep).toEqual('yes'); expect(myCars2[0].deepData.sodeep).toEqual('yes');
@ -209,7 +209,7 @@ tap.test('should store a new Truck', async () => {
tap.test('should return a count', async () => { tap.test('should return a count', async () => {
const truckCount = await Truck.getCount(); const truckCount = await Truck.getCount();
expect(truckCount).toEqual(1); expect(truckCount).toEqual(1);
}); })
tap.test('should use a cursor', async () => { tap.test('should use a cursor', async () => {
const cursor = await Car.getCursor({}); const cursor = await Car.getCursor({});

View File

@ -3,6 +3,6 @@
*/ */
export const commitinfo = { export const commitinfo = {
name: '@push.rocks/smartdata', name: '@push.rocks/smartdata',
version: '5.9.2', version: '5.4.0',
description: 'An advanced library for NoSQL data organization and manipulation using TypeScript with support for MongoDB, data validation, collections, and custom data types.' description: 'An advanced library for NoSQL data organization and manipulation using TypeScript with support for MongoDB, data validation, collections, and custom data types.'
} }

View File

@ -1,7 +1,7 @@
import * as plugins from './plugins.js'; import * as plugins from './plugins.js';
import { SmartdataDb } from './classes.db.js'; import { SmartdataDb } from './classes.db.js';
import { SmartdataDbCursor } from './classes.cursor.js'; import { SmartdataDbCursor } from './classes.cursor.js';
import { SmartDataDbDoc, type IIndexOptions, getSearchableFields } from './classes.doc.js'; import { SmartDataDbDoc } from './classes.doc.js';
import { SmartdataDbWatcher } from './classes.watcher.js'; import { SmartdataDbWatcher } from './classes.watcher.js';
import { CollectionFactory } from './classes.collectionfactory.js'; import { CollectionFactory } from './classes.collectionfactory.js';
@ -49,7 +49,7 @@ export interface IManager {
db: SmartdataDb; db: SmartdataDb;
} }
export const setDefaultManagerForDoc = <T,>(managerArg: IManager, dbDocArg: T): T => { export const setDefaultManagerForDoc = <T>(managerArg: IManager, dbDocArg: T): T => {
(dbDocArg as any).prototype.defaultManager = managerArg; (dbDocArg as any).prototype.defaultManager = managerArg;
return dbDocArg; return dbDocArg;
}; };
@ -127,9 +127,6 @@ export class SmartdataCollection<T> {
public collectionName: string; public collectionName: string;
public smartdataDb: SmartdataDb; public smartdataDb: SmartdataDb;
public uniqueIndexes: string[] = []; public uniqueIndexes: string[] = [];
public regularIndexes: Array<{field: string, options: IIndexOptions}> = [];
// flag to ensure text index is created only once
private textIndexCreated: boolean = false;
constructor(classNameArg: string, smartDataDbArg: SmartdataDb) { constructor(classNameArg: string, smartDataDbArg: SmartdataDb) {
// tell the collection where it belongs // tell the collection where it belongs
@ -155,16 +152,6 @@ export class SmartdataCollection<T> {
console.log(`Successfully initiated Collection ${this.collectionName}`); console.log(`Successfully initiated Collection ${this.collectionName}`);
} }
this.mongoDbCollection = this.smartdataDb.mongoDb.collection(this.collectionName); this.mongoDbCollection = this.smartdataDb.mongoDb.collection(this.collectionName);
// Auto-create a compound text index on all searchable fields
const searchableFields = getSearchableFields(this.collectionName);
if (searchableFields.length > 0 && !this.textIndexCreated) {
// Build a compound text index spec
const indexSpec: Record<string, 'text'> = {};
searchableFields.forEach(f => { indexSpec[f] = 'text'; });
// Cast to any to satisfy TypeScript IndexSpecification typing
await this.mongoDbCollection.createIndex(indexSpec as any, { name: 'smartdata_text_index' });
this.textIndexCreated = true;
}
} }
} }
@ -183,24 +170,6 @@ export class SmartdataCollection<T> {
} }
} }
/**
* creates regular indexes for the collection
*/
public createRegularIndexes(indexesArg: Array<{field: string, options: IIndexOptions}> = []) {
for (const indexDef of indexesArg) {
// Check if we've already created this index
const indexKey = indexDef.field;
if (!this.regularIndexes.some(i => i.field === indexKey)) {
this.mongoDbCollection.createIndex(
{ [indexDef.field]: 1 }, // Simple single-field index
indexDef.options
);
// Track that we've created this index
this.regularIndexes.push(indexDef);
}
}
}
/** /**
* adds a validation function that all newly inserted and updated objects have to pass * adds a validation function that all newly inserted and updated objects have to pass
*/ */
@ -221,7 +190,7 @@ export class SmartdataCollection<T> {
public async getCursor( public async getCursor(
filterObjectArg: any, filterObjectArg: any,
dbDocArg: typeof SmartDataDbDoc, dbDocArg: typeof SmartDataDbDoc
): Promise<SmartdataDbCursor<any>> { ): Promise<SmartdataDbCursor<any>> {
await this.init(); await this.init();
const cursor = this.mongoDbCollection.find(filterObjectArg); const cursor = this.mongoDbCollection.find(filterObjectArg);
@ -244,7 +213,7 @@ export class SmartdataCollection<T> {
*/ */
public async watch( public async watch(
filterObject: any, filterObject: any,
smartdataDbDocArg: typeof SmartDataDbDoc, smartdataDbDocArg: typeof SmartDataDbDoc
): Promise<SmartdataDbWatcher> { ): Promise<SmartdataDbWatcher> {
await this.init(); await this.init();
const changeStream = this.mongoDbCollection.watch( const changeStream = this.mongoDbCollection.watch(
@ -255,7 +224,7 @@ export class SmartdataCollection<T> {
], ],
{ {
fullDocument: 'updateLookup', fullDocument: 'updateLookup',
}, }
); );
const smartdataWatcher = new SmartdataDbWatcher(changeStream, smartdataDbDocArg); const smartdataWatcher = new SmartdataDbWatcher(changeStream, smartdataDbDocArg);
await smartdataWatcher.readyDeferred.promise; await smartdataWatcher.readyDeferred.promise;
@ -269,12 +238,6 @@ export class SmartdataCollection<T> {
await this.init(); await this.init();
await this.checkDoc(dbDocArg); await this.checkDoc(dbDocArg);
this.markUniqueIndexes(dbDocArg.uniqueIndexes); this.markUniqueIndexes(dbDocArg.uniqueIndexes);
// Create regular indexes if available
if (dbDocArg.regularIndexes && dbDocArg.regularIndexes.length > 0) {
this.createRegularIndexes(dbDocArg.regularIndexes);
}
const saveableObject = await dbDocArg.createSavableObject(); const saveableObject = await dbDocArg.createSavableObject();
const result = await this.mongoDbCollection.insertOne(saveableObject); const result = await this.mongoDbCollection.insertOne(saveableObject);
return result; return result;
@ -298,7 +261,7 @@ export class SmartdataCollection<T> {
const result = await this.mongoDbCollection.updateOne( const result = await this.mongoDbCollection.updateOne(
identifiableObject, identifiableObject,
{ $set: updateableObject }, { $set: updateableObject },
{ upsert: true }, { upsert: true }
); );
return result; return result;
} }

View File

@ -15,14 +15,14 @@ export class SmartdataDbCursor<T = any> {
this.smartdataDbDoc = dbDocArg; this.smartdataDbDoc = dbDocArg;
} }
public async next(closeAtEnd = true): Promise<T> { public async next(closeAtEnd = true) {
const result = this.smartdataDbDoc.createInstanceFromMongoDbNativeDoc( const result = this.smartdataDbDoc.createInstanceFromMongoDbNativeDoc(
await this.mongodbCursor.next(), await this.mongodbCursor.next()
); );
if (!result && closeAtEnd) { if (!result && closeAtEnd) {
await this.close(); await this.close();
} }
return result as T; return result;
} }
public async forEach(forEachFuncArg: (itemArg: T) => Promise<any>, closeCursorAtEnd = true) { public async forEach(forEachFuncArg: (itemArg: T) => Promise<any>, closeCursorAtEnd = true) {
@ -40,11 +40,6 @@ export class SmartdataDbCursor<T = any> {
} }
} }
public async toArray(): Promise<T[]> {
const result = await this.mongodbCursor.toArray();
return result.map((itemArg) => this.smartdataDbDoc.createInstanceFromMongoDbNativeDoc(itemArg)) as T[];
}
public async close() { public async close() {
await this.mongodbCursor.close(); await this.mongodbCursor.close();
} }

View File

@ -139,7 +139,7 @@ export class SmartdataDistributedCoordinator extends plugins.taskbuffer.distribu
const eligibleLeader = leaders.find( const eligibleLeader = leaders.find(
(leader) => (leader) =>
leader.data.lastUpdated >= leader.data.lastUpdated >=
Date.now() - plugins.smarttime.getMilliSecondsFromUnits({ seconds: 20 }), Date.now() - plugins.smarttime.getMilliSecondsFromUnits({ seconds: 20 })
); );
return eligibleLeader; return eligibleLeader;
}); });
@ -178,14 +178,16 @@ export class SmartdataDistributedCoordinator extends plugins.taskbuffer.distribu
console.log('bidding code stored.'); console.log('bidding code stored.');
}); });
console.log(`bidding for leadership...`); console.log(`bidding for leadership...`);
await plugins.smartdelay.delayFor(plugins.smarttime.getMilliSecondsFromUnits({ seconds: 5 })); await plugins.smartdelay.delayFor(
plugins.smarttime.getMilliSecondsFromUnits({ seconds: 5 })
);
await this.asyncExecutionStack.getExclusiveExecutionSlot(async () => { await this.asyncExecutionStack.getExclusiveExecutionSlot(async () => {
let biddingInstances = await DistributedClass.getInstances({}); let biddingInstances = await DistributedClass.getInstances({});
biddingInstances = biddingInstances.filter( biddingInstances = biddingInstances.filter(
(instanceArg) => (instanceArg) =>
instanceArg.data.status === 'bidding' && instanceArg.data.status === 'bidding' &&
instanceArg.data.lastUpdated >= instanceArg.data.lastUpdated >=
Date.now() - plugins.smarttime.getMilliSecondsFromUnits({ seconds: 10 }), Date.now() - plugins.smarttime.getMilliSecondsFromUnits({ seconds: 10 })
); );
console.log(`found ${biddingInstances.length} bidding instances...`); console.log(`found ${biddingInstances.length} bidding instances...`);
this.ownInstance.data.elected = true; this.ownInstance.data.elected = true;
@ -240,7 +242,7 @@ export class SmartdataDistributedCoordinator extends plugins.taskbuffer.distribu
for (const instance of allInstances) { for (const instance of allInstances) {
if (instance.data.status === 'stopped') { if (instance.data.status === 'stopped') {
await instance.delete(); await instance.delete();
} };
} }
await plugins.smartdelay.delayFor(10000); await plugins.smartdelay.delayFor(10000);
} }
@ -248,7 +250,7 @@ export class SmartdataDistributedCoordinator extends plugins.taskbuffer.distribu
// abstract implemented methods // abstract implemented methods
public async fireDistributedTaskRequest( public async fireDistributedTaskRequest(
taskRequestArg: plugins.taskbuffer.distributedCoordination.IDistributedTaskRequest, taskRequestArg: plugins.taskbuffer.distributedCoordination.IDistributedTaskRequest
): Promise<plugins.taskbuffer.distributedCoordination.IDistributedTaskRequestResult> { ): Promise<plugins.taskbuffer.distributedCoordination.IDistributedTaskRequestResult> {
await this.asyncExecutionStack.getExclusiveExecutionSlot(async () => { await this.asyncExecutionStack.getExclusiveExecutionSlot(async () => {
if (!this.ownInstance) { if (!this.ownInstance) {
@ -275,7 +277,7 @@ export class SmartdataDistributedCoordinator extends plugins.taskbuffer.distribu
} }
public async updateDistributedTaskRequest( public async updateDistributedTaskRequest(
infoBasisArg: plugins.taskbuffer.distributedCoordination.IDistributedTaskRequest, infoBasisArg: plugins.taskbuffer.distributedCoordination.IDistributedTaskRequest
): Promise<void> { ): Promise<void> {
await this.asyncExecutionStack.getExclusiveExecutionSlot(async () => { await this.asyncExecutionStack.getExclusiveExecutionSlot(async () => {
const existingInfoBasis = this.ownInstance.data.taskRequests.find((infoBasisItem) => { const existingInfoBasis = this.ownInstance.data.taskRequests.find((infoBasisItem) => {

View File

@ -61,10 +61,6 @@ export function getSearchableFields(className: string): string[] {
} }
return Array.from(searchableFieldsMap.get(className)); return Array.from(searchableFieldsMap.get(className));
} }
// Escape user input for safe use in MongoDB regular expressions
function escapeForRegex(input: string): string {
return input.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
}
/** /**
* unique index - decorator to mark a unique index * unique index - decorator to mark a unique index
@ -87,56 +83,7 @@ export function unI() {
}; };
} }
/**
* Options for MongoDB indexes
*/
export interface IIndexOptions {
background?: boolean;
unique?: boolean;
sparse?: boolean;
expireAfterSeconds?: number;
[key: string]: any;
}
/**
* index - decorator to mark a field for regular indexing
*/
export function index(options?: IIndexOptions) {
return (target: SmartDataDbDoc<unknown, unknown>, key: string) => {
console.log(`called index() on >${target.constructor.name}.${key}<`);
// Initialize regular indexes array if it doesn't exist
if (!target.regularIndexes) {
target.regularIndexes = [];
}
// Add this field to regularIndexes with its options
target.regularIndexes.push({
field: key,
options: options || {}
});
// Also ensure it's marked as saveable
if (!target.saveableProperties) {
target.saveableProperties = [];
}
if (!target.saveableProperties.includes(key)) {
target.saveableProperties.push(key);
}
};
}
export const convertFilterForMongoDb = (filterArg: { [key: string]: any }) => { export const convertFilterForMongoDb = (filterArg: { [key: string]: any }) => {
// Special case: detect MongoDB operators and pass them through directly
const topLevelOperators = ['$and', '$or', '$nor', '$not', '$text', '$where', '$regex'];
for (const key of Object.keys(filterArg)) {
if (topLevelOperators.includes(key)) {
return filterArg; // Return the filter as-is for MongoDB operators
}
}
// Original conversion logic for non-MongoDB query objects
const convertedFilter: { [key: string]: any } = {}; const convertedFilter: { [key: string]: any } = {};
const convertFilterArgument = (keyPathArg2: string, filterArg2: any) => { const convertFilterArgument = (keyPathArg2: string, filterArg2: any) => {
@ -179,7 +126,7 @@ export class SmartDataDbDoc<T extends TImplements, TImplements, TManager extends
// STATIC // STATIC
public static createInstanceFromMongoDbNativeDoc<T>( public static createInstanceFromMongoDbNativeDoc<T>(
this: plugins.tsclass.typeFest.Class<T>, this: plugins.tsclass.typeFest.Class<T>,
mongoDbNativeDocArg: any, mongoDbNativeDocArg: any
): T { ): T {
const newInstance = new this(); const newInstance = new this();
(newInstance as any).creationStatus = 'db'; (newInstance as any).creationStatus = 'db';
@ -197,7 +144,7 @@ export class SmartDataDbDoc<T extends TImplements, TImplements, TManager extends
*/ */
public static async getInstances<T>( public static async getInstances<T>(
this: plugins.tsclass.typeFest.Class<T>, this: plugins.tsclass.typeFest.Class<T>,
filterArg: plugins.tsclass.typeFest.PartialDeep<T>, filterArg: plugins.tsclass.typeFest.PartialDeep<T>
): Promise<T[]> { ): Promise<T[]> {
const foundDocs = await (this as any).collection.findAll(convertFilterForMongoDb(filterArg)); const foundDocs = await (this as any).collection.findAll(convertFilterForMongoDb(filterArg));
const returnArray = []; const returnArray = [];
@ -216,7 +163,7 @@ export class SmartDataDbDoc<T extends TImplements, TImplements, TManager extends
*/ */
public static async getInstance<T>( public static async getInstance<T>(
this: plugins.tsclass.typeFest.Class<T>, this: plugins.tsclass.typeFest.Class<T>,
filterArg: plugins.tsclass.typeFest.PartialDeep<T>, filterArg: plugins.tsclass.typeFest.PartialDeep<T>
): Promise<T> { ): Promise<T> {
const foundDoc = await (this as any).collection.findOne(convertFilterForMongoDb(filterArg)); const foundDoc = await (this as any).collection.findOne(convertFilterForMongoDb(filterArg));
if (foundDoc) { if (foundDoc) {
@ -230,10 +177,7 @@ export class SmartDataDbDoc<T extends TImplements, TImplements, TManager extends
/** /**
* get a unique id prefixed with the class name * get a unique id prefixed with the class name
*/ */
public static async getNewId<T = any>( public static async getNewId<T = any>(this: plugins.tsclass.typeFest.Class<T>, lengthArg: number = 20) {
this: plugins.tsclass.typeFest.Class<T>,
lengthArg: number = 20,
) {
return `${(this as any).className}:${plugins.smartunique.shortId(lengthArg)}`; return `${(this as any).className}:${plugins.smartunique.shortId(lengthArg)}`;
} }
@ -243,30 +187,16 @@ export class SmartDataDbDoc<T extends TImplements, TImplements, TManager extends
*/ */
public static async getCursor<T>( public static async getCursor<T>(
this: plugins.tsclass.typeFest.Class<T>, this: plugins.tsclass.typeFest.Class<T>,
filterArg: plugins.tsclass.typeFest.PartialDeep<T>, filterArg: plugins.tsclass.typeFest.PartialDeep<T>
) { ) {
const collection: SmartdataCollection<T> = (this as any).collection; const collection: SmartdataCollection<T> = (this as any).collection;
const cursor: SmartdataDbCursor<T> = await collection.getCursor( const cursor: SmartdataDbCursor<T> = await collection.getCursor(
convertFilterForMongoDb(filterArg), convertFilterForMongoDb(filterArg),
this as any as typeof SmartDataDbDoc, this as any as typeof SmartDataDbDoc
); );
return cursor; return cursor;
} }
public static async getCursorExtended<T>(
this: plugins.tsclass.typeFest.Class<T>,
filterArg: plugins.tsclass.typeFest.PartialDeep<T>,
modifierFunction = (cursorArg: plugins.mongodb.FindCursor<plugins.mongodb.WithId<plugins.mongodb.BSON.Document>>) => cursorArg,
): Promise<SmartdataDbCursor<T>> {
const collection: SmartdataCollection<T> = (this as any).collection;
await collection.init();
let cursor: plugins.mongodb.FindCursor<any> = collection.mongoDbCollection.find(
convertFilterForMongoDb(filterArg),
);
cursor = modifierFunction(cursor);
return new SmartdataDbCursor<T>(cursor, this as any as typeof SmartDataDbDoc);
}
/** /**
* watch the collection * watch the collection
* @param this * @param this
@ -275,12 +205,12 @@ export class SmartDataDbDoc<T extends TImplements, TImplements, TManager extends
*/ */
public static async watch<T>( public static async watch<T>(
this: plugins.tsclass.typeFest.Class<T>, this: plugins.tsclass.typeFest.Class<T>,
filterArg: plugins.tsclass.typeFest.PartialDeep<T>, filterArg: plugins.tsclass.typeFest.PartialDeep<T>
) { ) {
const collection: SmartdataCollection<T> = (this as any).collection; const collection: SmartdataCollection<T> = (this as any).collection;
const watcher: SmartdataDbWatcher<T> = await collection.watch( const watcher: SmartdataDbWatcher<T> = await collection.watch(
convertFilterForMongoDb(filterArg), convertFilterForMongoDb(filterArg),
this as any, this as any
); );
return watcher; return watcher;
} }
@ -292,7 +222,7 @@ export class SmartDataDbDoc<T extends TImplements, TImplements, TManager extends
public static async forEach<T>( public static async forEach<T>(
this: plugins.tsclass.typeFest.Class<T>, this: plugins.tsclass.typeFest.Class<T>,
filterArg: plugins.tsclass.typeFest.PartialDeep<T>, filterArg: plugins.tsclass.typeFest.PartialDeep<T>,
forEachFunction: (itemArg: T) => Promise<any>, forEachFunction: (itemArg: T) => Promise<any>
) { ) {
const cursor: SmartdataDbCursor<T> = await (this as any).getCursor(filterArg); const cursor: SmartdataDbCursor<T> = await (this as any).getCursor(filterArg);
await cursor.forEach(forEachFunction); await cursor.forEach(forEachFunction);
@ -303,7 +233,7 @@ export class SmartDataDbDoc<T extends TImplements, TImplements, TManager extends
*/ */
public static async getCount<T>( public static async getCount<T>(
this: plugins.tsclass.typeFest.Class<T>, this: plugins.tsclass.typeFest.Class<T>,
filterArg: plugins.tsclass.typeFest.PartialDeep<T> = {} as any, filterArg: plugins.tsclass.typeFest.PartialDeep<T> = ({} as any)
) { ) {
const collection: SmartdataCollection<T> = (this as any).collection; const collection: SmartdataCollection<T> = (this as any).collection;
return await collection.getCount(filterArg); return await collection.getCount(filterArg);
@ -316,7 +246,7 @@ export class SmartDataDbDoc<T extends TImplements, TImplements, TManager extends
*/ */
public static createSearchFilter<T>( public static createSearchFilter<T>(
this: plugins.tsclass.typeFest.Class<T>, this: plugins.tsclass.typeFest.Class<T>,
luceneQuery: string, luceneQuery: string
): any { ): any {
const className = (this as any).className || this.name; const className = (this as any).className || this.name;
const searchableFields = getSearchableFields(className); const searchableFields = getSearchableFields(className);
@ -330,85 +260,16 @@ export class SmartDataDbDoc<T extends TImplements, TImplements, TManager extends
} }
/** /**
* Search documents by text or field:value syntax, with safe regex fallback * Search documents using Lucene query syntax
* @param query A search term or field:value expression * @param luceneQuery Lucene query string
* @returns Array of matching documents * @returns Array of matching documents
*/ */
public static async search<T>( public static async search<T>(
this: plugins.tsclass.typeFest.Class<T>, this: plugins.tsclass.typeFest.Class<T>,
query: string, luceneQuery: string
): Promise<T[]> { ): Promise<T[]> {
const className = (this as any).className || this.name; const filter = (this as any).createSearchFilter(luceneQuery);
const searchableFields = getSearchableFields(className);
if (searchableFields.length === 0) {
throw new Error(`No searchable fields defined for class ${className}`);
}
// field:value exact match (case-sensitive for non-regex fields)
const fv = query.match(/^(\w+):(.+)$/);
if (fv) {
const field = fv[1];
const value = fv[2];
if (!searchableFields.includes(field)) {
throw new Error(`Field '${field}' is not searchable for class ${className}`);
}
return await (this as any).getInstances({ [field]: value });
}
// safe regex across all searchable fields (case-insensitive)
const escaped = escapeForRegex(query);
const orConditions = searchableFields.map((field) => ({
[field]: { $regex: escaped, $options: 'i' },
}));
return await (this as any).getInstances({ $or: orConditions });
}
/**
* Search by text across all searchable fields (fallback method)
* @param searchText The text to search for in all searchable fields
* @returns Array of matching documents
*/
private static async searchByTextAcrossFields<T>(
this: plugins.tsclass.typeFest.Class<T>,
searchText: string,
): Promise<T[]> {
try {
const className = (this as any).className || this.name;
const searchableFields = getSearchableFields(className);
// Fallback to direct filter if we have searchable fields
if (searchableFields.length > 0) {
// Create a simple $or query with regex for each field
const orConditions = searchableFields.map((field) => ({
[field]: { $regex: searchText, $options: 'i' },
}));
const filter = { $or: orConditions };
try {
// Try with MongoDB filter first
return await (this as any).getInstances(filter); return await (this as any).getInstances(filter);
} catch (error) {
console.warn('MongoDB filter failed, falling back to in-memory search');
}
}
// Last resort: get all and filter in memory
const allDocs = await (this as any).getInstances({});
const lowerSearchText = searchText.toLowerCase();
return allDocs.filter((doc: any) => {
for (const field of searchableFields) {
const value = doc[field];
if (value && typeof value === 'string' && value.toLowerCase().includes(lowerSearchText)) {
return true;
}
}
return false;
});
} catch (error) {
console.error(`Error in searchByTextAcrossFields: ${error.message}`);
return [];
}
} }
// INSTANCE // INSTANCE
@ -422,13 +283,13 @@ export class SmartDataDbDoc<T extends TImplements, TImplements, TManager extends
* updated from db in any case where doc comes from db * updated from db in any case where doc comes from db
*/ */
@globalSvDb() @globalSvDb()
_createdAt: string = new Date().toISOString(); _createdAt: string = (new Date()).toISOString();
/** /**
* will be updated everytime the doc is saved * will be updated everytime the doc is saved
*/ */
@globalSvDb() @globalSvDb()
_updatedAt: string = new Date().toISOString(); _updatedAt: string = (new Date()).toISOString();
/** /**
* an array of saveable properties of ALL doc * an array of saveable properties of ALL doc
@ -440,11 +301,6 @@ export class SmartDataDbDoc<T extends TImplements, TImplements, TManager extends
*/ */
public uniqueIndexes: string[]; public uniqueIndexes: string[];
/**
* regular indexes with their options
*/
public regularIndexes: Array<{field: string, options: IIndexOptions}> = [];
/** /**
* an array of saveable properties of a specific doc * an array of saveable properties of a specific doc
*/ */
@ -474,7 +330,7 @@ export class SmartDataDbDoc<T extends TImplements, TImplements, TManager extends
const self: any = this; const self: any = this;
let dbResult: any; let dbResult: any;
this._updatedAt = new Date().toISOString(); this._updatedAt = (new Date()).toISOString();
switch (this.creationStatus) { switch (this.creationStatus) {
case 'db': case 'db':
@ -530,7 +386,10 @@ export class SmartDataDbDoc<T extends TImplements, TImplements, TManager extends
*/ */
public async createSavableObject(): Promise<TImplements> { public async createSavableObject(): Promise<TImplements> {
const saveableObject: unknown = {}; // is not exposed to outside, so any is ok here const saveableObject: unknown = {}; // is not exposed to outside, so any is ok here
const saveableProperties = [...this.globalSaveableProperties, ...this.saveableProperties]; const saveableProperties = [
...this.globalSaveableProperties,
...this.saveableProperties
]
for (const propertyNameString of saveableProperties) { for (const propertyNameString of saveableProperties) {
saveableObject[propertyNameString] = this[propertyNameString]; saveableObject[propertyNameString] = this[propertyNameString];
} }

View File

@ -41,7 +41,7 @@ export class EasyStore<T> {
private async getEasyStore(): Promise<InstanceType<typeof this.easyStoreClass>> { private async getEasyStore(): Promise<InstanceType<typeof this.easyStoreClass>> {
if (this.easyStorePromise) { if (this.easyStorePromise) {
return this.easyStorePromise; return this.easyStorePromise;
} };
// first run from here // first run from here
const deferred = plugins.smartpromise.defer<InstanceType<typeof this.easyStoreClass>>(); const deferred = plugins.smartpromise.defer<InstanceType<typeof this.easyStoreClass>>();

View File

@ -4,17 +4,7 @@
import * as plugins from './plugins.js'; import * as plugins from './plugins.js';
// Types // Types
type NodeType = type NodeType = 'TERM' | 'PHRASE' | 'FIELD' | 'AND' | 'OR' | 'NOT' | 'RANGE' | 'WILDCARD' | 'FUZZY' | 'GROUP';
| 'TERM'
| 'PHRASE'
| 'FIELD'
| 'AND'
| 'OR'
| 'NOT'
| 'RANGE'
| 'WILDCARD'
| 'FUZZY'
| 'GROUP';
interface QueryNode { interface QueryNode {
type: NodeType; type: NodeType;
@ -69,15 +59,7 @@ interface GroupNode extends QueryNode {
value: AnyQueryNode; value: AnyQueryNode;
} }
type AnyQueryNode = type AnyQueryNode = TermNode | PhraseNode | FieldNode | BooleanNode | RangeNode | WildcardNode | FuzzyNode | GroupNode;
| TermNode
| PhraseNode
| FieldNode
| BooleanNode
| RangeNode
| WildcardNode
| FuzzyNode
| GroupNode;
/** /**
* Lucene query parser * Lucene query parser
@ -155,7 +137,8 @@ export class LuceneParser {
current += char; current += char;
// Check if current is an operator // Check if current is an operator
if (operators.test(current) && (i + 1 === input.length || /\s/.test(input[i + 1]))) { if (operators.test(current) &&
(i + 1 === input.length || /\s/.test(input[i + 1]))) {
tokens.push(current); tokens.push(current);
current = ''; current = '';
} }
@ -181,7 +164,7 @@ export class LuceneParser {
return { return {
type: token as 'AND' | 'OR', type: token as 'AND' | 'OR',
left, left,
right, right
}; };
} else if (token === 'NOT' || token === '-') { } else if (token === 'NOT' || token === '-') {
this.pos++; this.pos++;
@ -189,7 +172,7 @@ export class LuceneParser {
return { return {
type: 'NOT', type: 'NOT',
left, left,
right, right
}; };
} }
} }
@ -319,14 +302,13 @@ export class LuceneParser {
lower, lower,
upper, upper,
includeLower, includeLower,
includeUpper, includeUpper
}; };
} }
} }
/** /**
* Transformer for Lucene AST to MongoDB query * Transformer for Lucene AST to MongoDB query
* FIXED VERSION - proper MongoDB query structure
*/ */
export class LuceneToMongoTransformer { export class LuceneToMongoTransformer {
constructor() {} constructor() {}
@ -363,17 +345,16 @@ export class LuceneToMongoTransformer {
/** /**
* Transform a term to MongoDB query * Transform a term to MongoDB query
* FIXED: properly structured $or query for multiple fields
*/ */
private transformTerm(node: TermNode, searchFields?: string[]): any { private transformTerm(node: TermNode, searchFields?: string[]): any {
// If specific fields are provided, search across those fields // If specific fields are provided, search across those fields
if (searchFields && searchFields.length > 0) { if (searchFields && searchFields.length > 0) {
// Create an $or query to search across multiple fields // Create an $or query to search across multiple fields
const orConditions = searchFields.map((field) => ({ return {
[field]: { $regex: node.value, $options: 'i' }, $or: searchFields.map(field => ({
})); [field]: { $regex: node.value, $options: 'i' }
}))
return { $or: orConditions }; };
} }
// Otherwise, use text search (requires a text index on desired fields) // Otherwise, use text search (requires a text index on desired fields)
@ -382,16 +363,16 @@ export class LuceneToMongoTransformer {
/** /**
* Transform a phrase to MongoDB query * Transform a phrase to MongoDB query
* FIXED: properly structured $or query for multiple fields
*/ */
private transformPhrase(node: PhraseNode, searchFields?: string[]): any { private transformPhrase(node: PhraseNode, searchFields?: string[]): any {
// If specific fields are provided, search phrase across those fields // If specific fields are provided, search phrase across those fields
if (searchFields && searchFields.length > 0) { if (searchFields && searchFields.length > 0) {
const orConditions = searchFields.map((field) => ({ // Create an $or query to search phrase across multiple fields
[field]: { $regex: `${node.value.replace(/\s+/g, '\\s+')}`, $options: 'i' }, return {
})); $or: searchFields.map(field => ({
[field]: { $regex: `${node.value.replace(/\s+/g, '\\s+')}`, $options: 'i' }
return { $or: orConditions }; }))
};
} }
// For phrases, we use a regex to ensure exact matches // For phrases, we use a regex to ensure exact matches
@ -414,8 +395,8 @@ export class LuceneToMongoTransformer {
return { return {
[node.field]: { [node.field]: {
$regex: this.luceneWildcardToRegex((node.value as WildcardNode).value), $regex: this.luceneWildcardToRegex((node.value as WildcardNode).value),
$options: 'i', $options: 'i'
}, }
}; };
} }
@ -424,23 +405,23 @@ export class LuceneToMongoTransformer {
return { return {
[node.field]: { [node.field]: {
$regex: this.createFuzzyRegex((node.value as FuzzyNode).value), $regex: this.createFuzzyRegex((node.value as FuzzyNode).value),
$options: 'i', $options: 'i'
}, }
}; };
} }
// Special case for exact term matches on fields // Special case for exact term matches on fields
if (node.value.type === 'TERM') { if (node.value.type === 'TERM') {
return { [node.field]: { $regex: (node.value as TermNode).value, $options: 'i' } }; return { [node.field]: (node.value as TermNode).value };
} }
// Special case for phrase matches on fields // Special case for phrase matches on fields
if (node.value.type === 'PHRASE') { if (node.value.type === 'PHRASE') {
return { return {
[node.field]: { [node.field]: {
$regex: `${(node.value as PhraseNode).value.replace(/\s+/g, '\\s+')}`, $regex: `^${(node.value as PhraseNode).value}$`,
$options: 'i', $options: 'i'
}, }
}; };
} }
@ -449,50 +430,14 @@ export class LuceneToMongoTransformer {
// If the transformed value uses $text, we need to adapt it for the field // If the transformed value uses $text, we need to adapt it for the field
if (transformedValue.$text) { if (transformedValue.$text) {
return { [node.field]: { $regex: transformedValue.$text.$search, $options: 'i' } }; return { [node.field]: transformedValue.$text.$search };
}
// Handle $or and $and cases
if (transformedValue.$or || transformedValue.$and) {
// This is a bit complex - we need to restructure the query to apply the field
// For now, simplify by just using a regex on the field
const term = this.extractTermFromBooleanQuery(transformedValue);
if (term) {
return { [node.field]: { $regex: term, $options: 'i' } };
}
} }
return { [node.field]: transformedValue }; return { [node.field]: transformedValue };
} }
/**
* Extract a term from a boolean query (simplification)
*/
private extractTermFromBooleanQuery(query: any): string | null {
if (query.$or && Array.isArray(query.$or) && query.$or.length > 0) {
const firstClause = query.$or[0];
for (const field in firstClause) {
if (firstClause[field].$regex) {
return firstClause[field].$regex;
}
}
}
if (query.$and && Array.isArray(query.$and) && query.$and.length > 0) {
const firstClause = query.$and[0];
for (const field in firstClause) {
if (firstClause[field].$regex) {
return firstClause[field].$regex;
}
}
}
return null;
}
/** /**
* Transform AND operator to MongoDB query * Transform AND operator to MongoDB query
* FIXED: $and must be an array
*/ */
private transformAnd(node: BooleanNode): any { private transformAnd(node: BooleanNode): any {
return { $and: [this.transform(node.left), this.transform(node.right)] }; return { $and: [this.transform(node.left), this.transform(node.right)] };
@ -500,7 +445,6 @@ export class LuceneToMongoTransformer {
/** /**
* Transform OR operator to MongoDB query * Transform OR operator to MongoDB query
* FIXED: $or must be an array
*/ */
private transformOr(node: BooleanNode): any { private transformOr(node: BooleanNode): any {
return { $or: [this.transform(node.left), this.transform(node.right)] }; return { $or: [this.transform(node.left), this.transform(node.right)] };
@ -508,7 +452,6 @@ export class LuceneToMongoTransformer {
/** /**
* Transform NOT operator to MongoDB query * Transform NOT operator to MongoDB query
* FIXED: $and must be an array and $not usage
*/ */
private transformNot(node: BooleanNode): any { private transformNot(node: BooleanNode): any {
const leftQuery = this.transform(node.left); const leftQuery = this.transform(node.left);
@ -516,50 +459,21 @@ export class LuceneToMongoTransformer {
// Create a query that includes left but excludes right // Create a query that includes left but excludes right
if (rightQuery.$text) { if (rightQuery.$text) {
// For text searches, we need a different approach // Text searches need special handling for negation
// We'll use a negated regex instead
const searchTerm = rightQuery.$text.$search.replace(/"/g, '');
// Determine the fields to apply the negation to
const notConditions = [];
for (const field in leftQuery) {
if (field !== '$or' && field !== '$and') {
notConditions.push({
[field]: { $not: { $regex: searchTerm, $options: 'i' } },
});
}
}
// If left query has $or or $and, we need to handle it differently
if (leftQuery.$or) {
return { return {
$and: [leftQuery, { $nor: [{ $or: notConditions }] }], $and: [
leftQuery,
{ $not: rightQuery }
]
}; };
} else {
// Simple case - just add $not to each field
return {
$and: [leftQuery, { $and: notConditions }],
};
}
} else { } else {
// For other queries, we can use $not directly // For other queries, we can use $not directly
// We need to handle different structures based on the rightQuery return {
let notQuery = {}; $and: [
leftQuery,
if (rightQuery.$or) { { $not: rightQuery }
notQuery = { $nor: rightQuery.$or }; ]
} else if (rightQuery.$and) { };
// Convert $and to $nor
notQuery = { $nor: rightQuery.$and };
} else {
// Simple field condition
for (const field in rightQuery) {
notQuery[field] = { $not: rightQuery[field] };
}
}
return { $and: [leftQuery, notQuery] };
} }
} }
@ -582,7 +496,6 @@ export class LuceneToMongoTransformer {
/** /**
* Transform wildcard query to MongoDB query * Transform wildcard query to MongoDB query
* FIXED: properly structured for multiple fields
*/ */
private transformWildcard(node: WildcardNode, searchFields?: string[]): any { private transformWildcard(node: WildcardNode, searchFields?: string[]): any {
// Convert Lucene wildcards to MongoDB regex // Convert Lucene wildcards to MongoDB regex
@ -590,20 +503,19 @@ export class LuceneToMongoTransformer {
// If specific fields are provided, search wildcard across those fields // If specific fields are provided, search wildcard across those fields
if (searchFields && searchFields.length > 0) { if (searchFields && searchFields.length > 0) {
const orConditions = searchFields.map((field) => ({ return {
[field]: { $regex: regex, $options: 'i' }, $or: searchFields.map(field => ({
})); [field]: { $regex: regex, $options: 'i' }
}))
return { $or: orConditions }; };
} }
// By default, apply to the default field // By default, apply to all text fields using $text search
return { $regex: regex, $options: 'i' }; return { $regex: regex, $options: 'i' };
} }
/** /**
* Transform fuzzy query to MongoDB query * Transform fuzzy query to MongoDB query
* FIXED: properly structured for multiple fields
*/ */
private transformFuzzy(node: FuzzyNode, searchFields?: string[]): any { private transformFuzzy(node: FuzzyNode, searchFields?: string[]): any {
// MongoDB doesn't have built-in fuzzy search // MongoDB doesn't have built-in fuzzy search
@ -612,14 +524,13 @@ export class LuceneToMongoTransformer {
// If specific fields are provided, search fuzzy term across those fields // If specific fields are provided, search fuzzy term across those fields
if (searchFields && searchFields.length > 0) { if (searchFields && searchFields.length > 0) {
const orConditions = searchFields.map((field) => ({ return {
[field]: { $regex: regex, $options: 'i' }, $or: searchFields.map(field => ({
})); [field]: { $regex: regex, $options: 'i' }
}))
return { $or: orConditions }; };
} }
// By default, apply to the default field
return { $regex: regex, $options: 'i' }; return { $regex: regex, $options: 'i' };
} }
@ -704,28 +615,6 @@ export class SmartdataLuceneAdapter {
*/ */
convert(luceneQuery: string, searchFields?: string[]): any { convert(luceneQuery: string, searchFields?: string[]): any {
try { try {
// For simple single term queries, create a simpler query structure
if (
!luceneQuery.includes(':') &&
!luceneQuery.includes(' AND ') &&
!luceneQuery.includes(' OR ') &&
!luceneQuery.includes(' NOT ') &&
!luceneQuery.includes('(') &&
!luceneQuery.includes('[')
) {
// This is a simple term, use a more direct approach
const fieldsToSearch = searchFields || this.defaultSearchFields;
if (fieldsToSearch && fieldsToSearch.length > 0) {
return {
$or: fieldsToSearch.map((field) => ({
[field]: { $regex: luceneQuery, $options: 'i' },
})),
};
}
}
// For more complex queries, use the full parser
// Parse the Lucene query into an AST // Parse the Lucene query into an AST
const ast = this.parser.parse(luceneQuery); const ast = this.parser.parse(luceneQuery);
@ -735,7 +624,6 @@ export class SmartdataLuceneAdapter {
// Transform the AST to a MongoDB query // Transform the AST to a MongoDB query
return this.transformWithFields(ast, fieldsToSearch); return this.transformWithFields(ast, fieldsToSearch);
} catch (error) { } catch (error) {
console.error(`Failed to convert Lucene query "${luceneQuery}":`, error);
throw new Error(`Failed to convert Lucene query: ${error}`); throw new Error(`Failed to convert Lucene query: ${error}`);
} }
} }
@ -744,13 +632,8 @@ export class SmartdataLuceneAdapter {
* Helper method to transform the AST with field information * Helper method to transform the AST with field information
*/ */
private transformWithFields(node: AnyQueryNode, searchFields: string[]): any { private transformWithFields(node: AnyQueryNode, searchFields: string[]): any {
// Special case for term nodes without a specific field // For term nodes without a specific field, apply the search fields
if ( if (node.type === 'TERM') {
node.type === 'TERM' ||
node.type === 'PHRASE' ||
node.type === 'WILDCARD' ||
node.type === 'FUZZY'
) {
return this.transformer.transform(node, searchFields); return this.transformer.transform(node, searchFields);
} }

View File

@ -14,7 +14,7 @@ export class SmartdataDbWatcher<T = any> {
public changeSubject = new plugins.smartrx.rxjs.Subject<T>(); public changeSubject = new plugins.smartrx.rxjs.Subject<T>();
constructor( constructor(
changeStreamArg: plugins.mongodb.ChangeStream<T>, changeStreamArg: plugins.mongodb.ChangeStream<T>,
smartdataDbDocArg: typeof SmartDataDbDoc, smartdataDbDocArg: typeof SmartDataDbDoc
) { ) {
this.changeStream = changeStreamArg; this.changeStream = changeStreamArg;
this.changeStream.on('change', async (item: any) => { this.changeStream.on('change', async (item: any) => {
@ -23,7 +23,7 @@ export class SmartdataDbWatcher<T = any> {
return; return;
} }
this.changeSubject.next( this.changeSubject.next(
smartdataDbDocArg.createInstanceFromMongoDbNativeDoc(item.fullDocument) as any as T, smartdataDbDocArg.createInstanceFromMongoDbNativeDoc(item.fullDocument) as any as T
); );
}); });
plugins.smartdelay.delayFor(0).then(() => { plugins.smartdelay.delayFor(0).then(() => {

View File

@ -6,9 +6,7 @@
"module": "NodeNext", "module": "NodeNext",
"moduleResolution": "NodeNext", "moduleResolution": "NodeNext",
"esModuleInterop": true, "esModuleInterop": true,
"verbatimModuleSyntax": true, "verbatimModuleSyntax": true
"baseUrl": ".",
"paths": {}
}, },
"exclude": [ "exclude": [
"dist_*/**/*.d.ts" "dist_*/**/*.d.ts"