3.1.49

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushrocks/smartdata",
-  "version": "3.1.45",
+  "version": "3.1.49",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {
@@ -7686,18 +7686,18 @@
       }
     },
     "mongodb-memory-server": {
-      "version": "6.7.0",
+      "version": "6.7.2",
-      "resolved": "https://verdaccio.lossless.one/mongodb-memory-server/-/mongodb-memory-server-6.7.0.tgz",
+      "resolved": "https://verdaccio.lossless.one/mongodb-memory-server/-/mongodb-memory-server-6.7.2.tgz",
-      "integrity": "sha512-vCXvDfi2Sbvg6/Ww0LBRbp5FZtqeFA1zLJeF4wlwU7IBwcop3zI75nq+dm6hlMzLGVIsLhN5fb1Ps8hztz3TFw==",
+      "integrity": "sha512-isWtb1HM8z9wdLgOe4YZJjJGPRsDQfPh4X1cJfdUJcdRDl0A5Ullck6Yby2JYnTH9SFQaUePhi4RQnmQW98eNQ==",
       "dev": true,
       "requires": {
-        "mongodb-memory-server-core": "6.7.0"
+        "mongodb-memory-server-core": "6.7.2"
       }
     },
     "mongodb-memory-server-core": {
-      "version": "6.7.0",
+      "version": "6.7.2",
-      "resolved": "https://verdaccio.lossless.one/mongodb-memory-server-core/-/mongodb-memory-server-core-6.7.0.tgz",
+      "resolved": "https://verdaccio.lossless.one/mongodb-memory-server-core/-/mongodb-memory-server-core-6.7.2.tgz",
-      "integrity": "sha512-N6pQqS6KjOGcfdydDgJ0ddaaifM8Ee6BtP+nFQIDjon76pvOtPuR8PddXM/tWeSv5fNhPx00/ILZCmpE8IiwLw==",
+      "integrity": "sha512-SZ2Nw+4xZvRJ9r2q3mcE0rf8fz8u5FP1qvFydom6Q1VfDGR+rlunVPw/raw2JvuprbkxzpA1RQSiutnk4YLnCQ==",
       "dev": true,
       "requires": {
         "@types/tmp": "^0.2.0",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pushrocks/smartdata",
-  "version": "3.1.45",
+  "version": "3.1.49",
   "private": false,
   "description": "do more with data",
   "main": "dist_ts/index.js",
@@ -41,7 +41,7 @@
     "@types/mongodb-memory-server": "^2.3.0",
     "@types/node": "^14.6.4",
     "@types/shortid": "0.0.29",
-    "mongodb-memory-server": "^6.7.0",
+    "mongodb-memory-server": "^6.7.2",
     "tslint": "^6.1.3",
     "tslint-config-prettier": "^1.18.0"
   },

test/test.ts

@@ -95,20 +95,32 @@ tap.test('should save the car to the db', async () => {
   } while (counter < 2000);
 });
 
-tap.test('expect to get instance of Car', async () => {
+tap.test('expect to get instance of Car with shallow match', async () => {
   let counter = 0;
   do {
     const timeStart = Date.now();
     const myCars = await Car.getInstances<Car>({
-      brand: 'Volvo',
+      brand: 'Renault',
     });
+    console.log(`took ${Date.now() - timeStart}`);
+    expect(myCars[0].deepData.sodeep).to.equal('yes');
+    expect(myCars[0].brand).to.equal('Renault');
+    counter++;
+  } while (counter < 30);
+});
+
+tap.test('expect to get instance of Car with deep match', async () => {
+  let counter = 0;
+  do {
+    const timeStart = Date.now();
     const myCars2 = await Car.getInstances<Car>({
       'deepData.sodeep': 'yes',
     } as any);
-    expect(myCars[0].color).to.equal('red');
     console.log(`took ${Date.now() - timeStart}`);
+    expect(myCars2[0].deepData.sodeep).to.equal('yes');
+    expect(myCars2[0].brand).to.equal('Volvo');
     counter++;
-  } while (counter < 2000);
+  } while (counter < 30);
 });
 
 tap.test('expect to get instance of Car and update it', async () => {

ts/smartdata.classes.collection.ts

@@ -1,6 +1,7 @@
 import * as plugins from './smartdata.plugins';
 import { SmartdataDb } from './smartdata.classes.db';
 import { SmartDataDbDoc } from './smartdata.classes.doc';
+import { CollectionFactory } from './smartdata.classes.collectionfactory';
 
 export interface IFindOptions {
   limit?: number;
@@ -15,23 +16,26 @@ export interface IDocValidationFunc<T> {
 
 export type TDelayedDbCreation = () => SmartdataDb;
 
+const collectionFactory = new CollectionFactory();
+
 /**
  * This is a decorator that will tell the decorated class what dbTable to use
  * @param dbArg
  */
 export function Collection(dbArg: SmartdataDb | TDelayedDbCreation) {
-  return function (constructor) {
+  return function classDecorator<T extends { new (...args: any[]): {} }>(constructor: T) {
-    if (dbArg instanceof SmartdataDb) {
+    return class extends constructor {
-      // tslint:disable-next-line: no-string-literal
+      public static get collection() {
-      constructor['smartdataCollection'] = new SmartdataCollection(constructor, dbArg);
+        return collectionFactory.getCollection(constructor.name, dbArg);
-    } else {
+      }
-      constructor['smartdataDelayedCollection'] = () => {
+      public get collection() {
-        return new SmartdataCollection(constructor, dbArg());
+        return collectionFactory.getCollection(constructor.name, dbArg);
-      };
+      }
-    }
+    };
   };
 }
 
+// tslint:disable-next-line: max-classes-per-file
 export class SmartdataCollection<T> {
   /**
    * the collection that is used
@@ -42,13 +46,13 @@ export class SmartdataCollection<T> {
   public smartdataDb: SmartdataDb;
   public uniqueIndexes: string[] = [];
 
-  constructor(collectedClassArg: T & SmartDataDbDoc<T, unknown>, smartDataDbArg: SmartdataDb) {
+  constructor(classNameArg: string, smartDataDbArg: SmartdataDb) {
     // tell the collection where it belongs
-    this.collectionName = collectedClassArg.name;
+    this.collectionName = classNameArg;
     this.smartdataDb = smartDataDbArg;
 
     // tell the db class about it (important since Db uses different systems under the hood)
-    this.smartdataDb.addTable(this);
+    this.smartdataDb.addCollection(this);
   }
 
   /**

ts/smartdata.classes.collectionfactory.ts

@@ -0,0 +1,22 @@
+import * as plugins from './smartdata.plugins';
+import { SmartdataCollection } from './smartdata.classes.collection';
+import { SmartdataDb } from './smartdata.classes.db';
+
+export class CollectionFactory {
+  public collections: {[key: string]: SmartdataCollection<any>} = {};
+
+  public getCollection = (nameArg: string, dbArg: SmartdataDb | (() => SmartdataDb)): SmartdataCollection<any> => {
+    if (!this.collections[nameArg]) {
+      this.collections[nameArg] = (() => {
+        if (dbArg instanceof SmartdataDb) {
+          // tslint:disable-next-line: no-string-literal
+          return new SmartdataCollection(nameArg, dbArg);
+        } else {
+          dbArg = dbArg();
+          return new SmartdataCollection(nameArg, dbArg);
+        }
+      })();
+    }
+    return this.collections[nameArg];
+  }
+}

ts/smartdata.classes.db.ts

@@ -59,7 +59,7 @@ export class SmartdataDb {
 
   // handle table to class distribution
 
-  public addTable(SmartdataCollectionArg: SmartdataCollection<any>) {
+  public addCollection(SmartdataCollectionArg: SmartdataCollection<any>) {
     this.smartdataCollectionMap.add(SmartdataCollectionArg);
   }
 

ts/smartdata.classes.doc.ts

@@ -45,7 +45,8 @@ export class SmartDataDbDoc<T, TImplements> {
   /**
    * the collection object an Doc belongs to
    */
-  public collection: SmartdataCollection<T>;
+  public static collection: SmartdataCollection<any>;
+  public collection: SmartdataCollection<any>;
 
   /**
    * how the Doc in memory was created, may prove useful later.
@@ -75,32 +76,12 @@ export class SmartDataDbDoc<T, TImplements> {
   /**
    * class constructor
    */
-  constructor() {
+  constructor() {}
-    this.name = this.constructor['name'];
-    if (this.constructor['smartdataCollection']) {
-      // tslint:disable-next-line: no-string-literal
-      this.collection = this.constructor['smartdataCollection'];
-      // tslint:disable-next-line: no-string-literal
-    } else if (typeof this.constructor['smartdataDelayedCollection'] === 'function') {
-      // tslint:disable-next-line: no-string-literal
-      this.collection = this.constructor['smartdataDelayedCollection']();
-    } else {
-      console.error('Could not determine collection for DbDoc');
-    }
-  }
 
   public static async getInstances<T>(
     filterArg: plugins.tsclass.typeFest.PartialDeep<T>
   ): Promise<T[]> {
-    const self: any = this; // fool typesystem
+    const foundDocs = await this.collection.find(filterArg);
-    let referenceMongoDBCollection: SmartdataCollection<T>;
-
-    if (self.smartdataCollection) {
-      referenceMongoDBCollection = self.smartdataCollection;
-    } else if (self.smartdataDelayedCollection) {
-      referenceMongoDBCollection = self.smartdataDelayedCollection();
-    }
-    const foundDocs = await referenceMongoDBCollection.find(filterArg);
     const returnArray = [];
     for (const item of foundDocs) {
       const newInstance = new this();
@@ -146,8 +127,7 @@ export class SmartDataDbDoc<T, TImplements> {
    * deletes a document from the database
    */
   public async delete() {
-    const self: any = this;
+    await this.collection.delete(this);
-    await this.collection.delete(self);
   }
 
   /**