Compare commits
16 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 2fe3a72eaf | |||
| fb7e82557b | |||
| 8a3425e554 | |||
| d2092cc5f3 | |||
| 1a621ca64e | |||
| f6cc07880a | |||
| bf4b11f1f5 | |||
| 181e9da151 | |||
| 3013edb2eb | |||
| 604e4ba265 | |||
| 477f446c34 | |||
| fbb8bb685c | |||
| 4cf62fd91c | |||
| 8ee45c5646 | |||
| 12f1630adf | |||
| 0a349180b2 |
41
changelog.md
41
changelog.md
@@ -1,5 +1,46 @@
|
||||
# Changelog
|
||||
|
||||
## 2025-11-28 - 7.0.9 - fix(classes.collection)
|
||||
Fix closure bug in Collection decorator by defining collection getter on original constructor and prototype
|
||||
|
||||
- Define the collection getter on the original constructor so class-level references (e.g. `User.collection`) resolve to the decorated collection instead of the original constructor's closure value.
|
||||
- Also define the getter on the original constructor's prototype to ensure instance access works consistently across runtimes (Deno/Node).
|
||||
|
||||
## 2025-11-28 - 7.0.8 - fix(classes.collection)
|
||||
Fix closure issue in managed decorator so Class.collection/instance.collection resolve correctly
|
||||
|
||||
- Resolve closure bug in the managed() decorator where class methods referencing Class.collection (or instance.collection) could receive the original constructor's captured value and thus the wrong collection/manager.
|
||||
- Define dynamic getters on the original constructor and its prototype that compute the collection from the proper manager/db at access time (supports direct manager objects, delayed manager factory functions, and fallback to defaultManager).
|
||||
- Getters are defined as non-enumerable and configurable to preserve compatibility with existing consumers.
|
||||
|
||||
## 2025-11-28 - 7.0.7 - fix(decorators)
|
||||
Fix decorator metadata initialization and Lucene query transformation
|
||||
|
||||
- Ensure TC39 decorator metadata is used to initialize prototype properties so decorators work reliably across runtimes (context.metadata / Symbol.metadata shim imported early).
|
||||
- Field and class decorators now populate and consume metadata for saveable properties, indexes and searchable fields so prototype initialization happens before instance creation.
|
||||
- Fix Lucene -> MongoDB transformer to produce correct $or/$and/$not structures and improve wildcard/fuzzy/range handling for search queries.
|
||||
- Improve collection initialization to auto-create compound text indexes from searchableFields and ensure index creation is idempotent.
|
||||
|
||||
## 2025-11-28 - 7.0.6 - fix(classes.collection)
|
||||
Guard against missing collection before attaching document constructor in Collection decorator
|
||||
|
||||
- Added a truthy check for `coll` before setting `(coll as any).docCtor` in the Collection decorator (ts/classes.collection.ts).
|
||||
- Prevents a potential TypeError when `collectionFactory.getCollection` returns null/undefined during decorator initialization.
|
||||
|
||||
## 2025-11-28 - 7.0.5 - fix(package)
|
||||
Add package exports entry and remove legacy main/typings fields
|
||||
|
||||
- Added an "exports" entry in package.json mapping "." to ./dist_ts/index.js to declare the package's ESM entrypoint.
|
||||
- Removed legacy "main" and "typings" fields from package.json.
|
||||
- Improves Node/module resolution and modern bundler compatibility by using the package exports field.
|
||||
|
||||
## 2025-11-28 - 7.0.4 - fix(decorators)
|
||||
Add Symbol.metadata polyfill and import it at entry to ensure decorator metadata is available
|
||||
|
||||
- Add ts/shim.ts: defines Symbol.metadata when missing (polyfill for TC39 Stage 3 decorator metadata).
|
||||
- Import './shim.js' at the very top of ts/index.ts so the polyfill runs before any decorator code or exports are evaluated.
|
||||
- Prevents runtime errors when decorators rely on Symbol.metadata and improves compatibility across runtimes/environments.
|
||||
|
||||
## 2025-11-28 - 7.0.3 - fix(build)
|
||||
Bump devDependency @git.zone/tsbuild to ^3.1.2
|
||||
|
||||
|
||||
10
deno.lock
generated
10
deno.lock
generated
@@ -1,7 +1,7 @@
|
||||
{
|
||||
"version": "5",
|
||||
"specifiers": {
|
||||
"npm:@git.zone/tsbuild@^3.1.1": "3.1.1",
|
||||
"npm:@git.zone/tsbuild@^3.1.2": "3.1.2",
|
||||
"npm:@git.zone/tsrun@2": "2.0.0",
|
||||
"npm:@git.zone/tstest@^3.1.3": "3.1.3",
|
||||
"npm:@push.rocks/lik@^6.2.2": "6.2.2",
|
||||
@@ -1111,8 +1111,8 @@
|
||||
],
|
||||
"tarball": "https://verdaccio.lossless.digital/@esm-bundle/chai/-/chai-4.3.4-fix.0.tgz"
|
||||
},
|
||||
"@git.zone/tsbuild@3.1.1": {
|
||||
"integrity": "sha512-x2MxBu5vaGabWGLS2Rcu/75VDKRZ0F74x0wEzgWPEqG/z9+vFu+8E70FOHj/TZJdnrw0yLEL78dUartNdGqm3A==",
|
||||
"@git.zone/tsbuild@3.1.2": {
|
||||
"integrity": "sha512-K0u840Qo0WEhvcpAtktvdBX6KEXjelU32o820WzcK7dMA7dd2YV+mPOEYfbmWLcdtFJkrjkigQq5fpLhTN4oKQ==",
|
||||
"dependencies": [
|
||||
"@git.zone/tspublish",
|
||||
"@push.rocks/early",
|
||||
@@ -1125,7 +1125,7 @@
|
||||
"typescript"
|
||||
],
|
||||
"bin": true,
|
||||
"tarball": "https://verdaccio.lossless.digital/@git.zone/tsbuild/-/tsbuild-3.1.1.tgz"
|
||||
"tarball": "https://verdaccio.lossless.digital/@git.zone/tsbuild/-/tsbuild-3.1.2.tgz"
|
||||
},
|
||||
"@git.zone/tsbundle@2.6.1": {
|
||||
"integrity": "sha512-P1ER6A859GBY5mmC2hNro06O1w/vYCDt5XaetE4vsyJMlFSvWGXrKTxFpTdookZvntQyoXJglYsCPKEsy+OXWQ==",
|
||||
@@ -8369,7 +8369,7 @@
|
||||
"workspace": {
|
||||
"packageJson": {
|
||||
"dependencies": [
|
||||
"npm:@git.zone/tsbuild@^3.1.1",
|
||||
"npm:@git.zone/tsbuild@^3.1.2",
|
||||
"npm:@git.zone/tsrun@2",
|
||||
"npm:@git.zone/tstest@^3.1.3",
|
||||
"npm:@push.rocks/lik@^6.2.2",
|
||||
|
||||
@@ -1,10 +1,11 @@
|
||||
{
|
||||
"name": "@push.rocks/smartdata",
|
||||
"version": "7.0.3",
|
||||
"version": "7.0.11",
|
||||
"private": false,
|
||||
"description": "An advanced library for NoSQL data organization and manipulation using TypeScript with support for MongoDB, data validation, collections, and custom data types.",
|
||||
"main": "dist_ts/index.js",
|
||||
"typings": "dist_ts/index.d.ts",
|
||||
"exports": {
|
||||
".": "./dist_ts/index.js"
|
||||
},
|
||||
"type": "module",
|
||||
"scripts": {
|
||||
"test": "tstest test/ --verbose --logfile --timeout 120",
|
||||
|
||||
@@ -3,6 +3,6 @@
|
||||
*/
|
||||
export const commitinfo = {
|
||||
name: '@push.rocks/smartdata',
|
||||
version: '7.0.3',
|
||||
version: '7.0.9',
|
||||
description: 'An advanced library for NoSQL data organization and manipulation using TypeScript with support for MongoDB, data validation, collections, and custom data types.'
|
||||
}
|
||||
|
||||
@@ -41,7 +41,7 @@ export function Collection(dbArg: SmartdataDb | TDelayed<SmartdataDb>) {
|
||||
}
|
||||
const coll = collectionFactory.getCollection(constructor.name, dbArg);
|
||||
// Attach document constructor for searchableFields lookup
|
||||
if (!(coll as any).docCtor) {
|
||||
if (coll && !(coll as any).docCtor) {
|
||||
(coll as any).docCtor = decoratedClass;
|
||||
}
|
||||
return coll;
|
||||
@@ -64,6 +64,20 @@ export function Collection(dbArg: SmartdataDb | TDelayed<SmartdataDb>) {
|
||||
configurable: true
|
||||
});
|
||||
|
||||
// Closure fix: When class methods reference the class name (e.g., `User.collection`),
|
||||
// they get the original constructor via closure, not the decorated class.
|
||||
// Define collection getter on the original constructor.
|
||||
Object.defineProperty(constructor, 'collection', {
|
||||
get: getCollection,
|
||||
enumerable: false,
|
||||
configurable: true
|
||||
});
|
||||
Object.defineProperty(constructor.prototype, 'collection', {
|
||||
get: getCollection,
|
||||
enumerable: false,
|
||||
configurable: true
|
||||
});
|
||||
|
||||
// Deno compatibility note: Property decorators set properties on the prototype.
|
||||
// Since we removed instance property declarations from SmartDataDbDoc,
|
||||
// the decorator-set prototype properties are now accessible without shadowing.
|
||||
@@ -188,6 +202,42 @@ export function managed<TManager extends IManager>(managerArg?: TManager | TDela
|
||||
}
|
||||
};
|
||||
|
||||
// Closure fix: When class methods reference the class name (e.g., `User.collection`),
|
||||
// they get the original constructor via closure, not the decorated class.
|
||||
// Define collection/manager getters on the original constructor.
|
||||
const getCollectionStatic = function(this: any) {
|
||||
let dbArg: SmartdataDb;
|
||||
if (!managerArg) {
|
||||
dbArg = this.prototype.defaultManager.db;
|
||||
} else if (managerArg['db']) {
|
||||
dbArg = (managerArg as TManager).db;
|
||||
} else {
|
||||
dbArg = (managerArg as TDelayed<TManager>)().db;
|
||||
}
|
||||
return collectionFactory.getCollection(constructor.name, dbArg);
|
||||
};
|
||||
const getCollectionInstance = function(this: any) {
|
||||
let dbArg: SmartdataDb;
|
||||
if (!managerArg) {
|
||||
dbArg = this.defaultManager.db;
|
||||
} else if (managerArg['db']) {
|
||||
dbArg = (managerArg as TManager).db;
|
||||
} else {
|
||||
dbArg = (managerArg as TDelayed<TManager>)().db;
|
||||
}
|
||||
return collectionFactory.getCollection(constructor.name, dbArg);
|
||||
};
|
||||
Object.defineProperty(constructor, 'collection', {
|
||||
get: getCollectionStatic,
|
||||
enumerable: false,
|
||||
configurable: true
|
||||
});
|
||||
Object.defineProperty(constructor.prototype, 'collection', {
|
||||
get: getCollectionInstance,
|
||||
enumerable: false,
|
||||
configurable: true
|
||||
});
|
||||
|
||||
// Initialize prototype properties from context.metadata (TC39 decorator metadata)
|
||||
// This ensures prototype properties are available before any instance is created
|
||||
const originalConstructor = value as any;
|
||||
|
||||
@@ -1,3 +1,6 @@
|
||||
// Polyfill must be imported first - ES modules hoist exports before code runs
|
||||
import './shim.js';
|
||||
|
||||
export * from './classes.db.js';
|
||||
export * from './classes.collection.js';
|
||||
export * from './classes.doc.js';
|
||||
|
||||
6
ts/shim.ts
Normal file
6
ts/shim.ts
Normal file
@@ -0,0 +1,6 @@
|
||||
/**
|
||||
* Polyfill for Symbol.metadata required by TC39 Stage 3 decorators.
|
||||
* Must be imported before any decorator code loads.
|
||||
* @see https://github.com/tc39/proposal-decorator-metadata
|
||||
*/
|
||||
(Symbol as any).metadata ??= Symbol.for('Symbol.metadata');
|
||||
Reference in New Issue
Block a user