Compare commits
4 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 7020810b5e | |||
| 7f2546e041 | |||
| 53d663597a | |||
| 440197ccf3 |
+2
-2
@@ -44,9 +44,9 @@
|
||||
}
|
||||
},
|
||||
"@git.zone/tsdoc": {
|
||||
"legal": "\n## License and Legal Information\n\nThis repository contains open-source code that is licensed under the MIT License. A copy of the MIT License can be found in the [license](license) file within this repository. \n\n**Please note:** The MIT License does not grant permission to use the trade names, trademarks, service marks, or product names of the project, except as required for reasonable and customary use in describing the origin of the work and reproducing the content of the NOTICE file.\n\n### Trademarks\n\nThis project is owned and maintained by Task Venture Capital GmbH. The names and logos associated with Task Venture Capital GmbH and any related products or services are trademarks of Task Venture Capital GmbH and are not included within the scope of the MIT license granted herein. Use of these trademarks must comply with Task Venture Capital GmbH's Trademark Guidelines, and any usage must be approved in writing by Task Venture Capital GmbH.\n\n### Company Information\n\nTask Venture Capital GmbH \nRegistered at District court Bremen HRB 35230 HB, Germany\n\nFor any legal inquiries or if you require further information, please contact us via email at hello@task.vc.\n\nBy using this repository, you acknowledge that you have read this section, agree to comply with its terms, and understand that the licensing of the code does not imply endorsement by Task Venture Capital GmbH of any derivative works.\n"
|
||||
"legal": "\n## License and Legal Information\n\nThis repository contains open-source code licensed under the MIT License. A copy of the license can be found in the [license](./license) file.\n\n**Please note:** The MIT License does not grant permission to use the trade names, trademarks, service marks, or product names of the project, except as required for reasonable and customary use in describing the origin of the work and reproducing the content of the NOTICE file.\n\n### Trademarks\n\nThis project is owned and maintained by Task Venture Capital GmbH. The names and logos associated with Task Venture Capital GmbH and any related products or services are trademarks of Task Venture Capital GmbH or third parties, and are not included within the scope of the MIT license granted herein.\n\nUse of these trademarks must comply with Task Venture Capital GmbH's Trademark Guidelines or the guidelines of the respective third-party owners, and any usage must be approved in writing. Third-party trademarks used herein are the property of their respective owners and used only in a descriptive manner, e.g. for an implementation of an API or similar.\n\n### Company Information\n\nTask Venture Capital GmbH \nRegistered at District Court Bremen HRB 35230 HB, Germany\n\nFor any legal inquiries or further information, please contact us via email at hello@task.vc.\n\nBy using this repository, you acknowledge that you have read this section, agree to comply with its terms, and understand that the licensing of the code does not imply endorsement by Task Venture Capital GmbH of any derivative works.\n"
|
||||
},
|
||||
"@ship.zone/szci": {
|
||||
"npmGlobalTools": []
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,5 +1,22 @@
|
||||
# Changelog
|
||||
|
||||
## 2026-05-02 - 6.5.0 - feat(bucket-tenants)
|
||||
add persisted bucket-scoped tenant credentials with bucket export and import APIs
|
||||
|
||||
- Adds bucket tenant management APIs for creating, rotating, listing, retrieving, and deleting scoped per-bucket credentials.
|
||||
- Persists runtime credentials under the storage directory so tenant and replaced credentials survive restarts.
|
||||
- Enforces tenant bucket isolation in auth, including blocking cross-bucket access and copy operations.
|
||||
- Adds bucket export/import support using the smartstorage.bucket.v1 JSON format.
|
||||
- Introduces health and metrics APIs plus test coverage for tenant lifecycle, persistence, policy retention, and AWS SDK compatibility.
|
||||
|
||||
## 2026-04-30 - 6.4.1 - fix(build)
|
||||
tighten TypeScript compiler settings and refresh package metadata
|
||||
|
||||
- enable noImplicitAny in tsconfig and align the build script with strict compilation
|
||||
- update package metadata including author, repository URL, and pnpm version
|
||||
- bump dependency versions for @aws-sdk/client-s3 and @tsclass/tsclass
|
||||
- refresh README hints and legal text to match the current package setup
|
||||
|
||||
## 2026-04-30 - 6.4.0 - feat(cluster,server,auth)
|
||||
add operational health endpoints, persist cluster topology, and hide credential secrets from runtime listings
|
||||
|
||||
|
||||
@@ -1,4 +1,6 @@
|
||||
Copyright (c) 2021 Task Venture Capital GmbH (hello@task.vc)
|
||||
MIT License
|
||||
|
||||
Copyright (c) Task Venture Capital GmbH
|
||||
|
||||
Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||
of this software and associated documentation files (the "Software"), to deal
|
||||
@@ -16,4 +18,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
||||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
||||
SOFTWARE.
|
||||
SOFTWARE.
|
||||
|
||||
+7
-10
@@ -1,21 +1,21 @@
|
||||
{
|
||||
"name": "@push.rocks/smartstorage",
|
||||
"version": "6.4.0",
|
||||
"version": "6.5.0",
|
||||
"private": false,
|
||||
"description": "A Node.js TypeScript package to create a local S3-compatible storage server using mapped local directories for development and testing purposes.",
|
||||
"main": "dist_ts/index.js",
|
||||
"typings": "dist_ts/index.d.ts",
|
||||
"type": "module",
|
||||
"author": "Lossless GmbH",
|
||||
"author": "Task Venture Capital GmbH",
|
||||
"license": "MIT",
|
||||
"scripts": {
|
||||
"test:before": "(tsrust)",
|
||||
"test": "(tstest test/ --web --verbose --logfile --timeout 60)",
|
||||
"build": "(tsrust && tsbuild tsfolders --allowimplicitany)",
|
||||
"build": "(tsrust && tsbuild tsfolders)",
|
||||
"buildDocs": "tsdoc"
|
||||
},
|
||||
"devDependencies": {
|
||||
"@aws-sdk/client-s3": "^3.1032.0",
|
||||
"@aws-sdk/client-s3": "^3.1039.0",
|
||||
"@git.zone/tsbuild": "^4.4.0",
|
||||
"@git.zone/tsbundle": "^2.10.0",
|
||||
"@git.zone/tsrun": "^2.0.2",
|
||||
@@ -43,7 +43,7 @@
|
||||
"dependencies": {
|
||||
"@push.rocks/smartpath": "^6.0.0",
|
||||
"@push.rocks/smartrust": "^1.3.2",
|
||||
"@tsclass/tsclass": "^9.5.0"
|
||||
"@tsclass/tsclass": "^9.5.1"
|
||||
},
|
||||
"keywords": [
|
||||
"smartstorage",
|
||||
@@ -67,13 +67,10 @@
|
||||
"homepage": "https://code.foss.global/push.rocks/smartstorage#readme",
|
||||
"repository": {
|
||||
"type": "git",
|
||||
"url": "ssh://git@code.foss.global:29419/push.rocks/smartstorage.git"
|
||||
"url": "https://code.foss.global/push.rocks/smartstorage.git"
|
||||
},
|
||||
"bugs": {
|
||||
"url": "https://code.foss.global/push.rocks/smartstorage/issues"
|
||||
},
|
||||
"packageManager": "pnpm@10.14.0+sha512.ad27a79641b49c3e481a16a805baa71817a04bbe06a38d17e60e2eaee83f6a146c6a688125f5792e48dd5ba30e7da52a5cda4c3992b9ccf333f9ce223af84748",
|
||||
"pnpm": {
|
||||
"overrides": {}
|
||||
}
|
||||
"packageManager": "pnpm@10.28.2"
|
||||
}
|
||||
|
||||
Generated
+273
-259
File diff suppressed because it is too large
Load Diff
+14
-2
@@ -1,6 +1,6 @@
|
||||
# Project Hints for smartstorage
|
||||
|
||||
## Current State (v6.0.0)
|
||||
## Current State (v6.4.0)
|
||||
|
||||
- **Rust-powered S3-compatible storage server** via `@push.rocks/smartrust` IPC bridge
|
||||
- High-performance: streaming I/O, zero-copy, backpressure, range seek
|
||||
@@ -14,6 +14,9 @@
|
||||
- Runtime bucket summaries and storage stats via the Rust bridge (no S3 list scans)
|
||||
- Cluster health introspection via the Rust bridge (node membership, local drive probes, quorum, healing state)
|
||||
- Runtime credential listing and atomic replacement via the Rust bridge
|
||||
- Runtime credentials persist under `{storage}/.smartstorage/credentials.json`
|
||||
- Bucket tenant APIs provision scoped per-bucket credentials and enforce the scope before bucket-policy/default-auth authorization
|
||||
- Per-bucket export/import uses `smartstorage.bucket.v1` JSON with object payloads encoded per object
|
||||
- Cluster identity and topology snapshots persist under `{storage}/.smartstorage/cluster/`
|
||||
- S3-side operational endpoints are available at `/-/live`, `/-/ready`, `/-/health`, and `/-/metrics`
|
||||
- Runtime credential listing returns access-key metadata only; secrets are write-only
|
||||
@@ -44,6 +47,13 @@
|
||||
| `start` | `{ config: ISmartStorageConfig }` | Init storage + HTTP server |
|
||||
| `stop` | `{}` | Graceful shutdown |
|
||||
| `createBucket` | `{ name: string }` | Create bucket directory |
|
||||
| `createBucketTenant` | `{ bucketName, accessKeyId, secretAccessKey, region? }` | Create bucket and scoped persisted credential |
|
||||
| `deleteBucketTenant` | `{ bucketName, accessKeyId? }` | Revoke scoped credential or delete tenant bucket recursively |
|
||||
| `rotateBucketTenantCredentials` | `{ bucketName, accessKeyId, secretAccessKey, region? }` | Replace scoped credential for one bucket |
|
||||
| `listBucketTenants` | `{}` | Return scoped credential metadata |
|
||||
| `getBucketTenantCredential` | `{ bucketName }` | Return one scoped credential including secret for descriptor generation |
|
||||
| `exportBucket` | `{ bucketName }` | Export one bucket's objects and metadata |
|
||||
| `importBucket` | `{ bucketName, source }` | Import a `smartstorage.bucket.v1` bucket export |
|
||||
| `getStorageStats` | `{}` | Return cached bucket/global runtime stats + storage location capacity snapshots |
|
||||
| `listBucketSummaries` | `{}` | Return cached per-bucket runtime summaries |
|
||||
| `listCredentials` | `{}` | Return the active runtime auth credential set |
|
||||
@@ -65,10 +75,11 @@
|
||||
- MD5: `{root}/{bucket}/{key}._storage_object.md5`
|
||||
- Multipart: `{root}/.multipart/{upload_id}/part-{N}`
|
||||
- Policies: `{root}/.policies/{bucket}.policy.json`
|
||||
- Runtime credentials: `{root}/.smartstorage/credentials.json`
|
||||
|
||||
## Build
|
||||
|
||||
- `pnpm build` runs `tsrust && tsbuild tsfolders --allowimplicitany`
|
||||
- `pnpm build` runs `tsrust && tsbuild tsfolders`
|
||||
- `tsrust` compiles Rust to `dist_rust/ruststorage`
|
||||
- Targets: linux_amd64, linux_arm64 (configured in .smartconfig.json)
|
||||
|
||||
@@ -82,6 +93,7 @@
|
||||
## Testing
|
||||
|
||||
- `test/test.aws-sdk.node.ts` - AWS SDK v3 compatibility + runtime stats + standalone cluster health coverage (19 tests, auth disabled, port 3337)
|
||||
- `test/test.bucket-tenants.node.ts` - bucket tenant provisioning, per-bucket isolation, restart persistence, export/import, policy persistence, rotation, revoke/delete, AWS SDK v3 compatibility (12 tests, port 3361)
|
||||
- `test/test.credentials.node.ts` - runtime credential rotation coverage (10 tests, auth enabled, port 3349)
|
||||
- `test/test.health-http.node.ts` - unauthenticated operational endpoint coverage (3 tests, port 3353)
|
||||
- `test/test.cluster-health.node.ts` - single-node cluster health coverage (4 tests, S3 port 3348, QUIC port 4348)
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
# @push.rocks/smartstorage
|
||||
|
||||
A high-performance, S3-compatible storage server powered by a **Rust core** with a clean TypeScript API. Runs standalone for dev/test — or scales out as a **distributed, erasure-coded cluster** with QUIC-based inter-node communication. No cloud, no Docker. Just `npm install` and go. 🚀
|
||||
A high-performance, S3-compatible storage server powered by a **Rust core** with a clean TypeScript API. Runs standalone for dev/test — or scales out as a **distributed, erasure-coded cluster** with QUIC-based inter-node communication. No cloud, no Docker. Just install the package and go. 🚀
|
||||
|
||||
## Issue Reporting and Security
|
||||
|
||||
@@ -34,6 +34,7 @@ For reporting bugs, issues, or security vulnerabilities, please visit [community
|
||||
- 🧹 **Clean slate mode** — wipe storage on startup for test isolation
|
||||
- 📊 **Runtime storage stats** — cheap bucket summaries and global counts without S3 list scans
|
||||
- 🔑 **Runtime credential rotation** — list and replace active auth credentials without mutating internals
|
||||
- 🧩 **Bucket tenants** — provision one scoped S3 credential per bucket with restart persistence
|
||||
- ⚡ **Test-first design** — start/stop in milliseconds, no port conflicts
|
||||
|
||||
### Clustering Features
|
||||
@@ -225,15 +226,76 @@ await storage.replaceCredentials([
|
||||
interface IStorageCredential {
|
||||
accessKeyId: string;
|
||||
secretAccessKey: string;
|
||||
bucketName?: string;
|
||||
region?: string;
|
||||
}
|
||||
```
|
||||
|
||||
- `listCredentials()` returns the Rust core's current runtime credential set.
|
||||
- `replaceCredentials()` swaps the full set atomically. On success, new requests use the new set immediately and the old credentials stop authenticating immediately.
|
||||
- `replaceCredentials()` swaps the full set atomically and persists it under the storage root. On success, new requests use the new set immediately and the old credentials stop authenticating immediately.
|
||||
- Requests that were already authenticated before the replacement keep running; auth is evaluated when each request starts.
|
||||
- No restart is required.
|
||||
- No restart is required, and runtime-created credentials survive restart unless `storage.cleanSlate` removes the storage directory.
|
||||
- Replacement input must contain at least one credential, each `accessKeyId` and `secretAccessKey` must be non-empty, and `accessKeyId` values must be unique.
|
||||
|
||||
## Bucket Tenants
|
||||
|
||||
Bucket tenants are designed for platform services that need one bucket and one scoped S3 credential per app. Tenant credentials are enforced by the auth layer before the normal bucket-policy/default-auth pipeline, so a scoped credential cannot list all buckets or access another bucket even when it has a valid SigV4 signature.
|
||||
|
||||
```typescript
|
||||
const tenant = await storage.createBucketTenant({
|
||||
bucketName: 'workapp-123',
|
||||
});
|
||||
|
||||
// Directly usable by AWS SDK v3 or env injection
|
||||
const client = new S3Client({
|
||||
endpoint: `http://${tenant.endpoint}:${tenant.port}`,
|
||||
region: tenant.region,
|
||||
credentials: {
|
||||
accessKeyId: tenant.accessKeyId,
|
||||
secretAccessKey: tenant.secretAccessKey,
|
||||
},
|
||||
forcePathStyle: true,
|
||||
});
|
||||
|
||||
console.log(tenant.env.S3_BUCKET);
|
||||
console.log(tenant.env.AWS_ACCESS_KEY_ID);
|
||||
```
|
||||
|
||||
```typescript
|
||||
await storage.rotateBucketTenantCredentials({ bucketName: 'workapp-123' });
|
||||
await storage.deleteBucketTenant({ bucketName: 'workapp-123', accessKeyId: tenant.accessKeyId });
|
||||
const descriptor = await storage.getBucketTenantDescriptor({ bucketName: 'workapp-123' });
|
||||
const tenants = await storage.listBucketTenants();
|
||||
```
|
||||
|
||||
- `createBucketTenant()` creates the bucket if needed and stores a scoped credential for that bucket.
|
||||
- `rotateBucketTenantCredentials()` replaces the active scoped credential for the bucket and persists the new credential.
|
||||
- `deleteBucketTenant({ bucketName, accessKeyId })` revokes one scoped credential and keeps the bucket.
|
||||
- `deleteBucketTenant({ bucketName })` revokes scoped credentials for the bucket and deletes the bucket contents recursively.
|
||||
- Tenant credentials can list, read, write, and delete objects in their assigned bucket, but cannot list all buckets, access other buckets, copy from other buckets, delete buckets, or mutate bucket policies.
|
||||
- Bucket tenant APIs require `auth.enabled: true`.
|
||||
|
||||
## Bucket Backup/Restore
|
||||
|
||||
```typescript
|
||||
const appBackup = await storage.exportBucket({ bucketName: 'workapp-123' });
|
||||
await storage.importBucket({ bucketName: 'workapp-123-restore', source: appBackup });
|
||||
```
|
||||
|
||||
- `exportBucket()` returns a self-contained `smartstorage.bucket.v1` JSON export with only the selected bucket's objects and object metadata.
|
||||
- `importBucket()` creates the target bucket if needed and restores the exported objects into that bucket.
|
||||
- Exports do not include credentials, policies, or unrelated tenant data.
|
||||
|
||||
## Health and Metrics APIs
|
||||
|
||||
```typescript
|
||||
const health = await storage.getHealth();
|
||||
const metrics = await storage.getMetrics();
|
||||
```
|
||||
|
||||
- `getHealth()` reports running state, storage directory, auth enabled state, credential counts, bucket count, object count, total bytes, and cluster health.
|
||||
- `getMetrics()` returns numeric counters and a Prometheus text snippet for bucket, object, byte, tenant credential, and cluster-enabled metrics.
|
||||
|
||||
## Runtime Stats
|
||||
|
||||
```typescript
|
||||
@@ -577,6 +639,34 @@ Gracefully stop the server and kill the Rust process.
|
||||
|
||||
Create a storage bucket.
|
||||
|
||||
#### `createBucketTenant(options): Promise<IBucketTenantDescriptor>`
|
||||
|
||||
Create a bucket tenant with a generated or supplied scoped credential. Options: `{ bucketName, accessKeyId?, secretAccessKey?, region? }`.
|
||||
|
||||
#### `deleteBucketTenant(options): Promise<void>`
|
||||
|
||||
Revoke a tenant credential or delete the full tenant bucket. Options: `{ bucketName, accessKeyId? }`.
|
||||
|
||||
#### `rotateBucketTenantCredentials(options): Promise<IBucketTenantDescriptor>`
|
||||
|
||||
Replace the scoped credential for a bucket tenant. Options: `{ bucketName, accessKeyId?, secretAccessKey?, region? }`.
|
||||
|
||||
#### `listBucketTenants(): Promise<IBucketTenantMetadata[]>`
|
||||
|
||||
List scoped tenant credential metadata without returning secrets.
|
||||
|
||||
#### `getBucketTenantDescriptor(options): Promise<IBucketTenantDescriptor>`
|
||||
|
||||
Return endpoint, port, region, bucket, access key, secret key, SSL flag, legacy descriptor fields, and S3/AWS env values for the bucket tenant.
|
||||
|
||||
#### `exportBucket(options): Promise<IBucketExport>`
|
||||
|
||||
Export one bucket's objects and metadata into a `smartstorage.bucket.v1` JSON object.
|
||||
|
||||
#### `importBucket(options): Promise<void>`
|
||||
|
||||
Import a `smartstorage.bucket.v1` JSON object into the target bucket. Options: `{ bucketName, source }`.
|
||||
|
||||
#### `getStorageDescriptor(options?): Promise<IS3Descriptor>`
|
||||
|
||||
Get connection details for S3-compatible clients. Returns:
|
||||
@@ -609,6 +699,14 @@ Atomically replace the active runtime credential set without restarting the serv
|
||||
|
||||
Read the Rust core's current cluster, drive, quorum, and repair health snapshot. Standalone mode returns `{ enabled: false }`.
|
||||
|
||||
#### `getHealth(): Promise<ISmartStorageHealth>`
|
||||
|
||||
Return running state, storage directory, auth state, credential counts, bucket count, object count, total bytes, and cluster health.
|
||||
|
||||
#### `getMetrics(): Promise<ISmartStorageMetrics>`
|
||||
|
||||
Return numeric metrics plus a Prometheus text snippet for operational scraping.
|
||||
|
||||
## Architecture
|
||||
|
||||
smartstorage uses a **hybrid Rust + TypeScript** architecture:
|
||||
@@ -642,7 +740,7 @@ smartstorage uses a **hybrid Rust + TypeScript** architecture:
|
||||
|
||||
**Why Rust?** The original TypeScript implementation had critical perf issues: OOM on multipart uploads (parts buffered in memory), double stream copying, file descriptor leaks on HEAD requests, full-file reads for range requests, and no backpressure. The Rust binary solves all of these with streaming I/O, zero-copy, and direct `seek()` for range requests.
|
||||
|
||||
**IPC Protocol:** TypeScript communicates with the `ruststorage` binary over newline-delimited JSON via stdin/stdout. The current management commands are `start`, `stop`, `createBucket`, `getStorageStats`, `listBucketSummaries`, `listCredentials`, `replaceCredentials`, and `getClusterHealth`.
|
||||
**IPC Protocol:** TypeScript communicates with the `ruststorage` binary over newline-delimited JSON via stdin/stdout. The current management commands are `start`, `stop`, `createBucket`, `createBucketTenant`, `deleteBucketTenant`, `rotateBucketTenantCredentials`, `listBucketTenants`, `getBucketTenantCredential`, `exportBucket`, `importBucket`, `getStorageStats`, `listBucketSummaries`, `listCredentials`, `replaceCredentials`, and `getClusterHealth`.
|
||||
|
||||
### S3-Compatible Operations
|
||||
|
||||
|
||||
@@ -57,6 +57,7 @@ pub struct RequestContext {
|
||||
pub action: StorageAction,
|
||||
pub bucket: Option<String>,
|
||||
pub key: Option<String>,
|
||||
pub source_bucket: Option<String>,
|
||||
}
|
||||
|
||||
impl RequestContext {
|
||||
@@ -90,6 +91,7 @@ pub fn resolve_action(req: &Request<Incoming>) -> RequestContext {
|
||||
action: StorageAction::ListAllMyBuckets,
|
||||
bucket: None,
|
||||
key: None,
|
||||
source_bucket: None,
|
||||
}
|
||||
}
|
||||
1 => {
|
||||
@@ -113,6 +115,7 @@ pub fn resolve_action(req: &Request<Incoming>) -> RequestContext {
|
||||
action,
|
||||
bucket: Some(bucket),
|
||||
key: None,
|
||||
source_bucket: None,
|
||||
}
|
||||
}
|
||||
2 => {
|
||||
@@ -123,6 +126,18 @@ pub fn resolve_action(req: &Request<Incoming>) -> RequestContext {
|
||||
let has_part_number = query.contains_key("partNumber");
|
||||
let has_upload_id = query.contains_key("uploadId");
|
||||
let has_uploads = query.contains_key("uploads");
|
||||
let source_bucket = if has_copy_source {
|
||||
req.headers()
|
||||
.get("x-amz-copy-source")
|
||||
.and_then(|value| value.to_str().ok())
|
||||
.map(|source| {
|
||||
let source = source.trim_start_matches('/');
|
||||
let first_slash = source.find('/').unwrap_or(source.len());
|
||||
percent_decode(&source[..first_slash])
|
||||
})
|
||||
} else {
|
||||
None
|
||||
};
|
||||
|
||||
let action = match &method {
|
||||
&Method::PUT if has_part_number && has_upload_id => StorageAction::UploadPart,
|
||||
@@ -141,12 +156,14 @@ pub fn resolve_action(req: &Request<Incoming>) -> RequestContext {
|
||||
action,
|
||||
bucket: Some(bucket),
|
||||
key: Some(key),
|
||||
source_bucket,
|
||||
}
|
||||
}
|
||||
_ => RequestContext {
|
||||
action: StorageAction::ListAllMyBuckets,
|
||||
bucket: None,
|
||||
key: None,
|
||||
source_bucket: None,
|
||||
},
|
||||
}
|
||||
}
|
||||
|
||||
+180
-20
@@ -3,6 +3,8 @@ use hyper::body::Incoming;
|
||||
use hyper::Request;
|
||||
use sha2::{Digest, Sha256};
|
||||
use std::collections::{HashMap, HashSet};
|
||||
use std::path::PathBuf;
|
||||
use tokio::fs;
|
||||
use tokio::sync::RwLock;
|
||||
|
||||
use crate::config::{AuthConfig, Credential};
|
||||
@@ -14,6 +16,7 @@ type HmacSha256 = Hmac<Sha256>;
|
||||
#[derive(Debug, Clone)]
|
||||
pub struct AuthenticatedIdentity {
|
||||
pub access_key_id: String,
|
||||
pub bucket_name: Option<String>,
|
||||
}
|
||||
|
||||
/// Parsed components of an AWS4-HMAC-SHA256 Authorization header.
|
||||
@@ -56,11 +59,7 @@ pub fn verify_request(
|
||||
.headers()
|
||||
.get("x-amz-date")
|
||||
.and_then(|v| v.to_str().ok())
|
||||
.or_else(|| {
|
||||
req.headers()
|
||||
.get("date")
|
||||
.and_then(|v| v.to_str().ok())
|
||||
})
|
||||
.or_else(|| req.headers().get("date").and_then(|v| v.to_str().ok()))
|
||||
.ok_or_else(|| StorageError::missing_security_header("Missing x-amz-date header"))?;
|
||||
|
||||
// Enforce 15-min clock skew
|
||||
@@ -77,10 +76,7 @@ pub fn verify_request(
|
||||
let canonical_request = build_canonical_request(req, &parsed.signed_headers, content_sha256);
|
||||
|
||||
// Build string to sign
|
||||
let scope = format!(
|
||||
"{}/{}/s3/aws4_request",
|
||||
parsed.date_stamp, parsed.region
|
||||
);
|
||||
let scope = format!("{}/{}/s3/aws4_request", parsed.date_stamp, parsed.region);
|
||||
let canonical_hash = hex::encode(Sha256::digest(canonical_request.as_bytes()));
|
||||
let string_to_sign = format!(
|
||||
"AWS4-HMAC-SHA256\n{}\n{}\n{}",
|
||||
@@ -105,6 +101,7 @@ pub fn verify_request(
|
||||
|
||||
Ok(AuthenticatedIdentity {
|
||||
access_key_id: parsed.access_key_id,
|
||||
bucket_name: credential.bucket_name.clone(),
|
||||
})
|
||||
}
|
||||
|
||||
@@ -131,10 +128,9 @@ fn parse_auth_header(header: &str) -> Result<SigV4Header, StorageError> {
|
||||
}
|
||||
}
|
||||
|
||||
let credential_str = credential_str
|
||||
.ok_or_else(StorageError::authorization_header_malformed)?;
|
||||
let signed_headers_str = signed_headers_str
|
||||
.ok_or_else(StorageError::authorization_header_malformed)?;
|
||||
let credential_str = credential_str.ok_or_else(StorageError::authorization_header_malformed)?;
|
||||
let signed_headers_str =
|
||||
signed_headers_str.ok_or_else(StorageError::authorization_header_malformed)?;
|
||||
let signature = signature_str
|
||||
.ok_or_else(StorageError::authorization_header_malformed)?
|
||||
.to_string();
|
||||
@@ -164,7 +160,10 @@ fn parse_auth_header(header: &str) -> Result<SigV4Header, StorageError> {
|
||||
}
|
||||
|
||||
/// Find a credential by access key ID.
|
||||
fn find_credential<'a>(access_key_id: &str, credentials: &'a [Credential]) -> Option<&'a Credential> {
|
||||
fn find_credential<'a>(
|
||||
access_key_id: &str,
|
||||
credentials: &'a [Credential],
|
||||
) -> Option<&'a Credential> {
|
||||
credentials
|
||||
.iter()
|
||||
.find(|c| c.access_key_id == access_key_id)
|
||||
@@ -174,20 +173,49 @@ fn find_credential<'a>(access_key_id: &str, credentials: &'a [Credential]) -> Op
|
||||
pub struct RuntimeCredentialStore {
|
||||
enabled: bool,
|
||||
credentials: RwLock<Vec<Credential>>,
|
||||
persistence_path: Option<PathBuf>,
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, serde::Serialize)]
|
||||
#[serde(rename_all = "camelCase")]
|
||||
pub struct CredentialMetadata {
|
||||
pub access_key_id: String,
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
pub bucket_name: Option<String>,
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
pub region: Option<String>,
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, serde::Serialize)]
|
||||
#[serde(rename_all = "camelCase")]
|
||||
pub struct BucketTenantMetadata {
|
||||
pub bucket_name: String,
|
||||
pub access_key_id: String,
|
||||
#[serde(skip_serializing_if = "Option::is_none")]
|
||||
pub region: Option<String>,
|
||||
}
|
||||
|
||||
impl RuntimeCredentialStore {
|
||||
pub fn new(config: &AuthConfig) -> Self {
|
||||
Self {
|
||||
pub async fn new(
|
||||
config: &AuthConfig,
|
||||
persistence_path: Option<PathBuf>,
|
||||
) -> anyhow::Result<Self> {
|
||||
let credentials = match persistence_path.as_ref() {
|
||||
Some(path) if path.exists() => {
|
||||
let content = fs::read_to_string(path).await?;
|
||||
let credentials: Vec<Credential> = serde_json::from_str(&content)?;
|
||||
validate_credentials(&credentials)
|
||||
.map_err(|error| anyhow::anyhow!(error.message))?;
|
||||
credentials
|
||||
}
|
||||
_ => config.credentials.clone(),
|
||||
};
|
||||
|
||||
Ok(Self {
|
||||
enabled: config.enabled,
|
||||
credentials: RwLock::new(config.credentials.clone()),
|
||||
}
|
||||
credentials: RwLock::new(credentials),
|
||||
persistence_path,
|
||||
})
|
||||
}
|
||||
|
||||
pub fn enabled(&self) -> bool {
|
||||
@@ -201,6 +229,8 @@ impl RuntimeCredentialStore {
|
||||
.iter()
|
||||
.map(|credential| CredentialMetadata {
|
||||
access_key_id: credential.access_key_id.clone(),
|
||||
bucket_name: credential.bucket_name.clone(),
|
||||
region: credential.region.clone(),
|
||||
})
|
||||
.collect()
|
||||
}
|
||||
@@ -209,11 +239,140 @@ impl RuntimeCredentialStore {
|
||||
self.credentials.read().await.clone()
|
||||
}
|
||||
|
||||
pub async fn replace_credentials(&self, credentials: Vec<Credential>) -> Result<(), StorageError> {
|
||||
pub async fn replace_credentials(
|
||||
&self,
|
||||
credentials: Vec<Credential>,
|
||||
) -> Result<(), StorageError> {
|
||||
validate_credentials(&credentials)?;
|
||||
self.persist_credentials(&credentials).await?;
|
||||
*self.credentials.write().await = credentials;
|
||||
Ok(())
|
||||
}
|
||||
|
||||
pub async fn replace_bucket_tenant_credential(
|
||||
&self,
|
||||
bucket_name: &str,
|
||||
mut credential: Credential,
|
||||
) -> Result<Credential, StorageError> {
|
||||
validate_bucket_scope(bucket_name)?;
|
||||
credential.bucket_name = Some(bucket_name.to_string());
|
||||
|
||||
let mut credentials = self.credentials.read().await.clone();
|
||||
if credentials.iter().any(|existing| {
|
||||
existing.access_key_id == credential.access_key_id
|
||||
&& existing.bucket_name.as_deref() != Some(bucket_name)
|
||||
}) {
|
||||
return Err(StorageError::invalid_request(
|
||||
"Credential accessKeyId is already assigned to another principal.",
|
||||
));
|
||||
}
|
||||
|
||||
credentials.retain(|existing| existing.bucket_name.as_deref() != Some(bucket_name));
|
||||
credentials.push(credential.clone());
|
||||
validate_credentials(&credentials)?;
|
||||
self.persist_credentials(&credentials).await?;
|
||||
*self.credentials.write().await = credentials;
|
||||
Ok(credential)
|
||||
}
|
||||
|
||||
pub async fn remove_bucket_tenant_credentials(
|
||||
&self,
|
||||
bucket_name: &str,
|
||||
access_key_id: Option<&str>,
|
||||
) -> Result<usize, StorageError> {
|
||||
validate_bucket_scope(bucket_name)?;
|
||||
let mut credentials = self.credentials.read().await.clone();
|
||||
let before = credentials.len();
|
||||
credentials.retain(|credential| {
|
||||
if credential.bucket_name.as_deref() != Some(bucket_name) {
|
||||
return true;
|
||||
}
|
||||
|
||||
if let Some(access_key_id) = access_key_id {
|
||||
credential.access_key_id != access_key_id
|
||||
} else {
|
||||
false
|
||||
}
|
||||
});
|
||||
|
||||
let removed = before.saturating_sub(credentials.len());
|
||||
if credentials.is_empty() {
|
||||
return Err(StorageError::invalid_request(
|
||||
"Cannot remove the last active credential.",
|
||||
));
|
||||
}
|
||||
self.persist_credentials(&credentials).await?;
|
||||
*self.credentials.write().await = credentials;
|
||||
Ok(removed)
|
||||
}
|
||||
|
||||
pub async fn list_bucket_tenants(&self) -> Vec<BucketTenantMetadata> {
|
||||
let mut tenants: Vec<BucketTenantMetadata> = self
|
||||
.credentials
|
||||
.read()
|
||||
.await
|
||||
.iter()
|
||||
.filter_map(|credential| {
|
||||
credential
|
||||
.bucket_name
|
||||
.as_ref()
|
||||
.map(|bucket_name| BucketTenantMetadata {
|
||||
bucket_name: bucket_name.clone(),
|
||||
access_key_id: credential.access_key_id.clone(),
|
||||
region: credential.region.clone(),
|
||||
})
|
||||
})
|
||||
.collect();
|
||||
tenants.sort_by(|a, b| {
|
||||
a.bucket_name
|
||||
.cmp(&b.bucket_name)
|
||||
.then_with(|| a.access_key_id.cmp(&b.access_key_id))
|
||||
});
|
||||
tenants
|
||||
}
|
||||
|
||||
pub async fn get_bucket_tenant_credential(&self, bucket_name: &str) -> Option<Credential> {
|
||||
self.credentials
|
||||
.read()
|
||||
.await
|
||||
.iter()
|
||||
.find(|credential| credential.bucket_name.as_deref() == Some(bucket_name))
|
||||
.cloned()
|
||||
}
|
||||
|
||||
async fn persist_credentials(&self, credentials: &[Credential]) -> Result<(), StorageError> {
|
||||
let Some(path) = self.persistence_path.as_ref() else {
|
||||
return Ok(());
|
||||
};
|
||||
|
||||
if let Some(parent) = path.parent() {
|
||||
fs::create_dir_all(parent)
|
||||
.await
|
||||
.map_err(|error| StorageError::internal_error(&error.to_string()))?;
|
||||
}
|
||||
|
||||
let temp_path = path.with_extension("json.tmp");
|
||||
let json = serde_json::to_string_pretty(credentials)
|
||||
.map_err(|error| StorageError::internal_error(&error.to_string()))?;
|
||||
fs::write(&temp_path, json)
|
||||
.await
|
||||
.map_err(|error| StorageError::internal_error(&error.to_string()))?;
|
||||
fs::rename(&temp_path, path)
|
||||
.await
|
||||
.map_err(|error| StorageError::internal_error(&error.to_string()))?;
|
||||
|
||||
Ok(())
|
||||
}
|
||||
}
|
||||
|
||||
fn validate_bucket_scope(bucket_name: &str) -> Result<(), StorageError> {
|
||||
if bucket_name.trim().is_empty() {
|
||||
return Err(StorageError::invalid_request(
|
||||
"Bucket tenant bucketName must not be empty.",
|
||||
));
|
||||
}
|
||||
|
||||
Ok(())
|
||||
}
|
||||
|
||||
fn validate_credentials(credentials: &[Credential]) -> Result<(), StorageError> {
|
||||
@@ -253,7 +412,8 @@ fn check_clock_skew(amz_date: &str) -> Result<(), StorageError> {
|
||||
let parsed = chrono::NaiveDateTime::parse_from_str(amz_date, "%Y%m%dT%H%M%SZ")
|
||||
.map_err(|_| StorageError::authorization_header_malformed())?;
|
||||
|
||||
let request_time = chrono::DateTime::<chrono::Utc>::from_naive_utc_and_offset(parsed, chrono::Utc);
|
||||
let request_time =
|
||||
chrono::DateTime::<chrono::Utc>::from_naive_utc_and_offset(parsed, chrono::Utc);
|
||||
let now = chrono::Utc::now();
|
||||
let diff = (now - request_time).num_seconds().unsigned_abs();
|
||||
|
||||
|
||||
@@ -21,11 +21,10 @@ use super::quic_transport::QuicTransport;
|
||||
use super::shard_store::{ShardId, ShardStore};
|
||||
use super::state::{ClusterState, NodeStatus};
|
||||
use crate::storage::{
|
||||
storage_location_summary, BucketInfo, BucketSummary, ClusterDriveHealth,
|
||||
ClusterErasureHealth, ClusterHealth, ClusterPeerHealth, ClusterRepairHealth,
|
||||
CompleteMultipartResult, CopyResult, GetResult, HeadResult, ListObjectEntry,
|
||||
ListObjectsResult, MultipartUploadInfo, PutResult, RuntimeBucketStats,
|
||||
RuntimeStatsState, StorageLocationSummary, StorageStats,
|
||||
storage_location_summary, BucketInfo, BucketSummary, ClusterDriveHealth, ClusterErasureHealth,
|
||||
ClusterHealth, ClusterPeerHealth, ClusterRepairHealth, CompleteMultipartResult, CopyResult,
|
||||
GetResult, HeadResult, ListObjectEntry, ListObjectsResult, MultipartUploadInfo, PutResult,
|
||||
RuntimeBucketStats, RuntimeStatsState, StorageLocationSummary, StorageStats,
|
||||
};
|
||||
|
||||
use serde::{Deserialize, Serialize};
|
||||
@@ -170,7 +169,8 @@ impl DistributedStore {
|
||||
let peers = self.peer_health(&nodes);
|
||||
let drives = self.drive_health(&drive_states, &erasure_sets);
|
||||
let repairs = self.repair_health().await;
|
||||
let quorum_healthy = majority_healthy && self.quorum_is_healthy(&nodes, &drive_states, &erasure_sets);
|
||||
let quorum_healthy =
|
||||
majority_healthy && self.quorum_is_healthy(&nodes, &drive_states, &erasure_sets);
|
||||
|
||||
Ok(ClusterHealth {
|
||||
enabled: true,
|
||||
@@ -291,6 +291,69 @@ impl DistributedStore {
|
||||
Ok(PutResult { md5: md5_hex })
|
||||
}
|
||||
|
||||
pub async fn put_object_bytes(
|
||||
&self,
|
||||
bucket: &str,
|
||||
key: &str,
|
||||
data: &[u8],
|
||||
metadata: HashMap<String, String>,
|
||||
) -> Result<PutResult> {
|
||||
if !self.bucket_exists(bucket).await {
|
||||
return Err(crate::error::StorageError::no_such_bucket().into());
|
||||
}
|
||||
|
||||
let previous_size = self.manifest_size_if_exists(bucket, key).await;
|
||||
let erasure_set = self
|
||||
.state
|
||||
.get_erasure_set_for_object(bucket, key)
|
||||
.await
|
||||
.ok_or_else(|| anyhow::anyhow!("No erasure sets available"))?;
|
||||
|
||||
let mut chunks = Vec::new();
|
||||
for (chunk_index, chunk_data) in data
|
||||
.chunks(self.erasure_config.chunk_size_bytes)
|
||||
.enumerate()
|
||||
{
|
||||
let chunk_manifest = self
|
||||
.encode_and_distribute_chunk(
|
||||
&erasure_set,
|
||||
bucket,
|
||||
key,
|
||||
chunk_index as u32,
|
||||
chunk_data,
|
||||
)
|
||||
.await?;
|
||||
chunks.push(chunk_manifest);
|
||||
}
|
||||
|
||||
let md5_hex = format!("{:x}", Md5::digest(data));
|
||||
let now = Utc::now().to_rfc3339();
|
||||
let manifest = ObjectManifest {
|
||||
bucket: bucket.to_string(),
|
||||
key: key.to_string(),
|
||||
version_id: uuid::Uuid::new_v4().to_string(),
|
||||
size: data.len() as u64,
|
||||
content_md5: md5_hex.clone(),
|
||||
content_type: metadata
|
||||
.get("content-type")
|
||||
.cloned()
|
||||
.unwrap_or_else(|| "binary/octet-stream".to_string()),
|
||||
metadata,
|
||||
created_at: now.clone(),
|
||||
last_modified: now,
|
||||
data_shards: self.erasure_config.data_shards,
|
||||
parity_shards: self.erasure_config.parity_shards,
|
||||
chunk_size: self.erasure_config.chunk_size_bytes,
|
||||
chunks,
|
||||
};
|
||||
|
||||
self.store_manifest(&manifest).await?;
|
||||
self.track_object_upsert(bucket, previous_size, manifest.size)
|
||||
.await;
|
||||
|
||||
Ok(PutResult { md5: md5_hex })
|
||||
}
|
||||
|
||||
pub async fn get_object(
|
||||
&self,
|
||||
bucket: &str,
|
||||
@@ -1033,7 +1096,11 @@ impl DistributedStore {
|
||||
peers
|
||||
}
|
||||
|
||||
fn drive_health(&self, drive_states: &[DriveState], erasure_sets: &[ErasureSet]) -> Vec<ClusterDriveHealth> {
|
||||
fn drive_health(
|
||||
&self,
|
||||
drive_states: &[DriveState],
|
||||
erasure_sets: &[ErasureSet],
|
||||
) -> Vec<ClusterDriveHealth> {
|
||||
let local_node_id = self.state.local_node_id();
|
||||
let mut drive_to_set = HashMap::new();
|
||||
for erasure_set in erasure_sets {
|
||||
@@ -1118,7 +1185,10 @@ impl DistributedStore {
|
||||
.unwrap_or(false);
|
||||
}
|
||||
|
||||
matches!(node_statuses.get(drive.node_id.as_str()), Some(NodeStatus::Online))
|
||||
matches!(
|
||||
node_statuses.get(drive.node_id.as_str()),
|
||||
Some(NodeStatus::Online)
|
||||
)
|
||||
})
|
||||
.count();
|
||||
|
||||
|
||||
+5
-2
@@ -45,11 +45,14 @@ pub struct AuthConfig {
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, Serialize, Deserialize)]
|
||||
#[serde(rename_all = "camelCase")]
|
||||
pub struct Credential {
|
||||
#[serde(rename = "accessKeyId")]
|
||||
pub access_key_id: String,
|
||||
#[serde(rename = "secretAccessKey")]
|
||||
pub secret_access_key: String,
|
||||
#[serde(default, skip_serializing_if = "Option::is_none")]
|
||||
pub bucket_name: Option<String>,
|
||||
#[serde(default, skip_serializing_if = "Option::is_none")]
|
||||
pub region: Option<String>,
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, Serialize, Deserialize)]
|
||||
|
||||
+249
-18
@@ -7,6 +7,7 @@ use tokio::io::{AsyncBufReadExt, BufReader};
|
||||
use crate::config::Credential;
|
||||
use crate::config::SmartStorageConfig;
|
||||
use crate::server::StorageServer;
|
||||
use crate::storage::BucketExport;
|
||||
|
||||
#[derive(Deserialize)]
|
||||
struct IpcRequest {
|
||||
@@ -91,17 +92,15 @@ pub async fn management_loop() -> Result<()> {
|
||||
config: SmartStorageConfig,
|
||||
}
|
||||
match serde_json::from_value::<StartParams>(req.params) {
|
||||
Ok(params) => {
|
||||
match StorageServer::start(params.config).await {
|
||||
Ok(s) => {
|
||||
server = Some(s);
|
||||
send_response(id, serde_json::json!({}));
|
||||
}
|
||||
Err(e) => {
|
||||
send_error(id, format!("Failed to start server: {}", e));
|
||||
}
|
||||
Ok(params) => match StorageServer::start(params.config).await {
|
||||
Ok(s) => {
|
||||
server = Some(s);
|
||||
send_response(id, serde_json::json!({}));
|
||||
}
|
||||
}
|
||||
Err(e) => {
|
||||
send_error(id, format!("Failed to start server: {}", e));
|
||||
}
|
||||
},
|
||||
Err(e) => {
|
||||
send_error(id, format!("Invalid start params: {}", e));
|
||||
}
|
||||
@@ -126,10 +125,7 @@ pub async fn management_loop() -> Result<()> {
|
||||
send_response(id, serde_json::json!({}));
|
||||
}
|
||||
Err(e) => {
|
||||
send_error(
|
||||
id,
|
||||
format!("Failed to create bucket: {}", e),
|
||||
);
|
||||
send_error(id, format!("Failed to create bucket: {}", e));
|
||||
}
|
||||
}
|
||||
} else {
|
||||
@@ -141,6 +137,244 @@ pub async fn management_loop() -> Result<()> {
|
||||
}
|
||||
}
|
||||
}
|
||||
"createBucketTenant" => {
|
||||
#[derive(Deserialize)]
|
||||
#[serde(rename_all = "camelCase")]
|
||||
struct CreateBucketTenantParams {
|
||||
bucket_name: String,
|
||||
access_key_id: String,
|
||||
secret_access_key: String,
|
||||
region: Option<String>,
|
||||
}
|
||||
|
||||
match serde_json::from_value::<CreateBucketTenantParams>(req.params) {
|
||||
Ok(params) => {
|
||||
if let Some(ref s) = server {
|
||||
let credential = Credential {
|
||||
access_key_id: params.access_key_id,
|
||||
secret_access_key: params.secret_access_key,
|
||||
bucket_name: Some(params.bucket_name.clone()),
|
||||
region: params.region,
|
||||
};
|
||||
match s
|
||||
.create_bucket_tenant(¶ms.bucket_name, credential)
|
||||
.await
|
||||
{
|
||||
Ok(credential) => match serde_json::to_value(credential) {
|
||||
Ok(value) => send_response(id, value),
|
||||
Err(error) => send_error(
|
||||
id,
|
||||
format!("Failed to serialize bucket tenant: {}", error),
|
||||
),
|
||||
},
|
||||
Err(error) => send_error(
|
||||
id,
|
||||
format!("Failed to create bucket tenant: {}", error),
|
||||
),
|
||||
}
|
||||
} else {
|
||||
send_error(id, "Server not started".to_string());
|
||||
}
|
||||
}
|
||||
Err(error) => {
|
||||
send_error(id, format!("Invalid createBucketTenant params: {}", error));
|
||||
}
|
||||
}
|
||||
}
|
||||
"deleteBucketTenant" => {
|
||||
#[derive(Deserialize)]
|
||||
#[serde(rename_all = "camelCase")]
|
||||
struct DeleteBucketTenantParams {
|
||||
bucket_name: String,
|
||||
access_key_id: Option<String>,
|
||||
}
|
||||
|
||||
match serde_json::from_value::<DeleteBucketTenantParams>(req.params) {
|
||||
Ok(params) => {
|
||||
if let Some(ref s) = server {
|
||||
match s
|
||||
.delete_bucket_tenant(
|
||||
¶ms.bucket_name,
|
||||
params.access_key_id.as_deref(),
|
||||
)
|
||||
.await
|
||||
{
|
||||
Ok(()) => send_response(id, serde_json::json!({})),
|
||||
Err(error) => send_error(
|
||||
id,
|
||||
format!("Failed to delete bucket tenant: {}", error),
|
||||
),
|
||||
}
|
||||
} else {
|
||||
send_error(id, "Server not started".to_string());
|
||||
}
|
||||
}
|
||||
Err(error) => {
|
||||
send_error(id, format!("Invalid deleteBucketTenant params: {}", error));
|
||||
}
|
||||
}
|
||||
}
|
||||
"rotateBucketTenantCredentials" => {
|
||||
#[derive(Deserialize)]
|
||||
#[serde(rename_all = "camelCase")]
|
||||
struct RotateBucketTenantCredentialsParams {
|
||||
bucket_name: String,
|
||||
access_key_id: String,
|
||||
secret_access_key: String,
|
||||
region: Option<String>,
|
||||
}
|
||||
|
||||
match serde_json::from_value::<RotateBucketTenantCredentialsParams>(req.params) {
|
||||
Ok(params) => {
|
||||
if let Some(ref s) = server {
|
||||
let credential = Credential {
|
||||
access_key_id: params.access_key_id,
|
||||
secret_access_key: params.secret_access_key,
|
||||
bucket_name: Some(params.bucket_name.clone()),
|
||||
region: params.region,
|
||||
};
|
||||
match s
|
||||
.rotate_bucket_tenant_credentials(¶ms.bucket_name, credential)
|
||||
.await
|
||||
{
|
||||
Ok(credential) => match serde_json::to_value(credential) {
|
||||
Ok(value) => send_response(id, value),
|
||||
Err(error) => send_error(
|
||||
id,
|
||||
format!("Failed to serialize bucket tenant: {}", error),
|
||||
),
|
||||
},
|
||||
Err(error) => send_error(
|
||||
id,
|
||||
format!(
|
||||
"Failed to rotate bucket tenant credentials: {}",
|
||||
error
|
||||
),
|
||||
),
|
||||
}
|
||||
} else {
|
||||
send_error(id, "Server not started".to_string());
|
||||
}
|
||||
}
|
||||
Err(error) => {
|
||||
send_error(
|
||||
id,
|
||||
format!("Invalid rotateBucketTenantCredentials params: {}", error),
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
"listBucketTenants" => {
|
||||
if let Some(ref s) = server {
|
||||
match serde_json::to_value(s.list_bucket_tenants().await) {
|
||||
Ok(value) => send_response(id, value),
|
||||
Err(error) => {
|
||||
send_error(id, format!("Failed to serialize bucket tenants: {}", error))
|
||||
}
|
||||
}
|
||||
} else {
|
||||
send_error(id, "Server not started".to_string());
|
||||
}
|
||||
}
|
||||
"getBucketTenantCredential" => {
|
||||
#[derive(Deserialize)]
|
||||
#[serde(rename_all = "camelCase")]
|
||||
struct GetBucketTenantCredentialParams {
|
||||
bucket_name: String,
|
||||
}
|
||||
|
||||
match serde_json::from_value::<GetBucketTenantCredentialParams>(req.params) {
|
||||
Ok(params) => {
|
||||
if let Some(ref s) = server {
|
||||
match s.get_bucket_tenant_credential(¶ms.bucket_name).await {
|
||||
Some(credential) => match serde_json::to_value(credential) {
|
||||
Ok(value) => send_response(id, value),
|
||||
Err(error) => send_error(
|
||||
id,
|
||||
format!("Failed to serialize bucket tenant: {}", error),
|
||||
),
|
||||
},
|
||||
None => send_error(
|
||||
id,
|
||||
format!(
|
||||
"No bucket tenant credential exists for bucket {}",
|
||||
params.bucket_name
|
||||
),
|
||||
),
|
||||
}
|
||||
} else {
|
||||
send_error(id, "Server not started".to_string());
|
||||
}
|
||||
}
|
||||
Err(error) => {
|
||||
send_error(
|
||||
id,
|
||||
format!("Invalid getBucketTenantCredential params: {}", error),
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
"exportBucket" => {
|
||||
#[derive(Deserialize)]
|
||||
#[serde(rename_all = "camelCase")]
|
||||
struct ExportBucketParams {
|
||||
bucket_name: String,
|
||||
}
|
||||
|
||||
match serde_json::from_value::<ExportBucketParams>(req.params) {
|
||||
Ok(params) => {
|
||||
if let Some(ref s) = server {
|
||||
match s.store().export_bucket(¶ms.bucket_name).await {
|
||||
Ok(export) => match serde_json::to_value(export) {
|
||||
Ok(value) => send_response(id, value),
|
||||
Err(error) => send_error(
|
||||
id,
|
||||
format!("Failed to serialize bucket export: {}", error),
|
||||
),
|
||||
},
|
||||
Err(error) => {
|
||||
send_error(id, format!("Failed to export bucket: {}", error))
|
||||
}
|
||||
}
|
||||
} else {
|
||||
send_error(id, "Server not started".to_string());
|
||||
}
|
||||
}
|
||||
Err(error) => {
|
||||
send_error(id, format!("Invalid exportBucket params: {}", error));
|
||||
}
|
||||
}
|
||||
}
|
||||
"importBucket" => {
|
||||
#[derive(Deserialize)]
|
||||
#[serde(rename_all = "camelCase")]
|
||||
struct ImportBucketParams {
|
||||
bucket_name: String,
|
||||
source: BucketExport,
|
||||
}
|
||||
|
||||
match serde_json::from_value::<ImportBucketParams>(req.params) {
|
||||
Ok(params) => {
|
||||
if let Some(ref s) = server {
|
||||
match s
|
||||
.store()
|
||||
.import_bucket(¶ms.bucket_name, params.source)
|
||||
.await
|
||||
{
|
||||
Ok(()) => send_response(id, serde_json::json!({})),
|
||||
Err(error) => {
|
||||
send_error(id, format!("Failed to import bucket: {}", error))
|
||||
}
|
||||
}
|
||||
} else {
|
||||
send_error(id, "Server not started".to_string());
|
||||
}
|
||||
}
|
||||
Err(error) => {
|
||||
send_error(id, format!("Invalid importBucket params: {}", error));
|
||||
}
|
||||
}
|
||||
}
|
||||
"getStorageStats" => {
|
||||
if let Some(ref s) = server {
|
||||
match s.store().get_storage_stats().await {
|
||||
@@ -186,10 +420,7 @@ pub async fn management_loop() -> Result<()> {
|
||||
match serde_json::to_value(s.list_credentials().await) {
|
||||
Ok(value) => send_response(id, value),
|
||||
Err(error) => {
|
||||
send_error(
|
||||
id,
|
||||
format!("Failed to serialize credentials: {}", error),
|
||||
);
|
||||
send_error(id, format!("Failed to serialize credentials: {}", error));
|
||||
}
|
||||
}
|
||||
} else {
|
||||
|
||||
+255
-64
@@ -10,8 +10,8 @@ use hyper_util::rt::TokioIo;
|
||||
use std::collections::HashMap;
|
||||
use std::net::SocketAddr;
|
||||
use std::pin::Pin;
|
||||
use std::sync::Arc;
|
||||
use std::sync::atomic::{AtomicU64, Ordering};
|
||||
use std::sync::Arc;
|
||||
use std::task::{Context, Poll};
|
||||
use tokio::io::AsyncReadExt;
|
||||
use tokio::net::TcpListener;
|
||||
@@ -21,9 +21,6 @@ use uuid::Uuid;
|
||||
|
||||
use crate::action::{self, RequestContext, StorageAction};
|
||||
use crate::auth::{self, AuthenticatedIdentity};
|
||||
use crate::config::SmartStorageConfig;
|
||||
use crate::policy::{self, PolicyDecision, PolicyStore};
|
||||
use crate::error::StorageError;
|
||||
use crate::cluster::coordinator::DistributedStore;
|
||||
use crate::cluster::drive_manager::DriveManager;
|
||||
use crate::cluster::healing::HealingService;
|
||||
@@ -34,6 +31,9 @@ use crate::cluster::protocol::NodeInfo;
|
||||
use crate::cluster::quic_transport::QuicTransport;
|
||||
use crate::cluster::shard_store::ShardStore;
|
||||
use crate::cluster::state::ClusterState;
|
||||
use crate::config::{Credential, SmartStorageConfig};
|
||||
use crate::error::StorageError;
|
||||
use crate::policy::{self, PolicyDecision, PolicyStore};
|
||||
use crate::storage::{FileStore, StorageBackend};
|
||||
use crate::xml_response;
|
||||
|
||||
@@ -70,7 +70,6 @@ pub struct StorageServer {
|
||||
|
||||
impl StorageServer {
|
||||
pub async fn start(config: SmartStorageConfig) -> Result<Self> {
|
||||
let auth_runtime = Arc::new(auth::RuntimeCredentialStore::new(&config.auth));
|
||||
let mut cluster_shutdown_txs = Vec::new();
|
||||
let store: Arc<StorageBackend> = if let Some(ref cluster_config) = config.cluster {
|
||||
if cluster_config.enabled {
|
||||
@@ -88,8 +87,12 @@ impl StorageServer {
|
||||
let policy_store = Arc::new(PolicyStore::new(store.policies_dir()));
|
||||
policy_store.load_from_disk().await?;
|
||||
|
||||
let addr: SocketAddr = format!("{}:{}", config.address(), config.server.port)
|
||||
.parse()?;
|
||||
let auth_runtime = Arc::new(
|
||||
auth::RuntimeCredentialStore::new(&config.auth, Some(Self::credentials_path(&config)))
|
||||
.await?,
|
||||
);
|
||||
|
||||
let addr: SocketAddr = format!("{}:{}", config.address(), config.server.port).parse()?;
|
||||
|
||||
let listener = TcpListener::bind(addr).await?;
|
||||
let (shutdown_tx, shutdown_rx) = watch::channel(false);
|
||||
@@ -181,15 +184,81 @@ impl StorageServer {
|
||||
|
||||
pub async fn replace_credentials(
|
||||
&self,
|
||||
credentials: Vec<crate::config::Credential>,
|
||||
credentials: Vec<Credential>,
|
||||
) -> Result<(), StorageError> {
|
||||
self.auth_runtime.replace_credentials(credentials).await
|
||||
}
|
||||
|
||||
pub async fn create_bucket_tenant(
|
||||
&self,
|
||||
bucket_name: &str,
|
||||
credential: Credential,
|
||||
) -> Result<Credential> {
|
||||
self.ensure_tenant_auth_enabled()?;
|
||||
self.store.create_bucket(bucket_name).await?;
|
||||
Ok(self
|
||||
.auth_runtime
|
||||
.replace_bucket_tenant_credential(bucket_name, credential)
|
||||
.await?)
|
||||
}
|
||||
|
||||
pub async fn rotate_bucket_tenant_credentials(
|
||||
&self,
|
||||
bucket_name: &str,
|
||||
credential: Credential,
|
||||
) -> Result<Credential> {
|
||||
self.ensure_tenant_auth_enabled()?;
|
||||
if !self.store.bucket_exists(bucket_name).await {
|
||||
return Err(StorageError::no_such_bucket().into());
|
||||
}
|
||||
Ok(self
|
||||
.auth_runtime
|
||||
.replace_bucket_tenant_credential(bucket_name, credential)
|
||||
.await?)
|
||||
}
|
||||
|
||||
pub async fn delete_bucket_tenant(
|
||||
&self,
|
||||
bucket_name: &str,
|
||||
access_key_id: Option<&str>,
|
||||
) -> Result<()> {
|
||||
self.ensure_tenant_auth_enabled()?;
|
||||
self.auth_runtime
|
||||
.remove_bucket_tenant_credentials(bucket_name, access_key_id)
|
||||
.await?;
|
||||
if access_key_id.is_none() && self.store.bucket_exists(bucket_name).await {
|
||||
self.store.delete_bucket_recursive(bucket_name).await?;
|
||||
}
|
||||
Ok(())
|
||||
}
|
||||
|
||||
pub async fn list_bucket_tenants(&self) -> Vec<crate::auth::BucketTenantMetadata> {
|
||||
self.auth_runtime.list_bucket_tenants().await
|
||||
}
|
||||
|
||||
pub async fn get_bucket_tenant_credential(&self, bucket_name: &str) -> Option<Credential> {
|
||||
self.auth_runtime
|
||||
.get_bucket_tenant_credential(bucket_name)
|
||||
.await
|
||||
}
|
||||
|
||||
fn ensure_tenant_auth_enabled(&self) -> Result<()> {
|
||||
if !self.auth_runtime.enabled() {
|
||||
anyhow::bail!("Bucket tenants require auth.enabled=true");
|
||||
}
|
||||
Ok(())
|
||||
}
|
||||
|
||||
fn credentials_path(config: &SmartStorageConfig) -> std::path::PathBuf {
|
||||
std::path::PathBuf::from(&config.storage.directory)
|
||||
.join(".smartstorage")
|
||||
.join("credentials.json")
|
||||
}
|
||||
|
||||
async fn start_standalone(config: &SmartStorageConfig) -> Result<Arc<StorageBackend>> {
|
||||
let store = Arc::new(StorageBackend::Standalone(
|
||||
FileStore::new(config.storage.directory.clone().into()),
|
||||
));
|
||||
let store = Arc::new(StorageBackend::Standalone(FileStore::new(
|
||||
config.storage.directory.clone().into(),
|
||||
)));
|
||||
if config.storage.clean_slate {
|
||||
store.reset().await?;
|
||||
} else {
|
||||
@@ -208,7 +277,9 @@ impl StorageServer {
|
||||
let topology_path = persistence::topology_path(&cluster_metadata_dir);
|
||||
let persisted_identity = persistence::load_identity(&identity_path).await?;
|
||||
|
||||
if let (Some(configured_node_id), Some(identity)) = (&cluster_config.node_id, &persisted_identity) {
|
||||
if let (Some(configured_node_id), Some(identity)) =
|
||||
(&cluster_config.node_id, &persisted_identity)
|
||||
{
|
||||
if configured_node_id != &identity.node_id {
|
||||
anyhow::bail!(
|
||||
"Configured cluster node ID '{}' conflicts with persisted node ID '{}'",
|
||||
@@ -221,7 +292,11 @@ impl StorageServer {
|
||||
let node_id = cluster_config
|
||||
.node_id
|
||||
.clone()
|
||||
.or_else(|| persisted_identity.as_ref().map(|identity| identity.node_id.clone()))
|
||||
.or_else(|| {
|
||||
persisted_identity
|
||||
.as_ref()
|
||||
.map(|identity| identity.node_id.clone())
|
||||
})
|
||||
.unwrap_or_else(|| uuid::Uuid::new_v4().to_string());
|
||||
let cluster_id = persisted_identity
|
||||
.as_ref()
|
||||
@@ -273,7 +348,9 @@ impl StorageServer {
|
||||
let has_persisted_topology = persisted_topology.is_some();
|
||||
if let Some(topology) = persisted_topology {
|
||||
if topology.cluster_id != cluster_id {
|
||||
anyhow::bail!("Persisted topology cluster ID does not match persisted node identity");
|
||||
anyhow::bail!(
|
||||
"Persisted topology cluster ID does not match persisted node identity"
|
||||
);
|
||||
}
|
||||
cluster_state.apply_topology(&topology).await;
|
||||
} else if cluster_config.seed_nodes.is_empty() {
|
||||
@@ -347,7 +424,11 @@ impl StorageServer {
|
||||
let shard_stores_for_accept = local_shard_stores.clone();
|
||||
tokio::spawn(async move {
|
||||
transport_clone
|
||||
.accept_loop(shard_stores_for_accept, Some(cluster_state_for_accept), quic_shutdown_rx)
|
||||
.accept_loop(
|
||||
shard_stores_for_accept,
|
||||
Some(cluster_state_for_accept),
|
||||
quic_shutdown_rx,
|
||||
)
|
||||
.await;
|
||||
});
|
||||
|
||||
@@ -400,7 +481,10 @@ impl StorageServer {
|
||||
);
|
||||
}
|
||||
|
||||
Ok((store, vec![quic_shutdown_tx, hb_shutdown_tx, heal_shutdown_tx]))
|
||||
Ok((
|
||||
store,
|
||||
vec![quic_shutdown_tx, hb_shutdown_tx, heal_shutdown_tx],
|
||||
))
|
||||
}
|
||||
}
|
||||
|
||||
@@ -414,17 +498,26 @@ impl SmartStorageConfig {
|
||||
// Request handling
|
||||
// ============================
|
||||
|
||||
type BoxBody = http_body_util::combinators::BoxBody<Bytes, Box<dyn std::error::Error + Send + Sync>>;
|
||||
type BoxBody =
|
||||
http_body_util::combinators::BoxBody<Bytes, Box<dyn std::error::Error + Send + Sync>>;
|
||||
|
||||
fn full_body(data: impl Into<Bytes>) -> BoxBody {
|
||||
http_body_util::Full::new(data.into())
|
||||
.map_err(|never: std::convert::Infallible| -> Box<dyn std::error::Error + Send + Sync> { match never {} })
|
||||
.map_err(
|
||||
|never: std::convert::Infallible| -> Box<dyn std::error::Error + Send + Sync> {
|
||||
match never {}
|
||||
},
|
||||
)
|
||||
.boxed()
|
||||
}
|
||||
|
||||
fn empty_body() -> BoxBody {
|
||||
http_body_util::Empty::new()
|
||||
.map_err(|never: std::convert::Infallible| -> Box<dyn std::error::Error + Send + Sync> { match never {} })
|
||||
.map_err(
|
||||
|never: std::convert::Infallible| -> Box<dyn std::error::Error + Send + Sync> {
|
||||
match never {}
|
||||
},
|
||||
)
|
||||
.boxed()
|
||||
}
|
||||
|
||||
@@ -445,10 +538,10 @@ impl Stream for FrameStream {
|
||||
fn poll_next(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Option<Self::Item>> {
|
||||
let inner = unsafe { self.map_unchecked_mut(|s| &mut s.inner) };
|
||||
match inner.poll_next(cx) {
|
||||
Poll::Ready(Some(Ok(bytes))) => {
|
||||
Poll::Ready(Some(Ok(hyper::body::Frame::data(bytes))))
|
||||
}
|
||||
Poll::Ready(Some(Err(e))) => Poll::Ready(Some(Err(Box::new(e) as Box<dyn std::error::Error + Send + Sync>))),
|
||||
Poll::Ready(Some(Ok(bytes))) => Poll::Ready(Some(Ok(hyper::body::Frame::data(bytes)))),
|
||||
Poll::Ready(Some(Err(e))) => Poll::Ready(Some(Err(
|
||||
Box::new(e) as Box<dyn std::error::Error + Send + Sync>
|
||||
))),
|
||||
Poll::Ready(None) => Poll::Ready(None),
|
||||
Poll::Pending => Poll::Pending,
|
||||
}
|
||||
@@ -482,7 +575,11 @@ fn storage_error_response(err: &StorageError, request_id: &str) -> Response<BoxB
|
||||
.unwrap()
|
||||
}
|
||||
|
||||
fn json_response(status: StatusCode, value: serde_json::Value, request_id: &str) -> Response<BoxBody> {
|
||||
fn json_response(
|
||||
status: StatusCode,
|
||||
value: serde_json::Value,
|
||||
request_id: &str,
|
||||
) -> Response<BoxBody> {
|
||||
Response::builder()
|
||||
.status(status)
|
||||
.header("content-type", "application/json")
|
||||
@@ -491,7 +588,12 @@ fn json_response(status: StatusCode, value: serde_json::Value, request_id: &str)
|
||||
.unwrap()
|
||||
}
|
||||
|
||||
fn text_response(status: StatusCode, content_type: &str, body: String, request_id: &str) -> Response<BoxBody> {
|
||||
fn text_response(
|
||||
status: StatusCode,
|
||||
content_type: &str,
|
||||
body: String,
|
||||
request_id: &str,
|
||||
) -> Response<BoxBody> {
|
||||
Response::builder()
|
||||
.status(status)
|
||||
.header("content-type", content_type)
|
||||
@@ -521,17 +623,20 @@ async fn handle_request(
|
||||
}
|
||||
|
||||
if method == Method::GET && uri.path().starts_with("/-/") {
|
||||
let resp = match handle_operational_request(uri.path(), store, &config, &metrics, &request_id).await {
|
||||
Ok(resp) => resp,
|
||||
Err(error) => {
|
||||
tracing::error!(error = %error, "Operational endpoint failed");
|
||||
json_response(
|
||||
StatusCode::INTERNAL_SERVER_ERROR,
|
||||
serde_json::json!({ "ok": false, "error": error.to_string() }),
|
||||
&request_id,
|
||||
)
|
||||
}
|
||||
};
|
||||
let resp =
|
||||
match handle_operational_request(uri.path(), store, &config, &metrics, &request_id)
|
||||
.await
|
||||
{
|
||||
Ok(resp) => resp,
|
||||
Err(error) => {
|
||||
tracing::error!(error = %error, "Operational endpoint failed");
|
||||
json_response(
|
||||
StatusCode::INTERNAL_SERVER_ERROR,
|
||||
serde_json::json!({ "ok": false, "error": error.to_string() }),
|
||||
&request_id,
|
||||
)
|
||||
}
|
||||
};
|
||||
metrics.record_response(resp.status());
|
||||
return Ok(resp);
|
||||
}
|
||||
@@ -672,7 +777,11 @@ async fn handle_operational_request(
|
||||
let cluster_health = store.get_cluster_health().await?;
|
||||
let stats = store.get_storage_stats().await?;
|
||||
let cluster_enabled = if cluster_health.enabled { 1 } else { 0 };
|
||||
let quorum_healthy = if cluster_health.quorum_healthy.unwrap_or(true) { 1 } else { 0 };
|
||||
let quorum_healthy = if cluster_health.quorum_healthy.unwrap_or(true) {
|
||||
1
|
||||
} else {
|
||||
0
|
||||
};
|
||||
let body = format!(
|
||||
"# HELP smartstorage_requests_total Total HTTP requests observed by smartstorage.\n\
|
||||
# TYPE smartstorage_requests_total counter\n\
|
||||
@@ -720,6 +829,12 @@ async fn authorize_request(
|
||||
identity: Option<&AuthenticatedIdentity>,
|
||||
policy_store: &PolicyStore,
|
||||
) -> Result<(), StorageError> {
|
||||
if let Some(identity) = identity {
|
||||
if let Some(bucket_name) = identity.bucket_name.as_deref() {
|
||||
authorize_scoped_credential(ctx, bucket_name)?;
|
||||
}
|
||||
}
|
||||
|
||||
// ListAllMyBuckets requires authentication (no bucket to apply policy to)
|
||||
if ctx.action == StorageAction::ListAllMyBuckets {
|
||||
if identity.is_none() {
|
||||
@@ -750,6 +865,46 @@ async fn authorize_request(
|
||||
Ok(())
|
||||
}
|
||||
|
||||
fn authorize_scoped_credential(
|
||||
ctx: &RequestContext,
|
||||
bucket_name: &str,
|
||||
) -> Result<(), StorageError> {
|
||||
let Some(request_bucket) = ctx.bucket.as_deref() else {
|
||||
return Err(StorageError::access_denied());
|
||||
};
|
||||
|
||||
if request_bucket != bucket_name {
|
||||
return Err(StorageError::access_denied());
|
||||
}
|
||||
|
||||
if let Some(source_bucket) = ctx.source_bucket.as_deref() {
|
||||
if source_bucket != bucket_name {
|
||||
return Err(StorageError::access_denied());
|
||||
}
|
||||
}
|
||||
|
||||
match ctx.action {
|
||||
StorageAction::CreateBucket
|
||||
| StorageAction::DeleteBucket
|
||||
| StorageAction::GetBucketPolicy
|
||||
| StorageAction::PutBucketPolicy
|
||||
| StorageAction::DeleteBucketPolicy
|
||||
| StorageAction::ListAllMyBuckets => Err(StorageError::access_denied()),
|
||||
StorageAction::HeadBucket
|
||||
| StorageAction::ListBucket
|
||||
| StorageAction::GetObject
|
||||
| StorageAction::HeadObject
|
||||
| StorageAction::PutObject
|
||||
| StorageAction::DeleteObject
|
||||
| StorageAction::CopyObject
|
||||
| StorageAction::ListBucketMultipartUploads
|
||||
| StorageAction::AbortMultipartUpload
|
||||
| StorageAction::InitiateMultipartUpload
|
||||
| StorageAction::UploadPart
|
||||
| StorageAction::CompleteMultipartUpload => Ok(()),
|
||||
}
|
||||
}
|
||||
|
||||
// ============================
|
||||
// Routing
|
||||
// ============================
|
||||
@@ -788,9 +943,16 @@ async fn route_request(
|
||||
// Check for ?policy query parameter
|
||||
if query.contains_key("policy") {
|
||||
return match method {
|
||||
Method::GET => handle_get_bucket_policy(policy_store, &bucket, request_id).await,
|
||||
Method::PUT => handle_put_bucket_policy(req, &store, policy_store, &bucket, request_id).await,
|
||||
Method::DELETE => handle_delete_bucket_policy(policy_store, &bucket, request_id).await,
|
||||
Method::GET => {
|
||||
handle_get_bucket_policy(policy_store, &bucket, request_id).await
|
||||
}
|
||||
Method::PUT => {
|
||||
handle_put_bucket_policy(req, &store, policy_store, &bucket, request_id)
|
||||
.await
|
||||
}
|
||||
Method::DELETE => {
|
||||
handle_delete_bucket_policy(policy_store, &bucket, request_id).await
|
||||
}
|
||||
_ => Ok(empty_response(StatusCode::METHOD_NOT_ALLOWED, request_id)),
|
||||
};
|
||||
}
|
||||
@@ -804,7 +966,9 @@ async fn route_request(
|
||||
}
|
||||
}
|
||||
Method::PUT => handle_create_bucket(store, &bucket, request_id).await,
|
||||
Method::DELETE => handle_delete_bucket(store, &bucket, request_id, policy_store).await,
|
||||
Method::DELETE => {
|
||||
handle_delete_bucket(store, &bucket, request_id, policy_store).await
|
||||
}
|
||||
Method::HEAD => handle_head_bucket(store, &bucket, request_id).await,
|
||||
_ => Ok(empty_response(StatusCode::METHOD_NOT_ALLOWED, request_id)),
|
||||
}
|
||||
@@ -824,12 +988,8 @@ async fn route_request(
|
||||
handle_put_object(req, store, &bucket, &key, request_id).await
|
||||
}
|
||||
}
|
||||
Method::GET => {
|
||||
handle_get_object(req, store, &bucket, &key, request_id).await
|
||||
}
|
||||
Method::HEAD => {
|
||||
handle_head_object(store, &bucket, &key, request_id).await
|
||||
}
|
||||
Method::GET => handle_get_object(req, store, &bucket, &key, request_id).await,
|
||||
Method::HEAD => handle_head_object(store, &bucket, &key, request_id).await,
|
||||
Method::DELETE => {
|
||||
if query.contains_key("uploadId") {
|
||||
let upload_id = query.get("uploadId").unwrap();
|
||||
@@ -843,7 +1003,8 @@ async fn route_request(
|
||||
handle_initiate_multipart(req, store, &bucket, &key, request_id).await
|
||||
} else if query.contains_key("uploadId") {
|
||||
let upload_id = query.get("uploadId").unwrap().clone();
|
||||
handle_complete_multipart(req, store, &bucket, &key, &upload_id, request_id).await
|
||||
handle_complete_multipart(req, store, &bucket, &key, &upload_id, request_id)
|
||||
.await
|
||||
} else {
|
||||
let err = StorageError::invalid_request("Invalid POST request");
|
||||
Ok(storage_error_response(&err, request_id))
|
||||
@@ -972,7 +1133,13 @@ async fn handle_get_object(
|
||||
|
||||
let mut builder = Response::builder()
|
||||
.header("ETag", format!("\"{}\"", result.md5))
|
||||
.header("Last-Modified", result.last_modified.format("%a, %d %b %Y %H:%M:%S GMT").to_string())
|
||||
.header(
|
||||
"Last-Modified",
|
||||
result
|
||||
.last_modified
|
||||
.format("%a, %d %b %Y %H:%M:%S GMT")
|
||||
.to_string(),
|
||||
)
|
||||
.header("Content-Type", &content_type)
|
||||
.header("Accept-Ranges", "bytes")
|
||||
.header("x-amz-request-id", request_id);
|
||||
@@ -1023,7 +1190,13 @@ async fn handle_head_object(
|
||||
let mut builder = Response::builder()
|
||||
.status(StatusCode::OK)
|
||||
.header("ETag", format!("\"{}\"", result.md5))
|
||||
.header("Last-Modified", result.last_modified.format("%a, %d %b %Y %H:%M:%S GMT").to_string())
|
||||
.header(
|
||||
"Last-Modified",
|
||||
result
|
||||
.last_modified
|
||||
.format("%a, %d %b %Y %H:%M:%S GMT")
|
||||
.to_string(),
|
||||
)
|
||||
.header("Content-Type", &content_type)
|
||||
.header("Content-Length", result.size.to_string())
|
||||
.header("Accept-Ranges", "bytes")
|
||||
@@ -1086,7 +1259,14 @@ async fn handle_copy_object(
|
||||
};
|
||||
|
||||
let result = store
|
||||
.copy_object(&src_bucket, &src_key, dest_bucket, dest_key, &metadata_directive, new_metadata)
|
||||
.copy_object(
|
||||
&src_bucket,
|
||||
&src_key,
|
||||
dest_bucket,
|
||||
dest_key,
|
||||
&metadata_directive,
|
||||
new_metadata,
|
||||
)
|
||||
.await?;
|
||||
|
||||
let xml = xml_response::copy_object_result_xml(&result.md5, &result.last_modified.to_rfc3339());
|
||||
@@ -1130,7 +1310,11 @@ async fn handle_put_bucket_policy(
|
||||
}
|
||||
|
||||
// Read body
|
||||
let body_bytes = req.collect().await.map_err(|e| anyhow::anyhow!("Body error: {}", e))?.to_bytes();
|
||||
let body_bytes = req
|
||||
.collect()
|
||||
.await
|
||||
.map_err(|e| anyhow::anyhow!("Body error: {}", e))?
|
||||
.to_bytes();
|
||||
let body_str = String::from_utf8_lossy(&body_bytes);
|
||||
|
||||
// Validate and parse
|
||||
@@ -1212,7 +1396,11 @@ async fn handle_complete_multipart(
|
||||
request_id: &str,
|
||||
) -> Result<Response<BoxBody>> {
|
||||
// Read request body (XML)
|
||||
let body_bytes = req.collect().await.map_err(|e| anyhow::anyhow!("Body error: {}", e))?.to_bytes();
|
||||
let body_bytes = req
|
||||
.collect()
|
||||
.await
|
||||
.map_err(|e| anyhow::anyhow!("Body error: {}", e))?
|
||||
.to_bytes();
|
||||
let body_str = String::from_utf8_lossy(&body_bytes);
|
||||
|
||||
// Parse parts from XML using regex-like approach
|
||||
@@ -1276,8 +1464,12 @@ fn extract_metadata(headers: &hyper::HeaderMap) -> HashMap<String, String> {
|
||||
let name_str = name.as_str().to_lowercase();
|
||||
if let Ok(val) = value.to_str() {
|
||||
match name_str.as_str() {
|
||||
"content-type" | "cache-control" | "content-disposition"
|
||||
| "content-encoding" | "content-language" | "expires" => {
|
||||
"content-type"
|
||||
| "cache-control"
|
||||
| "content-disposition"
|
||||
| "content-encoding"
|
||||
| "content-language"
|
||||
| "expires" => {
|
||||
metadata.insert(name_str, val.to_string());
|
||||
}
|
||||
_ if name_str.starts_with("x-amz-meta-") => {
|
||||
@@ -1290,7 +1482,10 @@ fn extract_metadata(headers: &hyper::HeaderMap) -> HashMap<String, String> {
|
||||
|
||||
// Default content-type
|
||||
if !metadata.contains_key("content-type") {
|
||||
metadata.insert("content-type".to_string(), "binary/octet-stream".to_string());
|
||||
metadata.insert(
|
||||
"content-type".to_string(),
|
||||
"binary/octet-stream".to_string(),
|
||||
);
|
||||
}
|
||||
|
||||
metadata
|
||||
@@ -1325,10 +1520,9 @@ fn parse_complete_multipart_xml(xml: &str) -> Vec<(u32, String)> {
|
||||
if let Some(part_end) = after_part.find("</Part>") {
|
||||
let part_content = &after_part[..part_end];
|
||||
|
||||
let part_number = extract_xml_value(part_content, "PartNumber")
|
||||
.and_then(|s| s.parse::<u32>().ok());
|
||||
let etag = extract_xml_value(part_content, "ETag")
|
||||
.map(|s| s.replace('"', ""));
|
||||
let part_number =
|
||||
extract_xml_value(part_content, "PartNumber").and_then(|s| s.parse::<u32>().ok());
|
||||
let etag = extract_xml_value(part_content, "ETag").map(|s| s.replace('"', ""));
|
||||
|
||||
if let (Some(pn), Some(et)) = (part_number, etag) {
|
||||
parts.push((pn, et));
|
||||
@@ -1394,9 +1588,6 @@ fn add_cors_headers(headers: &mut hyper::HeaderMap, config: &SmartStorageConfig)
|
||||
);
|
||||
}
|
||||
if config.cors.allow_credentials == Some(true) {
|
||||
headers.insert(
|
||||
"access-control-allow-credentials",
|
||||
"true".parse().unwrap(),
|
||||
);
|
||||
headers.insert("access-control-allow-credentials", "true".parse().unwrap());
|
||||
}
|
||||
}
|
||||
|
||||
@@ -99,6 +99,25 @@ pub struct StorageStats {
|
||||
pub storage_locations: Vec<StorageLocationSummary>,
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, Serialize, Deserialize)]
|
||||
#[serde(rename_all = "camelCase")]
|
||||
pub struct BucketExport {
|
||||
pub format: String,
|
||||
pub bucket_name: String,
|
||||
pub exported_at: i64,
|
||||
pub objects: Vec<BucketExportObject>,
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, Serialize, Deserialize)]
|
||||
#[serde(rename_all = "camelCase")]
|
||||
pub struct BucketExportObject {
|
||||
pub key: String,
|
||||
pub size: u64,
|
||||
pub md5: String,
|
||||
pub metadata: HashMap<String, String>,
|
||||
pub data_hex: String,
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, Serialize)]
|
||||
#[serde(rename_all = "camelCase")]
|
||||
pub struct ClusterPeerHealth {
|
||||
@@ -593,6 +612,40 @@ impl FileStore {
|
||||
Ok(PutResult { md5: md5_hex })
|
||||
}
|
||||
|
||||
pub async fn put_object_bytes(
|
||||
&self,
|
||||
bucket: &str,
|
||||
key: &str,
|
||||
data: &[u8],
|
||||
metadata: HashMap<String, String>,
|
||||
) -> Result<PutResult> {
|
||||
if !self.bucket_exists(bucket).await {
|
||||
return Err(StorageError::no_such_bucket().into());
|
||||
}
|
||||
|
||||
let previous_size = self.object_size_if_exists(bucket, key).await;
|
||||
let object_path = self.object_path(bucket, key);
|
||||
if let Some(parent) = object_path.parent() {
|
||||
fs::create_dir_all(parent).await?;
|
||||
}
|
||||
|
||||
fs::write(&object_path, data).await?;
|
||||
let md5_hex = format!("{:x}", Md5::digest(data));
|
||||
fs::write(format!("{}.md5", object_path.display()), &md5_hex).await?;
|
||||
|
||||
let metadata_json = serde_json::to_string_pretty(&metadata)?;
|
||||
fs::write(
|
||||
format!("{}.metadata.json", object_path.display()),
|
||||
metadata_json,
|
||||
)
|
||||
.await?;
|
||||
|
||||
self.track_object_upsert(bucket, previous_size, data.len() as u64)
|
||||
.await;
|
||||
|
||||
Ok(PutResult { md5: md5_hex })
|
||||
}
|
||||
|
||||
pub async fn get_object(
|
||||
&self,
|
||||
bucket: &str,
|
||||
@@ -1311,6 +1364,25 @@ impl StorageBackend {
|
||||
}
|
||||
}
|
||||
|
||||
pub async fn delete_bucket_recursive(&self, bucket: &str) -> Result<()> {
|
||||
if !self.bucket_exists(bucket).await {
|
||||
return Err(StorageError::no_such_bucket().into());
|
||||
}
|
||||
|
||||
loop {
|
||||
let objects = self.list_objects(bucket, "", "", 1000, None).await?;
|
||||
if objects.contents.is_empty() {
|
||||
break;
|
||||
}
|
||||
|
||||
for object in objects.contents {
|
||||
self.delete_object(bucket, &object.key).await?;
|
||||
}
|
||||
}
|
||||
|
||||
self.delete_bucket(bucket).await
|
||||
}
|
||||
|
||||
pub async fn put_object(
|
||||
&self,
|
||||
bucket: &str,
|
||||
@@ -1324,6 +1396,21 @@ impl StorageBackend {
|
||||
}
|
||||
}
|
||||
|
||||
pub async fn put_object_bytes(
|
||||
&self,
|
||||
bucket: &str,
|
||||
key: &str,
|
||||
data: &[u8],
|
||||
metadata: HashMap<String, String>,
|
||||
) -> Result<PutResult> {
|
||||
match self {
|
||||
StorageBackend::Standalone(fs) => {
|
||||
fs.put_object_bytes(bucket, key, data, metadata).await
|
||||
}
|
||||
StorageBackend::Clustered(ds) => ds.put_object_bytes(bucket, key, data, metadata).await,
|
||||
}
|
||||
}
|
||||
|
||||
pub async fn get_object(
|
||||
&self,
|
||||
bucket: &str,
|
||||
@@ -1453,6 +1540,55 @@ impl StorageBackend {
|
||||
StorageBackend::Clustered(ds) => ds.list_multipart_uploads(bucket).await,
|
||||
}
|
||||
}
|
||||
|
||||
pub async fn export_bucket(&self, bucket: &str) -> Result<BucketExport> {
|
||||
if !self.bucket_exists(bucket).await {
|
||||
return Err(StorageError::no_such_bucket().into());
|
||||
}
|
||||
|
||||
let objects = self.list_objects(bucket, "", "", usize::MAX, None).await?;
|
||||
let mut exported_objects = Vec::with_capacity(objects.contents.len());
|
||||
|
||||
for object in objects.contents {
|
||||
let result = self.get_object(bucket, &object.key, None).await?;
|
||||
let mut file = result.body;
|
||||
let mut data = Vec::with_capacity(result.size as usize);
|
||||
file.read_to_end(&mut data).await?;
|
||||
exported_objects.push(BucketExportObject {
|
||||
key: object.key,
|
||||
size: result.size,
|
||||
md5: result.md5,
|
||||
metadata: result.metadata,
|
||||
data_hex: hex::encode(data),
|
||||
});
|
||||
}
|
||||
|
||||
Ok(BucketExport {
|
||||
format: "smartstorage.bucket.v1".to_string(),
|
||||
bucket_name: bucket.to_string(),
|
||||
exported_at: Utc::now().timestamp_millis(),
|
||||
objects: exported_objects,
|
||||
})
|
||||
}
|
||||
|
||||
pub async fn import_bucket(&self, bucket: &str, source: BucketExport) -> Result<()> {
|
||||
if source.format != "smartstorage.bucket.v1" {
|
||||
return Err(StorageError::invalid_request("Unsupported bucket export format.").into());
|
||||
}
|
||||
|
||||
if !self.bucket_exists(bucket).await {
|
||||
self.create_bucket(bucket).await?;
|
||||
}
|
||||
|
||||
for object in source.objects {
|
||||
let data = hex::decode(&object.data_hex)
|
||||
.map_err(|error| StorageError::invalid_request(&error.to_string()))?;
|
||||
self.put_object_bytes(bucket, &object.key, &data, object.metadata)
|
||||
.await?;
|
||||
}
|
||||
|
||||
Ok(())
|
||||
}
|
||||
}
|
||||
|
||||
// ============================
|
||||
|
||||
@@ -0,0 +1,335 @@
|
||||
/// <reference types="node" />
|
||||
|
||||
import { expect, tap } from '@git.zone/tstest/tapbundle';
|
||||
import {
|
||||
CopyObjectCommand,
|
||||
GetBucketPolicyCommand,
|
||||
GetObjectCommand,
|
||||
HeadBucketCommand,
|
||||
ListBucketsCommand,
|
||||
ListObjectsV2Command,
|
||||
PutBucketPolicyCommand,
|
||||
PutObjectCommand,
|
||||
DeleteObjectCommand,
|
||||
S3Client,
|
||||
} from '@aws-sdk/client-s3';
|
||||
import { rm } from 'fs/promises';
|
||||
import { fileURLToPath } from 'url';
|
||||
import { Readable } from 'stream';
|
||||
import * as smartstorage from '../ts/index.js';
|
||||
|
||||
const TEST_PORT = 3361;
|
||||
const STORAGE_DIR = fileURLToPath(new URL('../.nogit/bucket-tenant-tests', import.meta.url));
|
||||
const WORKAPP_A_BUCKET = 'workapp-a-bucket';
|
||||
const WORKAPP_B_BUCKET = 'workapp-b-bucket';
|
||||
const RESTORE_BUCKET = 'workapp-a-restore-bucket';
|
||||
const POLICY_BUCKET = 'workapp-policy-bucket';
|
||||
const ADMIN_CREDENTIAL: smartstorage.IStorageCredential = {
|
||||
accessKeyId: 'TENANTADMIN',
|
||||
secretAccessKey: 'TENANTADMINSECRET123',
|
||||
};
|
||||
|
||||
let testSmartStorageInstance: smartstorage.SmartStorage;
|
||||
let adminClient: S3Client;
|
||||
let tenantA: smartstorage.IBucketTenantDescriptor;
|
||||
let tenantB: smartstorage.IBucketTenantDescriptor;
|
||||
let tenantAClient: S3Client;
|
||||
let tenantBClient: S3Client;
|
||||
let oldTenantAClient: S3Client;
|
||||
|
||||
function createS3Client(
|
||||
credential: smartstorage.IStorageCredential,
|
||||
region = 'us-east-1',
|
||||
): S3Client {
|
||||
return new S3Client({
|
||||
endpoint: `http://localhost:${TEST_PORT}`,
|
||||
region,
|
||||
credentials: {
|
||||
accessKeyId: credential.accessKeyId,
|
||||
secretAccessKey: credential.secretAccessKey,
|
||||
},
|
||||
forcePathStyle: true,
|
||||
});
|
||||
}
|
||||
|
||||
function createS3ClientFromDescriptor(
|
||||
descriptor: smartstorage.IBucketTenantDescriptor,
|
||||
): S3Client {
|
||||
return new S3Client({
|
||||
endpoint: `http://${descriptor.endpoint}:${descriptor.port}`,
|
||||
region: descriptor.region,
|
||||
credentials: {
|
||||
accessKeyId: descriptor.accessKeyId,
|
||||
secretAccessKey: descriptor.secretAccessKey,
|
||||
},
|
||||
forcePathStyle: true,
|
||||
});
|
||||
}
|
||||
|
||||
async function streamToString(stream: Readable): Promise<string> {
|
||||
const chunks: Buffer[] = [];
|
||||
return new Promise((resolve, reject) => {
|
||||
stream.on('data', (chunk: string | Buffer | Uint8Array) => chunks.push(Buffer.from(chunk)));
|
||||
stream.on('error', reject);
|
||||
stream.on('end', () => resolve(Buffer.concat(chunks).toString('utf8')));
|
||||
});
|
||||
}
|
||||
|
||||
async function startStorage() {
|
||||
testSmartStorageInstance = await smartstorage.SmartStorage.createAndStart({
|
||||
server: {
|
||||
port: TEST_PORT,
|
||||
silent: true,
|
||||
region: 'us-east-1',
|
||||
},
|
||||
storage: {
|
||||
directory: STORAGE_DIR,
|
||||
cleanSlate: false,
|
||||
},
|
||||
auth: {
|
||||
enabled: true,
|
||||
credentials: [ADMIN_CREDENTIAL],
|
||||
},
|
||||
});
|
||||
adminClient = createS3Client(ADMIN_CREDENTIAL);
|
||||
}
|
||||
|
||||
tap.test('setup: start storage and provision bucket tenants', async () => {
|
||||
await rm(STORAGE_DIR, { recursive: true, force: true });
|
||||
await startStorage();
|
||||
|
||||
tenantA = await testSmartStorageInstance.createBucketTenant({
|
||||
bucketName: WORKAPP_A_BUCKET,
|
||||
});
|
||||
tenantB = await testSmartStorageInstance.createBucketTenant({
|
||||
bucketName: WORKAPP_B_BUCKET,
|
||||
});
|
||||
tenantAClient = createS3ClientFromDescriptor(tenantA);
|
||||
tenantBClient = createS3ClientFromDescriptor(tenantB);
|
||||
});
|
||||
|
||||
tap.test('tenant descriptors expose app-ready S3 connection data', async () => {
|
||||
expect(tenantA.endpoint).toEqual('localhost');
|
||||
expect(tenantA.port).toEqual(TEST_PORT);
|
||||
expect(tenantA.region).toEqual('us-east-1');
|
||||
expect(tenantA.bucket).toEqual(WORKAPP_A_BUCKET);
|
||||
expect(tenantA.bucketName).toEqual(WORKAPP_A_BUCKET);
|
||||
expect(tenantA.accessKeyId).toBeTypeofString();
|
||||
expect(tenantA.secretAccessKey).toBeTypeofString();
|
||||
expect(tenantA.useSsl).toEqual(false);
|
||||
expect(tenantA.env.S3_BUCKET).toEqual(WORKAPP_A_BUCKET);
|
||||
expect(tenantA.env.AWS_ACCESS_KEY_ID).toEqual(tenantA.accessKeyId);
|
||||
});
|
||||
|
||||
tap.test('listBucketTenants returns scoped credential metadata without secrets', async () => {
|
||||
const tenants = await testSmartStorageInstance.listBucketTenants();
|
||||
expect(tenants.length).toEqual(2);
|
||||
expect(tenants.some((tenant) => tenant.bucketName === WORKAPP_A_BUCKET)).toEqual(true);
|
||||
expect(tenants.some((tenant) => tenant.bucketName === WORKAPP_B_BUCKET)).toEqual(true);
|
||||
expect((tenants[0] as any).secretAccessKey).toEqual(undefined);
|
||||
});
|
||||
|
||||
tap.test('tenant credentials work with AWS SDK v3 for their assigned bucket', async () => {
|
||||
const putA = await tenantAClient.send(new PutObjectCommand({
|
||||
Bucket: WORKAPP_A_BUCKET,
|
||||
Key: 'hello.txt',
|
||||
Body: 'hello from tenant a',
|
||||
ContentType: 'text/plain',
|
||||
}));
|
||||
expect(putA.$metadata.httpStatusCode).toEqual(200);
|
||||
|
||||
const putB = await tenantBClient.send(new PutObjectCommand({
|
||||
Bucket: WORKAPP_B_BUCKET,
|
||||
Key: 'other.txt',
|
||||
Body: 'hello from tenant b',
|
||||
ContentType: 'text/plain',
|
||||
}));
|
||||
expect(putB.$metadata.httpStatusCode).toEqual(200);
|
||||
|
||||
const getA = await tenantAClient.send(new GetObjectCommand({
|
||||
Bucket: WORKAPP_A_BUCKET,
|
||||
Key: 'hello.txt',
|
||||
}));
|
||||
expect(await streamToString(getA.Body as Readable)).toEqual('hello from tenant a');
|
||||
|
||||
const listA = await tenantAClient.send(new ListObjectsV2Command({
|
||||
Bucket: WORKAPP_A_BUCKET,
|
||||
}));
|
||||
expect(listA.Contents?.some((object) => object.Key === 'hello.txt')).toEqual(true);
|
||||
});
|
||||
|
||||
tap.test('tenant credentials cannot access unrelated buckets', async () => {
|
||||
await expect(tenantAClient.send(new ListBucketsCommand({}))).rejects.toThrow();
|
||||
await expect(tenantAClient.send(new HeadBucketCommand({
|
||||
Bucket: WORKAPP_B_BUCKET,
|
||||
}))).rejects.toThrow();
|
||||
await expect(tenantAClient.send(new PutObjectCommand({
|
||||
Bucket: WORKAPP_B_BUCKET,
|
||||
Key: 'blocked-write.txt',
|
||||
Body: 'blocked',
|
||||
}))).rejects.toThrow();
|
||||
await expect(tenantAClient.send(new GetObjectCommand({
|
||||
Bucket: WORKAPP_B_BUCKET,
|
||||
Key: 'other.txt',
|
||||
}))).rejects.toThrow();
|
||||
await expect(tenantAClient.send(new DeleteObjectCommand({
|
||||
Bucket: WORKAPP_B_BUCKET,
|
||||
Key: 'other.txt',
|
||||
}))).rejects.toThrow();
|
||||
await expect(tenantAClient.send(new CopyObjectCommand({
|
||||
Bucket: WORKAPP_A_BUCKET,
|
||||
Key: 'copy-from-other-bucket.txt',
|
||||
CopySource: `/${WORKAPP_B_BUCKET}/other.txt`,
|
||||
}))).rejects.toThrow();
|
||||
await expect(tenantBClient.send(new GetObjectCommand({
|
||||
Bucket: WORKAPP_A_BUCKET,
|
||||
Key: 'hello.txt',
|
||||
}))).rejects.toThrow();
|
||||
});
|
||||
|
||||
tap.test('health and metrics expose running storage state', async () => {
|
||||
const health = await testSmartStorageInstance.getHealth();
|
||||
expect(health.running).toEqual(true);
|
||||
expect(health.ok).toEqual(true);
|
||||
expect(health.storageDirectory).toEqual(STORAGE_DIR);
|
||||
expect(health.auth.enabled).toEqual(true);
|
||||
expect(health.auth.tenantCredentialCount).toEqual(2);
|
||||
expect(health.bucketCount >= 2).toEqual(true);
|
||||
expect(health.objectCount >= 2).toEqual(true);
|
||||
expect(health.totalBytes > 0).toEqual(true);
|
||||
|
||||
const metrics = await testSmartStorageInstance.getMetrics();
|
||||
expect(metrics.tenantCredentialCount).toEqual(2);
|
||||
expect(metrics.prometheusText).toMatch(/smartstorage_tenant_credentials_total 2/);
|
||||
});
|
||||
|
||||
tap.test('export/import targets one bucket without unrelated tenant data', async () => {
|
||||
const bucketExport = await testSmartStorageInstance.exportBucket({
|
||||
bucketName: WORKAPP_A_BUCKET,
|
||||
});
|
||||
expect(bucketExport.format).toEqual('smartstorage.bucket.v1');
|
||||
expect(bucketExport.bucketName).toEqual(WORKAPP_A_BUCKET);
|
||||
expect(bucketExport.objects.some((object) => object.key === 'hello.txt')).toEqual(true);
|
||||
expect(bucketExport.objects.some((object) => object.key === 'other.txt')).toEqual(false);
|
||||
|
||||
await testSmartStorageInstance.importBucket({
|
||||
bucketName: RESTORE_BUCKET,
|
||||
source: bucketExport,
|
||||
});
|
||||
|
||||
const restoredObject = await adminClient.send(new GetObjectCommand({
|
||||
Bucket: RESTORE_BUCKET,
|
||||
Key: 'hello.txt',
|
||||
}));
|
||||
expect(await streamToString(restoredObject.Body as Readable)).toEqual('hello from tenant a');
|
||||
|
||||
const restoredObjects = await adminClient.send(new ListObjectsV2Command({
|
||||
Bucket: RESTORE_BUCKET,
|
||||
}));
|
||||
expect(restoredObjects.Contents?.some((object) => object.Key === 'other.txt')).toEqual(false);
|
||||
});
|
||||
|
||||
tap.test('bucket policies persist across restart', async () => {
|
||||
await testSmartStorageInstance.createBucket(POLICY_BUCKET);
|
||||
const policy = JSON.stringify({
|
||||
Version: '2012-10-17',
|
||||
Statement: [{
|
||||
Sid: 'TenantPolicyPersistence',
|
||||
Effect: 'Allow',
|
||||
Principal: { AWS: ADMIN_CREDENTIAL.accessKeyId },
|
||||
Action: ['s3:GetBucketPolicy', 's3:PutBucketPolicy', 's3:ListBucket'],
|
||||
Resource: `arn:aws:s3:::${POLICY_BUCKET}`,
|
||||
}],
|
||||
});
|
||||
|
||||
const response = await adminClient.send(new PutBucketPolicyCommand({
|
||||
Bucket: POLICY_BUCKET,
|
||||
Policy: policy,
|
||||
}));
|
||||
expect(response.$metadata.httpStatusCode).toEqual(204);
|
||||
});
|
||||
|
||||
tap.test('credential rotation replaces the active tenant credential', async () => {
|
||||
oldTenantAClient = tenantAClient;
|
||||
tenantA = await testSmartStorageInstance.rotateBucketTenantCredentials({
|
||||
bucketName: WORKAPP_A_BUCKET,
|
||||
});
|
||||
tenantAClient = createS3ClientFromDescriptor(tenantA);
|
||||
|
||||
await expect(oldTenantAClient.send(new GetObjectCommand({
|
||||
Bucket: WORKAPP_A_BUCKET,
|
||||
Key: 'hello.txt',
|
||||
}))).rejects.toThrow();
|
||||
|
||||
const getA = await tenantAClient.send(new GetObjectCommand({
|
||||
Bucket: WORKAPP_A_BUCKET,
|
||||
Key: 'hello.txt',
|
||||
}));
|
||||
expect(await streamToString(getA.Body as Readable)).toEqual('hello from tenant a');
|
||||
|
||||
const descriptor = await testSmartStorageInstance.getBucketTenantDescriptor({
|
||||
bucketName: WORKAPP_A_BUCKET,
|
||||
});
|
||||
expect(descriptor.accessKeyId).toEqual(tenantA.accessKeyId);
|
||||
expect(descriptor.secretAccessKey).toEqual(tenantA.secretAccessKey);
|
||||
});
|
||||
|
||||
tap.test('runtime credentials survive restart', async () => {
|
||||
await testSmartStorageInstance.stop();
|
||||
await startStorage();
|
||||
|
||||
const persistedTenantA = await testSmartStorageInstance.getBucketTenantDescriptor({
|
||||
bucketName: WORKAPP_A_BUCKET,
|
||||
});
|
||||
expect(persistedTenantA.accessKeyId).toEqual(tenantA.accessKeyId);
|
||||
expect(persistedTenantA.secretAccessKey).toEqual(tenantA.secretAccessKey);
|
||||
|
||||
tenantAClient = createS3ClientFromDescriptor(persistedTenantA);
|
||||
const getA = await tenantAClient.send(new GetObjectCommand({
|
||||
Bucket: WORKAPP_A_BUCKET,
|
||||
Key: 'hello.txt',
|
||||
}));
|
||||
expect(await streamToString(getA.Body as Readable)).toEqual('hello from tenant a');
|
||||
|
||||
const tenants = await testSmartStorageInstance.listBucketTenants();
|
||||
expect(tenants.some((tenant) => tenant.bucketName === WORKAPP_A_BUCKET)).toEqual(true);
|
||||
expect(tenants.some((tenant) => tenant.bucketName === WORKAPP_B_BUCKET)).toEqual(true);
|
||||
|
||||
const policyResponse = await adminClient.send(new GetBucketPolicyCommand({
|
||||
Bucket: POLICY_BUCKET,
|
||||
}));
|
||||
expect(policyResponse.Policy?.includes('TenantPolicyPersistence')).toEqual(true);
|
||||
});
|
||||
|
||||
tap.test('deleteBucketTenant can revoke credentials and delete tenant buckets', async () => {
|
||||
await testSmartStorageInstance.deleteBucketTenant({
|
||||
bucketName: WORKAPP_B_BUCKET,
|
||||
accessKeyId: tenantB.accessKeyId,
|
||||
});
|
||||
|
||||
await expect(tenantBClient.send(new GetObjectCommand({
|
||||
Bucket: WORKAPP_B_BUCKET,
|
||||
Key: 'other.txt',
|
||||
}))).rejects.toThrow();
|
||||
|
||||
const headAfterRevoke = await adminClient.send(new HeadBucketCommand({
|
||||
Bucket: WORKAPP_B_BUCKET,
|
||||
}));
|
||||
expect(headAfterRevoke.$metadata.httpStatusCode).toEqual(200);
|
||||
|
||||
await testSmartStorageInstance.deleteBucketTenant({
|
||||
bucketName: WORKAPP_B_BUCKET,
|
||||
});
|
||||
await expect(adminClient.send(new HeadBucketCommand({
|
||||
Bucket: WORKAPP_B_BUCKET,
|
||||
}))).rejects.toThrow();
|
||||
|
||||
const tenants = await testSmartStorageInstance.listBucketTenants();
|
||||
expect(tenants.some((tenant) => tenant.bucketName === WORKAPP_B_BUCKET)).toEqual(false);
|
||||
});
|
||||
|
||||
tap.test('teardown: stop storage server', async () => {
|
||||
await testSmartStorageInstance.stop();
|
||||
});
|
||||
|
||||
export default tap.start();
|
||||
@@ -3,6 +3,6 @@
|
||||
*/
|
||||
export const commitinfo = {
|
||||
name: '@push.rocks/smartstorage',
|
||||
version: '6.4.0',
|
||||
version: '6.5.0',
|
||||
description: 'A Node.js TypeScript package to create a local S3-compatible storage server using mapped local directories for development and testing purposes.'
|
||||
}
|
||||
|
||||
+295
@@ -7,10 +7,14 @@ import * as paths from './paths.js';
|
||||
export interface IStorageCredential {
|
||||
accessKeyId: string;
|
||||
secretAccessKey: string;
|
||||
bucketName?: string;
|
||||
region?: string;
|
||||
}
|
||||
|
||||
export interface IStorageCredentialMetadata {
|
||||
accessKeyId: string;
|
||||
bucketName?: string;
|
||||
region?: string;
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -155,6 +159,88 @@ export interface IStorageStats {
|
||||
storageLocations?: IStorageLocationSummary[];
|
||||
}
|
||||
|
||||
export interface IBucketTenantInput {
|
||||
bucketName: string;
|
||||
accessKeyId?: string;
|
||||
secretAccessKey?: string;
|
||||
region?: string;
|
||||
}
|
||||
|
||||
export interface IDeleteBucketTenantInput {
|
||||
bucketName: string;
|
||||
accessKeyId?: string;
|
||||
}
|
||||
|
||||
export interface IBucketTenantMetadata {
|
||||
bucketName: string;
|
||||
accessKeyId: string;
|
||||
region?: string;
|
||||
}
|
||||
|
||||
export interface IBucketTenantDescriptor extends plugins.tsclass.storage.IS3Descriptor {
|
||||
endpoint: string;
|
||||
port: number;
|
||||
region: string;
|
||||
bucket: string;
|
||||
bucketName: string;
|
||||
accessKeyId: string;
|
||||
secretAccessKey: string;
|
||||
accessKey: string;
|
||||
accessSecret: string;
|
||||
useSsl: boolean;
|
||||
ssl: boolean;
|
||||
env: Record<string, string>;
|
||||
}
|
||||
|
||||
export interface IBucketExportObject {
|
||||
key: string;
|
||||
size: number;
|
||||
md5: string;
|
||||
metadata: Record<string, string>;
|
||||
dataHex: string;
|
||||
}
|
||||
|
||||
export interface IBucketExport {
|
||||
format: 'smartstorage.bucket.v1';
|
||||
bucketName: string;
|
||||
exportedAt: number;
|
||||
objects: IBucketExportObject[];
|
||||
}
|
||||
|
||||
export interface IExportBucketInput {
|
||||
bucketName: string;
|
||||
}
|
||||
|
||||
export interface IImportBucketInput {
|
||||
bucketName: string;
|
||||
source: IBucketExport;
|
||||
}
|
||||
|
||||
export interface ISmartStorageHealth {
|
||||
ok: boolean;
|
||||
running: boolean;
|
||||
storageDirectory: string;
|
||||
auth: {
|
||||
enabled: boolean;
|
||||
credentialCount: number;
|
||||
tenantCredentialCount: number;
|
||||
};
|
||||
bucketCount: number;
|
||||
objectCount: number;
|
||||
totalBytes: number;
|
||||
cluster: IClusterHealth;
|
||||
}
|
||||
|
||||
export interface ISmartStorageMetrics {
|
||||
bucketCount: number;
|
||||
objectCount: number;
|
||||
totalBytes: number;
|
||||
authCredentialCount: number;
|
||||
tenantCredentialCount: number;
|
||||
clusterEnabled: boolean;
|
||||
prometheusText: string;
|
||||
}
|
||||
|
||||
/**
|
||||
* Known peer status from the local node's current cluster view.
|
||||
*/
|
||||
@@ -306,6 +392,14 @@ function mergeConfig(userConfig: ISmartStorageConfig): Required<ISmartStorageCon
|
||||
} as Required<ISmartStorageConfig>;
|
||||
}
|
||||
|
||||
function createAccessKeyId(): string {
|
||||
return `SS${plugins.crypto.randomBytes(10).toString('hex').toUpperCase()}`;
|
||||
}
|
||||
|
||||
function createSecretAccessKey(): string {
|
||||
return plugins.crypto.randomBytes(32).toString('hex');
|
||||
}
|
||||
|
||||
/**
|
||||
* IPC command type map for RustBridge
|
||||
*/
|
||||
@@ -313,6 +407,35 @@ type TRustStorageCommands = {
|
||||
start: { params: { config: Required<ISmartStorageConfig> }; result: {} };
|
||||
stop: { params: {}; result: {} };
|
||||
createBucket: { params: { name: string }; result: {} };
|
||||
createBucketTenant: {
|
||||
params: {
|
||||
bucketName: string;
|
||||
accessKeyId: string;
|
||||
secretAccessKey: string;
|
||||
region?: string;
|
||||
};
|
||||
result: IStorageCredential;
|
||||
};
|
||||
deleteBucketTenant: {
|
||||
params: { bucketName: string; accessKeyId?: string };
|
||||
result: {};
|
||||
};
|
||||
rotateBucketTenantCredentials: {
|
||||
params: {
|
||||
bucketName: string;
|
||||
accessKeyId: string;
|
||||
secretAccessKey: string;
|
||||
region?: string;
|
||||
};
|
||||
result: IStorageCredential;
|
||||
};
|
||||
listBucketTenants: { params: {}; result: IBucketTenantMetadata[] };
|
||||
getBucketTenantCredential: {
|
||||
params: { bucketName: string };
|
||||
result: IStorageCredential;
|
||||
};
|
||||
exportBucket: { params: { bucketName: string }; result: IBucketExport };
|
||||
importBucket: { params: { bucketName: string; source: IBucketExport }; result: {} };
|
||||
getStorageStats: { params: {}; result: IStorageStats };
|
||||
listBucketSummaries: { params: {}; result: IBucketSummary[] };
|
||||
listCredentials: { params: {}; result: IStorageCredentialMetadata[] };
|
||||
@@ -334,6 +457,7 @@ export class SmartStorage {
|
||||
// INSTANCE
|
||||
public config: Required<ISmartStorageConfig>;
|
||||
private bridge: InstanceType<typeof plugins.RustBridge<TRustStorageCommands>>;
|
||||
private running = false;
|
||||
|
||||
constructor(configArg: ISmartStorageConfig = {}) {
|
||||
this.config = mergeConfig(configArg);
|
||||
@@ -353,6 +477,7 @@ export class SmartStorage {
|
||||
throw new Error('Failed to spawn ruststorage binary. Make sure it is compiled (pnpm build).');
|
||||
}
|
||||
await this.bridge.sendCommand('start', { config: this.config });
|
||||
this.running = true;
|
||||
|
||||
if (!this.config.server.silent) {
|
||||
console.log('storage server is running');
|
||||
@@ -382,11 +507,110 @@ export class SmartStorage {
|
||||
};
|
||||
}
|
||||
|
||||
private getEndpoint(): string {
|
||||
return this.config.server.address === '0.0.0.0' ? 'localhost' : this.config.server.address!;
|
||||
}
|
||||
|
||||
private buildBucketTenantDescriptor(
|
||||
credential: IStorageCredential,
|
||||
bucketNameArg: string,
|
||||
): IBucketTenantDescriptor {
|
||||
const bucketName = credential.bucketName || bucketNameArg;
|
||||
const region = credential.region || this.config.server.region || 'us-east-1';
|
||||
const endpoint = this.getEndpoint();
|
||||
const port = this.config.server.port!;
|
||||
const useSsl = false;
|
||||
|
||||
return {
|
||||
endpoint,
|
||||
port,
|
||||
region,
|
||||
bucket: bucketName,
|
||||
bucketName,
|
||||
accessKeyId: credential.accessKeyId,
|
||||
secretAccessKey: credential.secretAccessKey,
|
||||
accessKey: credential.accessKeyId,
|
||||
accessSecret: credential.secretAccessKey,
|
||||
useSsl,
|
||||
ssl: useSsl,
|
||||
env: {
|
||||
S3_ENDPOINT: endpoint,
|
||||
S3_PORT: String(port),
|
||||
S3_REGION: region,
|
||||
S3_BUCKET: bucketName,
|
||||
S3_ACCESS_KEY_ID: credential.accessKeyId,
|
||||
S3_SECRET_ACCESS_KEY: credential.secretAccessKey,
|
||||
S3_USE_SSL: String(useSsl),
|
||||
AWS_ACCESS_KEY_ID: credential.accessKeyId,
|
||||
AWS_SECRET_ACCESS_KEY: credential.secretAccessKey,
|
||||
AWS_REGION: region,
|
||||
},
|
||||
};
|
||||
}
|
||||
|
||||
private assertTenantAuthEnabled(): void {
|
||||
if (!this.config.auth.enabled) {
|
||||
throw new Error('Bucket tenant APIs require auth.enabled=true.');
|
||||
}
|
||||
}
|
||||
|
||||
public async createBucket(bucketNameArg: string) {
|
||||
await this.bridge.sendCommand('createBucket', { name: bucketNameArg });
|
||||
return { name: bucketNameArg };
|
||||
}
|
||||
|
||||
public async createBucketTenant(
|
||||
tenantArg: IBucketTenantInput,
|
||||
): Promise<IBucketTenantDescriptor> {
|
||||
this.assertTenantAuthEnabled();
|
||||
const credential = await this.bridge.sendCommand('createBucketTenant', {
|
||||
bucketName: tenantArg.bucketName,
|
||||
accessKeyId: tenantArg.accessKeyId || createAccessKeyId(),
|
||||
secretAccessKey: tenantArg.secretAccessKey || createSecretAccessKey(),
|
||||
region: tenantArg.region || this.config.server.region,
|
||||
});
|
||||
return this.buildBucketTenantDescriptor(credential, tenantArg.bucketName);
|
||||
}
|
||||
|
||||
public async deleteBucketTenant(tenantArg: IDeleteBucketTenantInput): Promise<void> {
|
||||
this.assertTenantAuthEnabled();
|
||||
await this.bridge.sendCommand('deleteBucketTenant', tenantArg);
|
||||
}
|
||||
|
||||
public async rotateBucketTenantCredentials(
|
||||
tenantArg: IBucketTenantInput,
|
||||
): Promise<IBucketTenantDescriptor> {
|
||||
this.assertTenantAuthEnabled();
|
||||
const credential = await this.bridge.sendCommand('rotateBucketTenantCredentials', {
|
||||
bucketName: tenantArg.bucketName,
|
||||
accessKeyId: tenantArg.accessKeyId || createAccessKeyId(),
|
||||
secretAccessKey: tenantArg.secretAccessKey || createSecretAccessKey(),
|
||||
region: tenantArg.region || this.config.server.region,
|
||||
});
|
||||
return this.buildBucketTenantDescriptor(credential, tenantArg.bucketName);
|
||||
}
|
||||
|
||||
public async listBucketTenants(): Promise<IBucketTenantMetadata[]> {
|
||||
return this.bridge.sendCommand('listBucketTenants', {});
|
||||
}
|
||||
|
||||
public async getBucketTenantDescriptor(optionsArg: {
|
||||
bucketName: string;
|
||||
}): Promise<IBucketTenantDescriptor> {
|
||||
const credential = await this.bridge.sendCommand('getBucketTenantCredential', {
|
||||
bucketName: optionsArg.bucketName,
|
||||
});
|
||||
return this.buildBucketTenantDescriptor(credential, optionsArg.bucketName);
|
||||
}
|
||||
|
||||
public async exportBucket(optionsArg: IExportBucketInput): Promise<IBucketExport> {
|
||||
return this.bridge.sendCommand('exportBucket', { bucketName: optionsArg.bucketName });
|
||||
}
|
||||
|
||||
public async importBucket(optionsArg: IImportBucketInput): Promise<void> {
|
||||
await this.bridge.sendCommand('importBucket', optionsArg);
|
||||
}
|
||||
|
||||
public async getStorageStats(): Promise<IStorageStats> {
|
||||
return this.bridge.sendCommand('getStorageStats', {});
|
||||
}
|
||||
@@ -408,8 +632,79 @@ export class SmartStorage {
|
||||
return this.bridge.sendCommand('getClusterHealth', {});
|
||||
}
|
||||
|
||||
public async getHealth(): Promise<ISmartStorageHealth> {
|
||||
if (!this.running) {
|
||||
return {
|
||||
ok: false,
|
||||
running: false,
|
||||
storageDirectory: this.config.storage.directory || paths.bucketsDir,
|
||||
auth: {
|
||||
enabled: this.config.auth.enabled,
|
||||
credentialCount: this.config.auth.credentials.length,
|
||||
tenantCredentialCount: 0,
|
||||
},
|
||||
bucketCount: 0,
|
||||
objectCount: 0,
|
||||
totalBytes: 0,
|
||||
cluster: { enabled: false },
|
||||
};
|
||||
}
|
||||
|
||||
const [stats, credentials, tenants, cluster] = await Promise.all([
|
||||
this.getStorageStats(),
|
||||
this.listCredentials(),
|
||||
this.listBucketTenants(),
|
||||
this.getClusterHealth(),
|
||||
]);
|
||||
return {
|
||||
ok: true,
|
||||
running: true,
|
||||
storageDirectory: stats.storageDirectory,
|
||||
auth: {
|
||||
enabled: this.config.auth.enabled,
|
||||
credentialCount: credentials.length,
|
||||
tenantCredentialCount: tenants.length,
|
||||
},
|
||||
bucketCount: stats.bucketCount,
|
||||
objectCount: stats.totalObjectCount,
|
||||
totalBytes: stats.totalStorageBytes,
|
||||
cluster,
|
||||
};
|
||||
}
|
||||
|
||||
public async getMetrics(): Promise<ISmartStorageMetrics> {
|
||||
const health = await this.getHealth();
|
||||
const clusterEnabled = health.cluster.enabled;
|
||||
return {
|
||||
bucketCount: health.bucketCount,
|
||||
objectCount: health.objectCount,
|
||||
totalBytes: health.totalBytes,
|
||||
authCredentialCount: health.auth.credentialCount,
|
||||
tenantCredentialCount: health.auth.tenantCredentialCount,
|
||||
clusterEnabled,
|
||||
prometheusText: [
|
||||
'# HELP smartstorage_buckets_total Runtime bucket count.',
|
||||
'# TYPE smartstorage_buckets_total gauge',
|
||||
`smartstorage_buckets_total ${health.bucketCount}`,
|
||||
'# HELP smartstorage_objects_total Runtime object count.',
|
||||
'# TYPE smartstorage_objects_total gauge',
|
||||
`smartstorage_objects_total ${health.objectCount}`,
|
||||
'# HELP smartstorage_storage_bytes_total Runtime storage bytes.',
|
||||
'# TYPE smartstorage_storage_bytes_total gauge',
|
||||
`smartstorage_storage_bytes_total ${health.totalBytes}`,
|
||||
'# HELP smartstorage_tenant_credentials_total Scoped bucket tenant credential count.',
|
||||
'# TYPE smartstorage_tenant_credentials_total gauge',
|
||||
`smartstorage_tenant_credentials_total ${health.auth.tenantCredentialCount}`,
|
||||
'# HELP smartstorage_cluster_enabled Cluster mode enabled.',
|
||||
'# TYPE smartstorage_cluster_enabled gauge',
|
||||
`smartstorage_cluster_enabled ${clusterEnabled ? 1 : 0}`,
|
||||
].join('\n'),
|
||||
};
|
||||
}
|
||||
|
||||
public async stop() {
|
||||
await this.bridge.sendCommand('stop', {});
|
||||
this.bridge.kill();
|
||||
this.running = false;
|
||||
}
|
||||
}
|
||||
|
||||
+2
-1
@@ -1,7 +1,8 @@
|
||||
// node native
|
||||
import * as crypto from 'crypto';
|
||||
import * as path from 'path';
|
||||
|
||||
export { path };
|
||||
export { crypto, path };
|
||||
|
||||
// @push.rocks scope
|
||||
import * as smartpath from '@push.rocks/smartpath';
|
||||
|
||||
@@ -6,6 +6,7 @@
|
||||
"esModuleInterop": true,
|
||||
"verbatimModuleSyntax": true,
|
||||
"types": ["node"],
|
||||
"noImplicitAny": true,
|
||||
"ignoreDeprecations": "6.0",
|
||||
"baseUrl": ".",
|
||||
"paths": {}
|
||||
|
||||
Reference in New Issue
Block a user